Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-10 Thread xwmeng
> -原始邮件- > 发件人: "Pedro Arthur" > 发送时间: 2019-04-11 00:12:09 (星期四) > 收件人: "FFmpeg development discussions and patches" > 抄送: > 主题: Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init > version--GSoC Qualification Task. > > Hi, > Em ter, 9 de abr de 2019 às 22:42,

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-10 Thread xwmeng
> -原始邮件- > 发件人: "Liu Steven" > 发送时间: 2019-04-09 16:00:25 (星期二) > 收件人: "FFmpeg development discussions and patches" > 抄送: "Liu Steven" > 主题: Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init > version--GSoC Qualification Task. > > > > > 在

Re: [FFmpeg-devel] [PATCH v2] lavf/rtsp.c: Fix stimeout option not applied on http tunnel

2019-04-10 Thread Liu Steven
> 在 2019年4月11日,上午11:55,Jun Li 写道: > > On Mon, Apr 8, 2019 at 8:19 PM Jun Li wrote: > >> On Mon, Apr 8, 2019 at 6:23 PM Liu Steven wrote: >> >>> >>> 在 2019年4月9日,上午8:54,Jun Li 写道: Ping. On Fri, Apr 5, 2019 at 12:00 PM Jun Li wrote: > > > On

Re: [FFmpeg-devel] [PATCH v2] lavf/rtsp.c: Fix stimeout option not applied on http tunnel

2019-04-10 Thread Jun Li
On Mon, Apr 8, 2019 at 8:19 PM Jun Li wrote: > On Mon, Apr 8, 2019 at 6:23 PM Liu Steven wrote: > >> >> >> > 在 2019年4月9日,上午8:54,Jun Li 写道: >> > >> > Ping. >> > >> > On Fri, Apr 5, 2019 at 12:00 PM Jun Li wrote: >> > >> >> >> >> >> >> On Fri, Apr 5, 2019 at 11:50 AM Jun Li wrote: >> >> >> >>>

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

2019-04-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Wednesday, April 10, 2019 7:27 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: Fix the memory leak for > enc_ctrl.Payload > >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-10 Thread James Almer
On 4/10/2019 3:30 PM, James Almer wrote: > The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, > inclusive. > > Signed-off-by: James Almer > --- > A good example of why making offsets and sizes of structs like this tied to > the > ABI is not a good idea. > >

[FFmpeg-devel] Concatenate NAL units in av_write_frame call

2019-04-10 Thread Andriy Gelman
Hello, I've been working with HEVC + mpegts at low bitrates 10-20kbps. At these bitrates, mpegts can create a substantial overhead due to the 188 byte frame size (i.e. a NAL unit of 200 bytes will get rounded up to 376 bytes). I've tried to get around this by concatenating multiple NAL

Re: [FFmpeg-devel] [PATCH, v2] lavu/hwcontext_qsv: Fix the realign check for hwupload

2019-04-10 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Wednesday, April 10, 2019 7:56 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2] lavu/hwcontext_qsv: Fix the realign > check for hwupload > > Fix the aligned check

Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-10 Thread Cld fire
On Wed, Apr 10, 2019 at 6:10 PM Mark Thompson wrote: > The lack of checks in overlay_opencl generally leaves a lot to be > desired. It's is intended for (and only really tested with) hardware video > in YUV formats (primarily overlaying YUV or YUVA on YUV, for things like > subtitles or pips),

Re: [FFmpeg-devel] [PATCH] configure: sort decoder/encoder/filter/... names in alphabet order in one page

2019-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Thursday, April 11, 2019 4:14 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] configure: sort >

Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-10 Thread Cld fire
On Wed, Apr 10, 2019 at 4:30 PM Carl Eugen Hoyos wrote: > 2019-04-10 5:37 GMT+02:00, Jarek Samic : > > > +// Make sure the input is a format we support > > +if (fmt != AV_PIX_FMT_ARGB && > > +fmt != AV_PIX_FMT_RGBA && > > +fmt != AV_PIX_FMT_ABGR && > > +

[FFmpeg-devel] [PATCH] avcodec/agm: Check frame dimensions

2019-04-10 Thread Michael Niedermayer
Fixes: out of array access Fixes: 14110/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5649184864075776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/agm.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH] libavcodec/libdav1d: add libdav1d_get_format method to call ff_get_format

2019-04-10 Thread Hendrik Leppkes
On Thu, Apr 11, 2019 at 12:39 AM Lukas Rusak wrote: > > This will allow applications to properly init the decoder in > cases where a hardware decoder is tried first and and software > decoder is tried after by calling the get_format callback. > > Even though there is no hardware pixel formats

[FFmpeg-devel] [PATCH] libavcodec/libdav1d: add libdav1d_get_format method to call ff_get_format

2019-04-10 Thread Lukas Rusak
This will allow applications to properly init the decoder in cases where a hardware decoder is tried first and and software decoder is tried after by calling the get_format callback. Even though there is no hardware pixel formats available we still need to return the software pixel format.

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread James Almer
On 4/10/2019 6:23 PM, Baptiste Coudurier wrote: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 173 +++ > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 213

Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-10 Thread Mark Thompson
On 10/04/2019 04:37, Jarek Samic wrote: > This is a direct port of the CPU filter. > > Signed-off-by: Jarek Samic > --- > This is my submission for the GSoC OpenCL video filters project qualification > task. > > Command you can use to try it out: > > ./ffmpeg -i some_video -i some_img

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread James Almer
On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: >> On Apr 9, 2019, at 6:27 PM, James Almer wrote: >> >> On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: >>> On Apr 9, 2019, at 5:24 PM, James Almer wrote: On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at

[FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Baptiste Coudurier
--- libavformat/Makefile | 2 +- libavformat/avc.c| 173 +++ libavformat/avc.h| 15 +++ libavformat/hevc.c | 36 +--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 213 ++- 6 files changed, 359

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Baptiste Coudurier
> On Apr 9, 2019, at 6:27 PM, James Almer wrote: > > On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: >> >>> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >>> >>> On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > On Apr 9, 2019, at 4:51 PM, James Almer wrote: > > On 4/9/2019

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread James Almer
On 4/10/2019 2:22 AM, Hendrik Leppkes wrote: > On Wed, Apr 10, 2019 at 3:28 AM James Almer wrote: >>> Two thirds of SPS is not hard to implement, so i really don't understand why you're so adamantly against it. >>> >>> I’m adamant about re-using code between libavcodec and libavformat.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/pnm_parser: Factor out next/index compensation

2019-04-10 Thread Michael Niedermayer
On Sun, Apr 07, 2019 at 09:48:36AM +0200, Paul B Mahol wrote: > On 4/7/19, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/pnm_parser.c | 10 -- > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/libavcodec/pnm_parser.c

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/pnm_parser: Factor next initialization out

2019-04-10 Thread Michael Niedermayer
On Sun, Apr 07, 2019 at 09:47:57AM +0200, Paul B Mahol wrote: > On 4/7/19, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/pnm_parser.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libavcodec/pnm_parser.c

Re: [FFmpeg-devel] [PATCH] avcodec/pnm_parser: Support concatenated ASCII images

2019-04-10 Thread Michael Niedermayer
On Sat, Apr 06, 2019 at 02:39:25PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (8sec -> 0.1sec) > Fixes: > 13864/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAM_fuzzer-5737860621139968 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] lavfi: add colorkey_opencl filter

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 5:37 GMT+02:00, Jarek Samic : > +// Make sure the input is a format we support > +if (fmt != AV_PIX_FMT_ARGB && > +fmt != AV_PIX_FMT_RGBA && > +fmt != AV_PIX_FMT_ABGR && > +fmt != AV_PIX_FMT_BGRA && > +fmt !=

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 2:40 GMT+02:00, Baptiste Coudurier : > >> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >> More than one ffmpeg release will ship with libavcodec/libavformat >> sharing the same soname. Backwards compatibility is expected, hence the >> split between major, minor and micro, as you're

Re: [FFmpeg-devel] [PATCH] avcodec/bintext: Add error message when resolution is too small for font.

2019-04-10 Thread Michael Niedermayer
On Mon, Apr 08, 2019 at 03:22:10PM -0700, Nikolas Bowe via ffmpeg-devel wrote: > --- > libavcodec/bintext.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if

Re: [FFmpeg-devel] [PATCH] configure: sort decoder/encoder/filter/... names in alphabet order in one page

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 17:16 GMT+02:00, Guo, Yejun : > takes decoder names an example, with the default page length, > shell command 'pr' needs two pages for all the decoder names. > The names are firstly printed in the first page, then in the second > page. So, as a whole, the names are sorted neither in

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread Carl Eugen Hoyos
2019-04-09 20:32 GMT+02:00, James Almer : > Fixes ticket #7174. > > Signed-off-by: James Almer > --- > This makes what's essentially a non spec compliant > stream decodable again with no visual artifacts, and > without reintroducing the risk of overflows. Your patch leads to bit-exact output

[FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-10 Thread James Almer
The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, inclusive. Signed-off-by: James Almer --- A good example of why making offsets and sizes of structs like this tied to the ABI is not a good idea. libavcodec/h264_ps.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH v4 5/7] lavfi/vaapi: Improve support for colour properties

2019-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2019 at 11:07:28PM +0100, Mark Thompson wrote: > Attempts to pick the set of supported colour properties best matching the > input. Output is then set with the same values, except for the colour > matrix which may change when converting between RGB and YUV. > --- > On 04/03/2019

Re: [FFmpeg-devel] [PATCH]download: Fix the release link

2019-04-10 Thread Lou Logan
On Fri, Mar 29, 2019, at 9:39 AM, Michael Niedermayer wrote: > > and i would suggest we consider setting up some bug bounties for these > 151 ? regressions or a subset of them. This may help to draw more > interrest towards them ... Getting off-topic here, but I think some of the donated funds

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread James Almer
On 4/10/2019 5:24 AM, Michael Niedermayer wrote: > On Tue, Apr 09, 2019 at 03:32:26PM -0300, James Almer wrote: >> Fixes ticket #7174. >> >> Signed-off-by: James Almer >> --- >> This makes what's essentially a non spec compliant stream decodable again >> with >> no visual artifacts, and without

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread James Almer
Fixes ticket #7174. Signed-off-by: James Almer --- Now using avpriv_request_sample() libavcodec/h264_parse.c | 15 +-- libavcodec/h264_slice.c | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Thomas Mundt
Hi Baptiste, Am Mi., 10. Apr. 2019 um 00:29 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > Hi Thomas, I hope you are doing well > > > On Apr 4, 2019, at 7:27 AM, Thomas Mundt wrote: > > > > Hi Baptiste, > > > > […] > > For RP2027 Class 100 1080/50i I still get the error:

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: add ADPCM AGM decoder

2019-04-10 Thread Paul B Mahol
On 4/10/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/adpcm.c | 58 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + >

Re: [FFmpeg-devel] [PATCH v6] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2019 at 11:50:16PM +0530, Shivam Goyal wrote: > lavf/flv: Add XV (Xunlei Video) Support. > > Fixes ticket #3720. > > > > Changelog|1 > libavformat/Makefile |1 > libavformat/allformats.c |1 > libavformat/flvdec.c | 86 >

Re: [FFmpeg-devel] [PATCH] libavfilter: Add derain filter init version--GSoC Qualification Task.

2019-04-10 Thread Pedro Arthur
Hi, Em ter, 9 de abr de 2019 às 22:42, escreveu: > > Yes, I use the espcn model for deraining as the initial version as it's a > easier way to implement the filter, although the paper proposes it for > super-resolution. And the model does have some effect on deraining project. > While, it is

Re: [FFmpeg-devel] [PATCH]download: Fix the release link

2019-04-10 Thread Michael Niedermayer
On Wed, Apr 10, 2019 at 05:10:53PM +0200, Paul B Mahol wrote: > On 3/29/19, Michael Niedermayer wrote: > > On Fri, Mar 29, 2019 at 01:16:41AM +0100, Carl Eugen Hoyos wrote: > >> 2019-03-28 20:52 GMT+01:00, Michael Niedermayer : > >> > On Thu, Mar 28, 2019 at 06:47:52PM +0100, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]download: Fix the release link

2019-04-10 Thread Paul B Mahol
On 3/29/19, Michael Niedermayer wrote: > On Fri, Mar 29, 2019 at 01:16:41AM +0100, Carl Eugen Hoyos wrote: >> 2019-03-28 20:52 GMT+01:00, Michael Niedermayer : >> > On Thu, Mar 28, 2019 at 06:47:52PM +0100, Carl Eugen Hoyos wrote: >> >> 2019-03-28 18:31 GMT+01:00, Michael Niedermayer >> >> : >>

Re: [FFmpeg-devel] [PATCH] avformat/dashenc : Fix streaming mode support for webm output

2019-04-10 Thread Andreas Rheinhardt via ffmpeg-devel
Jeyapal, Karthick: > > On 4/8/19 7:37 PM, Andreas Rheinhardt via ffmpeg-devel wrote: >> Karthick J via ffmpeg-devel: >>> --- >>> libavformat/dashenc.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c >>> index

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec Adding ff_v210_planar_unpack AVX2

2019-04-10 Thread James Darnley
On 2019-04-10 14:47, James Darnley wrote: > From: Michael Stoner Screw you mailing list or git, which ever one of you managed to screw up the author's address. I will correct that, if I can. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 1/3] avcodec/v210dec: move DSP function setting into dedicated function

2019-04-10 Thread James Darnley
Prepare for checkasm test. --- libavcodec/v210dec.c | 16 ++-- libavcodec/v210dec.h | 1 + 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index ddc5dbe8be..fd8a6b0d78 100644 --- a/libavcodec/v210dec.c +++

[FFmpeg-devel] [PATCH 3/3] libavcodec Adding ff_v210_planar_unpack AVX2

2019-04-10 Thread James Darnley
From: Michael Stoner Replaced VSHUFPS with VPBLENDD to relieve port 5 bottleneck AVX2 is 1.4x faster than AVX --- Mike, is this still the patch you want applied. I had to make a small amendment to it because you had some tabs as indentation. libavcodec/v210dec.c | 10 +-

[FFmpeg-devel] [PATCH 0/3] v210dec checkasm test and avx2 function

2019-04-10 Thread James Darnley
I am resending this my patches because I am not sure if I sent this version in the past. I split my changes into two patches because they do separate things. I also changed some tabs to spaces in Mike's AVX2 patch. James Darnley (2): avcodec/v210dec: move DSP function setting into dedicated

[FFmpeg-devel] [PATCH 2/3] checkasm: add test for v210dec

2019-04-10 Thread James Darnley
--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/v210dec.c | 77 +++ 4 files changed, 82 insertions(+) create mode 100644 tests/checkasm/v210dec.c diff --git a/tests/checkasm/Makefile

[FFmpeg-devel] [PATCH, v2] lavu/hwcontext_qsv: Fix the realign check for hwupload

2019-04-10 Thread Linjie Fu
Fix the aligned check in hwupload, input surface should be 16 aligned too. Fix #7830. Signed-off-by: Linjie Fu --- libavutil/hwcontext_qsv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index b6d8bfe2bf..8b000fe636

[FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 404 +++-- libavformat/riff.c | 4 + 2 files changed, 392 insertions(+), 16 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index cbd45e8095..1d6a277827 100644 --- a/libavcodec/agm.c +++

[FFmpeg-devel] [PATCH 3/3] avcodec: add ADPCM AGM decoder

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 58 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavformat/riff.c | 1 + 6 files changed, 69

[FFmpeg-devel] [PATCH 2/3] avcodec/agm: add support for non-dct coding

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 332 +++-- libavformat/riff.c | 2 + 2 files changed, 291 insertions(+), 43 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index 1d6a277827..e465b22d41 100644 --- a/libavcodec/agm.c +++

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Fix the realign check for hwupload

2019-04-10 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Wednesday, April 10, 2019 19:35 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Fix the

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Fix the realign check for hwupload

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 13:26 GMT+02:00, Linjie Fu : > Fix the aligned check in hwupload, input surface should be 16 aligned > too. > > Fix #7830. > > Signed-off-by: Linjie Fu > --- > libavutil/hwcontext_qsv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 13:27 GMT+02:00, Linjie Fu : > frame->enc_ctrl.Payload is malloced in get_free_frame, directly memset > the whole structure of enc_ctrl to zero will cause the memory leak for > enc_ctrl.Payload. > > Fix the memory leak issue and reset other members in mfxEncodeCtrl. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-04-10 Thread Mathieu Duponchelle
No problem, note that the added indentation is because a loop was added :) On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: > 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : >> It is perfectly valid to have multiple CC Picture User Data >> for the same frame. Instead of using the first side_data >>

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

2019-04-10 Thread Linjie Fu
frame->enc_ctrl.Payload is malloced in get_free_frame, directly memset the whole structure of enc_ctrl to zero will cause the memory leak for enc_ctrl.Payload. Fix the memory leak issue and reset other members in mfxEncodeCtrl. Signed-off-by: Linjie Fu --- libavcodec/qsvenc.c | 2 +- 1 file

[FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Fix the realign check for hwupload

2019-04-10 Thread Linjie Fu
Fix the aligned check in hwupload, input surface should be 16 aligned too. Fix #7830. Signed-off-by: Linjie Fu --- libavutil/hwcontext_qsv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index b6d8bfe2bf..bc6236f25d

Re: [FFmpeg-devel] [PATCH] avdevice/opengl_enc: fix build error using msvc compiler

2019-04-10 Thread Carl Eugen Hoyos
2019-04-09 17:22 GMT+02:00, BIGLER Don (Framatome) : >>2019-04-08 17:07 GMT+02:00, BIGLER Don (Framatome) >> : > >>> diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c >>> index 54c7e610bd..4263f0e4ef 100644 >>> --- a/libavdevice/opengl_enc.c >>> +++ b/libavdevice/opengl_enc.c >>> @@

Re: [FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-10 Thread Andreas Rheinhardt via ffmpeg-devel
Aman Gupta: > On Wed, Apr 10, 2019 at 1:00 AM Hendrik Leppkes wrote: > >> On Wed, Apr 10, 2019 at 9:55 AM Aman Gupta wrote: >>> >>> On Tue, Apr 9, 2019 at 9:49 PM Hendrik Leppkes >> wrote: >>> On Wed, Apr 10, 2019 at 2:21 AM Aman Gupta wrote: > > From: Aman Gupta > >

Re: [FFmpeg-devel] [PATCH, v4] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

2019-04-10 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, April 10, 2019 07:20 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vaapi_decode: find exact > va_profile for HEVC_REXT > > On

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

2019-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2019 at 03:32:26PM -0300, James Almer wrote: > Fixes ticket #7174. > > Signed-off-by: James Almer > --- > This makes what's essentially a non spec compliant stream decodable again with > no visual artifacts, and without reintroducing the risk of overflows. > > Alternatively, we

Re: [FFmpeg-devel] [PATCH] lavfi: add nlmeans_opencl filter

2019-04-10 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Tuesday, April 9, 2019 9:21 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add nlmeans_opencl filter > >

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/dashenc : Prevent writing manifest files multiple times

2019-04-10 Thread Jeyapal, Karthick via ffmpeg-devel
On 4/8/19 6:23 PM, joepadmiraal wrote: > --- > libavformat/dashenc.c | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index f8d71166d4..4585a46202 100644 > --- a/libavformat/dashenc.c > +++

Re: [FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-10 Thread Aman Gupta
On Wed, Apr 10, 2019 at 1:00 AM Hendrik Leppkes wrote: > On Wed, Apr 10, 2019 at 9:55 AM Aman Gupta wrote: > > > > On Tue, Apr 9, 2019 at 9:49 PM Hendrik Leppkes > wrote: > > > > > On Wed, Apr 10, 2019 at 2:21 AM Aman Gupta wrote: > > > > > > > > From: Aman Gupta > > > > > > > > Previously,

Re: [FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-10 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 9:55 AM Aman Gupta wrote: > > On Tue, Apr 9, 2019 at 9:49 PM Hendrik Leppkes wrote: > > > On Wed, Apr 10, 2019 at 2:21 AM Aman Gupta wrote: > > > > > > From: Aman Gupta > > > > > > Previously, the initial seek position was recorded into > > > old_offset at the beginning

Re: [FFmpeg-devel] [RFC PATCH] avformat/utils: always seek back after avformat_find_stream_info()

2019-04-10 Thread Aman Gupta
On Tue, Apr 9, 2019 at 9:49 PM Hendrik Leppkes wrote: > On Wed, Apr 10, 2019 at 2:21 AM Aman Gupta wrote: > > > > From: Aman Gupta > > > > Previously, the initial seek position was recorded into > > old_offset at the beginning of avformat_find_stream_info(), > > and passed into

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: export operational pattern UL as file metadata

2019-04-10 Thread Tomas Härdin
mån 2019-04-08 klockan 14:36 +0100 skrev Tomas Härdin: > On 2019-04-03 21:35, Marton Balint wrote: > > Can be useful for API users as ffmpeg/libavformat can't properly > > support some > > operational patterns. > > > > Signed-off-by: Marton Balint > > --- > >   libavformat/mxfdec.c   | 7

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_parse: clear invalid luma weights in ff_h264_pred_weight_table()

2019-04-10 Thread Michael Niedermayer
On Tue, Apr 09, 2019 at 03:32:25PM -0300, James Almer wrote: > Based on commit 85c85f3f9c75301db3eba1bd5f2fb1e6285d. > > Signed-off-by: James Almer > --- > libavcodec/h264_parse.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH] configure: sort decoder/encoder/filter/... names in alphabet order in one page

2019-04-10 Thread Guo, Yejun
takes decoder names an example, with the default page length, shell command 'pr' needs two pages for all the decoder names. The names are firstly printed in the first page, then in the second page. So, as a whole, the names are sorted neither in column order nor in row order. It's a little

Re: [FFmpeg-devel] [PATCH] avformat/dashenc : Fix streaming mode support for webm output

2019-04-10 Thread Jeyapal, Karthick via ffmpeg-devel
On 4/8/19 7:37 PM, Andreas Rheinhardt via ffmpeg-devel wrote: > Karthick J via ffmpeg-devel: >> --- >> libavformat/dashenc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c >> index f8d71166d4..9dd520787f 100644 >> ---

[FFmpeg-devel] [PATCH] avformat/dashenc: Disable streaming for webm output

2019-04-10 Thread Karthick J via ffmpeg-devel
Currently streaming for webm output doesn't work. Disabling explicitly will make sure that the manifest will get generated correctly. --- libavformat/dashenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index f8d71166d4..d8dcbc1230