[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: Write slice data directly

2019-11-15 Thread Andreas Rheinhardt
Up until now, writing the data of a slice uses an intermediate buffer into which the unit (both header as well as the rest) is assembled before being copied into a freshly allocated buffer. But given that one has a very good upper bound on the size needed before one starts copying the slice data,

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs: Fix potential overflow

2019-11-15 Thread Andreas Rheinhardt
The number of bits in a PutBitsContext must fit into an int, yet the various cbs functions to write units did not check that the argument in init_put_bits is in the range 0..INT_MAX / 8. This has been changed. Furthermore, the check 8 * data_size > data_bit_start that there is data beyond the

[FFmpeg-devel] [PATCH 1/3] avcodec/put_bits: Relax requirements to rebase PutBitContext

2019-11-15 Thread Andreas Rheinhardt
The earlier requirement was for the new buffer to be bigger than the old one. This has been relaxed to only demand that the new buffer can hold all the data written so far. This is in preparation for further commits. Signed-off-by: Andreas Rheinhardt --- libavcodec/put_bits.h | 20

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: keep separate reference frame state for reading and writing

2019-11-15 Thread James Almer
In scearios where a Temporal Unit is written right after reading it using the same CBS context (av1_metadata, av1_frame_merge, etc), the reference frame state used by the writer must not be the state that's the result of the reader having already parsed the current frame in question. This fixes

[FFmpeg-devel] [PATCH 1/2] avformat/rmdec: Initialize and sanity check offset in ivr_read_header()

2019-11-15 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775808 - 17 cannot be represented in type 'long' Fixes: 18768/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5674385247830016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/2] avcodec/dvdec: Use av_clip_uint8 instead of ff_crop_tab

2019-11-15 Thread Michael Niedermayer
Fixes: out of array access Fixes: 18788/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVVIDEO_fuzzer-6254863113781248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dvdec.c | 3 +-- 1

Re: [FFmpeg-devel] [PATCH 01/23] avformat/matroskaenc: Fix ReferenceBlock timestamp

2019-11-15 Thread Andreas Rheinhardt
Andreas Rheinhardt: > In order to indicate that the frames in a BlockGroup are not keyframes, > one has to add a ReferenceBlock element containing the timestamp of a > reference block that has already been written. The timestamp ought to be > relative to the timestamp of the block it is attached

Re: [FFmpeg-devel] [PATCH 1/5] vcodec/agm: Alloc based on coded dimensions

2019-11-15 Thread Michael Niedermayer
On Thu, Nov 14, 2019 at 06:07:30PM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1: keep separate reference frame state for reading and writing

2019-11-15 Thread James Almer
In scearios where a Temporal Unit is written right after reading it using the same CBS context (av1_metadata, av1_frame_merge, etc), the reference frame state used by the writer must not be the state that's the result of the reader having already parsed the current frame in question. This fixes

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: fix reading reference order hint in skip_mode_params()

2019-11-15 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_av1_syntax_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index 806b302de6..c843cfa02b 100644 --- a/libavcodec/cbs_av1_syntax_template.c

[FFmpeg-devel] [PATCH] avformat/mov: fix typo in help text

2019-11-15 Thread Zhao Zhili
--- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5c67fbc68..7553a7fdfc 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8028,7 +8028,7 @@ static const AVOption mov_options[] = {

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Simplify flushing bsf

2019-11-15 Thread Andreas Rheinhardt
Since flushing can now also be signalled by sending an empty packet (a packet without (side-)data), it is unnecessary to explicitly send NULL as packet to flush the bitstream filters. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH V2 2/2] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-15 Thread Limin Wang
On Fri, Nov 15, 2019 at 04:35:49PM +0800, leozhang wrote: > Reviewed-by: Paul B Mahol > Reviewed-by: Jun Zhao > Signed-off-by: leozhang > --- > > doc/filters.texi | 4 > libavfilter/vf_bilateral.c | 23 ++- > 2 files changed, 26 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH v3 1/2] avfilter/vf_colorbalance:: Fix for framecrc bitexact for 32bit and 64bit system

2019-11-15 Thread lance . lmwang
Signed-off-by: Limin Wang --- libavfilter/vf_colorbalance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_colorbalance.c b/libavfilter/vf_colorbalance.c index cc90dc08c7..56f9d5c49c 100644 --- a/libavfilter/vf_colorbalance.c +++

[FFmpeg-devel] [PATCH v3 2/2] FATE: add a test for colorbalance

2019-11-15 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 12 tests/ref/fate/filter-colorbalance | 8 tests/ref/fate/filter-colorbalance-gbrap| 8 tests/ref/fate/filter-colorbalance-gbrap-16 | 8

Re: [FFmpeg-devel] [PATCH v1 4/4] fate/filter-video: add 10bit test for unsharp filter

2019-11-15 Thread Limin Wang
On Mon, Oct 21, 2019 at 08:33:07PM +0200, Michael Niedermayer wrote: > On Mon, Oct 21, 2019 at 03:55:50PM +0800, Limin Wang wrote: > > On Tue, Oct 15, 2019 at 04:41:36PM +0200, Michael Niedermayer wrote: > > > On Mon, Oct 14, 2019 at 06:27:07PM +0800, lance.lmw...@gmail.com wrote: > > > > From:

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2019-11-15 Thread Limin Wang
ping, the patchset is for HDR/HLG color support for prores. On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > It's based on the following specs: > RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax > and Decoding Process

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-15 Thread Limin Wang
On Sun, Nov 03, 2019 at 01:20:38AM +0100, Nomis101 wrote: > --- > libavcodec/videotoolboxenc.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 40a7f643e0..cc08cf6a50 100644 > --- a/libavcodec/videotoolboxenc.c >

Re: [FFmpeg-devel] [PATCH 1/2] backport NULL pointer dereference fix / CVE-2019-17539 / 15733 clusterfuzz

2019-11-15 Thread Michael Niedermayer
On Thu, Nov 14, 2019 at 11:42:45PM +0100, Michael Niedermayer wrote: > On Thu, Nov 14, 2019 at 03:01:29PM -0500, James Boyle wrote: > > Hello, > > > > This patch is nearly identical to commit > > 8df6884832ec413cf032dfaa45c23b1c7876670c, but is intended to backport > > the fix for CVE-2019-17539

[FFmpeg-devel] [PATCH] lavf/rtmpproto: fix the playpath truncation if the len > 512

2019-11-15 Thread Jun Zhao
From: Jun Zhao fix the playpath truncation if the len > 512 Found-by: liuwenhuang Signed-off-by: Jun Zhao --- libavformat/rtmpproto.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 42c6b94..5274993

Re: [FFmpeg-devel] [PATCH V4] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-15 Thread Tao Zhang
The new patchsets are https://patchwork.ffmpeg.org/patch/16279/ https://patchwork.ffmpeg.org/patch/16280/ Please review it, thx Tao Zhang 于2019年11月15日周五 下午4:38写道: > > I submit new patchset. Have separate functional and non-functional > changes. Also updated doc, inspired by Paul's commit >

Re: [FFmpeg-devel] [PATCH V4] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-15 Thread Tao Zhang
I submit new patchset. Have separate functional and non-functional changes. Also updated doc, inspired by Paul's commit https://github.com/FFmpeg/FFmpeg/commit/45f03cdd20c3f9a83d4955fa32ffdc287229ccfd Tao Zhang 于2019年11月11日周一 下午7:55写道: > > ping, at the beginning of the new week:) > > leozhang

[FFmpeg-devel] [PATCH v4 1/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-11-15 Thread Yuki Tsuchiya
Implemented according to the specification at https://www.iso.org/standard/69561.html The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS encapsulated single stream MPEG-H 3D Audio. 'MHAS' stands for MPEG-H audio stream, which contains encoded audio data and corresponds

[FFmpeg-devel] [PATCH v4 2/2] lavf/movenc: cosmetics

2019-11-15 Thread Yuki Tsuchiya
Signed-off-by: Yuki Tsuchiya --- libavformat/movenc.c | 72 +++- 1 file changed, 38 insertions(+), 34 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index ff234d9f2b..328fd7bee0 100644 --- a/libavformat/movenc.c +++

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-11-15 Thread Tsuchiya, Yuki (SHES)
I will rebase against current master and send the new patch. Hi Jan, Do you have any comment to my answer? Regards, Yuki Tsuchiya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH v1] avfilter: Add tonemap vaapi filter for H2S

2019-11-15 Thread Sun, Xinpeng
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Thursday, November 14, 2019 1:12 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1] avfilter: Add tonemap vaapi filter for > H2S > > On Tue, Nov 12, 2019 at