Re: [FFmpeg-devel] About support a new arch

2020-12-10 Thread Steven Liu
> 2020年12月11日 下午3:55,俞林杰 写道: > > a new arch called csky How should we test your code for this arch? Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

[FFmpeg-devel] About support a new arch

2020-12-10 Thread 俞林杰
Hi, all We have support a new arch called csky, for ffmpeg. How can I upload the code. Yours Damon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-10 Thread Steven Liu
> 2020年12月11日 下午1:58,hisunzhenli...@outlook.com 写道: > > From: SunZhenliang > > Just add HEVC's tag in 3gp tag list and it works to support HEVC in > 3gp files. > > Signed-off-by: SunZhenliang > --- > libavformat/movenc.c | 29 + > 1 file changed, 21 insertions(+),

[FFmpeg-devel] 回复: [PATCH, v3] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
Emmm, I didn't think carefully. Fixed it now. Sorry for another patch. Regards, Sunzhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 2020年12月11日 13:20 收件人: ffmpeg-devel@ffmpeg.org 主题: Re: [FFmpeg-devel] [PATCH, v3] libavformat/movenc: add support for HEVC in

[FFmpeg-devel] [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-10 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH, v3] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Gyan Doshi
On 11-12-2020 10:19 am, hisunzhenli...@outlook.com wrote: From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 32 1 file changed, 24 insertions(+), 8

[FFmpeg-devel] 回复: [PATCH v2] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
The modification has been completed and the patch has been submitted. Thanks for your review, Gyan. Regards, SunZhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 2020年12月11日 12:33 收件人: ffmpeg-devel@ffmpeg.org 主题: Re: [FFmpeg-devel] [PATCH v2]

[FFmpeg-devel] [PATCH, v3] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH v2] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Gyan Doshi
On 11-12-2020 09:08 am, hisunzhenli...@outlook.com wrote: From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 33 + 1 file changed, 25 insertions(+), 8

Re: [FFmpeg-devel] [FFmpeg-cvslog] mjpegdec: convert to receive_frame()

2020-12-10 Thread James Almer
On 12/10/2020 6:44 PM, Michael Niedermayer wrote: On Thu, Dec 10, 2020 at 09:11:44AM +, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Tue Dec 1 11:34:27 2020 +0100| [e9a2a8777317d91af658f774c68442ac4aa726ec] | committer: Anton Khirnov mjpegdec: convert to

[FFmpeg-devel] [PATCH v2] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH 04/11] avformat/utils: Move +1 to avoid overflow

2020-12-10 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Nov 28, 2020 at 09:51:44PM +0100, Michael Niedermayer wrote: >> On Fri, Oct 30, 2020 at 09:24:15PM +0100, Michael Niedermayer wrote: >>> On Wed, Oct 21, 2020 at 08:47:22AM +0200, Andreas Rheinhardt wrote: Andreas Rheinhardt: > Michael Niedermayer: >>

[FFmpeg-devel] 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
ok, I'll fix it and add a new patch shortly. And should i make [FFmpeg-devel,v2] to add the new patch ?and how? I am new to the patchwork, it would be helpful if you could give me some guidances. Regards, SunZhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间:

Re: [FFmpeg-devel] [PATCH 04/11] avformat/utils: Move +1 to avoid overflow

2020-12-10 Thread Michael Niedermayer
On Sat, Nov 28, 2020 at 09:51:44PM +0100, Michael Niedermayer wrote: > On Fri, Oct 30, 2020 at 09:24:15PM +0100, Michael Niedermayer wrote: > > On Wed, Oct 21, 2020 at 08:47:22AM +0200, Andreas Rheinhardt wrote: > > > Andreas Rheinhardt: > > > > Michael Niedermayer: > > > >> Fixes: signed integer

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Paul B Mahol
I strongly disagree, make use of money project got. Limiting size of samples is not gonna to be productive at all. On Fri, Dec 11, 2020 at 12:37 AM Carl Eugen Hoyos wrote: > Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol >: > > > > I already uploaded the other file to servers. > > We

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Carl Eugen Hoyos
Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol : > > I already uploaded the other file to servers. We can still remove it. Downloading the fate suite takes very long and it will get bigger no matter the year. Carl Eugen ___ ffmpeg-devel

[FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9005. Please comment, Carl Eugen From e1ee77e80f041aff2e24e029acdf0cc2ce073ecf Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 11 Dec 2020 00:26:20 +0100 Subject: [PATCH] lavd/decklink_dec: Use correct case for codec point / fourcc v210. Reported and

Re: [FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Andreas Rheinhardt
Paul B Mahol: > OK, > > I guess encoding still works. > Yes, it does. In fact, you need to enable either trellis or quantizer_noise_shaping for it to make a difference. A quick test with trellis on showed strange artifacts without this patch that are eliminated by this patch; furthermore, the

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe

2020-12-10 Thread Carl Eugen Hoyos
Am Do., 10. Dez. 2020 um 23:59 Uhr schrieb Michael Niedermayer : > > On Wed, Dec 09, 2020 at 11:43:49PM +0100, Carl Eugen Hoyos wrote: > > Am Mi., 9. Dez. 2020 um 23:38 Uhr schrieb Carl Eugen Hoyos > > : > > > > > Attached patch fixes ticket #9026. > > > > Alternative patch attached. > > > > Carl

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe

2020-12-10 Thread Michael Niedermayer
On Wed, Dec 09, 2020 at 11:43:49PM +0100, Carl Eugen Hoyos wrote: > Am Mi., 9. Dez. 2020 um 23:38 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patch fixes ticket #9026. > > Alternative patch attached. > > Carl Eugen > rawdec.c |2 ++ > 1 file changed, 2 insertions(+) >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_earwax: fix filter behavior

2020-12-10 Thread Paul B Mahol
Should be fixed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 14/39] avcodec/h261dec: Don't use too big max_depth in get_vlc2()

2020-12-10 Thread Michael Niedermayer
On Thu, Dec 10, 2020 at 12:16:32PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h261dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok assuming its not better to make H261_CBP_VLC_BITS smaller thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 18/39] avcodec/motion_est, mpegvideo: Make pointers to static storage const

2020-12-10 Thread Michael Niedermayer
On Thu, Dec 10, 2020 at 12:16:36PM +0100, Andreas Rheinhardt wrote: > Modifying static storage must not happen because of multithreading > (except initialization of course), so add const to the pointed-to type > for pointers that point to static storage. > > Signed-off-by: Andreas Rheinhardt >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_earwax: fix filter behavior

2020-12-10 Thread Michael Niedermayer
On Mon, Dec 07, 2020 at 08:11:33PM +, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Fri Dec 4 > 17:54:05 2020 +0100| [f41de0436cc8ce7221cd3702a51f3676cc689cf7] | committer: > Paul B Mahol > > avfilter/af_earwax: fix filter behavior > > Previous filter output was

Re: [FFmpeg-devel] [FFmpeg-cvslog] mjpegdec: convert to receive_frame()

2020-12-10 Thread Michael Niedermayer
On Thu, Dec 10, 2020 at 09:11:44AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue Dec 1 > 11:34:27 2020 +0100| [e9a2a8777317d91af658f774c68442ac4aa726ec] | committer: > Anton Khirnov > > mjpegdec: convert to receive_frame() > > This will be useful in the

[FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-12-10 Thread Alan Kelly
--- Replaces ff_sws_init_swscale_x86 with ff_getSwsFunc Load offset if not gprsize but 8 on both 32 and 64 bit Removes sfence as NT store no longer used libswscale/x86/Makefile | 1 + libswscale/x86/swscale.c| 106 +--- libswscale/x86/yuv2yuvX.asm | 117

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Gyan Doshi
On 10-12-2020 01:34 pm, hisunzhenli...@outlook.com wrote: From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-12-10 Thread Josh Dekker
On 2020/12/09 11:19, Alan Kelly wrote: --- Activates avx2 version of yuv2yuvX Adds checkasm for yuv2yuvX Modifies ff_yuv2yuvX_* signature to match yuv2yuvX_* Replaces non-temporal stores with temporal stores libswscale/x86/Makefile | 1 + libswscale/x86/swscale.c| 106

Re: [FFmpeg-devel] [PATCH] lavf/qsv_scale: add interpolation methods support

2020-12-10 Thread Xiang, Haihao
On Thu, 2020-12-10 at 14:52 +0300, Artem Galin wrote: > On Wed, 2 Dec 2020 at 04:25, Xiang, Haihao wrote: > > > On Tue, 2020-12-01 at 22:42 +, Artem Galin wrote: > > > Since 1.33 API version > > > > > > >

Re: [FFmpeg-devel] [PATCH 1/3] tests/audiomatch: add free to make static analysis tools happy

2020-12-10 Thread myp...@gmail.com
On Thu, Dec 10, 2020 at 4:11 PM Anton Khirnov wrote: > > Quoting Jun Zhao (2020-12-09 10:53:08) > > From: Jun Zhao > > > > Signed-off-by: Jun Zhao > > --- > > tests/audiomatch.c | 11 +-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > looks ok > Pushed, thx

[FFmpeg-devel] [PATCH v2 3/6] avcodec/dpx: Read SMPTE timecode from DPX

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/dpx.c | 29 + tests/ref/fate/dpx-probe | 7 +++ 2 files changed, 36 insertions(+) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 7e3ac0af2e..51428459ef 100644 --- a/libavcodec/dpx.c +++

[FFmpeg-devel] [PATCH v2 6/6] avcodec/dpx: Fix B film scans from Lasergraphics Inc

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/dpx.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 7b18141f97..bd431ccbcb 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -167,7 +167,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Paul B Mahol
Nope. You do not need to send new patches. On Thu, Dec 10, 2020 at 1:30 PM Harry Mallon wrote: > > > > On 10 Dec 2020, at 12:21, Paul B Mahol wrote: > > > > I already uploaded the other file to servers. > > Ah, sorry about that. > > > > > And I doubt it hurts at all in 2020. > > Also I doubt

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Harry Mallon
> On 10 Dec 2020, at 12:21, Paul B Mahol wrote: > > I already uploaded the other file to servers. Ah, sorry about that. > > And I doubt it hurts at all in 2020. > Also I doubt one can overwrite files that easily. I have sent the V2. It is all exactly the same except it is set up for the

[FFmpeg-devel] [PATCH v2 5/6] avcodec/dpx: Read color information from DPX header

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/dpx.c | 127 +-- tests/ref/fate/dpx-probe | 8 +-- 2 files changed, 127 insertions(+), 8 deletions(-) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 577171258a..7b18141f97 100644 ---

[FFmpeg-devel] [PATCH v2 4/6] avcodec/dpx: Report color_range from DPX header

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/dpx.c | 25 - tests/ref/fate/dpx-probe | 4 ++-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 51428459ef..577171258a 100644 --- a/libavcodec/dpx.c +++

[FFmpeg-devel] [PATCH v2 2/6] avcodec/dpx: Read alternative frame rate from television header

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- libavcodec/dpx.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index b1833ed9ef..7e3ac0af2e 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -216,10 +216,23 @@ static int

[FFmpeg-devel] [PATCH v2 1/6] fate: Add dpx-probe test

2020-12-10 Thread Harry Mallon
Signed-off-by: Harry Mallon --- tests/fate/image.mak | 4 ++ tests/ref/fate/dpx-probe | 85 2 files changed, 89 insertions(+) create mode 100644 tests/ref/fate/dpx-probe diff --git a/tests/fate/image.mak b/tests/fate/image.mak index

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Paul B Mahol
I already uploaded the other file to servers. And I doubt it hurts at all in 2020. Also I doubt one can overwrite files that easily. On Thu, Dec 10, 2020 at 1:17 PM Harry Mallon wrote: > Hi Paul etc, > > I attach a smaller file (it will need the width height etc changing in the > test which I

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Harry Mallon
Hi Paul etc, I attach a smaller file (it will need the width height etc changing in the test which I will send as a V2 in a couple of mins). Harry cyan.dpx Description: Binary data > On 10 Dec 2020, at 11:51, Paul B Mahol wrote: > > File is fine, gonna apply this with ffprobe improved

Re: [FFmpeg-devel] [PATCH] lavf/qsv_scale: add interpolation methods support

2020-12-10 Thread Artem Galin
On Wed, 2 Dec 2020 at 04:25, Xiang, Haihao wrote: > On Tue, 2020-12-01 at 22:42 +, Artem Galin wrote: > > Since 1.33 API version > > > > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/api/include/mfxstructures.h#L2088 > > > > Signed-off-by: Artem Galin > > --- > >

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Paul B Mahol
File is fine, gonna apply this with ffprobe improved test. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH 13/39] avcodec/msmpeg4dec: Reuse identical MV VLC

2020-12-10 Thread Andreas Rheinhardt
msmpeg4dec and ituh263dec both create VLCs with identical parameters out of ff_mvtab. Given that ff_msmpeg4_decode_init() always (indirectly) calls ff_h263_decode_init_vlc(), the VLC initialized by the latter can be directly used by msmpeg4dec. Doing so saves a bit more than 2KB from the .bss

Re: [FFmpeg-devel] [PATCH 39/39] configure, libavcodec/speedhq: Fix compiling SpeedHQ encoder

2020-12-10 Thread Paul B Mahol
probably ok On Thu, Dec 10, 2020 at 12:25 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > configure| 1 + > libavcodec/speedhq.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/configure b/configure > index

[FFmpeg-devel] [PATCH 22/39] avcodec/h261dec: Reindentation

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index 61cd38caed..817453f60c 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@

Re: [FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Paul B Mahol
OK, I guess encoding still works. On Thu, Dec 10, 2020 at 12:25 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Up until now, the SpeedHQ encoder called a wrong function for init: > void ff_init_uni_ac_vlc(const uint8_t huff_size_ac[256], > uint8_t

Re: [FFmpeg-devel] [PATCH] avfilter: add asuperpass and asuperstop filter

2020-12-10 Thread Paul B Mahol
Will apply shortly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 14/39] avcodec/h261dec: Don't use too big max_depth in get_vlc2()

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index dfa779b574..374d17dfba 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -431,7 +431,7 @@ static int

[FFmpeg-devel] [PATCH 00/39] Make mpegvideo encoders init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
This patchset makes all mpegvideo encoders (i.e. all those that use ff_mpv_encode_init()) init-threadsafe; some of the patches here supersede earlier patches (namely #214-216 from my earlier init-threadsafe patchset [1] as well as patches from the latter part of my init-vlc patchset (said part

[FFmpeg-devel] [PATCH 39/39] configure, libavcodec/speedhq: Fix compiling SpeedHQ encoder

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- configure| 1 + libavcodec/speedhq.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/configure b/configure index 90914752f1..249d7afe02 100755 --- a/configure +++ b/configure @@ -2846,6 +2846,7 @@ sonic_encoder_select="golomb rangecoder"

[FFmpeg-devel] [PATCH 38/39] avcodec/speedhqenc: Hardcode table to save space

2020-12-10 Thread Andreas Rheinhardt
The SpeedHQ encoder currently reverses the entries of two small tables and stores them in other tables. These other tables have a size of 48 bytes, yet the code for their initialization takes 135 bytes (GCC 9.3, x64, O3 albeit in an av_cold function). So remove the runtime initialization and

[FFmpeg-devel] [PATCH 37/39] avcodec/speedhq, speedhqenc: Make codecs init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
The SpeedHQ decoder uses and initializes a RLTable's VLC, yet it also initializes other parts of the RLTable that it does not use. This has downsides besides being wasteful: Because the SpeedHQ encoder also initializes these additional fields, there is a potential for data races (and therefore

[FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Andreas Rheinhardt
Up until now, the SpeedHQ encoder called a wrong function for init: void ff_init_uni_ac_vlc(const uint8_t huff_size_ac[256], uint8_t *uni_ac_vlc_len); Yet the first argument actually used is of type RLTable; the size of said struct is less than 256 if the size of a pointer

[FFmpeg-devel] [PATCH 35/39] avcodec/msmpeg4enc: Reindent after the last commit

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4enc.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/libavcodec/msmpeg4enc.c b/libavcodec/msmpeg4enc.c index 3fd4d38820..0b000e9017 100644 --- a/libavcodec/msmpeg4enc.c +++

[FFmpeg-devel] [PATCH 34/39] avcodec/msmpeg4enc: Make msmpeg4 encoders init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 6 +++--- libavcodec/msmpeg4enc.c| 33 +++-- libavcodec/wmv2enc.c | 2 +- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH 33/39] avcodec/msmpeg4: Factor out common RLTable initialization code

2020-12-10 Thread Andreas Rheinhardt
Up until now, both the msmpeg4 decoders and encoders initialized several RLTables common to them (the decoders also initialized the VLCs of these RLTables). This is an obstacle to making these codecs init-threadsafe. So move this initialization to ff_msmpeg4_common_init() that already contains

[FFmpeg-devel] [PATCH 32/39] avcodec/msmpeg4enc: Don't use code for static init that can fail

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 3 +-- libavcodec/msmpeg4.h | 2 +- libavcodec/msmpeg4enc.c| 23 --- 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index

[FFmpeg-devel] [PATCH 31/39] avcodec/msmpeg4: Reindentation

2020-12-10 Thread Andreas Rheinhardt
Forgotten in/after f5957f3fe2b8dfda13a9750acc3e3a03cd5d39c9. Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4.c | 91 ++-- 1 file changed, 45 insertions(+), 46 deletions(-) diff --git a/libavcodec/msmpeg4.c b/libavcodec/msmpeg4.c index

[FFmpeg-devel] [PATCH 30/39] avcodec/msmpeg4: Make ff_msmpeg4_common_init() thread-safe

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/msmpeg4.c b/libavcodec/msmpeg4.c index 920f50f32c..ea1083c1a0 100644 --- a/libavcodec/msmpeg4.c +++ b/libavcodec/msmpeg4.c @@ -27,6 +27,8 @@ *

[FFmpeg-devel] [PATCH 29/39] avcodec/mpeg4videoenc: Make encoder init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index ca1c0dfd9c..8b98a1d507 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH 28/39] avcodec/mpeg4video: Making initializing RLTable thread-safe

2020-12-10 Thread Andreas Rheinhardt
Up until now the RLTable ff_mpeg4_rl_intra was initialized by both mpeg4 decoder and encoder (except the VLCs that are only used by the decoder). This is an obstacle to making these codecs init-threadsafe, so move initializing this to a single function that is guarded by a dedicated AVOnce.

[FFmpeg-devel] [PATCH 27/39] avcodec/ituh263enc: Make static initializations thread-safe

2020-12-10 Thread Andreas Rheinhardt
This already makes several encoders (namely FLV, H.263, H.263+ and RealVideo 1.0 and 2.0) that use this init-threadsafe. It also makes the Snow encoder init-threadsafe; it was already marked as such since commit d49210788b0836d56dd872d517fe73f83b080101, because it was thought to be harmless if

[FFmpeg-devel] [PATCH 26/39] avcodec/h263data, ituh263*: Make initializing RL inter table thread-safe

2020-12-10 Thread Andreas Rheinhardt
Up until now, ff_h263_rl_inter was initialized by both ituh263dec and ituh263enc; this is an obstacle in making the codecs that use this code init-threadsafe. This obstacle is eliminated by only initializing this RLTable from a single place that is guarded by a dedicated AVOnce. Signed-off-by:

[FFmpeg-devel] [PATCH 25/39] avcodec/ituh263enc: Remove unused function parameter

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index b1b78218a5..e1debcf63b 100644 --- a/libavcodec/ituh263enc.c +++ b/libavcodec/ituh263enc.c @@

[FFmpeg-devel] [PATCH 24/39] avcodec/ituh263dec: Don't initialize unused parts of RLTable

2020-12-10 Thread Andreas Rheinhardt
The RLTable ff_rl_intra_aic is only used by ituh263dec and ituh263enc; the former only uses the RLTable's VLC, the latter only index_run, max_level and max_run. Yet ituh263dec also initializes the latter. This commit stops doing so. Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263dec.c

[FFmpeg-devel] [PATCH 23/39] avcodec/h261enc: Make encoder init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
This is easy now that the H.261 encoder is the only user that initializes the non-VLC parts of ff_h261_rl_tcoeff. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261.c| 13 - libavcodec/h261.h| 3 --- libavcodec/h261enc.c | 16 3 files changed, 12

[FFmpeg-devel] [PATCH 21/39] avcodec/h261dec: Make decoder init-threadsafe

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index 6b680a862d..61cd38caed 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -26,6 +26,7 @@

[FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2020-12-10 Thread Andreas Rheinhardt
The H.261 decoder only uses an RLTable's VLC table, yet it also initializes its index_run, max_level and max_run. This commit stops doing so; it will also simplify making this decoder init-threadsafe, as the H.261 decoder and encoder now initialize disjoint parts of their common RLTable.

[FFmpeg-devel] [PATCH 19/39] avcodec/mpegvideo_enc: Make mpv_encode_defaults thread-safe

2020-12-10 Thread Andreas Rheinhardt
This is a prerequisite for making any encoder that uses ff_mpv_encode_init() init-threadsafe; it already makes the AMV, the MJPEG and the MPEG-1/2 encoders init-threadsafe. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc.c | 4 ++-- libavcodec/mpeg12enc.c | 4 ++--

[FFmpeg-devel] [PATCH 18/39] avcodec/motion_est, mpegvideo: Make pointers to static storage const

2020-12-10 Thread Andreas Rheinhardt
Modifying static storage must not happen because of multithreading (except initialization of course), so add const to the pointed-to type for pointers that point to static storage. Signed-off-by: Andreas Rheinhardt --- libavcodec/motion_est.c | 12 ++-- libavcodec/motion_est.h

[FFmpeg-devel] [PATCH 17/39] avcodec/me_cmp: Remove ff_check_alignment()

2020-12-10 Thread Andreas Rheinhardt
The usage of a static variable presents a potential for data races and means that this function can't be used in init functions of codecs with FF_CODEC_CAP_INIT_THREADSAFE (unless of course one presumes that everything is alright in which case the error is not triggered; but then the whole

[FFmpeg-devel] [PATCH 16/39] avcodec/mpeg12dec: Remove redundant writes

2020-12-10 Thread Andreas Rheinhardt
ff_mpv_decode_init() already sets MpegEncContext.avctx. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 123ede4704..a7980eeda7 100644 --- a/libavcodec/mpeg12dec.c +++

[FFmpeg-devel] [PATCH 15/39] avcodec/mpegvideo: Merge ff_mpv_decode_defaults into ff_mpv_decode_init

2020-12-10 Thread Andreas Rheinhardt
These two are always called directly after each other (with the exception of the calls in mpeg_decode_init() where some irrelevant modifications of the avctx (which could just as well be done before ff_mpv_decode_defaults(), because it doesn't have a pointer to the AVCodecContext at all and

[FFmpeg-devel] [PATCH 08/39] avcodec/h261dec: Don't initialize unused VLCs

2020-12-10 Thread Andreas Rheinhardt
The H.261 decoder uses only the very first VLC of ff_h261_rl_tcoeff, so only initialize this one. Saves 68448B from the .bss segment; in case the decoder is actually used, this amount of memory is saved. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 12/39] avcodec/msmpeg4dec: Reuse identical RL VLCs

2020-12-10 Thread Andreas Rheinhardt
Some of the RLTables used by msmpeg4dec actually coincide with other RLTables: ff_rl_table[5] coincides with ff_h263_rl_inter (and ff_rl_table[2] with ff_mpeg4_rl_intra). Given that ff_h263_rl_inter is always initialized before msmpeg4dec's RLTables are initialized, one can just reuse the VLC

[FFmpeg-devel] [PATCH 07/39] avcodec/rl: Allow to create only a few VLC tables

2020-12-10 Thread Andreas Rheinhardt
It is not uncommon that only the first one is used; this is similar to ff_init_2d_vlc_rl(). Signed-off-by: Andreas Rheinhardt --- libavcodec/rl.c | 3 +++ libavcodec/rl.h | 8 2 files changed, 11 insertions(+) diff --git a/libavcodec/rl.c b/libavcodec/rl.c index c532b5bf56..93153ff723

[FFmpeg-devel] [PATCH 11/39] avcodec/ituh263dec: Don't initialize unused RL VLCs

2020-12-10 Thread Andreas Rheinhardt
The ff_rl_intra_aic RLTable is only used by ituh263dec and ituh263enc; the former is the only user of its RL VLC tables. It uses only the very first one of these VLC tables, but up until now all 32 are initialized, wasting 68696B from the .bss segment (or that amount of memory if this decoder has

[FFmpeg-devel] [PATCH 06/39] avcodec/speedhq: Remove cast

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/speedhq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 748e8617f6..0c08894315 100644 --- a/libavcodec/speedhq.c +++ b/libavcodec/speedhq.c @@ -135,7 +135,7 @@ static const

[FFmpeg-devel] [PATCH 10/39] avcodec/mpeg4videodec: Don't initialize unused RL VLCs

2020-12-10 Thread Andreas Rheinhardt
The RLTables whose VLC tables are only used for intra blocks only use the very first VLC table; yet all 32 have been initialized. This commit stops this by switching to INIT_FIRST_VLC_RL. This saves 201624B from the .bss segment; in case the decoder is actually used, this translates into less

[FFmpeg-devel] [PATCH 05/39] avcodec/mpeg12enc, speedhqenc: Avoid redundant copies of tables

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 12 ++-- libavcodec/speedhqenc.c | 12 ++-- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 05fd8c0e00..5cbcb15630 100644 ---

[FFmpeg-devel] [PATCH 09/39] avcodec/msmpeg4dec: Don't initialize unused RL VLCs

2020-12-10 Thread Andreas Rheinhardt
For the RLTables ff_rl_table[0..2] only the very first VLC is only ever used, so it makes no sense to create 32 of them. This saves 285200B from the .bss segment; this amount of memory is actually saved when this decoder is used. Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4dec.c | 6

[FFmpeg-devel] [PATCH 04/39] avcodec/mpeg12: Reindentation

2020-12-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12.c | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index 2aaed89920..1aacd07e41 100644 --- a/libavcodec/mpeg12.c +++

[FFmpeg-devel] [PATCH 03/39] avcodec/mpeg12: Make initializing VLCs thread-safe

2020-12-10 Thread Andreas Rheinhardt
This automatically makes the eamad, eatqi, ipu and mdec decoders init-threadsafe; in addition to the actual mpeg[12]video decoders, of course. Signed-off-by: Andreas Rheinhardt --- libavcodec/eamad.c | 1 + libavcodec/eatqi.c | 1 + libavcodec/mdec.c | 1 + libavcodec/mpeg12.c

[FFmpeg-devel] [PATCH 02/39] avcodec/mpeg12: Don't initialize encoder-only parts of RLTable

2020-12-10 Thread Andreas Rheinhardt
ff_mpeg12_init_vlcs() currently initializes index_run, max_level and max_run of ff_rl_mpeg1/2; yet the only user of these fields is the MPEG-1/2 encoder which already initializes these tables on its own. So remove the initializations in ff_mpeg12_init_vlcs(); this also simplifies making

[FFmpeg-devel] [PATCH 01/39] avcodec/rl: Remove nonstatic storage of RL tables

2020-12-10 Thread Andreas Rheinhardt
ff_rl_free() was added in 324e50ee95929a9491b855c5e15451145bd5d1ec, but never used; nonstatic storage was not used long before that. Signed-off-by: Andreas Rheinhardt --- The test for whether a RLTable has already been initialized will be removed once all callers are behind ff_thread_once()

[FFmpeg-devel] [PATCH 2/2] lavu/mem: move the DECLARE_ALIGNED macro family to mem_internal on next+1 bump

2020-12-10 Thread Anton Khirnov
They are not properly namespaced and not intended for public use. --- libavcodec/4xm.c | 1 + libavcodec/aac.h | 1 + libavcodec/aacenc.h| 2 + libavcodec/aacps.h | 2 +

[FFmpeg-devel] [PATCH 1/2] lavu: move LOCAL_ALIGNED from internal.h to mem_internal.h

2020-12-10 Thread Anton Khirnov
That is a more appropriate place for it. --- libavcodec/aacps.c| 1 + libavcodec/aacsbr.c | 1 + .../vp9dsp_init_16bpp_aarch64_template.c | 1 + libavcodec/aarch64/vp9dsp_init_aarch64.c | 1 + libavcodec/ac3enc.c

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2020-12-10 Thread Linjie Fu
Hi Guangxin, On Sun, Nov 15, 2020 at 11:07 AM Xu Guangxin wrote: > > you can download it from: > https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip > > Signed-off-by: Xu Guangxin > --- > tests/fate/hevc.mak

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/qsv: Add functions to print mfx iopattern, warning and error

2020-12-10 Thread Linjie Fu
On Thu, Dec 10, 2020 at 1:50 PM Haihao Xiang wrote: > > It is a copy of the relevant part in lavc/qsv. > > Signed-off-by: Haihao Xiang > --- > To avoid duplicated tables in the same library after applying patch ' > lavc/qsv: make some functions inline', use a local copy of the relevant > code in

Re: [FFmpeg-devel] [PATCH 3/3] tests/fate-run.sh: Don't overlook errors from md5 tests

2020-12-10 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-04 23:57:40) > The md5 test up until now ignored errors from ffmpeg (the cli) and just > md5'ed whatever ffmpeg has output; while testing scenarios in which > ffmpeg fails has its merits, errors should not be overlooked by default; > doing so also reduces the

Re: [FFmpeg-devel] [PATCH 1/9] img2dec: export avg_frame_rate

2020-12-10 Thread Anton Khirnov
pushed set with comments from James applied -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH 1/2] qsvdec: factor common options out

2020-12-10 Thread Linjie Fu
On Thu, Nov 26, 2020 at 1:30 PM Haihao Xiang wrote: > > --- > libavcodec/qsvdec.h | 13 + > libavcodec/qsvdec_h2645.c | 12 ++-- > libavcodec/qsvdec_other.c | 6 +- > 3 files changed, 16 insertions(+), 15 deletions(-) > > diff --git a/libavcodec/qsvdec.h

[FFmpeg-devel] 回复: 回复: 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
add a new patch. https://patchwork.ffmpeg.org/project/ffmpeg/patch/sl2pr06mb3052edb34939522d15655affc1...@sl2pr06mb3052.apcprd06.prod.outlook.com/ Thanks and regards, SunZhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 2020年12月10日 14:31 收件人:

Re: [FFmpeg-devel] [PATCH 1/3] tests/audiomatch: add free to make static analysis tools happy

2020-12-10 Thread Anton Khirnov
Quoting Jun Zhao (2020-12-09 10:53:08) > From: Jun Zhao > > Signed-off-by: Jun Zhao > --- > tests/audiomatch.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index