Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-18 Thread Tobias Rapp
On 18.01.2021 23:53, Tomas Härdin wrote: lör 2021-01-16 klockan 08:43 +0800 skrev lance.lmw...@gmail.com: On Fri, Jan 15, 2021 at 09:43:58PM +0100, Marton Balint wrote: On Fri, 15 Jan 2021, Tomas Härdin wrote: Again, why? If you have a company that maintains a fork of FFmpeg then compile

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2021-01-18 Thread Josh Allmann
Hi Martin, On Fri, 15 Jan 2021 at 04:59, Martin Storsjö wrote: > > Hi Josh, > > On Tue, 22 Dec 2020, Josh Allmann wrote: > > > Thank you for taking the time to look into this! Tested with your > > alternative patch and it does seem to be an improvement. I was able to > > find a case where it

[FFmpeg-devel] [PATCH 3/3] avcodec/xbmenc: Allow for making UW images

2021-01-18 Thread Jose Da Silva
I've run into some bugs where I was downloading a bunch of data and began seeing weird hiccups. For example, javascript promises to allow you to push some very long lines of data, but the hiccups I saw was with data larger than 2k in length (windows) pushed out of a child process stdout piped

[FFmpeg-devel] [PATCH 2/3] avcodec/xbmenc: xbm Lower memory use

2021-01-18 Thread Jose Da Silva
Two minor memory improvements. First bug reduces memory needed to about 6/7 the needed amount, which allows you to host almost 7 pictures in the same memory needed for 6 Second is a recalculation of the total additional memory for headers etc. size = avctx->height x (linesize * 6 + 1) +

[FFmpeg-devel] [PATCH 1/3] avcodec/xbmenc: Do not add last comma into output

2021-01-18 Thread Jose Da Silva
There is a minor bug in xbm encode which adds a trailing comma at the end of data. This isn't a big problem, but it would be nicer to be more technically true to an array of data (by not including the last comma). This bug fixes the output from something like this (having 4 values): static

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-01-18 Thread Lynne
Jan 19, 2021, 01:07 by borba...@fb.com: > Calculate Spatial Info (SI) and Temporal Info (TI) scores for a video, as > defined > in ITU-T P.910: Subjective video quality assessment methods for multimedia > applications. > > Update: Fixed bracket style. > Thanks, looks much neater now. > I'm

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-01-18 Thread Boris Baracaldo
Calculate Spatial Info (SI) and Temporal Info (TI) scores for a video, as defined in ITU-T P.910: Subjective video quality assessment methods for multimedia applications. Update: Fixed bracket style. I'm already adding the data to the frame's metadata, is the suggestion to remove the file

Re: [FFmpeg-devel] [PATCH v2 07/13] cbs: Implement common parts of cbs-based bitstream filters separately

2021-01-18 Thread James Almer
On 1/18/2021 7:44 PM, Mark Thompson wrote: +#define BSF_ELEMENT_OPTIONS_PIR(name, help, field, unit_name) \ You could reuse name instead of also passing unit_name. The only bsf where it differs is h264_metadata with display_orientation vs disp_or, and changing the latter into the former

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-18 Thread Mark Thompson
On 16/01/2021 22:12, Nicolas Caramelli wrote: This patch adds KMS/DRM output device for rendering a video stream using KMS/DRM dumb buffer. The proposed implementation is very basic, only bgr0 pixel format is currently supported (the most common format with KMS/DRM). To enable this output device

[FFmpeg-devel] [PATCH v2 07/13] cbs: Implement common parts of cbs-based bitstream filters separately

2021-01-18 Thread Mark Thompson
This allows removal of a lot of duplicated code between BSFs. --- libavcodec/Makefile | 2 +- libavcodec/cbs_bsf.c | 159 +++ libavcodec/cbs_bsf.h | 131 +++ 3 files changed, 291 insertions(+), 1 deletion(-) create mode

[FFmpeg-devel] [PATCH v2 00/13] Metadata handling in CBS, first half, v2

2021-01-18 Thread Mark Thompson
This is v2 of the first half of the series, which factorises out common parts of the existing code and fixes some minor issues but has little external effect. It is updated as noted from previous comments, but has no other significant changes. I'll apply this later this week if there are no

[FFmpeg-devel] [PATCH v2 02/13] h264_metadata_bsf: Move SEI user data parsing to init time

2021-01-18 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 91 -- 1 file changed, 43 insertions(+), 48 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index d7cf58095b..f39e649ac6 100644 --- a/libavcodec/h264_metadata_bsf.c +++

Re: [FFmpeg-devel] [PATCH 5/5] avformat/id3v2: Check against max compression ratio before allocation

2021-01-18 Thread Michael Niedermayer
On Sun, Nov 29, 2020 at 01:03:37AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (>10sec -> 12ms) > Fixes: > 27612/clusterfuzz-testcase-minimized-ffmpeg_dem_PCM_S24BE_fuzzer-6605893000757248 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/5] avformat/avidec: Use av_sat_sub64() in check_stream_max_drift()

2021-01-18 Thread Michael Niedermayer
On Sun, Nov 29, 2020 at 01:03:35AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 8833900919969684211 - -9223372036854775808 > cannot be represented in type 'long' > Fixes: > 26726/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-5669377724383232 > Fixes: >

Re: [FFmpeg-devel] [PATCH 2/5] avutil/timecode: Avoid undefined behavior with large framenum

2021-01-18 Thread Michael Niedermayer
On Sun, Nov 29, 2020 at 01:03:34AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147462079 + 2149596 cannot be represented in > type 'int' > Fixes: > 27565/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5091972813160448 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check a.size before computing next_root_atom

2021-01-18 Thread Michael Niedermayer
On Sun, Nov 29, 2020 at 01:03:33AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 64 + 9223372036854775799 cannot be > represented in type 'long' > Fixes: > 27563/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6244650163372032 > > Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH v2 10/13] mpeg2_metadata_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
This also adds support for updating new extradata. --- libavcodec/mpeg2_metadata_bsf.c | 94 + 1 file changed, 12 insertions(+), 82 deletions(-) diff --git a/libavcodec/mpeg2_metadata_bsf.c b/libavcodec/mpeg2_metadata_bsf.c index d0048c0e25..11b46c0ae3 100644 ---

[FFmpeg-devel] [PATCH v2 11/13] vp9_metadata_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
--- libavcodec/vp9_metadata_bsf.c | 61 +-- 1 file changed, 16 insertions(+), 45 deletions(-) diff --git a/libavcodec/vp9_metadata_bsf.c b/libavcodec/vp9_metadata_bsf.c index 00a5580c4d..d904a0088d 100644 --- a/libavcodec/vp9_metadata_bsf.c +++

[FFmpeg-devel] [PATCH v2 06/13] h264_metadata_bsf: Improve interpretation of input display matrices

2021-01-18 Thread Mark Thompson
The previous code here only worked in more limited cases. --- libavcodec/h264_metadata_bsf.c | 44 +++--- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 36f8aab245..71b49696cd 100644

[FFmpeg-devel] [PATCH v2 12/13] av1_metadata_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
--- libavcodec/av1_metadata_bsf.c | 176 -- 1 file changed, 21 insertions(+), 155 deletions(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c index 3158ba995b..6114dd6b31 100644 --- a/libavcodec/av1_metadata_bsf.c +++

[FFmpeg-devel] [PATCH v2 05/13] h264_metadata_bsf: Refactor the filter function into smaller parts

2021-01-18 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 326 ++--- 1 file changed, 180 insertions(+), 146 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 4ab97aee3a..36f8aab245 100644 --- a/libavcodec/h264_metadata_bsf.c +++

[FFmpeg-devel] [PATCH v2 03/13] cbs_h2645: Merge SEI message handling in common between codecs

2021-01-18 Thread Mark Thompson
--- libavcodec/Makefile | 4 +- libavcodec/cbs_h264.h | 50 +--- libavcodec/cbs_h2645.c| 300 +++-- libavcodec/cbs_h264_syntax_template.c | 173 +--- libavcodec/cbs_h265.h | 33 +--

[FFmpeg-devel] [PATCH v2 09/13] h265_metadata_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
--- libavcodec/h265_metadata_bsf.c | 191 - 1 file changed, 22 insertions(+), 169 deletions(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index 504a75dac2..4be41932bb 100644 --- a/libavcodec/h265_metadata_bsf.c +++

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-18 Thread Tomas Härdin
lör 2021-01-16 klockan 08:43 +0800 skrev lance.lmw...@gmail.com: > On Fri, Jan 15, 2021 at 09:43:58PM +0100, Marton Balint wrote: > > > > On Fri, 15 Jan 2021, Tomas Härdin wrote: > > > Again, why? If you have a company that maintains a fork of FFmpeg then > > > compile that info in here instead.

[FFmpeg-devel] [PATCH v2 13/13] h264_redundant_pps_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
--- libavcodec/h264_redundant_pps_bsf.c | 99 ++--- 1 file changed, 21 insertions(+), 78 deletions(-) diff --git a/libavcodec/h264_redundant_pps_bsf.c b/libavcodec/h264_redundant_pps_bsf.c index cf41abe96c..6ba40291d5 100644 --- a/libavcodec/h264_redundant_pps_bsf.c +++

[FFmpeg-devel] [PATCH v2 04/13] cbs_sei: Remove restrictions on MDCV values

2021-01-18 Thread Mark Thompson
Since this was originally written the standards have changed to allow arbitrary values here, but leaves their meaning unspecified. --- libavcodec/cbs_sei_syntax_template.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavcodec/cbs_sei_syntax_template.c

[FFmpeg-devel] [PATCH v2 08/13] h264_metadata_bsf: Use common cbs bsf implementation

2021-01-18 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 232 +++-- 1 file changed, 49 insertions(+), 183 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 71b49696cd..3e99283878 100644 --- a/libavcodec/h264_metadata_bsf.c +++

[FFmpeg-devel] [PATCH v2 01/13] cbs_h2645: Merge SEI messages in common between codecs

2021-01-18 Thread Mark Thompson
Make a new template file for common SEI messages - this will also apply to H.266. --- libavcodec/cbs_h264.h | 37 +-- libavcodec/cbs_h2645.c| 24 +++-- libavcodec/cbs_h264_syntax_template.c | 106 +--- libavcodec/cbs_h265.h |

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
On Mon, Jan 18, 2021 at 3:33 PM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2021-01-18 21:12:50) > > Hi, > > > > On Mon, Jan 18, 2021 at 2:55 PM Anton Khirnov wrote: > > > > > I have at some point touched most major pieces of code in the project. > > > I also have opinions on how many

Re: [FFmpeg-devel] [PATCH] avfilter/af_astats: fix possible crash because of undefined float to integer rounding

2021-01-18 Thread Marton Balint
On Sat, 16 Jan 2021, Marton Balint wrote: Fixes ticket #9049. Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index ebaae29f44..f50cbe199c 100644 ---

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/flashsv2enc: factorize updating block dimensions

2021-01-18 Thread Marton Balint
On Mon, 18 Jan 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-01-10 02:20:45) Signed-off-by: Marton Balint --- libavcodec/flashsv2enc.c | 76 +--- 1 file changed, 32 insertions(+), 44 deletions(-) diff --git a/libavcodec/flashsv2enc.c

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-18 Thread Anton Khirnov
Quoting Nachiket Tarate (2021-01-18 18:39:56) > Apple HTTP Live Streaming Sample Encryption: > > https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption > > Signed-off-by: Nachiket Tarate > --- > libavformat/Makefile | 2 +- >

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Anton Khirnov
Quoting Ronald S. Bultje (2021-01-18 21:12:50) > Hi, > > On Mon, Jan 18, 2021 at 2:55 PM Anton Khirnov wrote: > > > I have at some point touched most major pieces of code in the project. > > I also have opinions on how many things should be done. So according to > > your definition, that makes

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 18, 2021 at 2:55 PM Anton Khirnov wrote: > I have at some point touched most major pieces of code in the project. > I also have opinions on how many things should be done. So according to > your definition, that makes me biased and disqualified from voting on > almost anything,

Re: [FFmpeg-devel] [PATCH 4/7] avformat/nistspheredec: Check bits_per_coded_sample and channels

2021-01-18 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-17 00:07:26) > Fixes: signed integer overflow: 80 * 92233009 cannot be represented in type > 'int' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_NISTSPHERE_fuzzer-6669100654919680 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Anton Khirnov
Quoting Nicolas George (2021-01-18 19:25:39) > Anton Khirnov (12021-01-18): > > For another, they are excluded from having a say precisely in those > > matters where they have most expertise. > > And the matters where they are most biassed. > > What we are talking about is called conflict of

Re: [FFmpeg-devel] [PATCH 7/7] avformat/sbgdec: Reduce the amount of floating point in str_to_time()

2021-01-18 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 03:52:57PM +0100, Nicolas George wrote: > Michael Niedermayer (12021-01-17): > > Fixes: 1e+75 is outside the range of representable values of type 'long' > > Fixes: > > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6626834808700928 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Paul B Mahol
On Mon, Jan 18, 2021 at 7:49 PM Ronald S. Bultje wrote: > Hi, > > On Mon, Jan 18, 2021 at 1:25 PM Nicolas George wrote: > > > What we are talking about is called conflict of interest. Every > > functioning institution has rules to prevent them. > > > +1 on this. > How do you want to prevent

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 18, 2021 at 1:25 PM Nicolas George wrote: > What we are talking about is called conflict of interest. Every > functioning institution has rules to prevent them. +1 on this. Ronald ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/3] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-01-18 Thread Nachiket Tarate
These will be used by HLS demuxer in case of SAMPLE-AES encryption/decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 1 + libavcodec/adts_parser.c | 29 - libavcodec/adts_parser.h | 4 4 files changed,

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Nicolas George
Anton Khirnov (12021-01-18): > This wasn't in the previous version IIRC, and does not seem reasonable > to me. It was added at my suggestion, AFAIK. > For one thing, it adds a possibility of a tie, which was impossible with > odd number of TC members. Unless somebody abstains, which is always

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-18 Thread Paul B Mahol
Isn't this applied already? On Mon, Jan 18, 2021 at 6:46 PM Idan Freiberg wrote: > Can one of the maintainers review the patch please? > > בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg : > > > DAV files may contain a variable length padding in between chunks > > filled with 0xff bytes.

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-18 Thread Idan Freiberg
Can one of the maintainers review the patch please? בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg : > DAV files may contain a variable length padding in between chunks > filled with 0xff bytes. The current skipping logic is incorrect as it > may skip over DHAV chunks not appearing

[FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-18 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile | 2 +- libavformat/hls.c| 97 ++- libavformat/hls_sample_aes.c |

[FFmpeg-devel] [PATCH 3/3] libavformat/hls: correct indentation

2021-01-18 Thread Nachiket Tarate
Signed-off-by: Nachiket Tarate --- libavformat/hls.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index bc5247b8ce..7d34f349c3 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2028,23

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Lynne
Jan 18, 2021, 12:59 by an...@khirnov.net: > Quoting Lynne (2021-01-11 16:15:06) > >> Jan 11, 2021, 14:03 by j...@videolan.org: >> >> > --- >> > doc/dev_community/resolution_process.md | 89 + >> > 1 file changed, 89 insertions(+) >> > create mode 100644

[FFmpeg-devel] [PATCH 6/6] dnn_backend_native_layer_conv2d.c: refine code with av_malloc_array and av_freep

2021-01-18 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- .../dnn/dnn_backend_native_layer_conv2d.c | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c b/libavfilter/dnn/dnn_backend_native_layer_conv2d.c index

[FFmpeg-devel] [PATCH 5/6] dnn_backend_native_layer_conv2d.c: correct struct name with CamelCase

2021-01-18 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- .../dnn/dnn_backend_native_layer_conv2d.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c b/libavfilter/dnn/dnn_backend_native_layer_conv2d.c index 0fb968a1fc..7c6d96e916

[FFmpeg-devel] [PATCH 4/6] dnn/queue: remove prefix FF for Queue and SafeQueue

2021-01-18 Thread Guo, Yejun
we don't need FF prefix for internal data struct Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 4 +- libavfilter/dnn/queue.c| 58 +- libavfilter/dnn/queue.h| 20 - libavfilter/dnn/safe_queue.c |

[FFmpeg-devel] [PATCH 3/6] libavfilter/dnn: add prefix ff_ for internal functions

2021-01-18 Thread Guo, Yejun
from proc_from_frame_to_dnn to ff_proc_from_frame_to_dnn, and from proc_from_dnn_to_frame to ff_proc_from_dnn_to_frame. Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 4 ++-- libavfilter/dnn/dnn_backend_openvino.c | 4 ++-- libavfilter/dnn/dnn_backend_tf.c | 4 ++--

[FFmpeg-devel] [PATCH 2/6] libavfilter/dnn: use avpriv_report_missing_feature for unsupported features

2021-01-18 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 2 +- libavfilter/dnn/dnn_backend_openvino.c | 4 ++-- libavfilter/dnn/dnn_backend_tf.c | 4 ++-- libavfilter/dnn/dnn_io_proc.c | 10 -- libavfilter/vf_dnn_processing.c| 4 ++-- 5 files

[FFmpeg-devel] [PATCH 1/6] dnn_backend_openvino.c: add version mismatch reminder

2021-01-18 Thread Guo, Yejun
The OpenVINO model file format changes when OpenVINO goes to a new release, it does not work if the versions between model file and runtime are mismatched. Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 26/39] avcodec/h263data, ituh263*: Make initializing RL inter table thread-safe

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:44) > Up until now, ff_h263_rl_inter was initialized by both ituh263dec and > ituh263enc; this is an obstacle in making the codecs that use this code > init-threadsafe. > > This obstacle is eliminated by only initializing this RLTable from > a single

Re: [FFmpeg-devel] [PATCH 25/39] avcodec/ituh263enc: Remove unused function parameter

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:43) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ituh263enc.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 24/39] avcodec/ituh263dec: Don't initialize unused parts of RLTable

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:42) > The RLTable ff_rl_intra_aic is only used by ituh263dec and ituh263enc; > the former only uses the RLTable's VLC, the latter only index_run, > max_level and max_run. Yet ituh263dec also initializes the latter. > This commit stops doing so. Same as

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Anton Khirnov
Quoting Lynne (2021-01-11 16:15:06) > Jan 11, 2021, 14:03 by j...@videolan.org: > > > --- > > doc/dev_community/resolution_process.md | 89 + > > 1 file changed, 89 insertions(+) > > create mode 100644 doc/dev_community/resolution_process.md > > > > diff --git

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2021-01-11 14:03:42) > --- > doc/dev_community/resolution_process.md | 89 + > 1 file changed, 89 insertions(+) > create mode 100644 doc/dev_community/resolution_process.md > > diff --git a/doc/dev_community/resolution_process.md >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/flashsv2enc: factorize updating block dimensions

2021-01-18 Thread Anton Khirnov
Quoting Marton Balint (2021-01-10 02:20:45) > Signed-off-by: Marton Balint > --- > libavcodec/flashsv2enc.c | 76 +--- > 1 file changed, 32 insertions(+), 44 deletions(-) > > diff --git a/libavcodec/flashsv2enc.c b/libavcodec/flashsv2enc.c > index

Re: [FFmpeg-devel] [PATCH 23/39] avcodec/h261enc: Make encoder init-threadsafe

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:41) > This is easy now that the H.261 encoder is the only user that > initializes the non-VLC parts of ff_h261_rl_tcoeff. > > Signed-off-by: Andreas Rheinhardt > --- Looks good modulo my previous question about shared table -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH 22/39] avcodec/h261dec: Reindentation

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:40) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h261dec.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) Trivially ok -- Anton Khirnov ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 21/39] avcodec/h261dec: Make decoder init-threadsafe

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:39) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h261dec.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:38) > The H.261 decoder only uses an RLTable's VLC table, yet it also > initializes its index_run, max_level and max_run. This commit stops > doing so; it will also simplify making this decoder init-threadsafe, > as the H.261 decoder and encoder now

Re: [FFmpeg-devel] [PATCH 19/39] avcodec/mpegvideo_enc: Make mpv_encode_defaults thread-safe

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:37) > This is a prerequisite for making any encoder that uses > ff_mpv_encode_init() init-threadsafe; it already makes the AMV, > the MJPEG and the MPEG-1/2 encoders init-threadsafe. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegenc.c

Re: [FFmpeg-devel] [PATCH 17/39] avcodec/me_cmp: Remove ff_check_alignment()

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:35) > The usage of a static variable presents a potential for data races and > means that this function can't be used in init functions of codecs with > FF_CODEC_CAP_INIT_THREADSAFE (unless of course one presumes that > everything is alright in which

Re: [FFmpeg-devel] [PATCH 16/39] avcodec/mpeg12dec: Remove redundant writes

2021-01-18 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:34) > ff_mpv_decode_init() already sets MpegEncContext.avctx. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12dec.c | 3 --- > 1 file changed, 3 deletions(-) Ok -- Anton Khirnov ___