Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-26 Thread Tobias Rapp
On 26.01.2021 16:39, Tomas Härdin wrote: tis 2021-01-26 klockan 00:34 +0100 skrev Marton Balint: Maybe they should post patches instead of having workarounds? And I explained, libavformat MXF muxer will still be identifiable, but the proper field will be used for identifying the SDK used, not

Re: [FFmpeg-devel] [PATCH] libavutil/frame.h: correct typo for AVFilmGrainParams in comment

2021-01-26 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年1月27日 14:00 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavutil/frame.h: correct typo for > AVFilmGrainParams in comment > > Jan 27, 2021, 06:21 by

Re: [FFmpeg-devel] [PATCH] libavutil/frame.h: correct typo for AVFilmGrainParams in comment

2021-01-26 Thread Lynne
Jan 27, 2021, 06:21 by yejun@intel.com: > Signed-off-by: Guo, Yejun > --- > libavutil/frame.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/frame.h b/libavutil/frame.h > index 392315f40f..1aeafef6de 100644 > --- a/libavutil/frame.h > +++

[FFmpeg-devel] [PATCH] libavutil/frame.h: correct typo for AVFilmGrainParams in comment

2021-01-26 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavutil/frame.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 392315f40f..1aeafef6de 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -194,7 +194,7 @@ enum AVFrameSideDataType {

[FFmpeg-devel] [PATCH v1] avutil/time: fix av_usleep() inaccurate on Windows

2021-01-26 Thread gaojiangjie
From: Jiangjie Gao --- libavutil/time.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavutil/time.c b/libavutil/time.c index 740afc4785..dd04870983 100644 --- a/libavutil/time.c +++ b/libavutil/time.c @@ -90,7 +90,16 @@ int av_usleep(unsigned usec) #elif

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/dashdec: check init_section before use it.

2021-01-26 Thread Steven Liu
> 2021年1月18日 下午2:22,liuqi05 写道: > > because there have no Initialization in SegmentTemplate, > so it will have no init_section for init segment file. > but in the is_common_init_section_exist function it will be used for > check to url, url_offset and size, so check init_section > before use

[FFmpeg-devel] [PATCH v1] lavfi/qsvvpp: support async depth

2021-01-26 Thread Fei Wang
Async depth will allow qsv filter cache few frames, and avoid force switch and end filter task frame by frame. This change will improve performance for some multi-task case, for example 1:N transcode( decode + vpp + encode) with all QSV plugins. Signed-off-by: Fei Wang --- libavfilter/qsvvpp.c

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/flashsv2enc: factorize updating block dimensions

2021-01-26 Thread James Almer
On 1/23/2021 6:13 PM, Marton Balint wrote: On Tue, 19 Jan 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-01-18 21:53:30) On Mon, 18 Jan 2021, Anton Khirnov wrote: > Quoting Marton Balint (2021-01-10 02:20:45) >> Signed-off-by: Marton Balint >> --- >>  libavcodec/flashsv2enc.c |

Re: [FFmpeg-devel] [PATCH 3/3] dnn_backend_openvino.c: remove extra semicolon

2021-01-26 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年1月26日 9:25 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH 3/3] dnn_backend_openvino.c: remove extra semicolon > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn/dnn_backend_openvino.c | 6 +++--- > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/sei: add Parameter Set Inclusion Indication enum value

2021-01-26 Thread Mark Thompson
Parameter Set_s_ in the title. (That made me look carefully, so I guess it's good.) On 22/01/2021 19:34, James Almer wrote: Defined in H.274, it shares the same value as Active Parameter Sets (which was removed for codecs that reference H.274). It's really a rename. The concept of

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265_syntax_template: Better check for num_long_term_sps

2021-01-26 Thread Michael Niedermayer
On Mon, Jan 25, 2021 at 08:36:59PM +, Mark Thompson wrote: > On 24/01/2021 21:41, Michael Niedermayer wrote: > > On Sat, Nov 21, 2020 at 06:49:55PM +, Mark Thompson wrote: > > > On 21/11/2020 17:37, Michael Niedermayer wrote: > > > > On Sun, Nov 15, 2020 at 09:37:45PM +, Mark Thompson

[FFmpeg-devel] [PATCH] cbs_h2645: Implement replace-PS with a table rather than many functions

2021-01-26 Thread Mark Thompson
--- On 26/01/2021 13:40, James Almer wrote: On 1/26/2021 10:35 AM, Nuo Mi wrote: On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: On 1/25/2021 2:12 PM, James Almer wrote: Did you add this just to set active_vps? I thought the idea was to remove all that since it's not a concept defined in

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Simplify compile-time check for DV demuxer

2021-01-26 Thread Peter Ross
On Tue, Jan 26, 2021 at 02:21:27PM +0100, Andreas Rheinhardt wrote: > 1b373b41d940e3058cdfb3d17703e23ed665353c made it a bit harder to find > out that a call to avpriv_dv_produce_packet is dead when the DV demuxer > is disabled; too hard for GCC on -O0. So simplify the check a bit. > >

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-26 Thread levi
From: Levi Dooley There was an assumption in the existing code that indentation would not occur more than once on the same row. This was a bad assumption. There are examples of 608 streams which call handle_pac multiple times on the same row with different indentation. As the code was before

[FFmpeg-devel] [PATCH 2/2] avcodec/msmpeg4: Inline number of motion vectors

2021-01-26 Thread Andreas Rheinhardt
Both motion vector tables have the same number of elements, hence one can inline said number and remove the field containing the number of elements from the structure. Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4data.c | 6 ++ libavcodec/msmpeg4data.h | 2 +-

[FFmpeg-devel] [PATCH 1/2] avcodec/msmpeg4dec: Don't check for errors for complete VLCs

2021-01-26 Thread Andreas Rheinhardt
This also affected other users of VLCs from msmpeg4dec, namely vc1_block and wmv2dec. Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4.h| 2 +- libavcodec/msmpeg4dec.c | 20 ++-- libavcodec/vc1_block.c | 12 libavcodec/wmv2dec.c| 20

[FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-26 Thread Paul B Mahol
This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 + libavformat/Makefile| 1 + libavformat/librist.c | 251 libavformat/protocols.c | 1 + 5

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-26 Thread Mark Thompson
On 25/01/2021 23:20, Nicolas George wrote: Mark Thompson (12021-01-25): Merging the libraries (in source form, orthogonal to merging the binaries) only makes sense if we are going to continue using the libavformat internals, and that is exactly the thing we are trying to get rid of. "We"? It

Re: [FFmpeg-devel] [PATCH 40/40] avcodec/h261dec: Make VLC smaller

2021-01-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The VLC for the macroblock address increment uses nine bits; > yet there is no code with this length: All codes are either shorter or > longer. So one can make the table smaller without changing the amount of > codes that need more than one round of parsing. > >

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-26 Thread James Almer
On 1/26/2021 1:17 PM, Anton Khirnov wrote: Quoting James Almer (2021-01-26 17:07:28) On 1/26/2021 1:02 PM, Anton Khirnov wrote: Quoting Lynne (2021-01-24 18:34:36) Some devs (JEEB) wanted reception timestamps and original, overflowed timestamps for MPEG-TS. I'd be willing to add a reception

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: drop an FF_API-guarded block

2021-01-26 Thread James Almer
On 1/26/2021 2:01 PM, Anton Khirnov wrote: These macros are private and should not be used by external callers. --- fftools/ffmpeg_opt.c | 13 - 1 file changed, 13 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index bf2eb26246..472016b93c 100644 ---

[FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: drop an FF_API-guarded block

2021-01-26 Thread Anton Khirnov
These macros are private and should not be used by external callers. --- fftools/ffmpeg_opt.c | 13 - 1 file changed, 13 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index bf2eb26246..472016b93c 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@

[FFmpeg-devel] [PATCH 1/4] mjpegdec: stop setting the QP table

2021-01-26 Thread Anton Khirnov
MJPEG does not have a single quantiser scale, so this does not fit into the intended API use. This removes the last use of the long-deprecated QP table API. --- libavcodec/mjpegdec.c | 11 ++- tests/ref/fate/exif-image-embedded | 6 -- tests/ref/fate/exif-image-jpg

[FFmpeg-devel] [PATCH 2/4] vf_pp: remove unnecessary free

2021-01-26 Thread Anton Khirnov
ff_qp_table_extract() frees the table on failure. Found-by: Andreas Rheinhardt --- libavfilter/vf_pp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_pp.c b/libavfilter/vf_pp.c index 29ab777e01..19a0f9fc6e 100644 --- a/libavfilter/vf_pp.c +++ b/libavfilter/vf_pp.c @@ -145,7

Re: [FFmpeg-devel] [PATCH 6/7] avformat/realtextdec: Avoid undefined overflow in the end of read_ts()

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 12:07:28AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 234080282628234040 * 100 cannot be > represented in type 'long long' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-6649867065753600 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 5/7] avformat/nutdec: Fix integer overflow in count computation

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 12:07:27AM +0100, Michael Niedermayer wrote: > Note, the value is checked a few lines later already > > Fixes: signed integer overflow: -440402016 - 1879048064 cannot be represented > in type 'int' > Fixes: >

Re: [FFmpeg-devel] [PATCH 3/7] avformat/mvi: Use 64bit for testing dimensions

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 12:07:25AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65535 * 65535 cannot be represented in type > 'int' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-6649291124899840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/7] avformat/utils: Check dts in update_initial_timestamps() more

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 12:07:24AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372036853488158 - 9000 cannot be > represented in type 'long long' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MPSUB_fuzzer-6696625298866176 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mpsubdec: Use av_sat_add/sub64() in fracval handling

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 17, 2021 at 12:07:23AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 922337203685000 + 900 cannot be > represented in type 'long long' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MPSUB_fuzzer-665448017480908 > > Found-by: continuous

[FFmpeg-devel] [PATCH 4/4] avcodec/dolby_e: Avoid duplicating sample rate table

2021-01-26 Thread Andreas Rheinhardt
Set the sample rate when parsing the header instead and only copy the value in the decoder and the parser. Signed-off-by: Andreas Rheinhardt --- libavcodec/dolby_e.c| 2 +- libavcodec/dolby_e.h| 6 ++ libavcodec/dolby_e_parse.c | 6 +- libavcodec/dolby_e_parser.c | 2 +-

[FFmpeg-devel] [PATCH 3/4] avcodec/dolby_e: Avoid code duplication when converting input

2021-01-26 Thread Andreas Rheinhardt
convert_input, a nontrivial auxiliary function used by both the general parsing code as well as the decoder itself, has been duplicated in c7016e35a624a75bb5b82bee932ddfe28d013b3f; this commit removes said duplication. Signed-off-by: Andreas Rheinhardt --- libavcodec/dolby_e.c | 40

[FFmpeg-devel] [PATCH 2/4] avcodec/dolby_e_parse: Merge ff_dolby_e_parse_init/header

2021-01-26 Thread Andreas Rheinhardt
These two functions are always called after another; after all, what ff_dolby_e_parse_init does is obviously part of parsing the frame header. Also move the DolbyEHeaderInfo into DBEContext so that parsing the frame header only needs one struct (both users used a DBEContext immediately followed

[FFmpeg-devel] [PATCH 1/4] avcodec/dolby_e_parser: Remove unused ParseContext

2021-01-26 Thread Andreas Rheinhardt
Parsers are not forced to use a ParseContext and the other stuff from parser.h which is just designed to help parsers recombining frames. But this parser does not do this at all, i.e. the ParseContext is unused. Signed-off-by: Andreas Rheinhardt --- libavcodec/dolby_e_parser.c | 4 1 file

Re: [FFmpeg-devel] [PATCH 6/6] avformat/flvdec: Check for EOF in loop in flv_data_packet()

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 02:17:05PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-23 23:10:56) > > Fixes: Timeout > > Fixes: > > 29656/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5840098987999232 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 5/6] avformat/flvdec: Check for nesting depth in amf_skip_tag()

2021-01-26 Thread Michael Niedermayer
On Sat, Jan 23, 2021 at 11:10:55PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 29440/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5985279812960256.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 4/6] avformat/flvdec: Check for nesting depth in amf_parse_object()

2021-01-26 Thread Michael Niedermayer
On Tue, Jan 26, 2021 at 04:37:38PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-25 21:29:21) > > On Sun, Jan 24, 2021 at 02:14:43PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-01-23 23:10:54) > > > > Fixes: out of array access > > > > Fixes: > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/url: Reorder elements of URLProtocol to make it smaller

2021-01-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/url.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/url.h b/libavformat/url.h > index e33edf0cb9..1ef5ca35d5 100644 > --- a/libavformat/url.h > +++ b/libavformat/url.h > @@ -87,8

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-26 Thread Anton Khirnov
Quoting James Almer (2021-01-26 17:07:28) > On 1/26/2021 1:02 PM, Anton Khirnov wrote: > > Quoting Lynne (2021-01-24 18:34:36) > > Some devs (JEEB) wanted reception timestamps and original, overflowed > timestamps for MPEG-TS. > I'd be willing to add a reception timestamp as

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/apedec: Use FFABSU() in do_apply_filter()

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 02:13:07PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-23 23:10:52) > > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > > an unsigned type to negate this value to itself > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 1/6] avutil/common: Add FFABSU() for a signed -> unsigned ABS

2021-01-26 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 02:12:35PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-23 23:10:51) > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/common.h | 8 > > This is a public header, so a minor bump+APIchanges entry are needed. will apply with this

[FFmpeg-devel] [PATCH] avformat/flvdec: Check double before cast in parse_keyframes_index()

2021-01-26 Thread Michael Niedermayer
Fixes: -2.21166e+304 is outside the range of representable values of type 'long' Fixes: 29169/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5725452796821504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-26 Thread James Almer
On 1/26/2021 1:02 PM, Anton Khirnov wrote: Quoting Lynne (2021-01-24 18:34:36) Some devs (JEEB) wanted reception timestamps and original, overflowed timestamps for MPEG-TS. I'd be willing to add a reception timestamp as long as we add an additional time_base field and make it independent of

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-26 Thread Anton Khirnov
Quoting Lynne (2021-01-24 18:34:36) > >> > >> Some devs (JEEB) wanted reception timestamps and original, overflowed > >> timestamps for MPEG-TS. > >> I'd be willing to add a reception timestamp as long as we add an > >> additional time_base field > >> and make it independent of the packet's pts

[FFmpeg-devel] [PATCH] lavu/frame: extend AVFrame.opaque documentation

2021-01-26 Thread Anton Khirnov
--- libavutil/frame.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 392315f40f..f3e664bbc9 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -437,7 +437,12 @@ typedef struct AVFrame { int quality; /** -

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-26 Thread Tomas Härdin
tis 2021-01-26 klockan 00:34 +0100 skrev Marton Balint: > On Mon, 25 Jan 2021, emco...@ffastrans.com wrote: > > Uhm guys, it is very bad practice: if you just insert a different > > manufacturer name then you just cheat. SMPTE 377 has a clear statement > > about what goes to the identification,

Re: [FFmpeg-devel] [PATCH 4/6] avformat/flvdec: Check for nesting depth in amf_parse_object()

2021-01-26 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-25 21:29:21) > On Sun, Jan 24, 2021 at 02:14:43PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-01-23 23:10:54) > > > Fixes: out of array access > > > Fixes: > > > 29202/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5112845840809984

Re: [FFmpeg-devel] [PATCH v4 3/9] avcodec: add SEI enum for vvc

2021-01-26 Thread James Almer
On 1/26/2021 12:09 PM, Nuo Mi wrote: On Tue, Jan 26, 2021 at 10:36 PM James Almer wrote: On 1/25/2021 11:15 AM, Nuo Mi wrote: --- libavcodec/vvc_sei.h | 47 1 file changed, 47 insertions(+) create mode 100644 libavcodec/vvc_sei.h diff

Re: [FFmpeg-devel] [PATCH v4 3/9] avcodec: add SEI enum for vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 10:36 PM James Almer wrote: > On 1/25/2021 11:15 AM, Nuo Mi wrote: > > --- > > libavcodec/vvc_sei.h | 47 > > 1 file changed, 47 insertions(+) > > create mode 100644 libavcodec/vvc_sei.h > > > > diff --git

Re: [FFmpeg-devel] [PATCH v4 3/9] avcodec: add SEI enum for vvc

2021-01-26 Thread James Almer
On 1/25/2021 11:15 AM, Nuo Mi wrote: --- libavcodec/vvc_sei.h | 47 1 file changed, 47 insertions(+) create mode 100644 libavcodec/vvc_sei.h diff --git a/libavcodec/vvc_sei.h b/libavcodec/vvc_sei.h new file mode 100644 index

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 10:06 PM James Almer wrote: > On 1/25/2021 11:15 AM, Nuo Mi wrote: > > @@ -1637,6 +2047,16 @@ static const SEIMessageTypeDescriptor > cbs_sei_h265_types[] = { > > SEI_MESSAGE_TYPE_END > > }; > > > > +static const SEIMessageTypeDescriptor cbs_sei_h266_types[] = { >

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread James Almer
On 1/25/2021 11:15 AM, Nuo Mi wrote: @@ -1637,6 +2047,16 @@ static const SEIMessageTypeDescriptor cbs_sei_h265_types[] = { SEI_MESSAGE_TYPE_END }; +static const SEIMessageTypeDescriptor cbs_sei_h266_types[] = { You forgot to use this in ff_cbs_sei_find_type() below. Otherwise it

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 9:40 PM James Almer wrote: > On 1/26/2021 10:35 AM, Nuo Mi wrote: > > On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: > > > >> On 1/25/2021 2:12 PM, James Almer wrote: > >>> Did you add this just to set active_vps? I thought the > >>> idea was to remove all that since

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread James Almer
On 1/26/2021 10:35 AM, Nuo Mi wrote: On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: On 1/25/2021 2:12 PM, James Almer wrote: Did you add this just to set active_vps? I thought the idea was to remove all that since it's not a concept defined in h266. The following should get rid of

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_unsharp: Remove unnecessary ;

2021-01-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > A macro that expands to a function definition might look like a > declaration, but it isn't and therefore an extra ';' at the end is > unnecessary and actually invalid (both GCC and Clang warn about this > when using -pedantic). > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: > On 1/25/2021 2:12 PM, James Almer wrote: > > Did you add this just to set active_vps? I thought the > > idea was to remove all that since it's not a concept defined in h266. > > The following should get rid of active_*, but the actual fields

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 2:35 AM James Almer wrote: > On 1/25/2021 2:12 PM, James Almer wrote: > > On 1/25/2021 11:15 AM, Nuo Mi wrote: > >> +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, > >> RWContext *rw, > >> + H266RefPicListStruct

Re: [FFmpeg-devel] [PATCH 10/10] Revert "mpeg4videodec: raise an error if sprite_trajectory.table is NULL"

2021-01-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This reverts commit 6ac0e7818399a57e4684202bac79f35b3561ad1e. > > The mpeg4video parser can reach code that presumes that a certain VLC > has been initialized; yet Libav did not ensure this and Libav bug #1012 > [1] is about an ensuing crash. > > Instead of fixing the root

Re: [FFmpeg-devel] [PATCH] libavformat: avidec depends on dv for avpriv_dv_produce_packet

2021-01-26 Thread Andreas Rheinhardt
Peter Ross: > --- > libavformat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/Makefile b/libavformat/Makefile > index 3a8fbcbe5f..c4ce6ceb9b 100644 > --- a/libavformat/Makefile > +++ b/libavformat/Makefile > @@ -120,7 +120,7 @@

[FFmpeg-devel] [PATCH] avformat/avidec: Simplify compile-time check for DV demuxer

2021-01-26 Thread Andreas Rheinhardt
1b373b41d940e3058cdfb3d17703e23ed665353c made it a bit harder to find out that a call to avpriv_dv_produce_packet is dead when the DV demuxer is disabled; too hard for GCC on -O0. So simplify the check a bit. Signed-off-by: Andreas Rheinhardt --- libavformat/avidec.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avfilter: add colortemperature filter

2021-01-26 Thread Reto Kromer
Paul B Mahol wrote: >+@item temperature >+Set the temperature in Kelvins. Allowed range is from 1000 to 4. >+Default value is 6500 K. I would use the singular "Kelvin", otherwise LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avfilter: add colortemperature filter

2021-01-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colortemperature.c | 280 ++ 4 files changed, 304 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-26 Thread Jean-Baptiste Kempf
On Tue, 26 Jan 2021, at 11:28, Nicolas George wrote: > I will accept other people's opinion when it is founded on knowledge. Unfortunately, that's not how it works. We need to accept the will of majority of developers, even if you (or someone else) is not convinced. -- Jean-Baptiste Kempf -

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-26 Thread Nicolas George
James Almer (12021-01-25): > If by agenda you mean trying to solve the hacky state of the library, then > sure. Otherwise, please get rid of any potential slanderous thoughts you may > be have about it, because it sounds like you may be having trouble > distinguishing expressed personal opinions

[FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-01-26 Thread sgerwk-at-aol . com
In my previous email the patch got mangled by the web mail interface, so I am sending it again. Sorry for the duplicate. This patch allows ffmpeg to capture a specific window instead of the whole screen. An example: ffmpeg -f x11grab -window_id 0xa0a -i :0 output.mp4 --- doc/indevs.texi

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-26 Thread emcodem
Am 2021-01-26 00:34, schrieb Marton Balint: Uhm guys, it is very bad practice: if you just insert a different manufacturer name then you just cheat. SMPTE 377 has a clear statement about what goes to the identification, you cannot just write the infos from a different program there.

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-26 Thread Tobias Rapp
On 25.01.2021 20:40, emco...@ffastrans.com wrote: [...] What you can do instead is to push both identifications, the old one and the one from the current program into the identification array, this way the processing chain can be reconstructed. Unforutnately i have never seen anyone doing