Re: [FFmpeg-devel] [PATCH] avforma: add an AV1 Low overhead bitstream format muxer

2021-09-01 Thread James Almer
On 8/27/2021 4:34 PM, James Almer wrote: Suggested-by: BBB Signed-off-by: James Almer --- Changelog | 1 + configure | 1 + doc/general_contents.texi | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c |

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: set the RGB matrix coefficients in case of RGB

2021-09-01 Thread Jan Ekström
On Tue, Aug 31, 2021 at 1:14 AM Jan Ekström wrote: > > On Sun, Aug 29, 2021 at 10:05 PM Jan Ekström wrote: > > > > On Sun, Aug 29, 2021 at 9:21 PM Paul B Mahol wrote: > > > > > > probably fine if fate passes > > > > Yea, FATE passes :) . I think this stuff not being noticed until now > > is due

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Allow up to seven codec ids per parser

2021-09-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ff_pnm_parser and ff_vp3_parser already hit the current limit; > an addition to the former (to handle pfm) is planned. > > Signed-off-by: Andreas Rheinhardt > --- > If this API were not intended to be deprecated soon, I would make > the codec_ids an array of enum AVCodecID

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx265: add support for setting chroma sample location

2021-09-01 Thread Jan Ekström
On Wed, Sep 1, 2021 at 12:11 AM Jan Ekström wrote: > > On Tue, Aug 31, 2021 at 12:52 AM Jan Ekström wrote: > > > > On Sun, Aug 29, 2021 at 7:43 PM Jan Ekström wrote: > > > > > > Unlike libx264, libx265 does not handle the chroma format check > > > on its own side, so in order to not write out

Re: [FFmpeg-devel] [PATCH v2] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Paul B Mahol
parser sets keyframes, which allows proper decoding, so it is mandatory to use. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-09-01 Thread Michael Niedermayer
On Tue, Aug 31, 2021 at 10:44:57PM +0300, Martin Storsjö wrote: > > On Aug 23, 2021, at 17:41, Nicolas George wrote: > > > > Michael Niedermayer (12021-08-23): > >> Please make sure you use g...@git.ffmpeg.org:fateserver not > >> g...@source.ffmpeg.org:fateserver > > > > My bad. I fixed it and

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Allow up to seven codec ids per parser

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Joel Linn
On 2021-09-01 11:12, Paul B Mahol wrote: I do not get it, do you use parser in your code to support decoding of XMA? No. The duration information from the parser is of no use to me. Without parser decoding is not currently supported. I could use the parser but like I said it is

[FFmpeg-devel] [PATCH] avcodec/h264_levels, h265_profile_level: Avoid relocations

2021-09-01 Thread Andreas Rheinhardt
H.264 and H.265 levels' names are usually of the form "x" or "x.y" with x and y being single digits; the one exception are the H.264 1b levels. All of those levels' names fit into a char[4] and it is likely that this future levels will do so, too. Therefore this commit changes the

[FFmpeg-devel] [PATCH 4/4] libavformat/hls: correct indentation

2021-09-01 Thread Nachiket Tarate
Signed-off-by: Nachiket Tarate --- libavformat/hls.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 0feddb06e4..3c34d69538 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2051,23

[FFmpeg-devel] [PATCH 3/4] libavformat/hls: add support for decryption of HLS media segments encrypted using SAMPLE-AES encryption method

2021-09-01 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile| 2 +- libavformat/hls.c | 128 +++--

[FFmpeg-devel] [PATCH 2/4] libavformat/mov: add support for 'cens', 'cbc1' and 'cbcs' encryption schemes specified in Common Encryption (CENC) standard

2021-09-01 Thread Nachiket Tarate
correct implementation of 'cenc' encryption scheme to support decryption of partial cipher blocks at the end of subsamples https://www.iso.org/standard/68042.html Signed-off-by: Nachiket Tarate --- libavformat/isom.h | 2 + libavformat/mov.c | 246

[FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-09-01 Thread Nachiket Tarate
These will be used by HLS demuxer in case of sample decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 15 +++ libavcodec/adts_parser.c | 31 +++ 3 files changed, 47 insertions(+) diff --git

[FFmpeg-devel] [PATCH] Revert "ffmpeg: force 128k default audio bitrate if nothing is specified and there is no specific default"

2021-09-01 Thread Andreas Rheinhardt
This reverts commit 628a73f8f3768513fa6152c98d54842cf2ae1aad. At the time of said commit there was talk of removing the audio bitrate "ab" option to bring FFmpeg in line with what Libav has done in 2012 in commit 041cd5a0c55e02dd3b9a2419644b03103819c3d3. By having different option flags for the

[FFmpeg-devel] [PATCH] avcodec/avcodec: Allow up to seven codec ids per parser

2021-09-01 Thread Andreas Rheinhardt
ff_pnm_parser and ff_vp3_parser already hit the current limit; an addition to the former (to handle pfm) is planned. Signed-off-by: Andreas Rheinhardt --- If this API were not intended to be deprecated soon, I would make the codec_ids an array of enum AVCodecID and change av_parser_init()

Re: [FFmpeg-devel] [PATCH v2] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Paul B Mahol
I do not get it, do you use parser in your code to support decoding of XMA? Without parser decoding is not currently supported. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/{isom, movenc}: add kind box compatibility mode for Unified Origin

2021-09-01 Thread zhilizhao(赵志立)
> On Aug 30, 2021, at 7:14 PM, Jan Ekström wrote: > > From: Jan Ekström > > Unfortunately the current production versions of this software > do not 100% adhere to the CMAF specification, and have decided > to utilize the HTML5 media track identifier for audio descriptions. > > This way the

[FFmpeg-devel] [PATCH v2] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Joel Linn
Support decoding only a selection of the encoded XMA streams. Previously, the decoder assumed it was decoding all available streams. --- libavcodec/wmaprodec.c | 65 -- 1 file changed, 38 insertions(+), 27 deletions(-) diff --git a/libavcodec/wmaprodec.c

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Joel Linn
On 2021-09-01 08:26, Paul B Mahol wrote: On Tue, Aug 31, 2021 at 11:19 PM Joel Linn wrote: On 2021-08-31 23:13, Paul B Mahol wrote: > On Tue, Aug 31, 2021 at 11:10 PM Joel Linn wrote: > >> Hello, >> >> On 2021-08-31 22:53, Paul B Mahol wrote: >> > What samples this fixes? >> >> No specific

Re: [FFmpeg-devel] [PATCH 10/10] lavfi/vf_scale: pass the thread count to the scaler

2021-09-01 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-08-30 14:34:30) > On Mon, Aug 30, 2021 at 11:38:53AM +0200, Michael Niedermayer wrote: > > > I am not familiar with the generic scaler code, but it seems independent > > > of this partitioning, otherwise the threaded scaling tests would fail. > > > > the generic

[FFmpeg-devel] [PATCH] avcodec/mlpenc: add support for 24bit encoding

2021-09-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mlpenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index 37052d9e38..443cb41cf5 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @@ -2390,7 +2390,7 @@ const AVCodec

[FFmpeg-devel] [PATCH 2/2] fftools/cmdutils: Use %c, not %s, to write single char

2021-09-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 69c39479f5..71799f46ff 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -2240,7 +2240,7 @@ static int

[FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: Don't access AV(In|Out)putformat.get_device_list

2021-09-01 Thread Andreas Rheinhardt
It is not part of the public API. Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2dd035a7cf..69c39479f5 100644 --- a/fftools/cmdutils.c +++

Re: [FFmpeg-devel] [PATCH v2 10/10] avcodec/aptxenc: Process data in complete blocks of four samples only

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 06/10] avcodec/aptx: Use AVCodecContext.frame_size according to the API

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 07/10] avformat/aptxdec: Don't set AVCodecParameters.frame_size

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 09/10] avcodec/aptxdec: Process data in complete blocks only

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 08/10] avformat/aptxdec: Use ff_pcm_read_packet

2021-09-01 Thread Paul B Mahol
Make sure there is not limitation in APTX specification how packet size must be, looking that now it is changed for stereo. Otherwise LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v2 02/10] avformat/flacdec: Also set channels when setting channel_layout

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 05/10] avcodec/utils: Support APTX (HD) in av_get_audio_frame_duration()

2021-09-01 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: skip foreign XMA packets

2021-09-01 Thread Paul B Mahol
On Tue, Aug 31, 2021 at 11:19 PM Joel Linn wrote: > On 2021-08-31 23:13, Paul B Mahol wrote: > > On Tue, Aug 31, 2021 at 11:10 PM Joel Linn wrote: > > > >> Hello, > >> > >> On 2021-08-31 22:53, Paul B Mahol wrote: > >> > What samples this fixes? > >> > >> No specific sample, it depends on the

Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

2021-09-01 Thread Paul B Mahol
On Wed, Sep 1, 2021 at 12:49 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Mapul Bhola > > Sent: Tuesday, 31 August 2021 23:39 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2 7/8]