Re: [FFmpeg-devel] [PATCH 03/24] avcodec/subtitles: Introduce new frame-based subtitle decoding API

2022-01-14 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Friday, January 14, 2022 6:54 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 03/24] avcodec/subtitles: Introduce new > frame-based subtitle decoding API > > ffmpegagent: > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows

2022-01-14 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Saturday, January 15, 2022 7:40 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on > Windows > > ffmpegagent: > > From: softworkz > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows

2022-01-14 Thread Andreas Rheinhardt
ffmpegagent: > From: softworkz > > Signed-off-by: softworkz > --- > avformat/hlsenc: Fix path handling on Windows > > Handling for DOS path separators was missing > > Published-As: > https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-19%2Fsoftworkz%2Fsubmit_hlspath-v1

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Lynne
15 Jan 2022, 05:08 by ffm...@gyani.pro: > > > On 2022-01-15 06:18 am, Lynne wrote: > >> 14 Jan 2022, 20:39 by d...@lynne.ee: >> >>> 14 Jan 2022, 20:32 by mich...@niedermayer.cc: >>> On Fri, Jan 14, 2022 at 08:02:35PM +0100, Lynne wrote: > 14 Jan 2022, 18:48 by

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Gyan Doshi
On 2022-01-15 06:18 am, Lynne wrote: 14 Jan 2022, 20:39 by d...@lynne.ee: 14 Jan 2022, 20:32 by mich...@niedermayer.cc: On Fri, Jan 14, 2022 at 08:02:35PM +0100, Lynne wrote: 14 Jan 2022, 18:48 by mich...@niedermayer.cc: On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: Since I

[FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows

2022-01-14 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- avformat/hlsenc: Fix path handling on Windows Handling for DOS path separators was missing Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-19%2Fsoftworkz%2Fsubmit_hlspath-v1 Fetch-It-Via: git fetch

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Lynne
14 Jan 2022, 20:39 by d...@lynne.ee: > 14 Jan 2022, 20:32 by mich...@niedermayer.cc: > >> On Fri, Jan 14, 2022 at 08:02:35PM +0100, Lynne wrote: >> >>> 14 Jan 2022, 18:48 by mich...@niedermayer.cc: >>> >>> > On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: >>> > >>> >> Since I couldn't find

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Lynne
14 Jan 2022, 20:32 by mich...@niedermayer.cc: > On Fri, Jan 14, 2022 at 08:02:35PM +0100, Lynne wrote: > >> 14 Jan 2022, 18:48 by mich...@niedermayer.cc: >> >> > On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: >> > >> >> Since I couldn't find a codename preference, I went with "Desitter"

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Michael Niedermayer
On Fri, Jan 14, 2022 at 08:02:35PM +0100, Lynne wrote: > 14 Jan 2022, 18:48 by mich...@niedermayer.cc: > > > On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: > > > >> Since I couldn't find a codename preference, I went with "Desitter" > >> > > > > I just counted and i see > > 2 for

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Lynne
14 Jan 2022, 18:48 by mich...@niedermayer.cc: > On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: > >> Since I couldn't find a codename preference, I went with "Desitter" >> > > I just counted and i see > 2 for Desitter (the initial from the past and you) > 3 for Lorentz (the initial from

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Andreas Rheinhardt
Thilo Borgmann: > Am 14.01.22 um 19:05 schrieb Andreas Rheinhardt: >> Thilo Borgmann: >>> Am 14.01.22 um 14:17 schrieb "zhilizhao(赵志立)": > On Jan 14, 2022, at 8:14 PM, Thilo Borgmann > wrote: > > Am 06.01.22 um 12:27 schrieb Thilo Borgmann: >> Am 03.01.22 um 16:22

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 19:08 schrieb Nicolas George: > Thilo Borgman (12022-01-14): >> Ah and I misunderstood your other remark about it. >> >> What about adding an option for ms precision and stick to the existing >> expansions localtime/gmtime, then add .ms if set by option? > > I am not sure what you

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 19:05 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Am 14.01.22 um 14:17 schrieb "zhilizhao(赵志立)": >>> >>> On Jan 14, 2022, at 8:14 PM, Thilo Borgmann wrote: Am 06.01.22 um 12:27 schrieb Thilo Borgmann: > Am 03.01.22 um 16:22 schrieb Thilo Borgmann: >> Am

Re: [FFmpeg-devel] [PATCH v9 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 18:57 schrieb Romain Beauxis: > Le ven. 14 janv. 2022 à 11:47, Thilo Borgmann a > écrit : >> >> Am 14.01.22 um 13:57 schrieb Marvin Scholz: >>> >>> >>> On 6 Jan 2022, at 15:24, Romain Beauxis wrote: >>> * Implement support for AudioConverter * Switch to AudioConverter's

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Nicolas George
Thilo Borgman (12022-01-14): > Ah and I misunderstood your other remark about it. > > What about adding an option for ms precision and stick to the existing > expansions localtime/gmtime, then add .ms if set by option? I am not sure what you are suggesting. How does it look like from the point

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Andreas Rheinhardt
Thilo Borgmann: > Am 14.01.22 um 14:17 schrieb "zhilizhao(赵志立)": >> >> >>> On Jan 14, 2022, at 8:14 PM, Thilo Borgmann wrote: >>> >>> Am 06.01.22 um 12:27 schrieb Thilo Borgmann: Am 03.01.22 um 16:22 schrieb Thilo Borgmann: > Am 29.12.21 um 12:46 schrieb Nicolas George: >>

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 18:57 schrieb Nicolas George: > Thilo Borgman (12022-01-14): I think best will be to scan the format string for %S and extend it there with .ms part before expanding the rest of it, not? Shouldn't be too expensive for the filter. Just need to find time to

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Zhao Zhili
> On Jan 15, 2022, at 1:40 AM, Thilo Borgmann wrote: >> >>> +if (tag == 'M' || tag == 'm') { >>> +char *seconds = av_stristr(fmt, "%S"); >>> +if (seconds) { >>> +seconds += 2; >>> +int len = seconds - fmt + 1; >>> +char *tmp =

Re: [FFmpeg-devel] [PATCH v9 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2022-01-14 Thread Romain Beauxis
Le ven. 14 janv. 2022 à 11:47, Thilo Borgmann a écrit : > > Am 14.01.22 um 13:57 schrieb Marvin Scholz: > > > > > > On 6 Jan 2022, at 15:24, Romain Beauxis wrote: > > > >> * Implement support for AudioConverter > >> * Switch to AudioConverter's API to convert unsupported PCM > >> formats

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Nicolas George
Thilo Borgman (12022-01-14): > >> I think best will be to scan the format string for %S and extend it > >> there with .ms part before expanding the rest of it, not? Shouldn't > >> be too expensive for the filter. > >> > >> Just need to find time to actually implement it. Sorry, I completely

Re: [FFmpeg-devel] [PATCH 03/24] avcodec/subtitles: Introduce new frame-based subtitle decoding API

2022-01-14 Thread Andreas Rheinhardt
ffmpegagent: > From: softworkz > > - Add avcodec_decode_subtitle3 which takes subtitle frames, > serving as compatibility shim to legacy subtitle decoding > - Add additional methods for conversion between old and new API This commit message is completely wrong. > > Signed-off-by: softworkz

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-14 Thread Michael Niedermayer
On Tue, Jan 04, 2022 at 04:08:49PM +0100, Lynne wrote: > Since I couldn't find a codename preference, I went with "Desitter" I just counted and i see 2 for Desitter (the initial from the past and you) 3 for Lorentz (the initial from the past, jb and reto ) [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH v9 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 13:57 schrieb Marvin Scholz: > > > On 6 Jan 2022, at 15:24, Romain Beauxis wrote: > >> * Implement support for AudioConverter >> * Switch to AudioConverter's API to convert unsupported PCM >>   formats (non-interleaved, non-packed) to supported formats >> * Minimize data copy. >>

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Thilo Borgmann
Am 14.01.22 um 14:17 schrieb "zhilizhao(赵志立)": > > >> On Jan 14, 2022, at 8:14 PM, Thilo Borgmann wrote: >> >> Am 06.01.22 um 12:27 schrieb Thilo Borgmann: >>> Am 03.01.22 um 16:22 schrieb Thilo Borgmann: Am 29.12.21 um 12:46 schrieb Nicolas George: > "zhilizhao(赵志立)" (12021-12-29):

Re: [FFmpeg-devel] [PATCH] vf_paletteuse: fix color cache lookup for Bayer dithering mode.

2022-01-14 Thread Gyan Doshi
O On 2022-01-14 10:53 pm, Thierry Foucu wrote: On Mon, Jan 10, 2022 at 10:32 AM Paul B Mahol wrote: LGTM Any chance to push this change? On Sunday, if no one else does. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] vf_paletteuse: fix color cache lookup for Bayer dithering mode.

2022-01-14 Thread Thierry Foucu
On Mon, Jan 10, 2022 at 10:32 AM Paul B Mahol wrote: > LGTM > Any chance to push this change? > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 06/24] avcodec/subtitles: Migrate subtitle encoders to frame-based API

2022-01-14 Thread Michael Niedermayer
On Fri, Jan 14, 2022 at 01:13:15AM +, ffmpegagent wrote: > From: softworkz > > and provide a compatibility shim for the legacy api > > Signed-off-by: softworkz > --- > libavcodec/assenc.c| 189 ++--- > libavcodec/avcodec.h | 5 +- >

Re: [FFmpeg-devel] [PATCH 21/24] fftools/ffmpeg: Introduce subtitle filtering new frame-based subtitle encoding

2022-01-14 Thread Michael Niedermayer
On Fri, Jan 14, 2022 at 01:13:30AM +, ffmpegagent wrote: > From: softworkz > > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. > > The heartbeat functionality from the previous sub2video implementation > is

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-01-14 Thread Thilo Borgmann
Hi, Am 19.01.21 um 05:49 schrieb Lynne: > Jan 19, 2021, 01:07 by borba...@fb.com: > >> Calculate Spatial Info (SI) and Temporal Info (TI) scores for a video, as >> defined >> in ITU-T P.910: Subjective video quality assessment methods for multimedia >> applications. >> >> Update: Fixed bracket

[FFmpeg-devel] [PATCH] avcodec/libmp3lame: check channel count after the lame_init_params()

2022-01-14 Thread James Almer
LAME will silently change the channel count value if you pass it an unsupported one. This should normally not be an issue as we ensure only 1 and 2 channel streams are ever initialized, but since LAME could make changes outside our control anytime, add an extra check for this. Signed-off-by:

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread lance . lmwang
On Fri, Jan 14, 2022 at 02:07:26PM +0200, Martin Storsjö wrote: > On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > due to the limitations set in d3a7bdd4ac54349aea9150a234478635d50ebd87, > > you weren't able to use main profile with OpenH264 1.8, or high profile

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread zhilizhao(赵志立)
> On Jan 14, 2022, at 8:14 PM, Thilo Borgmann wrote: > > Am 06.01.22 um 12:27 schrieb Thilo Borgmann: >> Am 03.01.22 um 16:22 schrieb Thilo Borgmann: >>> Am 29.12.21 um 12:46 schrieb Nicolas George: "zhilizhao(赵志立)" (12021-12-29): > How about add a restriction like this: > >

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread James Almer
On 1/6/2022 8:27 AM, Thilo Borgmann wrote: Am 03.01.22 um 16:22 schrieb Thilo Borgmann: Am 29.12.21 um 12:46 schrieb Nicolas George: "zhilizhao(赵志立)" (12021-12-29): How about add a restriction like this: if (format.endsWith(“%S")) enable the feature else warning message It’s a

Re: [FFmpeg-devel] [PATCH v9 1/3] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2022-01-14 Thread Marvin Scholz
On 6 Jan 2022, at 15:24, Romain Beauxis wrote: * Implement support for AudioConverter * Switch to AudioConverter's API to convert unsupported PCM formats (non-interleaved, non-packed) to supported formats * Minimize data copy. This fixes: https://trac.ffmpeg.org/ticket/9502 API ref:

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Thilo Borgmann
Am 06.01.22 um 12:27 schrieb Thilo Borgmann: > Am 03.01.22 um 16:22 schrieb Thilo Borgmann: >> Am 29.12.21 um 12:46 schrieb Nicolas George: >>> "zhilizhao(赵志立)" (12021-12-29): How about add a restriction like this: if (format.endsWith(“%S")) enable the feature else

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread Martin Storsjö
On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang due to the limitations set in d3a7bdd4ac54349aea9150a234478635d50ebd87, you weren't able to use main profile with OpenH264 1.8, or high profile with older versions Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang ---

[FFmpeg-devel] [PATCH v3 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-14 Thread lance . lmwang
From: Limin Wang For high/main profile, user can choose to use cavlc by specify "-coder cavlc", for default, it'll will use cabac, if it's baseline, we'll use cavlc by specs anyway. ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f

[FFmpeg-devel] [PATCH v3 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread lance . lmwang
From: Limin Wang due to the limitations set in d3a7bdd4ac54349aea9150a234478635d50ebd87, you weren't able to use main profile with OpenH264 1.8, or high profile with older versions Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 8 1 file

[FFmpeg-devel] [PATCH v3 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-14 Thread lance . lmwang
From: Limin Wang Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..5b5914c 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread lance . lmwang
On Fri, Jan 14, 2022 at 11:28:14AM +0200, Martin Storsjö wrote: > On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions > > because we had missed to set uiProfileIdc. > > > > If the version

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-14 Thread Martin Storsjö
On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang For high/main profile, user can choose to use cavlc by specify "-coder cavlc", for default, it'll will use cabac, if it's baseline, we'll use cavlc by specs anyway. ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread Martin Storsjö
On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions because we had missed to set uiProfileIdc. If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-14 Thread Martin Storsjö
On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..5b5914c 100644 ---

[FFmpeg-devel] [PATCH v2 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-14 Thread lance . lmwang
From: Limin Wang For high/main profile, user can choose to use cavlc by specify "-coder cavlc", for default, it'll will use cabac, if it's baseline, we'll use cavlc by specs anyway. ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f

[FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-14 Thread lance . lmwang
From: Limin Wang d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions because we had missed to set uiProfileIdc. If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing cli: ffmpeg -y -f lavfi -i testsrc -c:v libopenh264

[FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-14 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..5b5914c 100644 --- a/libavcodec/libopenh264enc.c +++