[FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: fix memleak in plot_freqs

2022-05-12 Thread Steven Liu
plot_freqs should free colors before return error when ff_get_video_buffer failed Signed-off-by: Steven Liu --- libavfilter/avf_showfreqs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c index

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-12 Thread lance . lmwang
On Thu, May 12, 2022 at 06:29:51PM +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > lance.lmw...@gmail.com: > >> On Thu, May 12, 2022 at 08:25:29AM +0200, Paul B Mahol wrote: > >>> On Thu, May 12, 2022 at 1:39 AM wrote: > >>> > On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avcodec/libuavs3d: fix access uninitialized variable when draining

2022-05-12 Thread myp...@gmail.com
On Thu, May 12, 2022 at 5:55 PM Zhao Zhili wrote: > > buf_ptr is uninitialized and accessed when function return. > --- > libavcodec/libuavs3d.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/libuavs3d.c b/libavcodec/libuavs3d.c > index

[FFmpeg-devel] [PATCH] ffbuild/common: Fix CPPFLAGS applied for compiling C++ files

2022-05-12 Thread Andreas Rheinhardt
Currently, $(CPPFLAGS) and $(CFLAGS) are prepended to CXXFLAGS (the flags for compiling C++) like this: CXXFLAGS := $(CPPFLAGS) $(CFLAGS) $(CXXFLAGS) Using ":=" creates a simply expanded variable, i.e. the values of the variable at the time of assignment are used and later modifications to them

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: ipred_vl_16x16_16 avx2 implementation

2022-05-12 Thread Ronald S. Bultje
Hi, On Wed, May 4, 2022 at 8:57 AM FacelessLake wrote: > From: Semen Belozerov > > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 ++ > libavcodec/x86/vp9intrapred_16bpp.asm | 51 +++ > 2 files changed, 53 insertions(+) > Merged. Ronald

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > lance.lmw...@gmail.com: >> On Thu, May 12, 2022 at 08:25:29AM +0200, Paul B Mahol wrote: >>> On Thu, May 12, 2022 at 1:39 AM wrote: >>> On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > why? assuming the len is 1, the following code will

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-12 Thread Vignesh Venkatasubramanian
Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specification: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -still-picture 1 image.avif Sample usage for animated AVIF image: ffmpeg -i video.mp4 animated.avif We can

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-12 Thread Vignesh Venkatasubramanian
On Thu, May 12, 2022 at 3:27 AM Gyan Doshi wrote: > > > > On 2022-05-11 10:55 pm, Gyan Doshi wrote: > > > > > > On 2022-05-11 10:24 pm, Vignesh Venkatasubramanian wrote: > >> On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian > >> wrote: > >>> Add an AVIF muxer by re-using the existing

[FFmpeg-devel] [PATCH] lavc: fix h264 parser bug

2022-05-12 Thread Lingjiang Fang
will give a wrong nalu length(+1) when next nalu start with 0001 this bug will lead to an padding zero to pps in AVC Sequence header(flv) or in avc1(mpr) --- libavcodec/h2645_parse.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c

Re: [FFmpeg-devel] [PATCH 81/87] avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf

2022-05-12 Thread John Stebbins
Thanks for the pointer. Much appreciated. On Thu, 2022-05-12 at 17:43 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Hi all, > > > > I know this happened quite some time ago, but we just noticed the > > change. > > > > This effectively disables the public API AVCodecParser.split for > >

Re: [FFmpeg-devel] [PATCH 81/87] avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf

2022-05-12 Thread Andreas Rheinhardt
John Stebbins: > Hi all, > > I know this happened quite some time ago, but we just noticed the > change. > > This effectively disables the public API AVCodecParser.split for these > codecs. HandBrake uses this API to split out extradata for a few > codecs. Any chance we can bring these back?

[FFmpeg-devel] [PATCH v7 2/2] avcodec/libjxlenc: properly read input colorspace

2022-05-12 Thread Leo Izen
Whether an ICC profile is present or not, the libjxl encoder wrapper should now properly read colorspace tags and forward them to libjxl appropriately, rather than just assume sRGB as before. It will also print warnings when colorimetric assumptions are made about the input data. ---

[FFmpeg-devel] [PATCH v7 1/2] avcodec/libjxldec: properly tag output colorspace

2022-05-12 Thread Leo Izen
Whether an ICC profile is present or not, the decoder should now properly tag the colorspace of pixel data received by the decoder. --- libavcodec/libjxldec.c | 128 +++-- 1 file changed, 109 insertions(+), 19 deletions(-) diff --git a/libavcodec/libjxldec.c

[FFmpeg-devel] [PATCH v7 0/2] JPEG XL Colorspace Fixes

2022-05-12 Thread Leo Izen
Changes: v7: changes requested by haasn: - avoid attaching ICCP for now, with followup once lcms2 enters avutil - make gamma transfer slightly more tolerant others: - refactor some conversions into separate functions for cleaner code v6: - some cosmetic changes - check the AVFrame metadata if

[FFmpeg-devel] [PATCH 1/1] fix: use declared size for attribute of type string to ensure full value used and prevent parse failure for string lengths longer than 256

2022-05-12 Thread vectronic
Signed-off-by: vectronic --- libavcodec/exr.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 8cd867a32f..bc2afcee53 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1912,10 +1912,13 @@ static

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-12 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Thu, May 12, 2022 at 08:25:29AM +0200, Paul B Mahol wrote: >> On Thu, May 12, 2022 at 1:39 AM wrote: >> >>> On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: why? >>> >>> assuming the len is 1, the following code will access the next 3 >>> array

[FFmpeg-devel] [PATCH 0/1] avcodec/exr: variable string attribute length

2022-05-12 Thread vectronic
fix: use declared size for attribute of type string to ensure full value used and prevent parse failure for string lengths longer than 256 libavcodec/exr.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) -- 2.32.0 (Apple Git-132)

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-12 Thread lance . lmwang
On Thu, May 12, 2022 at 08:25:29AM +0200, Paul B Mahol wrote: > On Thu, May 12, 2022 at 1:39 AM wrote: > > > On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > > > why? > > > > assuming the len is 1, the following code will access the next 3 > > array anymore, I think it's better to

Re: [FFmpeg-devel] [PATCH 81/87] avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf

2022-05-12 Thread John Stebbins
Hi all, I know this happened quite some time ago, but we just noticed the change. This effectively disables the public API AVCodecParser.split for these codecs. HandBrake uses this API to split out extradata for a few codecs. Any chance we can bring these back? Otherwise, we will have to

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add query_timeout option for h264/hevc

2022-05-12 Thread zhilizhao(赵志立)
> On May 12, 2022, at 7:34 PM, 孙波 wrote: > > I think set maximum to 1000ms is better, because value bigger than 1000 can't > effect in my test. Please send v3 to update the default value and range. And check AMF_VIDEO_ENCODER_HEVC_QUERY_TIMEOUT/AMF_VIDEO_ENCODER_QUERY_TIMEOUT are defined.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3: Move non-(de|en)coder-only parts out of ac3.h

2022-05-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Move AC3HeaderInfo into ac3_parser_internal.h and the rest > into a new header ac3defs.h. > > This also breaks an include cycle of ac3.h and ac3tab.h > (the latter now only needs ac3defs.h). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3.c

[FFmpeg-devel] [PATCH 3/3] avcodec/ac3: Move non-(de|en)coder-only parts out of ac3.h

2022-05-12 Thread Andreas Rheinhardt
Move AC3HeaderInfo into ac3_parser_internal.h and the rest into a new header ac3defs.h. This also breaks an include cycle of ac3.h and ac3tab.h (the latter now only needs ac3defs.h). Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.c| 1 + libavcodec/ac3.h

[FFmpeg-devel] [PATCH 2/3] avcodec/ac3tab: Move some tables only used by ac3.c to it

2022-05-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.c| 86 +++-- libavcodec/ac3tab.c | 82 -- libavcodec/ac3tab.h | 2 -- 3 files changed, 84 insertions(+), 86 deletions(-) diff --git a/libavcodec/ac3.c

[FFmpeg-devel] [PATCH 1/3] avcodec/ac3: Remove declaration of inexistent function

2022-05-12 Thread Andreas Rheinhardt
Removed in 7b11eead1b4e08728561595e6b610cf8fe2b7122. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/ac3.h b/libavcodec/ac3.h index dabd49f4cc..8e66d47629 100644 --- a/libavcodec/ac3.h +++ b/libavcodec/ac3.h @@ -214,8 +214,6

Re: [FFmpeg-devel] [PATCH] avfilter/alimiter:add latency compensation

2022-05-12 Thread Paul B Mahol
On Wed, May 11, 2022 at 12:45 AM Wang Cao wrote: > On Thu, May 5, 2022 at 2:14 PM Wang Cao wrote: > > > Also added 2 FATE tests to verify delay is compenated correctly > Applied with minor fixes and tests removed for now. > > > > Signed-off-by: Wang Cao > > --- > > doc/filters.texi

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: add query_timeout option for h264/hevc

2022-05-12 Thread Zhao Zhili
From: 21pages Signed-off-by: 21pages Co-authored-by: Zhao Zhili --- v2: fix range libavcodec/amfenc.h | 1 + libavcodec/amfenc_h264.c | 4 libavcodec/amfenc_hevc.c | 4 libavcodec/version.h | 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] Issue - Error Due to higher number of threads

2022-05-12 Thread Timo Rothenpieler
On 12.05.2022 04:22, Srihari Sridhar wrote: Hi, I was building ffmpeg through windows. While I was able to successfully able to build for smaller number of threads, for larger number of threads I faced an issue The commands I used were bash ./configure --arch=x86 --target-os=mingw32

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-12 Thread Gyan Doshi
On 2022-05-11 10:55 pm, Gyan Doshi wrote: On 2022-05-11 10:24 pm, Vignesh Venkatasubramanian wrote: On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian wrote: Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specification: https://aomediacodec.github.io/av1-avif

[FFmpeg-devel] [PATCH] avcodec/amfenc: add query_timeout option for h264/hevc

2022-05-12 Thread Zhao Zhili
From: 21pages Signed-off-by: 21pages Co-authored-by: Zhao Zhili --- libavcodec/amfenc.h | 1 + libavcodec/amfenc_h264.c | 4 libavcodec/amfenc_hevc.c | 4 libavcodec/version.h | 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc.h

Re: [FFmpeg-devel] [PATCH 1/3] doc/encoders.texi: Document cinepak encoder

2022-05-12 Thread Tomas Härdin
tis 2022-05-10 klockan 09:59 +0200 skrev Tomas Härdin: > ons 2022-05-04 klockan 11:41 +0200 skrev Tomas Härdin: > > Ping > > > > I tested patch 2's output on Windows 3.1, still works fine. Could > > potentially merge both documentation patches > > Pushing this in a day or two. FATE passes.

[FFmpeg-devel] [PATCH] avcodec/libuavs3d: fix access uninitialized variable when draining

2022-05-12 Thread Zhao Zhili
buf_ptr is uninitialized and accessed when function return. --- libavcodec/libuavs3d.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/libuavs3d.c b/libavcodec/libuavs3d.c index 6966e00b62..23de4c8cd5 100644 --- a/libavcodec/libuavs3d.c +++

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-12 Thread Anton Khirnov
Quoting Gyan Doshi (2022-05-12 09:01:31) > A substitute option for metadata rotate would accept a single rotation > value. > If adding an option for matrix, we should allow flips too. I see no reason not to have both. You can have a simple option for just the rotation and an advanced option for

Re: [FFmpeg-devel] [PATCH v5 07/21] avdevice/avdevice: Revert "Deprecate AVDevice Capabilities API"

2022-05-12 Thread Diederick C. Niehorster
On Tue, May 10, 2022 at 7:25 PM Andreas Rheinhardt wrote: > > Diederick Niehorster: > > This reverts commit 4f49ca7bbc75a9db4cdf93f27f95a668c751f160. The next > > few patches clean up the API and implement this capability for > > avdevice/dshow. > > > > Bumping avformat and avdevice version. > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too

2022-05-12 Thread Gyan Doshi
On 2022-05-12 10:55 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 21:15:15) On 2022-05-12 12:19 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-11 14:18:49) On 2022-05-11 05:26 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-05-10 13:40:54) So far, -metadata:s:v rotate

Re: [FFmpeg-devel] [PATCH] configure: extend check to less than 3.0.0

2022-05-12 Thread Gyan Doshi
On 2022-05-12 10:35 am, Gyan Doshi wrote: On 2022-05-12 01:41 am, Christopher Degawa wrote: sdl2 recently changed their versioning, moving the patch level to minor level https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff and have said that they will

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length

2022-05-12 Thread Paul B Mahol
On Thu, May 12, 2022 at 1:39 AM wrote: > On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: > > why? > > assuming the len is 1, the following code will access the next 3 > array anymore, I think it's better to check the i with len -2. > > for (i = 0; i < len; i += 3) { > to > for (i =

Re: [FFmpeg-devel] [PATCH] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-12 Thread PLT
Thank you for your review. All your suggestions have been taken into account and new patches have just been put on the mailing list. -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Tuesday, April 5, 2022 7:37 PM To: ffmpeg-devel@ffmpeg.org Subject: Re:

[FFmpeg-devel] [PATCH 3/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-12 Thread Dawid Kozinski
- Added muxer for EVC format (MP4, raw) - Added demuxer for EVC format (MP4) - Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 +

[FFmpeg-devel] [PATCH 2/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-12 Thread Dawid Kozinski
- Added xeve encoder wrapper - Added xevd dencoder wrapper - Added documentation for xeve and xevd wrappers - Added parser for EVC format - Changes in project configuration file and libavcodec Makefile Signed-off-by: Dawid Kozinski --- configure |8 + doc/decoders.texi

[FFmpeg-devel] [PATCH 1/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-05-12 Thread Dawid Kozinski
Prerequisites that must be met before adding new codec - Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Changes in Changelog and MAINTAINERS files Signed-off-by: Dawid Kozinski --- Changelog | 3 ++- MAINTAINERS