Re: [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample

2022-12-19 Thread Paul B Mahol
On 12/18/22, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 53931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APAC_fuzzer-6072913738727424 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_decimate: add mixed option to process input only partially to be decimated

2022-12-19 Thread Paul B Mahol
On 11/9/22, m...@nodoa.me wrote: > The purpose of this new option is to enable processing of mixed content > such > as TV recordings or even movies which have some cuts in telecined 24fps and > others in 30p. > > Enabling it (mixed=1) will calculate a common timebase between decimated > and >

Re: [FFmpeg-devel] [PATCH] avfilter: add adrc filter

2022-12-19 Thread Paul B Mahol
On 12/10/22, Paul B Mahol wrote: > On 12/3/22, Paul B Mahol wrote: >> Patch attached. >> >> TODO: add documentation and examples with various transfer expressions >> (compressor, expander, limiter, gate, etc). >> > > Updated > Will push. ___

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread zhilizhao(赵志立)
> On Dec 19, 2022, at 21:40, Marvin Scholz wrote: > > > On 19 Dec 2022, at 14:37, Nicolas George wrote: > >> Marvin Scholz (12022-12-19): >>> IIUC this means the `-mask_url` option has to be the first option passed, >>> which seems a bit of an unfortunate requirement and is not documented at

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Nicolas George
Marvin Scholz (12022-12-19): > I agree, but then the docs should probably mention that to not give a false > sense of absolute security here. And maybe note that it might Indeed, documentation is necessary. > be a better option to pass the password via stdin or hide the process > from other

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Nicolas George
Gyan Doshi (12022-12-19): > Not the case. They are used for 'end', 'finish', retries ...etc Insufficient vigilance before accepting these changes. But not a reason to accept more. Regards, -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Marvin Scholz
On 19 Dec 2022, at 14:37, Nicolas George wrote: > Marvin Scholz (12022-12-19): >> IIUC this means the `-mask_url` option has to be the first option passed, >> which seems a bit of an unfortunate requirement and is not documented at >> all, as far as I can see. So at least this should be

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Gyan Doshi
On 2022-12-19 07:00 pm, Nicolas George wrote: Wujian(Chin) (12022-12-19): -return; +goto end; We only use goto for error processing. Not the case. They are used for 'end', 'finish', retries ...etc Regards, Gyan ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Nicolas George
Marvin Scholz (12022-12-19): > IIUC this means the `-mask_url` option has to be the first option passed, > which seems a bit of an unfortunate requirement and is not documented at > all, as far as I can see. So at least this should be clearly documented > to prevent users being confused why the

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Marvin Scholz
On 19 Dec 2022, at 14:15, Wujian(Chin) wrote: > I have modified the issues. Please review it again. Thank you. > > If the protocol address contains the user name and password, The ps -ef > command exposes plaintext. > The -mask_url parameter option is added to replace the protocol address in >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Nicolas George
Wujian(Chin) (12022-12-19): > I have modified the issues. Please review it again. Thank you. > > If the protocol address contains the user name and password, The ps -ef > command exposes plaintext. Spurious comma or capital. > The -mask_url parameter option is added to replace the protocol

[FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-19 Thread Wujian(Chin)
I have modified the issues. Please review it again. Thank you. If the protocol address contains the user name and password, The ps -ef command exposes plaintext. The -mask_url parameter option is added to replace the protocol address in the command line with the asterisk (*). Because other

[FFmpeg-devel] [PATCH v2] avcodec/mediacodecdec: add AV1 decoding support

2022-12-19 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- configure | 2 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/mediacodecdec.c | 16 +++- libavcodec/version.h | 4 ++-- 5 files changed, 21 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH v6] lavc: convert frame threading to the receive_frame() pattern

2022-12-19 Thread Timo Rothenpieler
On 14/12/2022 02:50, Timo Rothenpieler wrote: From: Anton Khirnov Reorganize the code such that the frame threading code does not call the decoders directly, but instead calls back into the generic decoding code. This avoids duplicating the logic that wraps the decoder invocation and will be

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add AV1 decoding support

2022-12-19 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/allcodecs.c | 1 + libavcodec/mediacodecdec.c | 16 +++- libavcodec/version.h | 4 ++-- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index

Re: [FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -safe to replace the user name and password in the protocol address

2022-12-19 Thread Gyan Doshi
On 2022-12-19 02:59 pm, Wujian(Chin) wrote: On Dec 19, 2022, at 14:50, Wujian(Chin) wrote: On Dec 17, 2022, at 15:36, Wujian(Chin) wrote: The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. The -safe parameter option is added to

[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -safe to replace the user name and password in the protocol address

2022-12-19 Thread Wujian(Chin)
>> On Dec 19, 2022, at 14:50, Wujian(Chin) wrote: >> >> On Dec 17, 2022, at 15:36, Wujian(Chin) wrote: The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. The -safe parameter option is added to replace the user

[FFmpeg-devel] [PATCH] avformat/mov: fix buffering issue on playing HTTP(s)/mp4.

2022-12-19 Thread Chen, Jinkai
Problem: Issue can be reproduced in ffplay on these sources: https://ali-sprite-video.yyouwang.com/video/works/202211/1667997073624_73.mp4 https://images.voghion.com/productImages/04_01_C_30011_2020220106GiuseppeFanara0012.mp4 Solution: Add a option, which is using separated IO context(HTTP