[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-22 Thread Wujian(Chin)
>Wujian(Chin) (12022-12-21): >> I have modified the issues again. Please review it again. Thank you. >> >> If the protocol address contains the user name and password, the ps >> -ef command exposes plaintext. The -mask_url parameter option is added >> to replace the protocol address in the

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec.c: flush pes buffer while rtsp seek

2022-12-22 Thread zhilizhao(赵志立)
> On Dec 22, 2022, at 11:32, tanwei (D) wrote: > > Fixes ticket #9949. > > > Signed-off-by: t00660896 > > --- > > libavformat/mpegts.c| 20 > > libavformat/mpegts.h| 1 + > > libavformat/rtpdec.c| 7 +++ > > libavformat/rtpdec.h|

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-22 Thread Mark Gaiser
On Thu, Dec 22, 2022 at 8:15 PM Gregor Riepl wrote: > > The result should be no need to provide "crypto://". The ffmpeg file > format > > detection should detect that ".crypto" should be handled by the crypto > > plugin. > > Instead of a custom descriptor file format that is only used for this >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mjpegbdec: Check for AVDISCARD_ALL

2022-12-22 Thread Michael Niedermayer
On Sun, Nov 13, 2022 at 12:44:00AM +0100, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 51825/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEGB_fuzzer-6393802688692224 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/lafdec: Check for EOF in header reading

2022-12-22 Thread Michael Niedermayer
On Sun, Nov 13, 2022 at 12:43:59AM +0100, Michael Niedermayer wrote: > Fixes: OOM testcase > Fixes: > 51527/clusterfuzz-testcase-minimized-ffmpeg_dem_LAF_fuzzer-5453663505612800 > > OOM can still happen after this as an arbitrary sized block is allocated and > read > this would require a

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Reduce overflows in essence_length computation

2022-12-22 Thread Michael Niedermayer
On Wed, Nov 16, 2022 at 12:49:10PM +0100, Tomas Härdin wrote: > sön 2022-11-13 klockan 00:44 +0100 skrev Michael Niedermayer: > > Fixes: signed integer overflow: -3741319169 - 9223372036823449370 > > cannot be represented in type 'long' > > Fixes:

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-22 Thread Marton Balint
On Mon, 19 Dec 2022, "zhilizhao(赵志立)" wrote: On Dec 19, 2022, at 21:40, Marvin Scholz wrote: On 19 Dec 2022, at 14:37, Nicolas George wrote: Marvin Scholz (12022-12-19): IIUC this means the `-mask_url` option has to be the first option passed, which seems a bit of an unfortunate

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Nicolas George
Camille Oudot (12022-12-22): > This patch introduces a "reuse" option over the RTP protocol. It simply > passes the value to the underlying UDP protocol's "reuse" option. > > Some RTP peers expect multiple streams to come from the same IP/port, e.g. > when RTP BUNDLE is involved (different

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-22 Thread Nicolas George
Wujian(Chin) (12022-12-21): > I have modified the issues again. Please review it again. Thank you. > > If the protocol address contains the user name and password, the ps -ef > command exposes plaintext. The -mask_url parameter option is added to > replace the protocol address in the command line

Re: [FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-22 Thread Nicolas George
Wujian(Chin) (12022-12-20): > I think that it's more concise to use code this way. Concision is not the goal here, maintainability is. Please do not use gotos. > I think that it would be better to replace the entire url, so that the code > implementation is simple. Then replace the whole

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-22 Thread Gregor Riepl
The result should be no need to provide "crypto://". The ffmpeg file format detection should detect that ".crypto" should be handled by the crypto plugin. Instead of a custom descriptor file format that is only used for this particular special case, you could also define a custom URI, such as:

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-22 Thread Hendrik Leppkes
On Thu, Dec 22, 2022 at 4:53 PM Mark Gaiser wrote: > > On Thu, Dec 22, 2022 at 11:40 AM Nicolas George wrote: > > > Mark Gaiser (12022-12-21): > > > While this works just fine, it's limited in use because the cryptography > > > details have to be passed on the command line. Applications that

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-22 Thread Mark Gaiser
On Thu, Dec 22, 2022 at 11:40 AM Nicolas George wrote: > Mark Gaiser (12022-12-21): > > While this works just fine, it's limited in use because the cryptography > > details have to be passed on the command line. Applications that might > well > > support much of ffmpeg functionality can't easily

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Camille Oudot
Re-submitting because google webmail did not set the correct mime type, sorry for the noise. -- Camille From 998e1d3d79b416422e2b1d4f9a5ffb92062db256 Mon Sep 17 00:00:00 2001 From: Camille Oudot Date: Fri, 16 Dec 2022 15:30:02 +0100 Subject: [PATCH] avformat/rtpproto: add support for RTP/UDP

[FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-22 Thread Camille Oudot
From 998e1d3d79b416422e2b1d4f9a5ffb92062db256 Mon Sep 17 00:00:00 2001 From: Camille Oudot Date: Fri, 16 Dec 2022 15:30:02 +0100 Subject: [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse This patch introduces a "reuse" option over the RTP protocol. It simply passes the value to

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: fix buffering issue for special HTTP(s) mp4.

2022-12-22 Thread Zhao Zhili
On Tue, 2022-12-20 at 09:20 +, Chen, Jinkai wrote: > Problem: > Using ffplay play on these sources: > https://ali-sprite-video.yyouwang.com/video/works/202211/1667997073624_73.mp4 > https://images.voghion.com/productImages/04_01_C_30011_2020220106GiuseppeFanara0012.mp4 > > Solution: > Add a

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-22 Thread Nicolas George
Mark Gaiser (12022-12-21): > While this works just fine, it's limited in use because the cryptography > details have to be passed on the command line. Applications that might well > support much of ffmpeg functionality can't easily hook into the crypto > functionality. Take KODI for example, it