Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition

2022-12-23 Thread Marton Balint
On Fri, 23 Dec 2022, Michael Niedermayer wrote: Suggested-by: Tomas Härdin Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) this_partition should be == pack_ofs - run_in, not pack_ofs

[FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition

2022-12-23 Thread Michael Niedermayer
Suggested-by: Tomas Härdin Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e6118e141d..cbacd03d1e 100644 ---

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Reduce overflows in essence_length computation

2022-12-23 Thread Michael Niedermayer
On Fri, Dec 23, 2022 at 12:47:02PM +0100, Tomas Härdin wrote: > fre 2022-12-23 klockan 00:25 +0100 skrev Michael Niedermayer: > > On Wed, Nov 16, 2022 at 12:49:10PM +0100, Tomas Härdin wrote: > > > sön 2022-11-13 klockan 00:44 +0100 skrev Michael Niedermayer: > > > > Fixes: signed integer

Re: [FFmpeg-devel] [PATCH] ffmpeg-3.4.12 does not build (i686-w64-mingw32)

2022-12-23 Thread Michael Niedermayer
On Fri, Dec 23, 2022 at 04:04:31PM +0100, Carlo Bramini wrote: > Hello, > > I tried to build ffmpeg-3.4.12, which is the last one supporting Windows XP, > but it fails to compile the resource file for Windows. > Running verbose build, it prints this output on the console: > > > $ make V=1 > >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mjpegbdec: Check for AVDISCARD_ALL

2022-12-23 Thread James Almer
On 11/12/2022 8:44 PM, Michael Niedermayer wrote: Fixes: Assertion failure Fixes: 51825/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEGB_fuzzer-6393802688692224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] AC3 decoding throws error number -16976906 ... vlc plays well

2022-12-23 Thread James Almer
On 12/23/2022 3:29 PM, Mahesh Velankar wrote: I have got a mpeg ts file with following composition (shown by ffprobe) Open a ticket in https://trac.ffmpeg.org/ with the sample to reproduce this problem. Alternatively, write to the ffmpeg-user mailing list, as this one is for development.

[FFmpeg-devel] AC3 decoding throws error number -16976906 ... vlc plays well

2022-12-23 Thread Mahesh Velankar
I have got a mpeg ts file with following composition (shown by ffprobe) ffprobe version N-109444-geef763c705 Copyright (c) 2007-2022 the FFmpeg developers built with gcc 7 (Ubuntu 7.5.0-3ubuntu1~18.04) configuration: --enable-openssl libavutil 57. 43.100 / 57. 43.100 libavcodec

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Gregor Riepl
I can't find a single thing about this in the ffmpeg documentation. How is this called, where can I read more about it and - most importantly - does it work out of the box? No, it does not. This was a suggestion that sounds like a better option than a custom metadata descriptor file that is

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Nicolas George
Mark Gaiser (12022-12-23): > They actually point to N files. Could also be just 1. Wow, what an interesing and crucial distinction for the discussion. Goodbye. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Mark Gaiser
On Fri, Dec 23, 2022 at 5:34 PM Nicolas George wrote: > Mark Gaiser (12022-12-23): > > Then M3U as a format is business logic too. > > HLS and MPD are business logic too. > > At least, based on your comment, they would fall into that same category. > > > > The difference between those formats

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Nicolas George
Mark Gaiser (12022-12-23): > Then M3U as a format is business logic too. > HLS and MPD are business logic too. > At least, based on your comment, they would fall into that same category. > > The difference between those formats and my suggestion? First difference: they point to several files,

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Mark Gaiser
On Fri, Dec 23, 2022 at 12:05 PM Tomas Härdin wrote: > ons 2022-12-21 klockan 16:44 +0100 skrev Mark Gaiser: > > Hi, > > > > The ffmpeg crypto protocol handler [1] allows one to play encrypted > > media. > > > > The great thing here is that it allows playback of any media format > > that > >

[FFmpeg-devel] [PATCH] ffmpeg-3.4.12 does not build (i686-w64-mingw32)

2022-12-23 Thread Carlo Bramini
Hello, I tried to build ffmpeg-3.4.12, which is the last one supporting Windows XP, but it fails to compile the resource file for Windows. Running verbose build, it prints this output on the console: > $ make V=1 > i686-w64-mingw32-windres -I. -Isrc/ --preprocessor "i686-w64-mingw32-gcc -E >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for fragmented TTML muxing

2022-12-23 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > Attempts to base the fragmentation timing on other streams > as most receivers expect media fragments to be more or less > aligned. > > Currently does not support fragmentation on subtitle track > only, as the subtitle packet queue timings would have to be >

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for fragmented TTML muxing

2022-12-23 Thread Jan Ekström
From: Jan Ekström Attempts to base the fragmentation timing on other streams as most receivers expect media fragments to be more or less aligned. Currently does not support fragmentation on subtitle track only, as the subtitle packet queue timings would have to be checked in addition to the

[FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: add functionality to prepend to AVPacketLists

2022-12-23 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/avpacket.c| 20 +++- libavcodec/packet_internal.h | 2 ++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 5fef65e97a..01eb9896d5 100644 ---

[FFmpeg-devel] [PATCH 0/2] Initial support for fragmented TTML muxing

2022-12-23 Thread Jan Ekström
This enables pushing TTML together with another track (usually video) as part of CMAF Ingest, as defined by the DASH-IF Live Media Ingest Protocol. Currently does not function well with just the subtitle track unless the API user explicitly requests fragmentation with a nullptr packet, as the

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Reduce overflows in essence_length computation

2022-12-23 Thread Tomas Härdin
fre 2022-12-23 klockan 00:25 +0100 skrev Michael Niedermayer: > On Wed, Nov 16, 2022 at 12:49:10PM +0100, Tomas Härdin wrote: > > sön 2022-11-13 klockan 00:44 +0100 skrev Michael Niedermayer: > > > Fixes: signed integer overflow: -3741319169 - 9223372036823449370 > > > cannot be represented in

Re: [FFmpeg-devel] 答复: 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-23 Thread Nicolas George
Wujian(Chin) (12022-12-23): > If you think my idea is wrong, please give your specific advice, I already have. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-23 Thread Tomas Härdin
ons 2022-12-21 klockan 16:44 +0100 skrev Mark Gaiser: > Hi, > > The ffmpeg crypto protocol handler [1] allows one to play encrypted > media. > > The great thing here is that it allows playback of any media format > that > ffmpeg supports! > Have a container format like mkv as an encrypted blob,

[FFmpeg-devel] 答复: 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-23 Thread Wujian(Chin)
Other issues have been modified. The following three issues have not been modified. I have explained them: >> @@ -215,13 +249,13 @@ static void prepare_app_arguments(int *argc_ptr, char >> ***argv_ptr) >> if (win32_argv_utf8) { >> *argc_ptr = win32_argc; >> *argv_ptr =

Re: [FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-23 Thread Nicolas George
Wujian(Chin) (12022-12-23): > I've modified most of the issues, and I've explained some of the issues that > don't. > If you don't accept my explanation, do you have any other better suggestions > and methods? I have already made a more detailed comment in the first thread. -- Nicolas