Re: [FFmpeg-devel] [PATCH] avcodec/sunrast: Fix maplength check

2022-12-24 Thread Michael Niedermayer
On Thu, Dec 22, 2022 at 12:05:20AM +0100, Michael Niedermayer wrote: > Fixes: out of bounds read > > Found-by: Ibrahim Mohamed > Reviewed-by; Ibrahim Mohamed > Signed-off-by: Michael Niedermayer > --- > libavcodec/sunrast.c | 19 +-- > 1 file changed, 17 insertions(+), 2

[FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-24 Thread Michael Niedermayer
Fixes: OOM Fixes: 50551/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6607795234930688 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH v2] avformat/mxfdec: Remove this_partition

2022-12-24 Thread Michael Niedermayer
Suggested-by: Tomas Härdin Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e6118e141d..0553728253 100644 --- a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition

2022-12-24 Thread Michael Niedermayer
On Fri, Dec 23, 2022 at 11:01:55PM +0100, Marton Balint wrote: > > > On Fri, 23 Dec 2022, Michael Niedermayer wrote: > > > Suggested-by: Tomas Härdin > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c | 37 +++-- > > 1 file changed, 23

[FFmpeg-devel] [AMD-AMF] What does these code in amfenc.c actually mean?

2022-12-24 Thread Schwarzer
I'm using h264_amf in my project, and want to use D3D11 pixel format to encode video in D3D11Texture2D to elinimate copy between GPU and CPU. I found the performance is very poor, comparing to obs-project which also use AMF as an encoder. After comparing and debugging through codes, I found

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-24 Thread Camille Oudot
Hello, On Sat, 2022-12-24 at 13:36 +0200, Rémi Denis-Courmont wrote: > I don't see why you need an option for this. In parsing the SDP, it > should be self-evident if a given socket needs to be reused for RTCP- > mux or for SDP BUNDLE. I indeed disregarded the "receiving RTP streams" part, my

Re: [FFmpeg-devel] [PATCH] ffmpeg-3.4.12 does not build (i686-w64-mingw32)

2022-12-24 Thread Carlo Bramini
Hello, yes, that commit seems to be the one that include the needed fix. Is it possible to import that change also into the next release of 3.4.x branch? Or do I need to open a new bug report? Sincerely, Carlo Bramini. > Il 23/12/2022 21:21 Michael Niedermayer ha scritto: > > > On Fri,

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-24 Thread Rémi Denis-Courmont
Hello, Le jeudi 22 décembre 2022, 17:42:09 EET Camille Oudot a écrit : > Re-submitting because google webmail did not set the correct mime type, > sorry for the noise. I don't see why you need an option for this. In parsing the SDP, it should be self-evident if a given socket needs to

Re: [FFmpeg-devel] 答复: 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-24 Thread Nicolas George
Wujian(Chin) (12022-12-24): > This code simplicity does not affect the readability and > maintainability of the program You are not the one who maintain them, that is not your judgement. > The mask effect is like this:ffmpeg -mask_url -i rtsp://tyyy.com --> ffmpeg > -mask_url -i

[FFmpeg-devel] 答复: 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-24 Thread Wujian(Chin)
Nicolas George(2022年12月23日 3:27): >Wujian(Chin) (12022-12-20): >> I think that it's more concise to use code this way. >Concision is not the goal here, maintainability is. Please do not use gotos. I found that goto can be used in three cases: 1. Jump directly from multiple cycles; 2. Clear