[FFmpeg-devel] [PATCH v2] vaapi: support VAProfileH264High10

2022-12-26 Thread Jianfeng Zheng
see https://github.com/intel/libva/pull/664 Signed-off-by: jianfeng.zheng --- configure | 13 + libavcodec/h264_slice.c| 6 ++ libavcodec/vaapi_decode.c | 10 ++ libavcodec/vaapi_encode_h264.c | 24 ++--

Re: [FFmpeg-devel] [PATCH] vaapi: support VAProfileH264High10

2022-12-26 Thread Jianfeng Zheng
Hi Andreas Rheinhardt, You are right, should be "#if HAVE_VA_PROFILE_H264_HIGH10" ranther than "#ifdef HAVE_VA_PROFILE_H264_HIGH10". Andreas Rheinhardt 于2022年12月26日周一 23:05写道: > > Jean Jogh: > > see https://github.com/intel/libva/pull/664 > > > > Signed-off-by: jianfeng.zheng > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-26 Thread zhilizhao(赵志立)
> On Dec 27, 2022, at 05:47, Nicolas George wrote: > > "zhilizhao(赵志立)" (12022-12-26): >> Just use the same socket file descriptor. Don’t use OS dependent hack to >> implement a feature. > > SO_REUSEADDR is absolutely not a hack. I agree that it is not the > correct way of implementing the

Re: [FFmpeg-devel] [PATCH] avcodec/dts2pts_bsf: Avoid poc overflows in cmp_find()

2022-12-26 Thread Michael Niedermayer
On Mon, Dec 26, 2022 at 03:48:41PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: signed integer overflow: -2147483648 - 5 cannot be represented in > > type 'int' > > Fixes: > > 54242/clusterfuzz-testcase-minimized-ffmpeg_BSF_DTS2PTS_fuzzer-472928339243827 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-26 Thread Martijn van Beurden
Op ma 26 dec. 2022 21:14 schreef Paul B Mahol : > Pushed. > > Next time do not put tabs in non Makefile parts in patch or I will > reject pushing it. > Thanks. Sorry about the tabs, I forgot to check, I will try to be more careful next time. > ___

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-26 Thread Michael Niedermayer
On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: > lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: > > > > index_table->nb_ptses += s->index_duration; > > +    // If index_duration is substantially larger than > > nb_index_entries then this algorithm which

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hdrdec: Check for end of input in decompress()

2022-12-26 Thread Michael Niedermayer
On Mon, Dec 26, 2022 at 03:08:38PM +0100, Paul B Mahol wrote: > On 12/25/22, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 54386/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HDR_fuzzer-5053598268784640 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse

2022-12-26 Thread Nicolas George
"zhilizhao(赵志立)" (12022-12-26): > Just use the same socket file descriptor. Don’t use OS dependent hack to > implement a feature. SO_REUSEADDR is absolutely not a hack. I agree that it is not the correct way of implementing the feature evoked in this thread, but I insist it is not a hack. --

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Use 64bit in remainder

2022-12-26 Thread Michael Niedermayer
On Mon, Dec 26, 2022 at 11:36:28AM +0100, Tomas Härdin wrote: > sön 2022-12-25 klockan 23:03 +0100 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 48000 * 223587 cannot be represented > > in type 'int' > > Fixes: 54513/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer- > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Use 64bit in remainder

2022-12-26 Thread Michael Niedermayer
On Mon, Dec 26, 2022 at 11:11:46AM -0300, James Almer wrote: > On 12/25/2022 7:03 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 48000 * 223587 cannot be represented in > > type 'int' > > Fixes: > > 54513/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5817594836025344 >

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

2022-12-26 Thread Mark Reid
On Mon, Dec 12, 2022 at 6:42 PM wrote: > From: Mark Reid > > --- > libavcodec/x86/bswapdsp.asm | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm > index 31c6c48a21..2aa235e13c 100644 > --- a/libavcodec/x86/bswapdsp.asm > +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/avfilter: add avfilter_print_config_formats()

2022-12-26 Thread Paul B Mahol
On 12/13/22, Soft Works wrote: > Another Ping Please confirm that this still applies without issues, otherwise provide new patches for this feature so i can apply it. > > Thanks, > softworkz > >> -Original Message- >> From: Paul B Mahol >> Sent: Thursday, November 3, 2022 10:58 AM >>

[FFmpeg-devel] [PATCH v1] fate/jpeg2000: add JPEG 2000 tests using ITU/ISO conformance materials

2022-12-26 Thread pal
From: Pierre-Anthony Lemieux Adds JPEG 2000 decoder tests using materials from the conformance suite specified in Rec. ITU-T T.803 | ISO/IEC 15444-4. The jpeg2000dec-ds0_ht_01_b11 test assumes that patchset https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=8078 has been applied. The

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-26 Thread Paul B Mahol
On 12/19/22, Paul B Mahol wrote: > On 12/11/22, Martijn van Beurden wrote: >> Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : >>> >>> On 11/25/22, Paul B Mahol wrote: >>> > On 10/11/22, Martijn van Beurden wrote: >>> >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) >>>

Re: [FFmpeg-devel] [PATCH] vaapi: support VAProfileH264High10

2022-12-26 Thread Andreas Rheinhardt
Jean Jogh: > see https://github.com/intel/libva/pull/664 > > Signed-off-by: jianfeng.zheng > --- > configure | 13 + > libavcodec/h264_slice.c| 6 ++ > libavcodec/vaapi_decode.c | 10 ++ > libavcodec/vaapi_encode_h264.c | 24

Re: [FFmpeg-devel] [PATCH] avcodec/dts2pts_bsf: Avoid poc overflows in cmp_find()

2022-12-26 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: signed integer overflow: -2147483648 - 5 cannot be represented in type > 'int' > Fixes: > 54242/clusterfuzz-testcase-minimized-ffmpeg_BSF_DTS2PTS_fuzzer-472928339243827 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Use 64bit in remainder

2022-12-26 Thread James Almer
On 12/25/2022 7:03 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 48000 * 223587 cannot be represented in type 'int' Fixes: 54513/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5817594836025344 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hdrdec: Check for end of input in decompress()

2022-12-26 Thread Paul B Mahol
On 12/25/22, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 54386/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HDR_fuzzer-5053598268784640 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-26 Thread Nicolas George
Wujian(Chin) (12022-12-26): > The issue has been modified. Please review again, thank you! > > Signed-off-by: wujian_nanjing > --- > doc/fftools-common-opts.texi | 11 +++ > fftools/cmdutils.c | 77 > ++-- > fftools/cmdutils.h |

[FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-26 Thread Wujian(Chin)
The issue has been modified. Please review again, thank you! Signed-off-by: wujian_nanjing --- doc/fftools-common-opts.texi | 11 +++ fftools/cmdutils.c | 77 ++-- fftools/cmdutils.h | 25 ++ fftools/ffmpeg.c

[FFmpeg-devel] [PATCH] avcodec/mjpegbdec: return the amount of bytes consumed when discarding frames

2022-12-26 Thread James Almer
EAGAIN is not correct in this scenario. FFCodec.cb.decode() callback decoders always return the amount of bytes consumed from the input packet (if any), and report if a frame was generated by setting got_frame. Signed-off-by: James Almer --- libavcodec/mjpegbdec.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-26 Thread Nicolas George
Tomas Härdin (12022-12-26): > Right. And trying to smuggle in command line options via a file feels > made for exploitation.. This is why my proposal years ago was rejected by Reimar. And this is why concat requires -safe to accept options. To be fair, limiting the case to cryptographic keys

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-26 Thread Tomas Härdin
mån 2022-12-26 klockan 12:00 +0100 skrev Nicolas George: > Tomas Härdin (12022-12-26): > > That we want to avoid having keys in the command line is not > > unreasonable. A -keyfile argument for crypto: might be appropriate. > > You are confusing two threads, the issue of credentials visible in >

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-26 Thread Nicolas George
Tomas Härdin (12022-12-26): > That we want to avoid having keys in the command line is not > unreasonable. A -keyfile argument for crypto: might be appropriate. You are confusing two threads, the issue of credentials visible in the command line is for another proposal. This here is about giving

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-26 Thread Tomas Härdin
fre 2022-12-23 klockan 17:31 +0100 skrev Mark Gaiser: > On Fri, Dec 23, 2022 at 12:05 PM Tomas Härdin wrote: > > > ons 2022-12-21 klockan 16:44 +0100 skrev Mark Gaiser: > > > Hi, > > > > > > The ffmpeg crypto protocol handler [1] allows one to play > > > encrypted > > > media. > > > > > > The

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Use 64bit in remainder

2022-12-26 Thread Tomas Härdin
sön 2022-12-25 klockan 23:03 +0100 skrev Michael Niedermayer: > Fixes: signed integer overflow: 48000 * 223587 cannot be represented > in type 'int' > Fixes: 54513/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer- > 5817594836025344 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2022-12-26 Thread Tomas Härdin
lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: > > index_table->nb_ptses += s->index_duration; > +    // If index_duration is substantially larger than > nb_index_entries then this algorithm which > +    // allocates index_duration elements is a bad idea. All >

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfdec: Remove this_partition

2022-12-26 Thread Tomas Härdin
lör 2022-12-24 klockan 20:36 +0100 skrev Michael Niedermayer: > @@ -725,10 +724,14 @@ static int mxf_read_partition_pack(void *arg, > AVIOContext *pb, int tag, int size > UID op; > uint64_t footer_partition; > uint32_t nb_essence_containers; > +    uint64_t this_partition; >   >