Re: [FFmpeg-devel] [PATCH] avfilter: use ff_inlink_make_frame_writable()

2023-02-08 Thread Paul B Mahol
New patch attached. From 86203516a4d38f312ea5319315aa79841a39a45b Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 6 Feb 2023 14:57:50 +0100 Subject: [PATCH] avfilter: use ff_inlink_make_frame_writable() Signed-off-by: Paul B Mahol --- libavfilter/avf_abitscope.c | 11 --

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category

2023-02-08 Thread Marth64
Thank you On Wed, Feb 8, 2023 at 9:13 PM Anton Khirnov wrote: > Quoting Marth64 (2023-02-06 19:12:15) > > Since at least 4.4.3, -ab/-b:a help text was in the video section > > of ffmpeg -h, but these are audio options. > > > > Signed-off-by: Marth64 > > --- > > fftools/ffmpeg_opt.c | 4 ++-- >

[FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-08 Thread Marth64
Signed-off-by: Marth64 --- Adds detection of spatial/object-based audio extensions in E-AC-3, TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. Please let me know what I could improve, I'm learning still. Thank you. doc/ffprobe.xsd| 1 + fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category

2023-02-08 Thread Anton Khirnov
Quoting Marth64 (2023-02-06 19:12:15) > Since at least 4.4.3, -ab/-b:a help text was in the video section > of ffmpeg -h, but these are audio options. > > Signed-off-by: Marth64 > --- > fftools/ffmpeg_opt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] ffprobe: report the corrupt flag on packets

2023-02-08 Thread Anton Khirnov
will push tomorrow -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Philip Langdale
On Wed, 08 Feb 2023 19:38:07 +0200 Rémi Denis-Courmont wrote: > Le keskiviikkona 8. helmikuuta 2023, 16.27.52 EET Devin Heitmueller a > écrit : > > On Wed, Feb 8, 2023 at 8:08 AM Jean-Baptiste Kempf > > wrote: > > > Do we really need those PIX_FMT in FFmpeg public API? > > > > Tiled

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description

2023-02-08 Thread Michael Niedermayer
On Mon, Feb 06, 2023 at 02:25:23AM +0100, Stefano Sabatini wrote: > On date Wednesday 2023-01-25 10:47:20 +0530, Gyan Doshi wrote: > > > > > > On 2023-01-25 06:37 am, Stefano Sabatini wrote: > > > --- > > > doc/ffmpeg.texi | 17 +++-- > > > 1 file changed, 15 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avfilter: use ff_inlink_make_frame_writable()

2023-02-08 Thread Michael Niedermayer
On Tue, Feb 07, 2023 at 06:26:17PM +0100, Paul B Mahol wrote: > On 2/6/23, Paul B Mahol wrote: > > Patch attached. > > > > Better patch attached. > avf_abitscope.c | 11 +-- > avf_ahistogram.c |9 +++-- > avf_aphasemeter.c |9 +++-- > avf_avectorscope.c

Re: [FFmpeg-devel] [PATCH] swresample: try to fix regression

2023-02-08 Thread Martin Storsjö
On Wed, 8 Feb 2023, Paul B Mahol wrote: This one should pass FATE. diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index 80c194b066..067f646805 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter/af_pan.c @@ -313,9 +313,7 @@ static int config_props(AVFilterLink *link)

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Devin Heitmueller
Hi Remi, On Wed, Feb 8, 2023 at 12:38 PM Rémi Denis-Courmont wrote: > Uh, not to deny that, but tiled formats are in no way an embedded thing, as > you imply. They are also used by desktop GPUs. And that is not really > relevant, I would argue, to the discussion, either way. I don't disagree

[FFmpeg-devel] [PATCH] swresample: try to fix regression

2023-02-08 Thread Paul B Mahol
This one should pass FATE. From ca54f241756e764f70c919acd0c99c811762dcb1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 8 Feb 2023 18:35:38 +0100 Subject: [PATCH] swresample: do not attempt to rematrix if channel map is provided Signed-off-by: Paul B Mahol --- libavfilter/af_pan.c

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Rémi Denis-Courmont
Le keskiviikkona 8. helmikuuta 2023, 16.27.52 EET Devin Heitmueller a écrit : > On Wed, Feb 8, 2023 at 8:08 AM Jean-Baptiste Kempf wrote: > > Do we really need those PIX_FMT in FFmpeg public API? > > Tiled formats are annoying, but not uncommon in popular embedded > platforms (e.g. NXP iMX, TI

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-08 Thread Anton Khirnov
Quoting Devin Heitmueller (2023-02-08 16:59:43) > On Wed, Feb 8, 2023 at 8:54 AM Anton Khirnov wrote: > > Muxers are fundamentally consume-only, I don't see what stats could > > possibly be printed after muxing, even conceptually. > > I can offer some examples, in particular because I generate

Re: [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()

2023-02-08 Thread Gyan Doshi
On 2023-02-08 08:47 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-07 15:58:47) Needed to transfer programs in parent muxing contexts to child muxers, like in hls, segment, tee muxers. If it's only intended for use in muxers, why is it public? Could have worded the msg better. The

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-08 Thread Devin Heitmueller
On Wed, Feb 8, 2023 at 8:54 AM Anton Khirnov wrote: > Muxers are fundamentally consume-only, I don't see what stats could > possibly be printed after muxing, even conceptually. I can offer some examples, in particular because I generate lots of such statistics after muxing in my private tree. -

[FFmpeg-devel] [PATCH 2/2] doc: Merge doc/dev_community/* and Code of Conduct into a seperate file

2023-02-08 Thread Thilo Borgmann
Remove doc/dev_communit markup files completely as they are at the wrong place. Create a new community page, merging all of doc/dev_community and subsection Code of Conduct into a common place. The corresponding patch to ffmpeg-web puts the Organisation & Code of Conduct into a seperate

[FFmpeg-devel] [PATCH 1/2] doc/dev_community: add the addresses of the committees

2023-02-08 Thread Thilo Borgmann
From: Nicolas George Omitting the .org from the address should be protection enough against spam spiders. Signed-off-by: Nicolas George --- doc/dev_community/community.md | 4 1 file changed, 4 insertions(+) diff --git a/doc/dev_community/community.md b/doc/dev_community/community.md

Re: [FFmpeg-devel] [PATCH 1/2] doc/dev_community: add the addresses of the committees

2023-02-08 Thread Thilo Borgmann
Pls ignnore this as well... I'll send the actual patch now patching two repos is confusing, sorry for spam. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] doc: Merge doc/dev_community/* and Code of Conduct into a seperate file

2023-02-08 Thread Thilo Borgmann
Am 08.02.23 um 16:45 schrieb Thilo Borgmann: Remove doc/dev_communit markup files completely as they are at the wrong place. Create a new community page, merging all of doc/dev_community and subsection Code of Conduct into a common place. The corresponding patch to ffmpeg-web puts the

[FFmpeg-devel] [PATCH 2/2] doc: Merge doc/dev_community/* and Code of Conduct into a seperate file

2023-02-08 Thread Thilo Borgmann
Remove doc/dev_communit markup files completely as they are at the wrong place. Create a new community page, merging all of doc/dev_community and subsection Code of Conduct into a common place. The corresponding patch to ffmpeg-web puts the Organisation & Code of Conduct into a seperate

[FFmpeg-devel] [PATCH 1/2] doc/dev_community: add the addresses of the committees

2023-02-08 Thread Thilo Borgmann
From: Nicolas George Omitting the .org from the address should be protection enough against spam spiders. Signed-off-by: Nicolas George --- doc/dev_community/community.md | 4 1 file changed, 4 insertions(+) diff --git a/doc/dev_community/community.md b/doc/dev_community/community.md

Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

2023-02-08 Thread Anton Khirnov
Since Nicolas did not follow up, shall we go ahead and push this? Something so simple really should not be stuck in place for a year. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] src/template_head2: Make "community" a seperate page containing Organisation and Code of Conduct.

2023-02-08 Thread Thilo Borgmann
Forgot to put this in the subject, this patch is for ffmpeg-web, of course. -Thilo Am 08.02.23 um 16:47 schrieb Thilo Borgmann: --- src/template_head2 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/template_head2 b/src/template_head2 index a0b11ab..7ba634b 100644

[FFmpeg-devel] [PATCH] src/template_head2: Make "community" a seperate page containing Organisation and Code of Conduct.

2023-02-08 Thread Thilo Borgmann
--- src/template_head2 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/template_head2 b/src/template_head2 index a0b11ab..7ba634b 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -21,8 +21,9 @@ News Download Documentation -

[FFmpeg-devel] [PATCH] doc: Merge doc/dev_community/* and Code of Conduct into a seperate file

2023-02-08 Thread Thilo Borgmann
Remove doc/dev_communit markup files completely as they are at the wrong place. Create a new community page, merging all of doc/dev_community and subsection Code of Conduct into a common place. The corresponding patch to ffmpeg-web puts the Organisation & Code of Conduct into a seperate

Re: [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()

2023-02-08 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-07 15:58:47) > Needed to transfer programs in parent muxing contexts to child muxers, > like in hls, segment, tee muxers. If it's only intended for use in muxers, why is it public? -- Anton Khirnov ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 1/1] avformat/assenc: avoid incorrect copy of null terminator

2023-02-08 Thread Tim Angus
On 27/01/2023 17:20, Tim Angus wrote: When writing a subtitle SSA/ASS subtitle file, the AVCodecParameters::extradata buffer is written directly to the output. In the case where the buffer is filled from a matroska source file produced by some older versions of Handbrake, this buffer ends with a

Re: [FFmpeg-devel] [PATCH] sws/utils.c: Do not uselessly call initFilter() when unscaling

2023-02-08 Thread Tomas Härdin
fre 2023-02-03 klockan 10:51 +0100 skrev Tomas Härdin: > ons 2023-02-01 klockan 13:25 +0100 skrev Michael Niedermayer: > > On Tue, Jan 31, 2023 at 04:54:46PM +0100, Tomas Härdin wrote: > > > Passes FATE > > > > > > /Tomas > > > > >  utils.c |   62

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Devin Heitmueller
On Wed, Feb 8, 2023 at 8:08 AM Jean-Baptiste Kempf wrote: > Do we really need those PIX_FMT in FFmpeg public API? Tiled formats are annoying, but not uncommon in popular embedded platforms (e.g. NXP iMX, TI Davinci). Of course ffmpeg could choose to ignore them, but it would effectively prevent

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate

2023-02-08 Thread Leo Izen
On 2/7/23 14:17, Leo Izen wrote: On 2/2/23 10:09, Leo Izen wrote: We parse the fallback cHRM on decode and correctly determine that we have BT.709 primaries, but unknown TRC. This causes us to write cICP where we shouldn't. Primaries without transfer can be handled entirely by cHRM, so we

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-08 Thread Anton Khirnov
Quoting Tim Harris (2023-02-07 18:19:48) > > > Am 07.02.23 um 10:41 schrieb Anton Khirnov: > > > Also, I'm wondering if we shouldn't rename the options to > > > -stats_{mux,enc_pre,enc_post}[_fmt] for consistency. > > > They were added just recently, so it should be fine if done before the > > >

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Hendrik Leppkes
On Wed, Feb 8, 2023 at 2:08 PM Jean-Baptiste Kempf wrote: > > On Wed, 8 Feb 2023, at 10:47, Le Bao Tin Ha wrote: > > Hello, you can found the explanation here: > > > > https://docs.kernel.org/userspace-api/media/v4l/pixfmt-yuv-planar.html > > > > "V4L2_PIX_FMT_NV12M_8L128 is similar to

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Jean-Baptiste Kempf
On Wed, 8 Feb 2023, at 10:47, Le Bao Tin Ha wrote: > Hello, you can found the explanation here: > > https://docs.kernel.org/userspace-api/media/v4l/pixfmt-yuv-planar.html > > "V4L2_PIX_FMT_NV12M_8L128 is similar to V4L2_PIX_FMT_NV12M but stores > pixels in 2D 8x128 tiles, and stores tiles

[FFmpeg-devel] [PATCH] avcodec/vp9:add skip-loop-filter flag

2023-02-08 Thread xufuji456
--- libavcodec/vp9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7c0a246446..ebb89a413c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1371,7 +1371,7 @@ static int decode_tiles(AVCodecContext *avctx, }

Re: [FFmpeg-devel] Request for assistance with adding new pixel format (NV12_8L128) in FFmpeg

2023-02-08 Thread Le Bao Tin Ha
Hello, you can found the explanation here: https://docs.kernel.org/userspace-api/media/v4l/pixfmt-yuv-planar.html "V4L2_PIX_FMT_NV12M_8L128 is similar to V4L2_PIX_FMT_NV12M but stores pixels in 2D 8x128 tiles, and stores tiles linearly in memory. The image height must be aligned to a multiple

Re: [FFmpeg-devel] [PATCH] avfilter: use ff_inlink_make_frame_writable()

2023-02-08 Thread Nicolas George
Paul B Mahol (12023-02-07): > On 2/6/23, Paul B Mahol wrote: > > Patch attached. > > > > Better patch attached. > From 15f004ccb196e39c6c429e2c93041444c1a1e419 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Mon, 6 Feb 2023 14:57:50 +0100 > Subject: [PATCH] avfilter: use

[FFmpeg-devel] [PATCH] libavfilter/qsvvpp: check the return value

2023-02-08 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- libavfilter/qsvvpp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index e181e7b584..54e7284234 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -441,7 +441,10