[FFmpeg-devel] [PATCH] Use '-' instead of '/' for rc.exe options (take 2)

2023-02-09 Thread Ziemowit Laski
Second version of my patch. Please let me know if I forgot something. --Zem === When building FFMPEG in the MSYS environment under Windows, one must not use forward slashes ('/') for command-line options. It appears that

Re: [FFmpeg-devel] [PATCH] mswindres: Use '-' instead of '/' for rc.exe options

2023-02-09 Thread Ziemowit Laski
> paths; it's msys2 which does the whole unix-style paths and which > automatically tries to rewrite command line arguments as if they were > paths, with some level of heuristics. Yes, this makes sense. The build uses /bin/bash, which is configured as x86_64-pc-msys, and that's where the

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Marth64
Ack'd. Nice catch. Thank you! On Thu, Feb 9, 2023 at 4:35 PM Michael Niedermayer wrote: > On Wed, Feb 08, 2023 at 10:41:00PM -0600, Marth64 wrote: > > Signed-off-by: Marth64 > > --- > > Adds detection of spatial/object-based audio extensions in E-AC-3, > > TrueHD, and DCA XLL (DTS). This

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Marth64
Hi, Thank you for your time and thoughts. Some of this I had wondered about the same. Re: Hendrik, Using profile > This was an original intention of mine but I changed course. I'm happy to do it, but felt too unsure for a first pass. My reasoning being that I'm not sure if the presence of

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Michael Niedermayer
On Wed, Feb 08, 2023 at 10:41:00PM -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > Adds detection of spatial/object-based audio extensions in E-AC-3, > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. > Please let me know what I could improve, I'm learning still. >

Re: [FFmpeg-devel] [PATCH] mswindres: Use '-' instead of '/' for rc.exe options

2023-02-09 Thread Martin Storsjö
On Thu, 9 Feb 2023, Ziemowit Laski wrote: These changes seem fine, but you're apparently not touching the case at the top, used for --version, where it is calling 'rc.exe /?'. For me, this That's an interesting point. I guess MinGW is "smart enough" not to rewrite "/?" because it doesn't

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Michael Niedermayer
On Thu, Feb 09, 2023 at 04:58:46PM +0100, Timo Rothenpieler wrote: > On 09.02.2023 15:22, aline.gondimsan...@savoirfairelinux.com wrote: > > From: Aline Gondim Santos > > > > A dxgi grab device may be either a display or a window. > > Differently from the existing gdigrab, this new device does >

Re: [FFmpeg-devel] [PATCH] mswindres: Use '-' instead of '/' for rc.exe options

2023-02-09 Thread Hendrik Leppkes
On Thu, Feb 9, 2023 at 10:02 PM Ziemowit Laski wrote: > > > FWIW, this setup is definitely being used by lots of others already - so > > whenever there's such an issue, the main question to ask is why others > > haven't run into the issue before. But improvements are definitely > > welcome! > >

Re: [FFmpeg-devel] [PATCH] mswindres: Use '-' instead of '/' for rc.exe options

2023-02-09 Thread Ziemowit Laski
> FWIW, this setup is definitely being used by lots of others already - so > whenever there's such an issue, the main question to ask is why others > haven't run into the issue before. But improvements are definitely > welcome! You have to have PATH set up so that rc.exe is found inside the

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-09 Thread Hendrik Leppkes
On Thu, Feb 9, 2023 at 5:42 AM Marth64 wrote: > > Signed-off-by: Marth64 > --- > Adds detection of spatial/object-based audio extensions in E-AC-3, > TrueHD, and DCA XLL (DTS). This includes Atmos, DTS:X, and IMAX formats. > Please let me know what I could improve, I'm learning still. > Thank

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread Marton Balint
On Thu, 9 Feb 2023, Aline Gondim Santos Gondim Santos wrote: Hello Nicolas, Bellow you can find the bechmarks using `ffmpeg -benchmark` option. Utime change seems significant - as expected. In general I don't like the idea of removing shared memory support, and I don't quite see why

Re: [FFmpeg-devel] [PATCH] avformat/movenc: allow writing out channel count in MP4 and 3GP

2023-02-09 Thread Jan Ekström
On Thu, Feb 9, 2023 at 12:08 PM Martin Storsjö wrote: > > This looks reasonable to me. I didn't follow the references in the commit > message, but it sounds plausible and probably correct to me. > For the record, due to dumb ISO/IEC rule changes regarding how specifications need to be authorized

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Aline Gondim Santos Gondim Santos
> How do you get access to the d3d hwdevice, given this lives in lavd, > which has no provisions for that? > This looks much more like it'd fit in with the desktop duplication > capture, which ended up being a vsrc filter for that reason. Upon developing the device i did notice the d3dhwdevice

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread Aline Gondim Santos Gondim Santos
Hello Nicolas, Bellow you can find the bechmarks using `ffmpeg -benchmark` option. 1 - master ./ffmpeg -benchmark -t 10 -framerate 25 -f x11grab -i ":1+0,0 1920x1080" output1master.mp4 ffmpeg version N-109782-g458ae405ef Copyright (c) 2000-2023 the FFmpeg developers built with gcc 11

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread Aline Gondim Santos
Signed-off-by: Aline Gondim Santos --- libavdevice/xcbgrab.c | 180 +- 1 file changed, 39 insertions(+), 141 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 64a68ba497..05282911a9 100644 --- a/libavdevice/xcbgrab.c +++

[FFmpeg-devel] (no subject)

2023-02-09 Thread Aline Gondim Santos
Hello Nicolas, Bellow you can find the bechmarks using `ffmpeg -benchmark` option. 1 - master ./ffmpeg -benchmark -t 10 -framerate 25 -f x11grab -i ":1+0,0 1920x1080" output1master.mp4 ffmpeg version N-109782-g458ae405ef Copyright (c) 2000-2023 the FFmpeg developers built with gcc 11

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Timo Rothenpieler
On 09.02.2023 17:10, Nicolas George wrote: Timo Rothenpieler (12023-02-09): How do you get access to the d3d hwdevice, given this lives in lavd, which has no provisions for that? Would it work better if it was in the same library? It's not so much about in which library it is, but that

Re: [FFmpeg-devel] [PATCH 1/2] doc/dev_community: add the addresses of the committees

2023-02-09 Thread Nicolas George
Thilo Borgman (12023-02-08): > From: Nicolas George > > Omitting the .org from the address should be protection enough > against spam spiders. > > Signed-off-by: Nicolas George > --- > doc/dev_community/community.md | 4 > 1 file changed, 4 insertions(+) Thanks for picking this up.

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: distinguish between sync queue and muxer EOF

2023-02-09 Thread Gyan Doshi
On 2023-02-09 09:27 pm, Anton Khirnov wrote: --- How about something like this? Yes, this works. Regards, Gyan --- fftools/ffmpeg_mux.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/flvenc: add option to read metadata from file

2023-02-09 Thread Gyan Doshi
On 2023-02-09 09:15 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-05 12:05:19) On 2023-02-05 04:07 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-04 11:11:12) On 2023-02-03 09:04 pm, Andreas Rheinhardt wrote: What does this achieve that can't be achieved by other means

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Nicolas George
Timo Rothenpieler (12023-02-09): > How do you get access to the d3d hwdevice, given this lives in lavd, which > has no provisions for that? Would it work better if it was in the same library? Regards, -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Timo Rothenpieler
On 09.02.2023 15:22, aline.gondimsan...@savoirfairelinux.com wrote: From: Aline Gondim Santos A dxgi grab device may be either a display or a window. Differently from the existing gdigrab, this new device does not make the mouse to flick and also allows proper grabbing of accelerated windows,

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: distinguish between sync queue and muxer EOF

2023-02-09 Thread Anton Khirnov
--- How about something like this? --- fftools/ffmpeg_mux.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index dffc1410c8..cf58051949 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -159,14 +159,18

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/flvenc: add option to read metadata from file

2023-02-09 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-05 12:05:19) > > > On 2023-02-05 04:07 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2023-02-04 11:11:12) > >> On 2023-02-03 09:04 pm, Andreas Rheinhardt wrote: > >>> What does this achieve that can't be achieved by other means (namely by > >>> an API-user updating

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Add mapping for AV_PIX_FMT_BGRA

2023-02-09 Thread Romain Roffé
DXGI Desktop duplication outputs BGRA frames. Signed-off-by: Romain Roffé --- libavcodec/amfenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index c487fc48aa..06bd2a45db 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -73,6 +73,7

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread Nicolas George
aline.gondimsan...@savoirfairelinux.com (12023-02-09): > From: Aline Gondim Santos > > Signed-off-by: Aline Gondim Santos > --- > libavdevice/xcbgrab.c | 180 +- > 1 file changed, 39 insertions(+), 141 deletions(-) Hi. Thanks for the patch. Are you

[FFmpeg-devel] [PATCH] fftools/ffmpeg: rename -enc_stats* to -stats_enc*

2023-02-09 Thread Anton Khirnov
This is consistent with -stats_mux* As the options were added very recently, this should not break any users. --- Changelog| 2 +- doc/ffmpeg.texi | 20 ++-- fftools/ffmpeg_opt.c | 12 ++-- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: enable window resizing

2023-02-09 Thread aline . gondimsantos
From: Aline Gondim Santos Signed-off-by: Aline Gondim Santos --- libavdevice/xcbgrab.c | 180 +- 1 file changed, 39 insertions(+), 141 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 64a68ba497..05282911a9 100644 ---

[FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread aline . gondimsantos
From: Aline Gondim Santos A dxgi grab device may be either a display or a window. Differently from the existing gdigrab, this new device does not make the mouse to flick and also allows proper grabbing of accelerated windows, such as chrome or visual studio code. Signed-off-by: Aline Gondim

[FFmpeg-devel] [PATCH] lavfi/metal: fix build for iOS with deployment target lower than 13

2023-02-09 Thread Rechi
supportsFamily: is only available on iOS 13.0 or newer Signed-off-by: Rechi --- libavfilter/metal/utils.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/metal/utils.m b/libavfilter/metal/utils.m index f365d3cee..bb1825ae3 100644 --- a/libavfilter/metal/utils.m

Re: [FFmpeg-devel] [PATCH] mswindres: Use '-' instead of '/' for rc.exe options

2023-02-09 Thread Martin Storsjö
Hi, On Sat, 4 Feb 2023, Ziemowit Laski wrote: I've been bringing up FFMPEG using Visual Studio 2022 and the MINGW64 environment, and came across sundry things that absolutely needed fixes, so I thought I'd submit them as a series of small patches for you to consider. Here is the first

[FFmpeg-devel] [PATCH v2 4/4] avformat/tee: relay programs to child muxers

2023-02-09 Thread Gyan Doshi
--- libavformat/tee.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tee.c b/libavformat/tee.c index dd408dd096..2fde8a3828 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -291,6 +291,12 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave

[FFmpeg-devel] [PATCH v2 3/4] avformat/segment: relay programs to child muxers

2023-02-09 Thread Gyan Doshi
--- libavformat/segment.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 80e4bf851c..2d9f24e194 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,12 @@ static int segment_mux_init(AVFormatContext *s)

[FFmpeg-devel] [PATCH v2 2/4] avformat/hls: relay programs to child muxers

2023-02-09 Thread Gyan Doshi
--- libavformat/hlsenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 39df9becc7..0b66efad3e 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -907,6 +907,12 @@ static int hls_mux_init(AVFormatContext *s, VariantStream

[FFmpeg-devel] [PATCH v2 1/4] avformat: add av_program_copy()

2023-02-09 Thread Gyan Doshi
Helper to transfer programs from one muxing context to another. --- doc/APIchanges | 3 ++ libavformat/avformat.c | 70 ++ libavformat/avformat.h | 14 + libavformat/version.h | 2 +- 4 files changed, 88 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] avformat/movenc: allow writing out channel count in MP4 and 3GP

2023-02-09 Thread Martin Storsjö
On Tue, 7 Feb 2023, Jan Ekström wrote: ISOBMFF (14496-12) made this field ('channelcount') in the AudioSampleEntry structure non-template¹ somewhere before the release of the 2022 edition. As for ETSI TS 126 244 AKA 3GPP file format (V16.1.0, 2020-10), it does not seem contain any references

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_metadata_bsf: remove AUDs at any position

2023-02-09 Thread Gyan Doshi
On 2023-02-08 12:03 pm, Gyan Doshi wrote: On 2023-02-04 03:36 pm, Gyan Doshi wrote: Some files, likely due to faulty packetization or muxing, can have AUDs at other positions besides the head unit of a packet. Remove these too. Plan to push in 24h if no more comments. Pushed as

Re: [FFmpeg-devel] [PATCH v5] avformat/hls: Add option to retry failed segments for hls

2023-02-09 Thread Gyan Doshi
On 2023-02-08 01:25 pm, Gyan Doshi wrote: On 2022-10-21 02:49 pm, Steven Liu wrote: gnattu 于2022年10月20日周四 20:12写道: Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a