Re: [FFmpeg-devel] [PATCH 2/3] lavc/assenc: set AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread Nicolas George
rcombs (12023-02-20): > This already gave garbled output when multiple rects were present, > so this is simply documenting an existing requirement. > --- > libavcodec/assenc.c | 2 ++ > 1 file changed, 2 insertions(+) NAK: the code has provisions for multiple rectangles, if you enforce a single

Re: [FFmpeg-devel] [PATCH 3/3] ffmpeg: respect AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread Nicolas George
rcombs (12023-02-20): > Fixes ASS output when multiple rects are present. > --- > fftools/ffmpeg.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) Does this not belong to the framework? > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index

Re: [FFmpeg-devel] [PATCH 1/3] lavc/codec.h: add AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread Nicolas George
rcombs (12023-02-20): > --- > doc/APIchanges | 3 +++ > libavcodec/codec.h | 5 + > libavcodec/version.h | 2 +- > 3 files changed, 9 insertions(+), 1 deletion(-) And... No change to the framework to make use of this flag? Like, return AVERROR(EINVAL) if the flag is present but

Re: [FFmpeg-devel] trac updating bits

2023-02-20 Thread Gyan Doshi
On 2023-02-18 04:58 am, Michael Niedermayer wrote: Hi It appears that a bunch of static files for our trac where missed during previous updates. I re-deployed them so we should have the latest files now (this is css / js stuff mostly) I didnt notice any change in looks, but if something

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: allow to write qualifying metadata as number

2023-02-20 Thread Gyan Doshi
On 2023-02-20 10:10 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-19 09:13:55) On 2023-02-14 06:21 pm, Gyan Doshi wrote: On 2023-02-14 03:35 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-11 12:02:51) The FLV format can store metadata as numbers which are used and handled by

Re: [FFmpeg-devel] [PATCH] mips: fix build fail on MIPS R6

2023-02-20 Thread Junxian Zhu
Could anyone review this patch and merge it into master? It will fix build failed problems on mips r6 isa platform. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

[FFmpeg-devel] [PATCH 3/3] ffmpeg: respect AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread rcombs
Fixes ASS output when multiple rects are present. --- fftools/ffmpeg.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 9884e0c6c6..23eac52438 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@

[FFmpeg-devel] [PATCH 2/3] lavc/assenc: set AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread rcombs
This already gave garbled output when multiple rects were present, so this is simply documenting an existing requirement. --- libavcodec/assenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/assenc.c b/libavcodec/assenc.c index db6fd25dd7..1c49a6685b 100644 ---

[FFmpeg-devel] [PATCH 1/3] lavc/codec.h: add AV_CODEC_CAP_SINGLE_SUB_RECT

2023-02-20 Thread rcombs
--- doc/APIchanges | 3 +++ libavcodec/codec.h | 5 + libavcodec/version.h | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index bc52a07964..56f33aa25b 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -14,6 +14,9 @@ libavutil:

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9:reduce memory copy of prob.coef

2023-02-20 Thread Michael Niedermayer
On Mon, Feb 20, 2023 at 06:12:51PM +0800, xufuji456 wrote: > --- > libavcodec/vp9.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) This breaks fate --- ./tests/ref/fate/vp9-00-quantizer-262023-02-18 22:17:19.172862988 +0100 +++ tests/data/fate/vp9-00-quantizer-26

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc.c: correctly re-emit extradata ahead of IDR pictures

2023-02-20 Thread Marton Balint
On Mon, 20 Feb 2023, Anton Khirnov wrote: I'm wondering if there isn't a bsf that could do this in a cleaner way than messing with codec internals in a muxer. I thought about that too, but in the end I sticked to the more simple approach, because I could not decide which would be better,

[FFmpeg-devel] [PATCH 3/3] avfilter: add avx2 filter_line function for bwdif

2023-02-20 Thread James Darnley
2.24x faster (1925±1.3 vs. 859±2.2 decicycles) compared with ssse3 --- libavfilter/x86/vf_bwdif.asm| 29 - libavfilter/x86/vf_bwdif_init.c | 12 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/libavfilter/x86/vf_bwdif.asm

[FFmpeg-devel] [PATCH 2/3] checkasm: add test for bwdif

2023-02-20 Thread James Darnley
--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_bwdif.c | 70 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 76 insertions(+) create mode 100644 tests/checkasm/vf_bwdif.c

[FFmpeg-devel] [PATCH 1/3] avfilter: move bwdif's filter_line init into a dedicated function

2023-02-20 Thread James Darnley
--- libavfilter/bwdif.h | 3 ++- libavfilter/vf_bwdif.c | 13 + libavfilter/x86/vf_bwdif_init.c | 4 +--- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/libavfilter/bwdif.h b/libavfilter/bwdif.h index 889ff772ed..5749345f78 100644 ---

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-02-20 Thread Pierre-Anthony Lemieux
On Mon, Feb 20, 2023 at 9:55 AM Anton Khirnov wrote: > > Quoting p...@sandflow.com (2023-01-06 00:29:44) > > From: Pierre-Anthony Lemieux > > > > --- > > libavformat/imfdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/imfdec.c

[FFmpeg-devel] [PATCH 6/6] avcodec/rka: avoid undefined doubling sum overflow

2023-02-20 Thread Michael Niedermayer
Fixes: signed integer overflow: -2124073172 * 2 cannot be represented in type 'int' Fixes: 56099/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-4530933127839744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 5/6] avcodec/rka: avoid negative value shift

2023-02-20 Thread Michael Niedermayer
Fixes: left shift of negative value -81 Fixes: 56061/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-4649758062149632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rka.c | 2 +-

[FFmpeg-devel] [PATCH 3/6] avcodec/rka: Fix some integer anomalies

2023-02-20 Thread Michael Niedermayer
Fixes: left shift of negative value -3201 Fixes: integer overflow: -76470276 * -25608 cannot be represented in type 'int' Fixes: 56052/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5236218750435328 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 4/6] avcodec/rka: check for size 1 filter

2023-02-20 Thread Michael Niedermayer
Such filters will not advance and be stuck in the current implementation Fixes: Infinite loop Fixes: 56052/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5236218750435328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 2/6] avformat/rka: Fix 1/0 with bps=1

2023-02-20 Thread Michael Niedermayer
Fixes: division by zero Fixes: 55940/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6333107679920128 The decoder does not support bps=1 and i have no such sample so it is not known if this duration is correct. Alternatively we could error out on all bps we currently do not support on

[FFmpeg-devel] [PATCH 1/6] avformat/mov: Check samplesize and offset to avoid integer overflow

2023-02-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775584 + 536870912 cannot be represented in type 'long' Fixes: 55844/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-510613920664780 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH] lavc: disable an obsolete hack for real video

2023-02-20 Thread Anton Khirnov
AVCodecContext.slice_{count,offset} are unneeded since 2007, commit 383b123ed37df4ff99010646f1fa5911ff1428cc and following. Deprecate those fields. --- libavcodec/avcodec.h | 4 libavcodec/options_table.h | 2 ++ libavcodec/pthread_frame.c | 8 libavcodec/rv10.c |

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description

2023-02-20 Thread Anton Khirnov
Quoting Stefano Sabatini (2023-02-11 03:30:00) > On date Thursday 2023-02-09 00:41:18 +0100, Michael Niedermayer wrote: > > On Mon, Feb 06, 2023 at 02:25:23AM +0100, Stefano Sabatini wrote: > [...] > > > Subject: [PATCH 2/2] ffmpeg: review -dts_delta_threshold and > > > -dts_delta_error > > >

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-02-20 Thread Anton Khirnov
Quoting p...@sandflow.com (2023-01-06 00:29:44) > From: Pierre-Anthony Lemieux > > --- > libavformat/imfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index 03de9ce151..a92686e93b 100644 > --- a/libavformat/imfdec.c

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-17 04:43:50) > From 4645f1fb3249f8249fdebaf9b3edffc848b9af3c Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Wed, 14 Dec 2022 00:18:42 +0100 > Subject: [PATCH 17/72] hevc_ps: expose and parse scc range extension fields > > --- > libavcodec/hevc.h| 2 ++ >

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-20 Thread Lynne
Feb 20, 2023, 18:23 by an...@khirnov.net: > Quoting Lynne (2023-02-20 18:18:40) > >> Feb 20, 2023, 16:34 by an...@khirnov.net: >> >> > Quoting Lynne (2023-02-18 15:53:32) >> > >> >> Feb 18, 2023, 14:58 by jamr...@gmail.com: >> >> > vf_spp should be ported to tx, not the avdct functions silenced.

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-20 18:18:40) > Feb 20, 2023, 16:34 by an...@khirnov.net: > > > Quoting Lynne (2023-02-18 15:53:32) > > > >> Feb 18, 2023, 14:58 by jamr...@gmail.com: > >> > vf_spp should be ported to tx, not the avdct functions silenced. You're > >> > just scheduling a compilation failure

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-17 04:43:50) > From 52ab3cd8d165a838be92189c87c54915efc1c7e5 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Wed, 11 Jan 2023 05:20:32 +0100 > Subject: [PATCH 10/72] h264dec: track picture_structure in H264Picture > > --- > libavcodec/h264_picture.c | 1 + >

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-20 Thread Lynne
Feb 20, 2023, 16:34 by an...@khirnov.net: > Quoting Lynne (2023-02-18 15:53:32) > >> Feb 18, 2023, 14:58 by jamr...@gmail.com: >> > vf_spp should be ported to tx, not the avdct functions silenced. You're >> > just scheduling a compilation failure as is. >> There's enough time to port it, a whole

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-20 Thread Marth64
Thank you, It’s done in v2 set On Mon, Feb 20, 2023 at 10:41 Anton Khirnov wrote: > Quoting Marth64 (2023-02-17 15:51:09) > > I can do the doc update, just not sure how to do the version. Is there an > > example? (Or is this not something I can do). Thank you! > > Just increase the minor

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-17 04:43:50) > From 1279c6011c610fdb054cd9eea7a6f07c94f69f29 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Wed, 14 Dec 2022 00:09:08 +0100 > Subject: [PATCH 08/72] h264_ps: expose bit rate and CPB size fields > > --- > libavcodec/h264_ps.c | 8 >

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-17 04:43:50) > From a9ae85816dfaa8791f974348825fc8ba9209423d Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Thu, 10 Mar 2022 18:08:53 +0100 > Subject: [PATCH 05/72] h264_parser: expose idr_pic_id > > Vulkan needs it. > --- > libavcodec/h264_parse.h | 1 + >

Re: [FFmpeg-devel] [PATCH] ffprobe/eac3/mlp/dca: add detection of spatial audio extensions

2023-02-20 Thread Anton Khirnov
Quoting Marth64 (2023-02-17 15:51:09) > I can do the doc update, just not sure how to do the version. Is there an > example? (Or is this not something I can do). Thank you! Just increase the minor version number in libavcodec/version.h -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: allow to write qualifying metadata as number

2023-02-20 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-19 09:13:55) > On 2023-02-14 06:21 pm, Gyan Doshi wrote: > > > > > > On 2023-02-14 03:35 pm, Anton Khirnov wrote: > >> Quoting Gyan Doshi (2023-02-11 12:02:51) > >>> The FLV format can store metadata as numbers which are used and handled > >>> by many streaming

Re: [FFmpeg-devel] patch for ccaption decoder

2023-02-20 Thread Anton Khirnov
Makes sense, will push soonish of nobody objects. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH v4 2/5] avformat: add av_program_copy()

2023-02-20 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-18 05:49:46) > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 33ab0bc8ba..46b4d177c3 100644 > --- a/libavformat/avformat.h > +++ b/libavformat/avformat.h > @@ -1886,6 +1886,28 @@ uint8_t *av_stream_get_side_data(const AVStream > *stream, > >

Re: [FFmpeg-devel] [PATCH v4 3/5] avformat/hls: relay programs to child muxers

2023-02-20 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-18 05:49:47) > --- > libavformat/hlsenc.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index e1f96feda3..74db447085 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -911,6 +911,14

Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct

2023-02-20 Thread Anton Khirnov
Quoting Lynne (2023-02-18 15:53:32) > Feb 18, 2023, 14:58 by jamr...@gmail.com: > > vf_spp should be ported to tx, not the avdct functions silenced. You're > > just scheduling a compilation failure as is. > There's enough time to port it, a whole year in fact. Past experience shows that it never

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc.c: correctly re-emit extradata ahead of IDR pictures

2023-02-20 Thread Anton Khirnov
I'm wondering if there isn't a bsf that could do this in a cleaner way than messing with codec internals in a muxer. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v4 1/5] avformat: add av_program_add_stream_index2()

2023-02-20 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-18 05:49:45) > av_program_add_stream_index() added in 526efa10534 > may fail to carry out its purpose but the lack of > a return value stops callers from catching any error. av_program_add_stream_index() should be deprecated then -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions

2023-02-20 Thread James Darnley
On 2/20/23 13:49, Nicolas George wrote: James Darnley (12023-02-20): -fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p10le -frames:v 30 -vf yadif=0,scale -fate-filter-yadif16: CMD = framecrc

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/yadif: add avx2 filter_line function

2023-02-20 Thread James Darnley
On 2/10/23 14:06, James Darnley wrote: snip This patch set is broken. The checkasm test is incomplete. This avx2 function has some bug that only manifests when the strides (prefs mrefs) are opposite signs (one positive and one negative). That situation is what happens with real usage. I

Re: [FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions

2023-02-20 Thread Nicolas George
James Darnley (12023-02-20): > --- > tests/fate/filter-video.mak | 4 +-- > tests/ref/fate/filter-yadif10 | 60 +-- > tests/ref/fate/filter-yadif16 | 60 +-- > 3 files changed, 62 insertions(+), 62 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions

2023-02-20 Thread James Darnley
--- tests/fate/filter-video.mak | 4 +-- tests/ref/fate/filter-yadif10 | 60 +-- tests/ref/fate/filter-yadif16 | 60 +-- 3 files changed, 62 insertions(+), 62 deletions(-) diff --git a/tests/fate/filter-video.mak

[FFmpeg-devel] [PATCH] libavcodec/vp9:reduce memory copy of prob.coef

2023-02-20 Thread xufuji456
--- libavcodec/vp9.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index ebb89a413c..4a9fed62e0 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -948,7 +948,7 @@ static int decode_frame_header(AVCodecContext *avctx,

Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

2023-02-20 Thread Hendrik Leppkes
On Mon, Feb 20, 2023 at 12:50 AM Neal Gompa wrote: > > On Sun, Feb 19, 2023 at 5:00 PM Kieran Kunhya wrote: > > > > On Sun, 19 Feb 2023 at 18:46, Lynne wrote: > > > > > Feb 19, 2023, 18:43 by kier...@obe.tv: > > > > > > > On Sun, 19 Feb 2023 at 17:36, Kieran Kunhya wrote: > > > > > > > >>