[FFmpeg-devel] [PATCH] avcodec/options_table: reorder nokey after nointra

2023-04-25 Thread Zhao Zhili
From: Zhao Zhili So the values are in ascending order. Signed-off-by: Zhao Zhili --- libavcodec/options_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index f331ce2861..4f5918c7f6 100644 ---

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc

2023-04-25 Thread Vignesh Venkatasubramanian
On Mon, Apr 17, 2023 at 4:18 PM Michael Niedermayer wrote: > > On Mon, Apr 17, 2023 at 12:36:26PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-04-17 00:25:16) > > > Fixes: memleak > > > Fixes: > > > 45982/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6674082962997248

Re: [FFmpeg-devel] [PATCH 0/2] Implement SMPTE 2038 output support over Decklink SDI

2023-04-25 Thread Marton Balint
On Mon, 24 Apr 2023, Devin Heitmueller wrote: Hello Marton, Thanks for reviewing. Comments inline: On Sun, Apr 23, 2023 at 2:43 PM Marton Balint wrote: [...] Thanks for the detailed explanations. I guess then keeping the queue is well justified here. Regarding the use of

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Explicitly cast quad_width and quad_height to size_t

2023-04-25 Thread James Almer
On 4/25/2023 5:13 PM, Pierre-Anthony Lemieux wrote: On Tue, Apr 25, 2023 at 11:25 AM wrote: From: caleb Prevents un-necessary casts when calculating buf_size This is to address Coverity CID 1528149: """Suspicious implicit sign extension: "quad_height" with type "uint16_t const" (16 bits,

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Explicitly cast quad_width and quad_height to size_t

2023-04-25 Thread Pierre-Anthony Lemieux
On Tue, Apr 25, 2023 at 11:25 AM wrote: > > From: caleb > > Prevents un-necessary casts when calculating buf_size This is to address Coverity CID 1528149: """Suspicious implicit sign extension: "quad_height" with type "uint16_t const" (16 bits, unsigned) is promoted in "4 * quad_width *

[FFmpeg-devel] [PATCH 2/2] avcodec/aacdec_template: Fix undefined signed interger operations

2023-04-25 Thread Michael Niedermayer
Fixed: signed integer overflow: -2 * -1085502286 cannot be represented in type 'int' Fixed: 57986/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5123651145170944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/2] avcodec/wavarc: Fix k limit

2023-04-25 Thread Michael Niedermayer
The implementation does not support k=32 Fixes: shift exponent 32 is too large for 32-bit type 'unsigned int' Fixes: 57976/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5911925807775744 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Explicitly cast quad_width and quad_height to size_t

2023-04-25 Thread etemesicaleb
From: caleb Prevents un-necessary casts when calculating buf_size --- libavcodec/jpeg2000htdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c index 51cd96e0f1..8907820806 100644 --- a/libavcodec/jpeg2000htdec.c

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2023-04-25 Thread James Almer
On 4/25/2023 2:11 PM, Nicolas George wrote: Hi. I finally have some tome to go at this again. Totalizing this thread, the previous discussions and the few private mails I received, I conclude there is significant more support than opposition to AVWriter, so I am moving forward with polishing

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2023-04-25 Thread Nicolas George
Hi. I finally have some tome to go at this again. Totalizing this thread, the previous discussions and the few private mails I received, I conclude there is significant more support than opposition to AVWriter, so I am moving forward with polishing and pushing the implementation. (To avoid

Re: [FFmpeg-devel] [PATCH] mov: Do not blindly disable advanced edit lists if use_mfra_for is set

2023-04-25 Thread Derek Buitenhuis
On 4/20/2023 3:36 PM, Derek Buitenhuis wrote: > This was a bug/mistake in dae3679a9bfa421829ef9049ae2167089a2fdef7. > > use_mfra_for by defintion only has an effect on fragmented MP4 files, > making the check not only redundant, but also broken if a user used > the option globally (i.e. set on

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error

2023-04-25 Thread Nicolas George
Anton Khirnov (12023-04-24): > I think the point on which we disagree is your notion of "error > conditions" as being basically interchangeable. The way everything, FFmpeg and all other sane system work, is that the caller handles the very few errors it know how to handle (EAGAIN certainly, maybe

Re: [FFmpeg-devel] [PATCH] MXF - Add jpeg2000 subdescriptor - Sponsored by INA

2023-04-25 Thread Cédric Le Barz
Le 05/04/2023 à 15:53, Tomas Härdin a écrit : ons 2023-04-05 klockan 15:05 +0200 skrev Cédric Le Barz: Le 03/04/2023 à 17:14, Michael Niedermayer a écrit : On Mon, Apr 03, 2023 at 10:08:25AM +0200, Cédric Le Barz wrote: Hi, I've attached the patch to this mail, in order to solve newlines

Re: [FFmpeg-devel] [PATCH v3 1/5] ccfifo: Properly handle CEA-708 captions through framerate conversion

2023-04-25 Thread Lance Wang
On Fri, Apr 21, 2023 at 9:29 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > When transcoding video that contains 708 closed captions, the > caption data is tied to the frames as side data. Simply dropping > or adding frames to change the framerate will result in loss of > data,

Re: [FFmpeg-devel] trac spam

2023-04-25 Thread Thilo Borgmann
Am 24.04.23 um 22:23 schrieb Michael Niedermayer: Hi all thilo pointed me to some spam on trac today, investigating i found a spammer with 4 accounts who spammed ~6 tickets thanks to the last update the permission for the admin page to delete users seems to got a new name which slightly slowed

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc: add strict bit rate control mode

2023-04-25 Thread Jeremy Wu
Thanks for the feedback! I was also looking at whether there is a less intrusive way to enable the code path. I have uploaded a v2 patch that looks at `bit_rate_tolerance`, with minor changes to the option table as it was ignored in the context of audio. I'm only looking at the Bluetooth

[FFmpeg-devel] [PATCH v5 5/5] lavfi/format: add a hwmap auto conversion filter

2023-04-25 Thread Tong Wu
When two formats lists cannot be merged, a scale filter is auto-inserted. However, when it comes to hardware map, we have to manually add a hwmap filter to do the conversion. This patch introduces an auto hwmap filter to do the hwmap conversion automatically. Signed-off-by: Tong Wu ---

[FFmpeg-devel] [PATCH v5 4/5] lavfi/format: wrap auto filters into structures

2023-04-25 Thread Tong Wu
This patch wraps auto conversion filters into new structures, making it easier to add more auto filters. And it adds a loop to automatically insert every possible conversion filter until merge succeeds. Signed-off-by: Tong Wu --- libavfilter/avfiltergraph.c | 76

[FFmpeg-devel] [PATCH v5 3/5] lavfi/avfiltergraph: move convert codes into functions

2023-04-25 Thread Tong Wu
This patch moves the auto-insert filter codes into two functions. Signed-off-by: Tong Wu --- libavfilter/avfiltergraph.c | 128 ++-- 1 file changed, 79 insertions(+), 49 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index

[FFmpeg-devel] [PATCH v5 2/5] avfilter/vf_hwmap: get the AVHWDeviceType from outlink format

2023-04-25 Thread Tong Wu
When both derive_device_type and device context are not presented during hw->hw map, the hwmap filter should be able to retrieve AVHWDeviceType from outlink->format and create corresponding hwdevice context. Signed-off-by: Tong Wu --- libavfilter/vf_hwmap.c | 35

[FFmpeg-devel] [PATCH v5 1/5] avutil/hwcontext: add a function to get the AVHWDeviceType

2023-04-25 Thread Tong Wu
Add a function to get the corresponding AVHWDeviceType from a given hardware pixel format. Signed-off-by: Tong Wu --- libavutil/hwcontext.c | 11 +++ libavutil/hwcontext.h | 12 2 files changed, 23 insertions(+) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c

[FFmpeg-devel] [PATCH v2] avcodec/aacenc: add strict bit rate control option

2023-04-25 Thread Jeremy Wu
From: Jeremy Wu In certain use cases, controlling the maximum frame size is critical. An example is when transmitting AAC packets over Bluetooth A2DP. While the spec allows the packets to be fragmented (but UNRECOMMENDED), in practice most headsets do not recognize nor reassemble such packets.