Re: [FFmpeg-devel] [PATCH v4 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-27 Thread Leo Izen
On 6/27/23 19:46, James Almer wrote: On 6/27/2023 8:32 PM, Leo Izen wrote: On 6/27/23 19:25, James Almer wrote: On 6/26/2023 12:49 PM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note

Re: [FFmpeg-devel] [PATCH v4 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-27 Thread James Almer
On 6/27/2023 8:32 PM, Leo Izen wrote: On 6/27/23 19:25, James Almer wrote: On 6/26/2023 12:49 PM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not

Re: [FFmpeg-devel] [PATCH v4 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-27 Thread Leo Izen
On 6/27/23 19:25, James Almer wrote: On 6/26/2023 12:49 PM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false

Re: [FFmpeg-devel] [PATCH v4 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-27 Thread James Almer
On 6/26/2023 12:49 PM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false positives. Signed-off-by: ---

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/jpegxl_parser: add JPEG XL parser

2023-06-27 Thread James Almer
On 6/27/2023 8:18 PM, Leo Izen wrote: On 6/27/23 18:58, James Almer wrote: On 6/26/2023 12:49 PM, Leo Izen wrote: +/* + * copies as much of the codestream into the buffer as possible + * pass a shorter buflen to request less + * returns the number of bytes consumed from input, may be greater

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/jpegxl_parser: add JPEG XL parser

2023-06-27 Thread Leo Izen
On 6/27/23 18:58, James Almer wrote: On 6/26/2023 12:49 PM, Leo Izen wrote: +/* + * copies as much of the codestream into the buffer as possible + * pass a shorter buflen to request less + * returns the number of bytes consumed from input, may be greater than input_len + * if the input

Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/jpegxl_parser: add JPEG XL parser

2023-06-27 Thread James Almer
On 6/26/2023 12:49 PM, Leo Izen wrote: +/* + * copies as much of the codestream into the buffer as possible + * pass a shorter buflen to request less + * returns the number of bytes consumed from input, may be greater than input_len + * if the input doesn't end on an ISOBMFF-box boundary + */

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Andreas Rheinhardt
Paul B Mahol: > On Tue, Jun 27, 2023 at 11:45 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Tue, Jun 27, 2023 at 11:05 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Tue, Jun 27, 2023 at 9:47 PM

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Paul B Mahol
On Tue, Jun 27, 2023 at 11:45 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Tue, Jun 27, 2023 at 11:05 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Tue, Jun 27, 2023 at 9:47 PM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Andreas Rheinhardt
Paul B Mahol: > On Tue, Jun 27, 2023 at 11:05 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Tue, Jun 27, 2023 at 9:47 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > Patch attached. > Where

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Paul B Mahol
On Tue, Jun 27, 2023 at 11:05 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Tue, Jun 27, 2023 at 9:47 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> Patch attached. > >>> > >> > >> Where do you intend to use

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Andreas Rheinhardt
Paul B Mahol: > On Tue, Jun 27, 2023 at 9:47 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> Patch attached. >>> >> >> Where do you intend to use this? What is the point of it? >> After all, using this value in GET_VLC makes no sense; only compile-time >>

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Paul B Mahol
On Tue, Jun 27, 2023 at 9:47 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > Patch attached. > > > > Where do you intend to use this? What is the point of it? > After all, using this value in GET_VLC makes no sense; only compile-time > constants do. > It works

Re: [FFmpeg-devel] [PATCH v4 1/4] avcodec/libjxldec: use internal AVFrame as buffered space

2023-06-27 Thread Andreas Rheinhardt
Leo Izen: > Before this commit, the decoder erroneously assumes that the AVFrame > passed to the receive_frame is the same one each time. Now it keeps an > internal AVFrame to write into, and copies it over when it's done. > --- > libavcodec/libjxldec.c | 38 ++

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-27 Thread Andreas Rheinhardt
Paul B Mahol: > Patch attached. > Where do you intend to use this? What is the point of it? After all, using this value in GET_VLC makes no sense; only compile-time constants do. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore picture start code in extradata for AVID mpeg2 files

2023-06-27 Thread Marton Balint
AVID IMX MPEG2 files in MOV seems to have extradata like this: : 0018 4143 4c52 4143 4c52 3030 3031 ACLRACLR0001 0010: 0001 Signed-off-by: Marton Balint --- libavcodec/mpeg12dec.c | 5 + 1 file changed, 5 insertions(+)

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-27 Thread Rémi Denis-Courmont
Le sunnuntaina 25. kesäkuuta 2023, 1.19.04 EEST Nicolas George a écrit : > Michael Niedermayer (12023-06-23): > > * What iam interrested in was working with the signals at a low level, why > > because i find it interresting and fun. > > Then this is what you should be spending your time on, and

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

2023-06-27 Thread Ronald S. Bultje
Hi Vignesh, On Tue, Jun 27, 2023 at 1:55 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: > > >>> In some versions of libsvtav1, setting intra_period_length to 0 > [..] > > >>> SVT-AV1 Bug: https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 > > >>> > > >>> Example command:

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

2023-06-27 Thread Vignesh Venkat
On Mon, Jun 26, 2023 at 4:53 PM James Almer wrote: > > On 6/26/2023 7:32 PM, Vignesh Venkat wrote: > > On Mon, Jun 26, 2023 at 3:17 PM Ronald S. Bultje wrote: > >> > >> Hi, > >> > >> On Mon, Jun 26, 2023 at 1:47 PM Vignesh Venkatasubramanian > >> wrote: > >>> > >>> In some versions of

Re: [FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

2023-06-27 Thread Dominik 'Rathann' Mierzejewski
On Tuesday, 27 June 2023 at 19:23, Dominik 'Rathann' Mierzejewski wrote: > Hi! > I'm forwarding this patch from HandBrake. Original author is > Damiano Galassi (galad87@github). > > Apparently, this is required to pass through Dolby Vision metadata > to x265. Author's comment says: 'Profile 5

[FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

2023-06-27 Thread Dominik 'Rathann' Mierzejewski
Hi! I'm forwarding this patch from HandBrake. Original author is Damiano Galassi (galad87@github). Apparently, this is required to pass through Dolby Vision metadata to x265. Author's comment says: 'Profile 5 seems to require the "dvh1" fourcc.' See

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-27 Thread Nicolas George
Tomas Härdin (12023-06-27): > I propose we add the ability for ffmpeg to send email. After all some > users might find that useful. And because many users use webmail we > should also implement HTML parsing. If you like to work on it and manage to produce something that integrates elegantly in

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-27 Thread Tomas Härdin
tis 2023-06-27 klockan 12:57 +0200 skrev Nicolas George: > Tomas Härdin (12023-06-27): > > Yes those are all fine use cases. But that doesn't explain why they > > belong in FFmpeg rather than say a driver that turns generic SDRs > > into > > V4L FM devices, or a dedicated GUI application. > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/packet: add a define for the max buffer size a packet can hold

2023-06-27 Thread James Almer
On 6/27/2023 4:23 AM, Anton Khirnov wrote: Quoting James Almer (2023-06-21 22:46:56) Signed-off-by: James Almer --- TODO: Version bump and APIchanges entry. libavcodec/packet.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-27 Thread Nicolas George
Tomas Härdin (12023-06-27): > Yes those are all fine use cases. But that doesn't explain why they > belong in FFmpeg rather than say a driver that turns generic SDRs into > V4L FM devices, or a dedicated GUI application. They can be implemented in any of these pieces of software, including

Re: [FFmpeg-devel] [WIP] [PATCH v5 0/1] add Software Defined Radio support

2023-06-27 Thread Michael Niedermayer
On Tue, Jun 27, 2023 at 02:16:50PM +1000, Peter Ross wrote: > On Tue, Jun 27, 2023 at 01:53:01AM +0200, Michael Niedermayer wrote: > > Changes since v4: > > * vissualization shows modulation and frequency > > * limit station search to AM shortwave and FM broadcast band > > * enable FM Probing with

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/evc_frame_merge: ensure the assembled buffer fits in an AVPacket

2023-06-27 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
Hi James, I would like to thank you for the thorough review and merging of the majority of the 10-patchset into the FFmpeg master branch. Your personal dedication to making numerous valuable and impactful improvements to the code has been remarkable. I am really grateful for your work and your

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-27 Thread Tomas Härdin
sön 2023-06-25 klockan 11:54 +0200 skrev Michael Niedermayer: > On Sun, Jun 25, 2023 at 12:01:07AM +0200, Tomas Härdin wrote: > > lör 2023-06-24 klockan 23:01 +0200 skrev Michael Niedermayer: > > > On Sat, Jun 24, 2023 at 11:51:57AM +0200, Tomas Härdin wrote: > > > > fre 2023-06-23 klockan 23:18

Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

2023-06-27 Thread Wang Bin
James Almer 于2023年6月19日周一 10:43写道: > On 6/18/2023 11:27 PM, Wang Bin wrote: > > - Changes in mov_write_video_tag function to handle EVC elementary stream > >> - Provided structure EVCDecoderConfigurationRecord that specifies the > >> decoder configuration information for ISO/IEC 23094-1 video

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/packet: add a define for the max buffer size a packet can hold

2023-06-27 Thread Anton Khirnov
Quoting James Almer (2023-06-21 22:46:56) > Signed-off-by: James Almer > --- > TODO: Version bump and APIchanges entry. > > libavcodec/packet.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/packet.h b/libavcodec/packet.h > index f28e7e7011..f7dd687c23 100644 > ---