[FFmpeg-devel] [PATCH 11/14] avradio/sdrdemux: Basic prefilter for RDS

2023-07-12 Thread Michael Niedermayer
25% lower error rate Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index bbd756f1d6..c0ca420c84 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@

[FFmpeg-devel] [PATCH 10/14] avradio/sdrdemux: Export RT+ metadata updates

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index e45d00724b..bbd756f1d6 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1677,6 +1677,7 @@

[FFmpeg-devel] [PATCH 14/14] avradio/sdrdemux: Print log_debug level message on metadata changes

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index b69b13d075..d40b92dd24 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1716,6 +1716,7 @@ process_next_block:

[FFmpeg-devel] [PATCH 09/14] remove stray av_log()

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/rds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavradio/rds.c b/libavradio/rds.c index 4b16521e4c..1f2979d068 100644 --- a/libavradio/rds.c +++ b/libavradio/rds.c @@ -179,7 +179,6 @@ static int decode_rds_group(SDRContext *sdr,

[FFmpeg-devel] [PATCH 08/14] avradio/rds: Better file title

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/rds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavradio/rds.c b/libavradio/rds.c index 30e4209ae8..4b16521e4c 100644 --- a/libavradio/rds.c +++ b/libavradio/rds.c @@ -1,5 +1,5 @@ /* - * RDS + * Radio Data System *

[FFmpeg-devel] [PATCH 13/14] avradio/sdrdemux: deemphasis filter fixes

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 54d7622809..b69b13d075 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -67,7

[FFmpeg-devel] [PATCH 07/14] avradio/rds: Implement RadioText Plus

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/rds.c| 44 - libavradio/sdr.h| 7 +++ libavradio/vissualize.c | 5 + 3 files changed, 55 insertions(+), 1 deletion(-) diff --git a/libavradio/rds.c b/libavradio/rds.c index

[FFmpeg-devel] [PATCH 12/14] avradio/sdrdemux: Reduce FM audio bandwidth down toward reality

2023-07-12 Thread Michael Niedermayer
This avoids useless computations Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index c0ca420c84..54d7622809 100644 --- a/libavradio/sdrdemux.c +++

[FFmpeg-devel] [PATCH 06/14] avradio/rds: Implement clearing radio text

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/rds.c | 9 +++-- libavradio/sdr.h | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libavradio/rds.c b/libavradio/rds.c index 55b24a0d9e..e121c9db8e 100644 --- a/libavradio/rds.c +++ b/libavradio/rds.c @@ -130,14 +130,19

[FFmpeg-devel] [PATCH 05/14] avradio/sdrdemux: basic warning cleanup

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index fd3f5dd52d..e45d00724b 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1148,7 +1148,6 @@

[FFmpeg-devel] [PATCH 04/14] avradio/sdrdemux: Compute FM station frequency more exactly

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index fea4202709..fd3f5dd52d 100644 --- a/libavradio/sdrdemux.c +++

[FFmpeg-devel] [PATCH 03/14] avradio/sdrdemux: require better timeout for replacing station

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 2103feaca8..fea4202709 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -216,7 +216,8 @@ static

[FFmpeg-devel] [PATCH 02/14] avradio/sdr: Factor demodulate_all_fm out

2023-07-12 Thread Michael Niedermayer
This is cleaner Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 1 + libavradio/sdrdemux.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavradio/sdr.h b/libavradio/sdr.h index 6c4647823e..29ac4a2963 100644 --- a/libavradio/sdr.h +++ b/libavradio/sdr.h

[FFmpeg-devel] [PATCH 01/14] avradio/rds: reset station timeout on successfull group decode

2023-07-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/rds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavradio/rds.c b/libavradio/rds.c index 99e5360b72..55b24a0d9e 100644 --- a/libavradio/rds.c +++ b/libavradio/rds.c @@ -123,6 +123,9 @@ static int decode_rds_group(SDRContext *sdr,

Re: [FFmpeg-devel] [PATCH 01/12] avradio/sdrdemux: Fix use of uninitialized memory

2023-07-12 Thread Michael Niedermayer
On Tue, Jul 11, 2023 at 11:18:59PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavradio/sdrdemux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Will apply patchset [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH v3 4/4] avcodec/decode: check the output frame for discard samples with all decoders

2023-07-12 Thread James Almer
And not just those with the old decode() API. Signed-off-by: James Almer --- libavcodec/decode.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index d1aa183b78..b8c1862ad8 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@

[FFmpeg-devel] [PATCH v4 3/4] avcodec/decode: fill missing frame fields for all decoders

2023-07-12 Thread James Almer
And not just those with the old decode() API. Signed-off-by: James Almer --- libavcodec/decode.c | 65 - 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 57d38cbc54..d1aa183b78 100644 ---

[FFmpeg-devel] [PATCH 2/4] avcodec/decode: simplify applying or exporting skip samples

2023-07-12 Thread James Almer
Copy packet side data to the output frame in ff_decode_frame_props_from_pkt() instead of in discard_samples(), having the latter only applying the skip if required. This will be useful for the following commit. Signed-off-by: James Almer --- libavcodec/decode.c | 37

[FFmpeg-devel] [PATCH v4 1/4] avcodec/decode: move processing discard samples to its own function

2023-07-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 269 +++- 1 file changed, 141 insertions(+), 128 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 239ad70b41..4478c8c4fe 100644 --- a/libavcodec/decode.c +++

[FFmpeg-devel] [PATCH] checkasm/riscv: report an error upon SIGILL

2023-07-12 Thread Rémi Denis-Courmont
Terminating the whole checkasm process is not very helpful. This will report if an illegal instruction occurs while executing a tested function. --- tests/checkasm/checkasm.c | 20 tests/checkasm/checkasm.h | 8 +++- 2 files changed, 27 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 3/3] avcodec/hevcdec: simplify decrementing of MDCV/CLL flags

2023-07-12 Thread Jan Ekström
Mostly done to be able to update the comment so that it no longer mentions the same flag twice. --- libavcodec/hevcdec.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 1e0bac1fa3..d7b9b529ff 100644 ---

[FFmpeg-devel] [PATCH 2/3] avcodec: move content light level SEI handling to h2645_sei

2023-07-12 Thread Jan Ekström
This allows this common H.274 SEI to be parsed from both H.264 as well as HEVC, as well as probably from VVC in the future. Generally attempts to keep the original code as similar as possible. FATE test refererence changes only change the order of side data export within a single frame. Nothing

[FFmpeg-devel] [PATCH 1/3] avcodec: move mastering display colour volume SEI handling to h2645_sei

2023-07-12 Thread Jan Ekström
This allows this common H.274 SEI to be parsed from both H.264 as well as HEVC, as well as probably from VVC in the future. Generally attempts to keep the original code as similar as possible. FATE test refererence changes only change the order of side data export within a single frame. Nothing

[FFmpeg-devel] [PATCH 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei

2023-07-12 Thread Jan Ekström
This allows parsing code to be re-utilized from H.264, as well as probably from VVC in the future. This additionally eases verification of the AVCodecContext side data patch set, which includes libx264 integration for HDR10 side data. Notes: * At least in ffprobe and FATE tests the code works

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/avassert: include config.h

2023-07-12 Thread Nicolas George
Anton Khirnov (12023-07-12): > I do not see this patch on the mailing list. You need to look better, just like for the benefits of good infrastructure APIs. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] lavu/avassert: include config.h

2023-07-12 Thread Nicolas George
Nicolas George (12023-04-26): > Updated version attached, similar to what exists in common.h. Pushed. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavu/avassert: include config.h

2023-07-12 Thread Anton Khirnov
Quoting Nicolas George (2023-07-12 15:58:58) > ffmpeg | branch: master | Nicolas George | Wed Apr 26 > 14:29:29 2023 +0200| [ca9ec4e7ed64e222b2045e66b1000c7f88ea696e] | committer: > Nicolas George > > lavu/avassert: include config.h > > Fix setting the assert level. > > >

[FFmpeg-devel] [PATCH v2] avformat/mov: enable identifying TTML subtitle streams as such

2023-07-12 Thread Jan Ekström
From: Jan Ekström The contents are full TTML XML documents. TTML writing tests' results are updated as the streams are now properly identified as TTML ones. Signed-off-by: Jan Ekström --- libavformat/mov.c| 11 +-- tests/ref/fate/mov-mp4-ttml-dfxp | 9 +

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

2023-07-12 Thread Anton Khirnov
Quoting Gyan Doshi (2023-07-12 15:31:57) > > > On 2023-07-12 06:51 pm, James Almer wrote: > > On 7/12/2023 10:14 AM, Gyan Doshi wrote: > >> > >> > >> On 2023-07-12 06:12 pm, James Almer wrote: > >>> On 7/9/2023 9:57 AM, Anton Khirnov wrote: > This decoding flag makes decoders drop all

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Fix issue with missing headers in AV1 encoder

2023-07-12 Thread Evgeny Pavlov
This commit fixes issue with missing SPS/PPS headers in video encoded by AMF AV1 encoder. Missing headers leads to broken seek in MPV video player. Default value for property AV1_HEADER_INSERTION_MODE shouldn't be setup to NONE (no headers insertion). We need to skip definition of this property,

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: don't discard the buffered packet if the underlying bsf can't take it

2023-07-12 Thread James Almer
On 7/12/2023 10:32 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-12 13:40:25) On 7/12/2023 6:08 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-12 04:06:44) Signed-off-by: James Almer --- libavcodec/decode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

2023-07-12 Thread Gyan Doshi
On 2023-07-12 06:51 pm, James Almer wrote: On 7/12/2023 10:14 AM, Gyan Doshi wrote: On 2023-07-12 06:12 pm, James Almer wrote: On 7/9/2023 9:57 AM, Anton Khirnov wrote: This decoding flag makes decoders drop all frames after a parameter change, but what exactly constitutes a parameter

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: don't discard the buffered packet if the underlying bsf can't take it

2023-07-12 Thread Anton Khirnov
Quoting James Almer (2023-07-12 13:40:25) > On 7/12/2023 6:08 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-07-12 04:06:44) > >> Signed-off-by: James Almer > >> --- > >> libavcodec/decode.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: don't reject flush packets when buffer_pkt is not empty

2023-07-12 Thread Anton Khirnov
Quoting James Almer (2023-07-12 13:30:30) > On 7/12/2023 6:06 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-07-12 04:06:43) > >> Restores the behavior pre commit a92dbeb9ae. > >> > >> Signed-off-by: James Almer > > > > Do you see any advantage to this? > > Not returning an error when a

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

2023-07-12 Thread Gyan Doshi
On 2023-07-12 06:12 pm, James Almer wrote: On 7/9/2023 9:57 AM, Anton Khirnov wrote: This decoding flag makes decoders drop all frames after a parameter change, but what exactly constitutes a parameter change is not well defined and will typically depend on the exact use case. This

Re: [FFmpeg-devel] [PATCH] lavc: deprecate AV_CODEC_FLAG_DROPCHANGED

2023-07-12 Thread James Almer
On 7/9/2023 9:57 AM, Anton Khirnov wrote: This decoding flag makes decoders drop all frames after a parameter change, but what exactly constitutes a parameter change is not well defined and will typically depend on the exact use case. This functionality then does not belong in libavcodec, but

[FFmpeg-devel] [PATCH] libavcodec/amfenc: Fix issue with missing headers in AV1 encoder

2023-07-12 Thread Evgeny Pavlov
This commit fixes issue with missing SPS/PPS headers in video encoded by AMF AV1 encoder. Missing headers leads to broken seek in MPV video player. Default value for property AV1_HEADER_INSERTION_MODE shouldn't be setup to NONE (no headers insertion). We need to skip definition of this

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: move each muxer to a separate thread

2023-07-12 Thread Nicolas George
Anton Khirnov (12022-07-23): > ffmpeg | branch: master | Anton Khirnov | Thu Mar 31 > 17:33:48 2022 +0200| [2d924b3a630869c65fe0c76568910500f54ed057] | committer: > Anton Khirnov > > fftools/ffmpeg: move each muxer to a separate thread > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: don't discard the buffered packet if the underlying bsf can't take it

2023-07-12 Thread James Almer
On 7/12/2023 6:08 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-12 04:06:44) Signed-off-by: James Almer --- libavcodec/decode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 239ad70b41..cd49cca7c2 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: don't reject flush packets when buffer_pkt is not empty

2023-07-12 Thread James Almer
On 7/12/2023 6:06 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-12 04:06:43) Restores the behavior pre commit a92dbeb9ae. Signed-off-by: James Almer Do you see any advantage to this? Not returning an error when a flush packet is feed to the decoder. Why would the API force me to

Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding

2023-07-12 Thread Wu, Tong1
>On Vr, 2023-06-02 at 16:06 +0800, Tong Wu wrote: >> From: Wu Jianhua >> >> The implementation is based on: >> https://learn.microsoft.com/en-us/windows/win32/medfound/direct3d-12- >video-overview >> >> With the Direct3D 12 video decoding support, we can render or process >> the decoded images by

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: don't discard the buffered packet if the underlying bsf can't take it

2023-07-12 Thread Anton Khirnov
Quoting James Almer (2023-07-12 04:06:44) > Signed-off-by: James Almer > --- > libavcodec/decode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 239ad70b41..cd49cca7c2 100644 > --- a/libavcodec/decode.c > +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: don't reject flush packets when buffer_pkt is not empty

2023-07-12 Thread Anton Khirnov
Quoting James Almer (2023-07-12 04:06:43) > Restores the behavior pre commit a92dbeb9ae. > > Signed-off-by: James Almer Do you see any advantage to this? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org