Adds a fate test for the jpegxl_anim demuxer, that should allow testing
for true positives and false positives for animated jpegxl files. Note
that two of the test cases are not animated, in order to help sort out
false positives.
Signed-off-by: Leo Izen
---
tests/Makefile
This prevents code duplication in the source form by calling the parse
code that was moved to avcodec last commit. The code will be duplicated
in binary form for shared builds (it's not that large), but for source
code it will only exist in one location now.
Signed-off-by: Leo Izen
---
Add a parser to libavcodec for AV_CODEC_ID_JPEGXL. It doesn't find the
end of the stream in order to packetize the codec, but it does look at
the headers to set preliminary information like dimensions and pixel
format.
Note that much of this code is duplicated from avformat/jpegxl_probe.c,
but
Before this commit, the decoder erroneously assumes that the AVFrame
passed to the receive_frame is the same one each time. Now it keeps an
internal AVFrame to write into, and copies it over when it's done.
Signed-off-by: Leo Izen
---
libavcodec/libjxldec.c | 37
Fixes an error that's caused by decoding a grayscale JXL image after an
RGB image is decoded, with the same decoder instance.
Signed-off-by: Leo Izen
---
libavcodec/libjxldec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libjxldec.c
Changes from v6:
- Added dummy stub libavformat/jpegxl_parse.c to fix shared builds
Changes from v5:
- Attached an extra commit to fix existing bug with libjxldec
- Made various changes based on comments by Andreas Reinhardt
-- removed jpegxl_parse.c from avformat, and jpegxl_parse.o from
Leo Izen:
> On 8/1/23 14:59, Michael Niedermayer wrote:
>> On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote:
>>> This prevents code duplication in the source form by calling the parse
>>> code that was moved to avcodec last commit. The code will be duplicated
>>> in binary form for shared
> On Aug 2, 2023, at 7:30 AM, Nicolas George wrote:
>
> Michael Niedermayer (12023-08-02):
>> The libraries should be split into runtime loadable plugins
>> Not only would that make tools alot smaller it also would allow
>> development of code available in ffmpeg that is maintained outside
>>
In general, unless a listserv, such as ffmpeg's, requires it, I only
send HTML email. Please do not request plaintext personal email from me
without a very good reason to do so. I do this as very few free software
folks of any competence in our community insist on it. HTML email:
*
On Wed, Aug 02, 2023 at 03:14:10PM +0300, kobrineli wrote:
> From: Eli Kobrin
>
> We've been fuzzing torchvision with
> [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
> and found out of bounds error in ffmpeg project at audioconvert.c:151.
> To prevent error we need to fix checks for in
Anton Khirnov:
> Quoting Andreas Rheinhardt (2023-07-11 03:10:38)
>> This allows to avoid exposing AVCodecInternal to files that
>> don't need it and only include internal.h for something else
>> (like the avpriv functions which are of course included outside
>> of libavcodec where AVCodecInternal
On 8/1/23 14:59, Michael Niedermayer wrote:
On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote:
This prevents code duplication in the source form by calling the parse
code that was moved to avcodec last commit. The code will be duplicated
in binary form for shared builds (it's not that
On Wed, 2 Aug 2023, at 16:20, Michael Niedermayer wrote:
> There are multiple problems but the real problem is that
> How many people discuss an SDR API ? (0)
> How many people propose an SDR API ? (0)
Did you ask people to do that?
> How many people say what they want an SDR API to be able to
Alexandre Heitor Schmidt (12023-08-01):
> doc/demuxers.texi: Documented how to use the new parameter.
>
> Usage example:
>
> ffmpeg -i /dev/video0 -strftime 1 -strftime_mkdir 1
> "/tmp/%Y/%m/%Y_%m_%d-%H_%M_%S.jpg"
> ---
> doc/muxers.texi | 13 +
> libavformat/img2enc.c | 28
Michael Niedermayer (12023-08-02):
> The libraries should be split into runtime loadable plugins
> Not only would that make tools alot smaller it also would allow
> development of code available in ffmpeg that is maintained outside
> FFmpeg.
>
> I suggested this previosuly, it is of course not a
On Wed, Aug 02, 2023 at 09:12:14AM -0500, Brad Isbell wrote:
> As a frequent FFmpeg user, and an occasional RTL-SDR user, the major
> tradeoff for me is in the size of FFmpeg binaries vs. features. I
> agree with Jean-Baptiste that if this were an optional library to be
> added to the build, then
On Wed, Aug 02, 2023 at 02:59:11PM +0200, Jean-Baptiste Kempf wrote:
> On Wed, 2 Aug 2023, at 14:55, Michael Niedermayer wrote:
> > the code already is in a seperate repository. And is basically isolated
> > in a single demuxer and single input device.
>
> But it's not a library in that
Brad Isbell (12023-08-02):
> As a frequent FFmpeg user, and an occasional RTL-SDR user, the major
> tradeoff for me is in the size of FFmpeg binaries vs. features. I
> agree with Jean-Baptiste that if this were an optional library to be
> added to the build, then that resolves any issues I might
As a frequent FFmpeg user, and an occasional RTL-SDR user, the major
tradeoff for me is in the size of FFmpeg binaries vs. features. I
agree with Jean-Baptiste that if this were an optional library to be
added to the build, then that resolves any issues I might have as a
user.
Then I have the
On Wed, Aug 02, 2023 at 03:00:54PM +0200, Paul B Mahol wrote:
> On Wed, Aug 2, 2023 at 2:47 PM Michael Niedermayer
> wrote:
>
> > On Tue, Aug 01, 2023 at 10:06:19PM +0200, Paul B Mahol wrote:
> > > On Tue, Aug 1, 2023 at 9:51 PM Cosmin Stejerean
> > wrote:
> > >
> > > > On Jul 27, 2023, at
On Wed, 2 Aug 2023, at 14:55, Michael Niedermayer wrote:
> the code already is in a seperate repository. And is basically isolated
> in a single demuxer and single input device.
But it's not a library in that repository, like swscale, swresample or similar
libraries.
If it was, with an API, it
Hi Vittorio
On Wed, Aug 02, 2023 at 03:44:13AM +0200, Vittorio Giovara wrote:
> On Sun, Jul 30, 2023 at 3:04 PM Nicolas George wrote:
>
> > Kieran Kunhya (12023-07-28):
> > > FFmpeg doesn't implement TCP in userspace, it doesn't implement the
> > > WiFi protocol etc etc. Different layers are
Signed-off-by: Andreas Rheinhardt
---
libavcodec/svq1enc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
index 4651e01ae8..5e7f410214 100644
--- a/libavcodec/svq1enc.c
+++ b/libavcodec/svq1enc.c
@@ -118,7 +118,7 @@ static void
Namely proresenc_anatoliy.c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/internal.h | 12 --
libavcodec/proresenc_anatoliy.c | 39 +
libavcodec/utils.c | 19
3 files changed, 35 insertions(+), 35 deletions(-)
Namely h264_slice.c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h264_slice.c | 34 +-
libavcodec/internal.h | 2 --
libavcodec/utils.c | 28
3 files changed, 29 insertions(+), 35 deletions(-)
diff --git
On Wed, Aug 2, 2023 at 2:47 PM Michael Niedermayer
wrote:
> On Tue, Aug 01, 2023 at 10:06:19PM +0200, Paul B Mahol wrote:
> > On Tue, Aug 1, 2023 at 9:51 PM Cosmin Stejerean
> wrote:
> >
> > > On Jul 27, 2023, at 11:36 AM, Michael Niedermayer <
> mich...@niedermayer.cc>
> > > wrote:
> > >
> > >
Signed-off-by: Andreas Rheinhardt
---
libavcodec/avcodec.c | 7 +++
libavcodec/internal.h | 7 ---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
index 340abe830e..0700a53b5c 100644
--- a/libavcodec/avcodec.c
+++
On Tue, Aug 01, 2023 at 10:06:19PM +0200, Paul B Mahol wrote:
> On Tue, Aug 1, 2023 at 9:51 PM Cosmin Stejerean wrote:
>
> > On Jul 27, 2023, at 11:36 AM, Michael Niedermayer
> > wrote:
> >
> > Let me first explain what i want to provide to the user (most of this
> > is already implemented,
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Resubmitted, thanks
On 2023-08-02 15:06, Ronald S. Bultje wrote:
Hi,
On Wed, Aug 2, 2023 at 7:31 AM kobrineli wrote:
From: Eli Kobrin
We've been fuzzing torchvision with [sydr-fuzz](
https://github.com/ispras/oss-sydr-fuzz)
and found out of bounds error in ffmpeg project at
From: Eli Kobrin
We've been fuzzing torchvision with
[sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
and found out of bounds error in ffmpeg project at audioconvert.c:151.
To prevent error we need to fix checks for in and out fmt in swr_init.
Signed-off-by: Eli Kobrin
---
Hi,
On Wed, Aug 2, 2023 at 7:31 AM kobrineli wrote:
> From: Eli Kobrin
>
> We've been fuzzing torchvision with [sydr-fuzz](
> https://github.com/ispras/oss-sydr-fuzz)
> and found out of bounds error in ffmpeg project at audioconvert.c:51.
> To prevent error we need to insert corresponding
Resubmitted the patch
(https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802113106.1138555-1-kobrin...@ispras.ru/).
Didn't understand how to fix the existing patch.
On 2023-08-02 13:51, Andreas Rheinhardt wrote:
kobrineli:
From: Eli Kobrin
We've been fuzzing torchvision with
From: Eli Kobrin
We've been fuzzing torchvision with
[sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
and found out of bounds error in ffmpeg project at audioconvert.c:51.
To prevent error we need to insert corresponding check and fix checks
for in and out fmt in swr_init.
Signed-off-by:
I've found out that `in_fmt` is equal to -1 at the place of error, so we
just need to insert check at the beginning of `swr_init` function to
check fmts positivity.
On 2023-08-02 13:51, Andreas Rheinhardt wrote:
kobrineli:
From: Eli Kobrin
We've been fuzzing torchvision with
Invalid out or int fmts are got from the user input, which was
discovered through fuzzing. Don't know where to add check at the time of
SwrContext creating, but I think this change is redundant to at least
prevent dangerous out of bounds access, which set the pointer to illegal
address.
On
It only needs codec_id.h.
Signed-off-by: Andreas Rheinhardt
---
libavdevice/pulse_audio_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavdevice/pulse_audio_common.h b/libavdevice/pulse_audio_common.h
index 902795e4f7..9def3cb796 100644
---
This avoids including lavc/codec_desc.h everywhere and thereby
forces users to include it directly instead of lazily and potentially
unknowingly relying on indirect inclusions.
Also add the proper inclusion to libavformat/demux.c, one of the
two files that actually use the new field.
Most of the inline functions in h264dec.h are only used
by h264_cavlc.c and h264_cabac.c. Therefore move them
to the common header for these two, namely h264_mvpred.h.
Signed-off-by: Andreas Rheinhardt
---
Does someone have a better name than h264_mvpred.h for the destination?
Signed-off-by: Andreas Rheinhardt
---
libavformat/evcdec.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 6cce174f46..5ace604db6 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/evcdec.c
@@ -20,15 +20,11 @@
* Foundation, Inc., 51
Possible since 60ecf44b037c7961ac4e69f83ff315c11c5df922.
Signed-off-by: Andreas Rheinhardt
---
libavformat/av1dec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c
index d0d53f41f7..2883b320a1 100644
--- a/libavformat/av1dec.c
+++
Avoids implicit inclusions of avcodec.h in lavf/takdec.c
and lavc/tak.c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/tak.c | 4 ++--
libavcodec/tak.h | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavcodec/tak.c b/libavcodec/tak.c
index 99678e9887..91feac5451
h264_sei.h is no longer used since the SEIs were moved to sei.h;
this also avoids inclusions of avcodec.h and bytestream.h.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h264_metadata_bsf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_metadata_bsf.c
Possible since 2850584876e52beaddf7a9f30e9914dad7115618.
Signed-off-by: Andreas Rheinhardt
---
libavformat/rawdec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c
index 6b623d366e..1dd7fafcf0 100644
--- a/libavformat/rawdec.c
+++
Don't include them implicitly via avcodec.h. This avoids
indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c,
and lavf/rtp(dec|enc)_vc2hq.c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dirac.c | 3 +++
libavcodec/dirac.h | 6 +-
2 files changed, 8 insertions(+), 1
This would only be necessary if this header declared a function
that takes a (pointer to) struct AVCodecContext as parameter.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/avcodec.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index
kobrineli:
> From: Eli Kobrin
>
> We've been fuzzing torchvision with
> [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
> and found out of bounds error in ffmpeg project at audioconvert.c:51.
> To prevent error we need to insert corresponding check.
>
> Signed-off-by: Eli Kobrin
> ---
>
From: Eli Kobrin
We've been fuzzing torchvision with
[sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
and found out of bounds error in ffmpeg project at audioconvert.c:51.
To prevent error we need to insert corresponding check.
Signed-off-by: Eli Kobrin
---
libswresample/audioconvert.c |
In WinRT mode, we use CreateThread instead of _beginthreadex.
CreateThread takes a LPTHREAD_START_ROUTINE function pointer,
which has got the signature DWORD WINAPI ThreadProc(LPVOID).
_beginthreadex takes a function with the signature
unsigned __stdcall func(void *).
DWORD is defined as an
This fixes the test when running in a cross test setup where the
samples are located at a different path between build host and
temote test target.
---
tests/fate/hlsenc.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak
index
While MSVC proper doesn't have a way to signal potential aliasing
corresponding to __attribute__((may_alias)) (which is what
av_alias expands to, if supported), Clang does support it.
When building with Clang in MSVC mode, __GNUC__ isn't defined but
_MSC_VER is, so Clang uses the MSVC
This commit is the AVHWAccel analogue of commit
20f972701806be20a77f808db332d9489343bb78: It moves the private fields
of AVHWAccel to a new struct FFHWAccel extending AVHWAccel
in an internal header (namely hwaccel_internal.h).
Signed-off-by: Andreas Rheinhardt
---
I wonder whether I should make
All usages of ff_hwaccel_frame_priv_alloc() have the same pattern:
Check for whether a hwaccel is in use; check whether it needs
private frame-specific data; allocate the AVBuffer and set
it.
This commit modifies ff_hwaccel_frame_priv_alloc() to perform
this task on its own.
(It also seems that
libavcodec/hwconfig.h currently contains HWACCEL_CAP_* flags
as well as the definition of AVCodecHWConfigInternal and some
macros to create them.
The users of these two are nearly disjoint: The flags are used
by files providing AVHWAccels whereas AVCodecHWConfigInternal
is used by files providing
Having a decode_slice callback is mandatory for HWAccels;
the only exception to this (and the reason why these checks
were added) was XvMC, but it is no more since commit
be95df12bb06b183c8d2aea3b0831fdf05466cf3.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/error_resilience.c | 4 ++--
The discrepancy between the actual definition and the declarations
in hwaccels.h is actually UB.
Signed-off-by: Andreas Rheinhardt
---
Resending patches 1-3 because the last patch depends upon it.
libavcodec/nvdec_mjpeg.c | 2 +-
libavcodec/nvdec_vp8.c | 2 +-
2 files changed, 2
56 matches
Mail list logo
