Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000htdec: Consolidate jpeg2000 spec bits in jpeg2000_bitbuf_refill_backwards()

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > Code should make more sense now > > Fixes: out of array access > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6627570448465920 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > This also fixes assertion failures > > Fixes: shift exponent 95 is too large for 64-bit type 'unsigned long long' > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5828618092937216 > > Found-by:

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-04 Thread Kieran Kunhya
On Fri, 4 Aug 2023, 13:35 Nicolas George, wrote: > Michael Niedermayer (12023-08-04): > > Everything is there for a reason. > > Every part of mp4 has a use, still we extract the data and setup various > > structs like AVStream, AVPacket, AVProgram and so on. > > We do not return raw mp4/mov

[FFmpeg-devel] [PATCH 2/2] wmavoice: convert DCT-I/DST-I to lavu/tx

2023-08-04 Thread Lynne
This is the very last user of any lavc transform code. This also *corrects* wmavoice decoding, as the previous DCT/DST transforms were incorrect, bringing it closer to Microsoft's own wmavoice decoder. Note: this requires new FATE files, or for the tests to be modified to use a target error.

[FFmpeg-devel] [PATCH 1/2] wmavoice: convert RDFT to lavu/tx

2023-08-04 Thread Lynne
Patch attached. >From a5b6b7d954447d4cc07377f00370a0781e5056b3 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 4 Aug 2023 20:20:10 +0200 Subject: [PATCH 1/2] wmavoice: convert RDFT to lavu/tx --- libavcodec/wmavoice.c | 75 ++- 1 file changed, 45

Re: [FFmpeg-devel] [RFC][PATCH] libwebp: combine libwebp_anim and libwebp encoders into one

2023-08-04 Thread Cosmin Stejerean
On May 24, 2015 at 04:49PM, Michael Niedermayer wrote: > On Sun, May 24, 2015 at 06:39:05PM -0300, James Almer wrote: > > On 24/05/15 5:59 PM, Michael Niedermayer wrote: > > > On Sun, May 24, 2015 at 04:22:42PM -0300, James Almer wrote: > > >> Use either the WebPEncoder or WebPAnimEncoder APIs

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-04 Thread Nicolas George
Michael Niedermayer (12023-08-04): > Everything is there for a reason. > Every part of mp4 has a use, still we extract the data and setup various > structs like AVStream, AVPacket, AVProgram and so on. > We do not return raw mp4/mov atoms > the seperation between programs in a stream of bits/bytes

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-08-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > asivery: >> Signed-off-by: asivery >> --- >> libavformat/matroska.c | 1 + >> libavformat/matroskadec.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/libavformat/matroska.c b/libavformat/matroska.c >> index 90d94b65bf..37305a523c 100644 >> ---

Re: [FFmpeg-devel] [PATCH v5 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-04 Thread Lynne
Aug 4, 2023, 15:50 by tong1.wu-at-intel@ffmpeg.org: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > Signed-off-by: Tong Wu > --- > configure | 5 + > doc/APIchanges | 7 + > libavutil/Makefile | 3 + >

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2023-08-04 Thread Andreas Rheinhardt
asivery: > Signed-off-by: asivery > --- > libavformat/matroska.c | 1 + > libavformat/matroskadec.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index 90d94b65bf..37305a523c 100644 > --- a/libavformat/matroska.c > +++

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-04 Thread Michael Niedermayer
On Thu, Aug 03, 2023 at 04:04:23PM -0400, Kieran Kunhya wrote: > On Thu, 3 Aug 2023, 15:25 Michael Niedermayer, > wrote: > > > On Thu, Aug 03, 2023 at 02:24:04PM -0400, Kieran Kunhya wrote: > > > > > > > > > > > > There are 2 things DAB and DVB both use mpeg ts > > > > > > > > > > DAB does not

[FFmpeg-devel] [PATCH v5 8/9] Changelog: D3D12VA hardware accelerated H264, HEVC, VP9, AV1, MPEG-2 and VC1 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index bbda4f4fd4..5b21103b29 100644 --- a/Changelog +++ b/Changelog @@ -27,6 +27,7 @@ version : - Bitstream filter for converting VVC from

[FFmpeg-devel] [PATCH v5 7/9] avcodec: add D3D12VA hardware accelerated VC1 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 3 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vc1.c| 214

[FFmpeg-devel] [PATCH v5 9/9] avcodec/d3d12va_hevc: enable allow_profile_mismatch flag for d3d12va msp profile

2023-08-04 Thread Tong Wu
Same as d3d11va, this flag enables main still picture profile for d3d12va. User should add this flag when decoding main still picture profile. Signed-off-by: Tong Wu --- libavcodec/d3d12va_hevc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH v5 6/9] avcodec: add D3D12VA hardware accelerated MPEG-2 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_mpeg2.c | 191

[FFmpeg-devel] [PATCH v5 5/9] avcodec: add D3D12VA hardware accelerated AV1 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/av1dec.c | 10 ++

[FFmpeg-devel] [PATCH v5 4/9] avcodec: add D3D12VA hardware accelerated VP9 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_vp9.c| 176

[FFmpeg-devel] [PATCH v5 3/9] avcodec: add D3D12VA hardware accelerated HEVC decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The command below is how to enable d3d12va: ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 2 + libavcodec/Makefile | 1 + libavcodec/d3d12va_hevc.c | 211

[FFmpeg-devel] [PATCH v5 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding

2023-08-04 Thread Tong Wu
From: Wu Jianhua The implementation is based on: https://learn.microsoft.com/en-us/windows/win32/medfound/direct3d-12-video-overview With the Direct3D 12 video decoding support, we can render or process the decoded images by the pixel shaders or compute shaders directly without the extra copy

[FFmpeg-devel] [PATCH v5 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-04 Thread Tong Wu
From: Wu Jianhua Signed-off-by: Wu Jianhua Signed-off-by: Tong Wu --- configure | 5 + doc/APIchanges | 7 + libavutil/Makefile | 3 + libavutil/hwcontext.c | 4 + libavutil/hwcontext.h

Re: [FFmpeg-devel] [PATCH] os_support, network: Fix build failure on Windows with BZIP2

2023-08-04 Thread Martin Storsjö
On Fri, 4 Aug 2023, Martin Storsjö wrote: On Thu, 27 Jul 2023, L. E. Segovia wrote: Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h (included transitively from windows.h). See:

Re: [FFmpeg-devel] [PATCH] os_support, network: Fix build failure on Windows with BZIP2

2023-08-04 Thread Martin Storsjö
On Thu, 27 Jul 2023, L. E. Segovia wrote: Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h (included transitively from windows.h). See: https://stackoverflow.com/a/27794577 Signed-off-by: L. E. Segovia

Re: [FFmpeg-devel] [PATCH] w32pthreads: Fix function signature mismatches for CreateThread

2023-08-04 Thread Martin Storsjö
On Wed, 2 Aug 2023, Martin Storsjö wrote: In WinRT mode, we use CreateThread instead of _beginthreadex. CreateThread takes a LPTHREAD_START_ROUTINE function pointer, which has got the signature DWORD WINAPI ThreadProc(LPVOID). _beginthreadex takes a function with the signature unsigned

Re: [FFmpeg-devel] [PATCH] tests: Correctly distinguish between SAMPLES and TARGET_SAMPLES for hls_fmp4_ac3.m3u8

2023-08-04 Thread Martin Storsjö
On Wed, 2 Aug 2023, Martin Storsjö wrote: This fixes the test when running in a cross test setup where the samples are located at a different path between build host and temote test target. --- tests/fate/hlsenc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2] intreadwrite: Indicate potential aliasing in AV_RN/AV_WN for Clang/MSVC mode

2023-08-04 Thread Martin Storsjö
Use the GCC specific codepath for Clang in MSVC mode too. This matches the condition used in a number of other places. MSVC doesn't have a way to signal potential aliasing, while GCC (and Clang) can use __attribute__((may_alias)) for this purpose. When building with Clang in MSVC mode, __GNUC__

Re: [FFmpeg-devel] [PATCH v4 0/4] Add passthrough support for SCTE-35

2023-08-04 Thread Devin Heitmueller
On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller wrote: > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field > in SCTE_35 packets, such that a user can transparently pass through > SCTE-35 streams when both the input and output are MPEG-TS. > > This patch series updated to

Re: [FFmpeg-devel] [PATCH] Replace br return with ret

2023-08-04 Thread Martin Storsjö
On Thu, 27 Jul 2023, Rémi Denis-Courmont wrote: Hi, The use of RET vs BR also has microarchitectural side effects. AFAIU, RET should always be paired with an earlier BL/BLR to avoid interfering with branch prediction. So depending on the circumstances, either one of these should be

Re: [FFmpeg-devel] [PATCH 06/15] avcodec/avcodec: Remove unnecessary forward declaration

2023-08-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This would only be necessary if this header declared a function > that takes a (pointer to) struct AVCodecContext as parameter. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avcodec.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v6 1/3] tests/fate/flvenc: add hevc in enhanced flv test case

2023-08-04 Thread Steven Liu
Steven Liu 于2023年7月24日周一 17:20写道: > > Signed-off-by: Steven Liu > --- > tests/fate/flvenc.mak| 7 +- > tests/ref/fate/enhanced-flv-hevc | 258 +++ > 2 files changed, 264 insertions(+), 1 deletion(-) > create mode 100644 tests/ref/fate/enhanced-flv-hevc

Re: [FFmpeg-devel] [PATCH] Replace br return with ret

2023-08-04 Thread Casey Smalley
Hi, Just wondering what current thoughts on the patch was. It looks as though the change is fine, but if there is still an issue I can submit a new patch using BTI landing pads instead. Best regards, Casey. On 7/27/23 18:22, Reimar Döffinger wrote: On 27 Jul 2023, at 15:55, Rémi

Re: [FFmpeg-devel] [PATCH v4 1/9] libavutil: add hwcontext_d3d12va and AV_PIX_FMT_D3D12

2023-08-04 Thread Xiang, Haihao
On Wo, 2023-07-19 at 18:01 +0800, Tong Wu wrote: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > Signed-off-by: Tong Wu > --- >  configure  |   5 + >  doc/APIchanges |   7 + >  libavutil/Makefile |   3 + >