Re: [FFmpeg-devel] [PATCH v2] avcodec/on2avc: use correct fft sizes

2023-08-06 Thread Lynne
Aug 6, 2023, 21:45 by c...@passwd.hu: > Also rename the contexts and the functions so their names will reflect their > intended size. > > With the earlier patch this fixes the audio corruption regression caused by > 6ba0aa1770ba29eb4126c6a706f6b0cd3809648f. > > Fixes ticket #10029. > >

Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame

2023-08-06 Thread Xiang, Haihao
On So, 2023-08-06 at 19:54 +0800, Ting Hu wrote: > From: tinghu3 > > In order to save bandwith for video conference application, > set pic_timing_sei of av_option to disable SEI frames. > It doesn't take effect. > > Signed-off-by: tinghu3 > --- >  libavcodec/qsvenc.c | 3 ++- >  1 file changed,

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Add filler_data option

2023-08-06 Thread Xiang, Haihao
On Sa, 2023-08-05 at 14:06 +0200, David Rosca wrote: > --- >  libavcodec/vaapi_encode.c | 1 + >  libavcodec/vaapi_encode.h | 9 - >  2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > index bfca315a7a..f161c76304 100644

Re: [FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly

2023-08-06 Thread Michael Niedermayer
On Mon, Aug 07, 2023 at 02:49:03AM +0200, Michael Niedermayer wrote: > From: Andreas Rheinhardt > > Don't include them implicitly via avcodec.h. This avoids > indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c, > and lavf/rtp(dec|enc)_vc2hq.c. > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 5/5] avcodec/wavarc: Check that nb_samples is not negative

2023-08-06 Thread Michael Niedermayer
It is currently probably not possible for it to be negative as the needed 2Mb input buf size is not achievable. But it is more robust to check for it too. If it would become negative than code like s->samples[0][n] = s->samples[0][s->nb_samples + n]; would crash Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 4/5] avcodec/wavarc: Check shift

2023-08-06 Thread Michael Niedermayer
Fixes: shift exponent 1285 is too large for 32-bit type 'int' Fixes: 60870/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5332050340347904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 3/5] avcodec/xvididct: Fix integer overflow in idct_row()

2023-08-06 Thread Michael Niedermayer
Fixes: signed integer overflow: -1403461578 + -843974775 cannot be represented in type 'int' Fixes: 60868/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-4599793035378688 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 2/5] avcodec/mv30: Check the input length before allocation

2023-08-06 Thread Michael Niedermayer
Fixes: Timeout Fixes: 60867/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-6381933108527104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mv30.c | 5 + 1 file changed, 5

[FFmpeg-devel] [PATCH 1/5] avcodec/mv30: Allocate frame later

2023-08-06 Thread Michael Niedermayer
This way we can check the input before allocation in the next commit Signed-off-by: Michael Niedermayer --- libavcodec/mv30.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c index c2d0547053..0b19534b00 100644 ---

[FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly

2023-08-06 Thread Michael Niedermayer
From: Andreas Rheinhardt Don't include them implicitly via avcodec.h. This avoids indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c, and lavf/rtp(dec|enc)_vc2hq.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/dirac.c | 3 +++ libavcodec/dirac.h | 6 +- 2 files

[FFmpeg-devel] [PATCH 4/5] avformat/matroskaenc: Don't pretend to support unsupported codecs

2023-08-06 Thread Andreas Rheinhardt
RV10 and RV20 are unsupported because creating the correct CodecPrivate is unsupported (the demuxer uses a codecpriv_offset of 26, so one would need to recreate the missing 26 bytes); COOK and SIPR are unsupported, because Matroska uses a packetization mode that is different from what FFmpeg uses

[FFmpeg-devel] [PATCH 5/5] avformat/matroskaenc: Don't pretend to be able to mux RV30

2023-08-06 Thread Andreas Rheinhardt
The demuxer uses a extradata offset of 26, so we would need to recreate the missing 26 bytes somehow in the muxer, but we just don't. Remuxed files (like real/rv30.rm from the FATE-suite) don't work due to missing extradata. (The extradata offset also applies to RV40 and the extradata is indeed

[FFmpeg-devel] [PATCH 3/5] fate/matroska: Add ALAC remux test

2023-08-06 Thread Andreas Rheinhardt
Provides coverage for the code transforming the ALAC extradata. Signed-off-by: Andreas Rheinhardt --- tests/fate/matroska.mak| 4 + tests/ref/fate/matroska-alac-remux | 136 + 2 files changed, 140 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 2/5] avformat/matroskaenc: Don't reserve unnecessarily many EBML elements

2023-08-06 Thread Andreas Rheinhardt
bda44f0f39e8ee646e54f15989d7845f4bf58d26 added code that potentially added another BlockMore master and BlockAdditional data as well as BlockAddID number, yet it bumped the number of EBML elements by four instead of only three. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 2

[FFmpeg-devel] [PATCH 1/5] avformat/matroskaenc: Support rotations

2023-08-06 Thread Andreas Rheinhardt
Matroska supports orthogonal transformations (both pure rotations as well as reflections) via its 3D-projection elements, namely ProjectionPoseYaw (for a horizontal reflection) as well as ProjectionPoseRoll (for rotations). This commit adds support for this. Support for this in the demuxer has

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-06 Thread Michael Niedermayer
Hi Vittorio On Sun, Aug 06, 2023 at 01:32:30AM +0200, Vittorio Giovara wrote: > On Sat, Aug 5, 2023 at 8:55 PM Michael Niedermayer > wrote: > > > Hi > > > > replying to the other question too > > > > On Wed, Aug 02, 2023 at 04:44:14PM +0200, Jean-Baptiste Kempf wrote: > > > On Wed, 2 Aug 2023,

[FFmpeg-devel] [PATCH v2] avcodec/on2avc: use correct fft sizes

2023-08-06 Thread Marton Balint
Also rename the contexts and the functions so their names will reflect their intended size. With the earlier patch this fixes the audio corruption regression caused by 6ba0aa1770ba29eb4126c6a706f6b0cd3809648f. Fixes ticket #10029. Signed-off-by: Marton Balint --- libavcodec/on2avc.c | 32

Re: [FFmpeg-devel] [PATCH] avcodec/on2avc: use correct fft sizes

2023-08-06 Thread Lynne
Aug 6, 2023, 14:42 by c...@passwd.hu: > With the earlier patch this fixes the audio corruption regression caused by > 6ba0aa1770ba29eb4126c6a706f6b0cd3809648f. > > Fixes ticket #10029. > > Signed-off-by: Marton Balint > --- > libavcodec/on2avc.c | 8 > 1 file changed, 4 insertions(+),

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-06 Thread Pierre-Anthony Lemieux
On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer wrote: > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer > > wrote: > > > > > > This also fixes assertion failures > > > > > > Fixes: shift exponent 95 is too large

Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/flac_picture: Add ff_flac_write_picture

2023-08-06 Thread Zsolt Vadász
Hi, it's been a while, can I get a review on this patch set? It would close https://trac.ffmpeg.org/ticket/4448. Thanks in advance! Zsolt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH] fftools/ffprobe: Use proper enum type

2023-08-06 Thread Andreas Rheinhardt
This is a bit cleaner as int need not be the underlying type of an enum if a smaller type can hold all its values. Also declare the children_ids array as const as it never changes. Signed-off-by: Andreas Rheinhardt --- fftools/ffprobe.c | 38 ++ 1 file

[FFmpeg-devel] [PATCH] avcodec/on2avc: use correct fft sizes

2023-08-06 Thread Marton Balint
With the earlier patch this fixes the audio corruption regression caused by 6ba0aa1770ba29eb4126c6a706f6b0cd3809648f. Fixes ticket #10029. Signed-off-by: Marton Balint --- libavcodec/on2avc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/on2avc.c

[FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame

2023-08-06 Thread Ting Hu
From: tinghu3 In order to save bandwith for video conference application, set pic_timing_sei of av_option to disable SEI frames. It doesn't take effect. Signed-off-by: tinghu3 --- libavcodec/qsvenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c

[FFmpeg-devel] [PATCH 7/7] avcodec/amfenc: Fix declaration-after-statement warning

2023-08-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/amfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index cb48f8c273..518b8396e7 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -720,10 +720,10 @@ int

[FFmpeg-devel] [PATCH 6/7] avutil/tests/channel_layout: Test av_channel_layout_copy()

2023-08-06 Thread Andreas Rheinhardt
Specifically, test copying a channel layout with custom order, so that the allocation codepath of av_channel_layout_copy() is executed. Signed-off-by: Andreas Rheinhardt --- libavutil/tests/channel_layout.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 5/7] avutil/tests/channel_layout: Don't include lavu/channel_layout.c

2023-08-06 Thread Andreas Rheinhardt
This test does not need access to the internals of said compilation unit. Signed-off-by: Andreas Rheinhardt --- libavutil/tests/channel_layout.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavutil/tests/channel_layout.c b/libavutil/tests/channel_layout.c index

[FFmpeg-devel] [PATCH 4/7] avutil/tests/channel_layout: Also test non-AVBPrint variants

2023-08-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/tests/channel_layout.c | 108 +-- 1 file changed, 90 insertions(+), 18 deletions(-) diff --git a/libavutil/tests/channel_layout.c b/libavutil/tests/channel_layout.c index 5516db0904..665ae6e277 100644 ---

[FFmpeg-devel] [PATCH 3/7] avutil/channel_layout: Account for \0 in sizes

2023-08-06 Thread Andreas Rheinhardt
av_channel_name(), av_channel_description() and av_channel_layout_describe() are supposed to return the size of the needed buffer to allow the user to check for truncation; the documentation ("If the returned value is bigger than buf_size, then the string was truncated.") confirms that size does

[FFmpeg-devel] [PATCH 2/7] avutil/bprint: Allow size == 0 in av_bprint_init_for_buffer()

2023-08-06 Thread Andreas Rheinhardt
The AVBPrint API guarantees that the string buffer is always zero-terminated; in order to honour this guarantee, there obviously must be a string buffer at all and it must have a size >= 1. Therefore av_bprint_init_for_buffer() treats passing a NULL buffer or size == 0 as invalid data that leads

[FFmpeg-devel] [PATCH 1/7] avutil/bprint: Don't use value of AV_BPRINT_SIZE_AUTOMATIC directly

2023-08-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/bprint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/bprint.c b/libavutil/bprint.c index 5b540ebc9e..23998a8b02 100644 --- a/libavutil/bprint.c +++ b/libavutil/bprint.c @@ -71,7 +71,7 @@ void

Re: [FFmpeg-devel] What is FFmpeg and what should it be

2023-08-06 Thread Tomas Härdin
sön 2023-08-06 klockan 01:32 +0200 skrev Vittorio Giovara: > On Sat, Aug 5, 2023 at 8:55 PM Michael Niedermayer > > wrote: > > > Hi > > > > replying to the other question too > > > > On Wed, Aug 02, 2023 at 04:44:14PM +0200, Jean-Baptiste Kempf > > wrote: > > > On Wed, 2 Aug 2023, at 16:20,