Re: [FFmpeg-devel] [MPlayer-dev-eng] FFmpeg/MPlayer/rtmpdump possibly searching for a new server and hosting

note, to make this clear there will be no ffmpeg.org or mplayerhq.hu soon if noone helps we need a server we need volunteers to help with the move Is there anything you can share about what the current bandwidth requirements are? It might make it easier to assess whether it's feasible to host

[FFmpeg-devel] [PATCH 0/1] Add ETC1 encoder/decoder

fixes to compile in C90 mode (cases where variables were being declared in-line with code). Devin Heitmueller (1): Add support for Ericsson Texture Compression 1 (ETC1) libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7

[FFmpeg-devel] [PATCH 1/1] Add support for Ericsson Texture Compression 1 (ETC1)

This patch adds support for encoding/decoding ETC1 compressed textures. This includes support for the PKM file format. Example usage: ./ffmpeg -i input_image.jpg new.pkm ./ffmpeg -i new.pkm foo.jpg Signed-off-by: Devin Heitmueller <dheitmuel...@kernellabs.com> --- libavcodec/Ma

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

Hello Marton, On Tue, Jun 6, 2017 at 5:45 PM, Marton Balint wrote: > As far as I remember multiple side data of the same type is not something we > wanted to support. Why do you need it? Can't a single AV_FRAME_DATA_A53_CC > side data packet contain many CC entries? Could you

[FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

From: Devin Heitmueller <dheitmuel...@kernellabs.com> Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line constr

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> > Sorry, what I meant was: > Nothing inside FFmpeg except the decklink device could use > VANC? Ah, I understand now. Yes, the decklink device is currently the only SDI device which is supported by libavdevice. I’ve got a whole pile of patches coming which add support for a variety of

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Carl, > On Oct 6, 2017, at 5:07 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-10-06 18:56 GMT+02:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: >> From: Devin Heitmueller <dheitmuel...@kernellabs.com> >> >> Hook in libklvanc a

[FFmpeg-devel] [PATCH 0/4] avdevice/decklink: 10-bit video out and sources/sinks support

Hello all, Below please find several patches which fix a couple of bugs as well as adding support for 10-bit video on output and the "-sources" and "-sinks" argument when specified by ffmpeg.c. If you have any question/concerns, please don't hesitate to reply. Thanks, Devi

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink: Fix segfault when running -list_devices on OSX

The string is allocated with CFStringGetCString but was being deallocated with free(), which would intermittently result in a segmentation fault. Use the correct function for freeing the allocated CFString. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libav

[FFmpeg-devel] [PATCH 4/4] livavdevice/decklink: Don't allow any codecs but V210 and UYVY422

Make sure that codecs other than V210 or wrapped avframes with uyvy422 video are passed to decklink output (which would result in undefined behavior). Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 4 1 file changed, 4 insertions(+)

[FFmpeg-devel] [PATCH 2/4] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 52 + libavdevice/decklink_common.h | 2 +- libavdevice/decklink_dec.cpp| 22

[FFmpeg-devel] [PATCH 3/4] Add support for 10-bit output for Decklink SDI

From: Devin Heitmueller <dheitmuel...@kernellabs.com> Can be tested via the following command: ./ffmpeg -i foo.ts -f decklink -vcodec v210 'DeckLink Duo (1)' Note that the 8-bit support works as it did before, and setting the pix_fmt isn't required for 10-bit mode. The code de

Re: [FFmpeg-devel] [PATCH 3/4] Add support for 10-bit output for Decklink SDI

Hello Marton, Thanks for taking the time to provide feedback. >> + } else { >> +*buffer = (void *)(_avpacket->data); > > The DeckLink SDK requires a 128 byte alignment for data. I am thinking > AVPacket does not always provides that. Maybe we should simply ignore the SDK >

[FFmpeg-devel] [PATCH 2/2] libavdevice/decklink: add support for 10-bit output for Decklink SDI

, for backward compatibility. Updated to reflect feedback from Marton Balink <c...@passwd.hu> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 112 --- 1 file changed, 83 insertions(+), 29 deletions(-)

[FFmpeg-devel] [PATCHv2 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

ies was consolidated into patch 3 per Marton's suggestion. If you have any question/concerns, please don't hesitate to reply. Thanks, Devin Heitmueller Devin Heitmueller (2): libavdevice/decklink: add support for -sources and -sinks arguments libavdevice/decklink: add support for 10-bit out

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Updated to reflect feedback from Marton Balink <c...@passwd.hu>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 89 ++--- liba

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/decklink: add support for -sources and -sinks arguments

> On Sep 30, 2017, at 4:02 PM, Marton Balint <c...@passwd.hu> wrote: > > > > On Tue, 26 Sep 2017, Devin Heitmueller wrote: > >> Add support for enumerating the sources/sinks via the ffmpeg >> command line options, as opposed to having to create a real pi

Re: [FFmpeg-devel] [PATCHv2 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

> On Oct 6, 2017, at 5:13 AM, Moritz Barsnick <barsn...@gmx.net> wrote: > > On Thu, Oct 05, 2017 at 15:32:04 -0400, Devin Heitmueller wrote: >> This patch series incorporates feedback provided from Marton Balint. >> Note that patch 4 in the previous patch series was c

[FFmpeg-devel] [PATCHv3 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

ies was consolidated into patch 3 per Marton's suggestion. Patch series V3 corrects a misspelling in Marton's name in the commit. If you have any question/concerns, please don't hesitate to reply. Thanks, Devin Heitmueller Devin Heitmueller (2): libavdevice/decklink: add support for -sources

[FFmpeg-devel] [PATCHv3 2/2] libavdevice/decklink: add support for 10-bit output for Decklink SDI

, for backward compatibility. Updated to reflect feedback from Marton Balint <c...@passwd.hu> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 112 --- 1 file changed, 83 insertions(+), 29 deletions(-)

[FFmpeg-devel] [PATCHv3 1/2] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Updated to reflect feedback from Marton Balint <c...@passwd.hu>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 89 ++--- liba

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Dave, > > The President of AJA has publicly stated an intent to add an open license to > their SDK, https://twitter.com/ajaprez/status/910100436224499713 > . This is certainly good news. Looking at AJA’s offering is on my TODO list

Re: [FFmpeg-devel] decklink 24/32 bit question

> > The decklink sdk only defines two BMDAudioSampleType values: > bmdAudioSampleType16bitInteger and bmdAudioSampleType32bitInteger. I don't > think there's an easy way to support a 24 bit input here. Generally in this > case I've used bmdAudioSampleType32bitInteger and then encode it at

Re: [FFmpeg-devel] decklink 24/32 bit question

Hello Marton, > On Oct 18, 2017, at 3:02 PM, Marton Balint <c...@passwd.hu> wrote: > > > > On Tue, 17 Oct 2017, Devin Heitmueller wrote: > >>> > The decklink sdk only defines two BMDAudioSampleType values: >>> > bmdAudioSampleType16

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 6, 2017, at 12:56 PM, Devin Heitmueller <dheitmuel...@ltnglobal.com> > wrote: > > From: Devin Heitmueller <dheitmuel...@kernellabs.com> > > Hook in libklvanc and use it for output of EIA-708 captions over > SDI. The bulk of this patch is just gen

Re: [FFmpeg-devel] decklink 24/32 bit question

Hi Doug, > On Oct 18, 2017, at 4:15 PM, Douglas Marsh wrote: > > I am not really sure I follow. I am not sure supporting 24-bit is a big > issue. A sample size of 32-bit should work fine for most folks. I can only > think of people (in the output stream) converting to 24-bits

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Deron, > I was going to actually test this with some old broadcast equipment I have > just dying for a purpose, but I don't see how to generate AV_PKT_DATA_A53_CC > side packet data except using the Decklink capture. I have A53 documentation, > but it just refers to CEA-708 (or SMPTE 334,

Re: [FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Marton, Thanks for taking the time to review. Most of the comments you’ve raised will be fixed and I’ll resubmit an updated patch. Comments on other issues inline below. >> >>/* Options */ >>int list_devices; >> @@ -88,6 +93,7 @@ struct decklink_ctx { >>DecklinkPtsSource

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Hi Marton, Comments inline. >> +data = av_packet_get_side_data(pkt, AV_PKT_DATA_AFD, ); >> +if (data) { >> +struct klvanc_packet_afd_s *pkt; >> +uint16_t *afd; >> +uint16_t len; >> + >> +ret = klvanc_create_AFD(); >> +if (ret != 0) >> +

Re: [FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Marton, > SDK says: > > When capturing ancillary data with a 4K DeckLink device, the ancillary > data will always be in the 10-bit YUV pixel format. > > This also applies to 8 bit YUV captures according to my experience. > Thanks for refreshing my memory. I remember reading that text,

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello Derek, Comments inline. >> >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > Is there a reason we shouldn't fail hard here? Not really. The parser will log an error if the callback

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello James, Thanks for reviewing. >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > For this, av_packet_new_side_data() seems more adequate than av_malloc() > + av_packet_add_side_data(). > >

Re: [FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

Hi Mark, >> >> Here’s the vainfo output which provides the version info for the driver, >> va-api version, etc. This is on a Haswell system running Centos 7. >> >> libva info: VA-API version 0.34.0 >> libva info: va_getDriverName() returns 0 >> libva info: Trying to open

Re: [FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

>> Try this? (Not tested, hardware which can run a version that old isn't >> immediately to hand.) >> >> --- a/libavcodec/vaapi_encode_h264.c >> +++ b/libavcodec/vaapi_encode_h264.c >> @@ -261,7 +261,8 @@ static int >> vaapi_encode_h264_write_extra_header(AVCodecContext *avctx, >>

[FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

' -c:v h264_vaapi out.mp4 Any suggestions that could be offered would be greatly appreciated. Likewise please let me know if there is any other information I can provide that would assist in getting this resolved. Thanks, Devin Heitmueller ___ ffmpeg

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint <c...@passwd.hu> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- configure | 4 ++ libavcodec/v210enc.c| 12 libavdevice/decklink_comm

[FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/avcodec.h

[FFmpeg-devel] [PATCHv2 0/2] Add support for EIA-708/AFD on decklink output

This patch series hooks in the libklvanc library to provide support of output for EIA-708 and AFD packets over SDI output. Patch 1 reflects feedback from Marton Balint <c...@passwd.hu> Devin Heitmueller (2): libavdevice/decklink: Add support for EIA-708 output over SDI decklink: Add s

[FFmpeg-devel] [PATCH 3/6] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/liba

[FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

use case where multi-channel audio can be captured (i.e. 7.1), we introduced a new configuration option, which defaults to the existing behavior. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 9 +++ libavdevice/decklink_common.h

[FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

enabled by the user through the "-enable_scte_104" option, since we cannot autodetect the presence of SCTE-104 (because unlike with 708/AFD messages are not set except when trigger occurs, thus the stream wouldn't get created during the read_header phase). Signed-off-by: Devin Heitmueller

[FFmpeg-devel] [RFC PATCH 0/6] Decklink capture VANC improvements and AFD in libx264

Format Description if present as side-data. This was needed in order to capture AFD on the decklink interface and have it end up in the final TS (assuming an encoding use case). Devin Heitmueller (6): decklink: Fix case where return value wasn't being set before checked for errors decklink

[FFmpeg-devel] [PATCH 1/6] decklink: Fix case where return value wasn't being set before checked for errors

I missed an assignement which cauesd the error case to not ever be properly checked. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_enc.cpp b/libav

[FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_dec.cpp

[FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

types (i.e. videotoolbox, etc). Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/internal.h | 3 +++ libavcodec/libx264.c | 38 ++ libavcodec/utils.c| 36 3 files changed, 73 insertions

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

> On Nov 16, 2017, at 7:22 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

Hello Derek, Thanks for taking the time to review these patches. Comments below. > On Nov 16, 2017, at 7:20 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > >> +/* Active Format Description

Re: [FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

> On Nov 16, 2017, at 7:35 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> --- >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 6 >> libavdevice/de

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 25, 2017, at 2:23 PM, Marton Balint <c...@passwd.hu> wrote: > > > On Fri, 6 Oct 2017, Devin Heitmueller wrote: > >> From: Devin Heitmueller <dheitmuel...@kernellabs.com >> <mailto:dheitmuel...@kernellabs.com>> >> >> Hook in

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

> I'm leaning toward 2, but there would need to be some other way to deal > with people not getting along. Maybe Mumble conferences where the > involved parties get to air their feelings on whatever is at issue? I > dunno I'm not weighing in on the CoC so much as offering my experience with other

Re: [FFmpeg-devel] Stream selection algorithm crossing program boundaries

Hello Gyan, Thanks for your comments. See inline: > On May 18, 2018, at 10:24 AM, Gyan Doshi wrote: > If nb_input_files is 1, coupling the stream selection seems to me an > improvement. But in the scenario of multiple inputs and no -map options, > users usually intend to

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

Hello Aman, On Thu, May 17, 2018 at 8:04 PM, Aman Gupta wrote: > From: Aman Gupta > > Some filtered mpegts streams may erroneously include PMTs for programs > that are not advertised in the PAT. This confuses ffmpeg and most > players because multiple audio/video

[FFmpeg-devel] Stream selection algorithm crossing program boundaries

dio/video in MPEG-TS streams behave differently than other formats). Thoughts? Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

> The issue is that the PMT PID advertised in the PAT contains multiple PMTs > for different programs. This is because the broadcaster decided to re-use > the same PID for multiple program PMTs. Ugh, ok. I understand the case you're talking about now. Thanks for clarifying. > To be clear, this

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

> > I'd rather see a new AVPacketSideData type which will contain the timecode as > a string, so you can set it frame-by-frame. For what it’s worth, this is what I’ve done on the decklink output side. I’ve introduced a new side data type and I’m able to decode timecodes provided in H.264

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Carl, Thanks for your feedback. Comments inline> > On Dec 29, 2017, at 3:41 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: > >> +side_data = av_frame_get_si

[FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

from Derek Buitenhuis <derek.buitenh...@gmail.com> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 libavdevice/decklink_common.h | 6 libavdevice/decklink_common_c.h | 1 + libavd

[FFmpeg-devel] [PATCHv3 0/8] Decklink updates

This patch series provides a number of enhancements for both capture and output using the decklink module, including addressing comments from Marton Balint, Derek Buitenhuis, and James Almer. Devin Heitmueller (8): libavdevice/decklink: Add support for EIA-708 output over SDI decklink: Add

[FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint <c...@passwd.hu> Signed-off-by: Devin Heitmueller <

[FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint <c...@passwd.hu> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- configure | 4 ++ libavcodec/v210enc.c| 10 +++ libavdevice/decklink_comm

[FFmpeg-devel] [PATCH 4/8] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/liba

[FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pair per audio language). To support the existing

[FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

types (i.e. videotoolbox, etc). Updated to reflect feedback from Derek Buitenhuis <derek.buitenh...@gmail.com> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/internal.h | 3 +++ libavcodec/libx264.c | 47 +++

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Hi Carl, > On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: > >> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { >> +

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

> On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 22:02 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: >> >>> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>>

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

> On Dec 29, 2017, at 4:17 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 22:14 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: >> Hi Carl, >> >>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos <ceffm...@gmail.com>

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

> On Dec 29, 2017, at 3:59 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: > >> +uint8_t *outbuf = NULL; > >> +if (st->codecpar->codec_id =

[FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedback from Derek Buitenhuis <derek.buitenh...@gmail.com> and James Almer <jamr...@gmail.com> Signed-o

[FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

tudio Mini Monitor' Note that the default behavior continues to be to do PCM output, which means without specifying the copy codec a stream containing AC-3 will be decoded and downmixed to stereo audio before output. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com>

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: > >> +/* FIXME: Should really rely on the coded_width but seems like that >> + is n

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Aaron, Comments inline: > > Most of the changes in this set of patches appear to only be relevant in the > case that libklvanc is enabled. Nevertheless, a number of the changes are > not wrapped in #if CONFIG_LIBKLVANC, which means that they will be exercised > even if libklvanc is not

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

Hello Aaron, Thanks for the feedback. Comments inline. On Sat, Dec 30, 2017 at 12:34 AM, Aaron Levinson wrote: > Technically, there are a number of 2K and 4K video modes supported by some > DeckLink cards that have a 16x9 aspect ratio as well. This code would treat

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

Hi Aaron, > On Dec 30, 2017, at 2:34 AM, Aaron Levinson wrote: > > Patch title: "suppoort" -> "support", also "decklink" -> “DeckLink" Ok. >>ff_decklink_cleanup(avctx); >> avpacket_queue_end(>queue); >> +klvanc_context_destroy(ctx->vanc_ctx); > >

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

Hi Aaron, >> +ret = ff_alloc_afd_sei(frame, 0, _data, _size); >> +if (ret < 0) { >> +for (i = 0; i < num_payloads; i++) >> +av_free(x4->pic.extra_sei.payloads[i].payload); >> +av_free(x4->pic.extra_sei.payloads); > >

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

> On Dec 30, 2017, at 3:11 AM, Aaron Levinson <alevinsn_...@levland.net> wrote: > > On 12/29/2017 10:12 AM, Devin Heitmueller wrote: >> Make use of libklvanc to parse SCTE-104 packets and announce them >> as a new stream. Right now we just pass the payload st

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

Hi Aaron, >> +static int create_s337_payload(AVPacket *pkt, enum AVCodecID codec_id, >> uint8_t **outbuf, int *outsize) >> +{ >> +uint8_t *s337_payload; >> +uint8_t *s337_payload_start; >> +int i; >> + >> +/* Encapsulate AC3 syncframe into SMPTE 337 packet */ >> +*outsize =

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

>> +if (ctx->max_audio_channels > DECKLINK_MAX_AUDIO_CHANNELS) { >> +av_log(avctx, AV_LOG_WARNING, "Decklink card reported support for >> more channels than ffmpeg supports\n"); > > "Decklink" -> "DeckLink", "ffmpeg" -> "FFmpeg". Also, I think it is > preferable to not state

[FFmpeg-devel] [PATCH 04/11] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/liba

[FFmpeg-devel] [PATCH 07/11] decklink: Add support for SCTE-104 to decklink capture

Buitenhuis <derek.buitenh...@gmail.com> and Aaron Levinson <alevinsn_...@levland.net> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- doc/indevs.texi | 4 +++ libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 l

[FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

n <alevinsn_...@levland.net> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_dec.cpp | 136 +++ 1 file changed, 136 insertions(+) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index

[FFmpeg-devel] [PATCH 08/11] decklink: Add support for compressed AC-3 output over SDI

> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 100 --- 1 file changed, 85 insertions(+), 15 deletions(-) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index f

[FFmpeg-devel] [PATCH 09/11] decklink: Suppress warning about misuse of struct instead of class

When building with Clang, the following warning is shown: warning: struct 'IDeckLinkVideoFrame' was previously declared as a class [-Wmismatched-tags] The function incorrectly casts IDeckLinkVideoFrame as a struct instead of a class pointer. Signed-off-by: Devin Heitmueller <dheitm

[FFmpeg-devel] [PATCH 02/11] decklink: Add support for output of Active Format Description (AFD)

t; and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/avcodec.h | 6 ++ libavcodec/v210enc.c | 8 libavdevice/decklink_enc.cpp | 44 ++-- 3 file

[FFmpeg-devel] [PATCH 03/11] decklink: Introduce support for capture of multiple audio streams

<a...@fem.tu-ilmenau.de>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- doc/indevs.texi | 8 ++- libavdevice/decklink_common.cpp | 12 libavdevice/decklink_common.h | 8 ++- libavdevice/decklink_common_c.h | 6 ++ libavdevice/d

[FFmpeg-devel] [PATCH 05/11] Support encoding of Active Format Description (AFD) in libx264

types (i.e. videotoolbox, etc). Updated to reflect feedback from Derek Buitenhuis <derek.buitenh...@gmail.com> and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/internal.h | 3 +++ libavcod

[FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint <c...@passwd.hu>, Carl Eugen Hoyos <ceffm...@gmail.com>, and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- configure

[FFmpeg-devel] [PATCHv4 00/11] Decklink updates

This patch series provides a number of enhancements for both capture and output using the decklink module, including addressing comments from Marton Balint, Derek Buitenhuis, James Almer, Carl Eugen Hoyos, and Aaron Levinson. Devin Heitmueller (11): libavdevice/decklink: Add support for EIA-708

[FFmpeg-devel] [PATCH 11/11] decklink: Fix compilation of module on OSX

SDK sources, so suppress the warning just for that one #include. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Moritz, > On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote: >>> +for (size_t i = 0; i < cc_count; i++) { >> Declare i outside the clause. >>> +for (int i = 0; i < vanc_lines.num_lines; i++) { >> Same here. > > Sorry, this rule may not apply to C++ files, as it's

[FFmpeg-devel] [PATCH 10/11] decklink: log Blackmagic SDK version compiled against

Add a line to show the SDK version used in the build, if loglevel is set to verbose. This is simply to aid in debugging when building against different SDKs. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 4 1 file changed, 4 inse

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Hello Matthias, Thanks for the feedback. Comments inline: > On Jan 2, 2018, at 4:52 AM, Matthias Hunstock <a...@fem.tu-ilmenau.de> wrote: > > Am 29.12.2017 um 19:12 schrieb Devin Heitmueller: >> To support the existing use case where multi-channel audio can be >> ca

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

Hi Ray, > > Please find updated patch attatched. I reverted the vanc lines changes and > found that all my tests worked as expected, so not sure what was wrong w/ > my original test. The need to extract vanc from the entire line vs just the > luma in NTSC is still required. It’s helpful if in

Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

Hello Marton, Thank you for the feedback. Comments inline. >> +vanc_ctx->callback_context = _ctx; >> +int ret = klvanc_packet_parse(vanc_ctx, lineNr, decoded_words, >> sizeof(decoded_words) / (sizeof(uint16_t))); > > A parity error also causes a negative return value? Or

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

Hello Marton, > I thought you are working on an updated patch, or I just missed the new one? > The email you replied to here definitely contains the old, without > interleaved VANC autodetection or proper width for get_metadata. I did some digging into this after discussion with Ray (both by

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

Hi Marton, > > Have you found which standard contains reference to interleaved VANC? So SMPTE falls back onto the earlier standards for digital video bitstreams as defined in ITU BT.656 (for SD) and BT.1120 (for HD). > >> >> That said, the list of modes should probably be expanded to

Re: [FFmpeg-devel] Ffmpeg, UDP input source from satellite audio sync issues

Hello Ibrahim, > I do have another issue with Audio sync when segmenting live content coming > from satellite but without encoding (stream copying only). And since you > cannot use aresample when copying I am unsure how you would go about to > solve that issue. I can make a few general

Re: [FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

mber of commercial hardware encoders I’ve worked with. We can debate the mechanics of how the buffers are referenced (which is why I believe it wasn’t merged last year), but I can say that this is a very real problem and at least this patch results in those streams playing properly. Cheers,

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos , Aaron Levinson , and Moritz Barsnick Signed-off-by: Devin Heitmueller --- configure | 4 + libavcodec/v210enc.c| 9 ++ libavdevice/decklink_common.cpp

[FFmpeg-devel] [PATCH] Support 64-bit integers for av_get_frame_filename2()

s -vsync 0 -i foo.ts -frame_pts 1 -enc_time_base -1 foo_%d.png Signed-off-by: Devin Heitmueller --- libavformat/avformat.h | 2 ++ libavformat/img2enc.c | 2 +- libavformat/utils.c| 9 +++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/avformat.h b/l

[FFmpeg-devel] [PATCH 0/2] Support for Decklink output of EIA-708 and AFD

The following patches add support for output of 708 and AFD over the Decklink SDI interface. This series is a subset of a series submitted in early January, with the hope of getting the less controversial parts merged upstream. Devin Heitmueller (2): libavdevice/decklink: Add support for EIA

  1   2   3   4   >