Re: [FFmpeg-devel] [PATCH 2/2] [RFC] libavcodec: remove DSP acceleration code for DEC Alpha

2024-06-01 Thread James Almer
On 5/30/2024 6:21 PM, Sean McGovern wrote: --- Changelog| 1 + libavcodec/alpha/Makefile| 10 - libavcodec/alpha/asm.h | 153 -- libavcodec/alpha/blockdsp_alpha.c| 49 - libavcodec/alpha/hpeldsp_alpha.c | 213

Re: [FFmpeg-devel] [PATCH] checkasm: add aacencdsp.quant_bands test

2024-05-31 Thread James Almer
On 5/31/2024 3:18 PM, Rémi Denis-Courmont wrote: --- tests/checkasm/aacencdsp.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c index 1756c4ecd5..756f92fd8f 100644 --- a/tests/checkasm/aacencdsp.

[FFmpeg-devel] [PATCH] x86/float_dsp: add SSE2 and AVX versions of scalarproduct_double

2024-05-31 Thread James Almer
Signed-off-by: James Almer --- libavutil/x86/float_dsp.asm| 52 ++ libavutil/x86/float_dsp_init.c | 5 2 files changed, 57 insertions(+) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm index e84ba52566..e9816cdf02 100644 --- a

Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread James Almer
On 5/31/2024 2:51 PM, Rémi Denis-Courmont wrote: --- tests/checkasm/lpc.c | 57 ++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..62232fdaf7 100644 --- a/tests/checkasm/lpc.c

[FFmpeg-devel] [PATCH] avcodec/lpc: account for odd len values

2024-05-31 Thread James Almer
Signed-off-by: James Almer --- libavcodec/lpc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index dfd6114690..e793e54038 100644 --- a/libavcodec/lpc.c +++ b/libavcodec/lpc.c @@ -120,9 +120,8 @@ static void lpc_compute_autocorr_c

[FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-05-30 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.h| 7 +++ fftools/ffmpeg_demux.c | 16 fftools/ffmpeg_filter.c | 10 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 36 insertions(+) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index fe75706afd

Re: [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr

2024-05-30 Thread James Almer
On 5/30/2024 12:58 PM, Rémi Denis-Courmont wrote: Also restrict length to even values as per (questionable) assumption in the reference C code. --- tests/checkasm/lpc.c | 59 +--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/tests/check

Re: [FFmpeg-devel] [PATCHv2 1/5] lavu/float_dsp: add double-precision scalar product

2024-05-30 Thread James Almer
On 5/30/2024 4:31 PM, Rémi Denis-Courmont wrote: Le torstaina 30. toukokuuta 2024, 22.06.55 EEST Rémi Denis-Courmont a écrit : The function pointer is appended to the structure for backward binary compatibility. Fortunately, this is allocated by libavutil, not by the user, so increasing the stru

Re: [FFmpeg-devel] [PATCHv2 1/5] lavu/float_dsp: add double-precision scalar product

2024-05-30 Thread James Almer
On 5/30/2024 4:21 PM, Rémi Denis-Courmont wrote: Le torstaina 30. toukokuuta 2024, 22.10.28 EEST James Almer a écrit : Why are you adding this to the doxy for scalarproduct_float()? Those constrains are not correct for it. They are for scalarproduct_double() which you're adding now. Be

Re: [FFmpeg-devel] [PATCHv2 1/5] lavu/float_dsp: add double-precision scalar product

2024-05-30 Thread James Almer
On 5/30/2024 4:06 PM, Rémi Denis-Courmont wrote: The function pointer is appended to the structure for backward binary compatibility. Fortunately, this is allocated by libavutil, not by the user, so increasing the structure size is safe. --- libavutil/float_dsp.c | 12 libavutil/f

Re: [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c()

2024-05-30 Thread James Almer
On 5/30/2024 12:32 PM, Tomas Härdin wrote: tor 2024-05-30 klockan 17:28 +0300 skrev Rémi Denis-Courmont: Le 30 mai 2024 17:07:21 GMT+03:00, "Tomas Härdin" a écrit : We should depend on punning as long as it conforms to the standard. My mistake, I forgot type punning is allowed in C. It's U

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type

2024-05-29 Thread James Almer
On 5/29/2024 10:02 PM, Lynne via ffmpeg-devel wrote: On 29/05/2024 23:46, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/packet.h | 14 ++   1 file changed, 14 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index a9a41576da..9dee035690 100644

Re: [FFmpeg-devel] [PATCH 5/6] fftools/ffmpeg: support applying container level cropping

2024-05-29 Thread James Almer
On 5/29/2024 10:01 PM, Lynne via ffmpeg-devel wrote: On 29/05/2024 23:46, James Almer wrote: Signed-off-by: James Almer ---   fftools/ffmpeg.h    |  7 +++   fftools/ffmpeg_demux.c  | 16   fftools/ffmpeg_filter.c | 11 +++   fftools/ffmpeg_opt.c    |  3 +++   4

Re: [FFmpeg-devel] [PATCH v3] avformat/nutdec: Don't create inconsistent side data

2024-05-29 Thread James Almer
On 5/29/2024 9:14 PM, Andreas Rheinhardt wrote: Forgotten in 65ddc74988245a01421a63c5cffa4d900c47117c. Signed-off-by: Andreas Rheinhardt --- libavformat/nutdec.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c in

[FFmpeg-devel] [PATCH] avcodec/packet: remove reference to old AV_SIDE_DATA_PARAM_CHANGE_ values

2024-05-29 Thread James Almer
They were forgotten in 65ddc74988245a01421a63c5cffa4d900c47117c. Signed-off-by: James Almer --- libavcodec/packet.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index a9a41576da..f05deb7950 100644 --- a/libavcodec/packet.h +++ b/libavcodec

[FFmpeg-devel] [PATCH 6/6] fftools/ffplay: support applying container level cropping

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- fftools/ffplay.c | 25 + 1 file changed, 25 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 1d0511b254..47e2865abb 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -32,6 +32,7 @@ #include "libavutil/avstr

[FFmpeg-devel] [PATCH 5/6] fftools/ffmpeg: support applying container level cropping

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.h| 7 +++ fftools/ffmpeg_demux.c | 16 fftools/ffmpeg_filter.c | 11 +++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 37 insertions(+) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index fe75706afd

[FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- libavcodec/packet.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index a9a41576da..9dee035690 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -330,6 +330,20 @@ enum AVPacketSideDataType

[FFmpeg-devel] [PATCH 4/6] avformat/matroskaenc: support writing cropping values

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskaenc.c | 44 --- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 76c542d50b..37a6a5b4f8 100644 --- a/libavformat/matroskaenc.c +++ b

[FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: export cropping values

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 53 +++ 1 file changed, 43 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 2f07e11d87..a30bac786b 100644 --- a/libavformat/matroskadec.c +++ b

[FFmpeg-devel] [PATCH 2/6] avformat/dump: print Frame Cropping side data info

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- libavformat/dump.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 059fb84522..610965cf81 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -431,6 +431,23 @@ static void

Re: [FFmpeg-devel] [PATCHv4] checkasm/lpc: test compute_autocorr

2024-05-29 Thread James Almer
On 5/29/2024 4:42 PM, Rémi Denis-Courmont wrote: Also restrict length to even values, matching real uses. This test is disabled, known broken, on x86. --- tests/checkasm/lpc.c | 57 +--- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/test

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-05-29 Thread James Almer
On 5/29/2024 12:51 PM, Rémi Denis-Courmont wrote: Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit : +static double ff_scalarproduct_double_c(const double *v1, Don't use an ff_ prefix for a static function. I can see over 300 such identifiers in the code base (

[FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers

2024-05-29 Thread James Almer
They will be filled immediately after. Signed-off-by: James Almer --- tests/checkasm/vvc_mc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c index 40be837d68..bc6b580f42 100644 --- a/tests/checkasm/vvc_mc.c +++ b/tests/checkasm/vvc_mc.c

[FFmpeg-devel] [PATCH 1/2] tests/checkasm/vvc_mc: fix indentation

2024-05-29 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/vvc_mc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c index 09cac82edb..40be837d68 100644 --- a/tests/checkasm/vvc_mc.c +++ b/tests/checkasm/vvc_mc.c @@ -341,8 +341,10

Re: [FFmpeg-devel] [PATCH] checkasm: add linear least square tests

2024-05-28 Thread James Almer
On 5/28/2024 4:57 PM, Rémi Denis-Courmont wrote: --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/lls.c | 110 ++ tests/fate/checkasm.mak | 1 + 5 files changed, 114 inse

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/vc2enc: Avoid relocations for short strings

2024-05-27 Thread James Almer
On 5/27/2024 11:49 PM, Andreas Rheinhardt wrote: These strings are so short that they can be put directly into the containing structure, avoiding the pointer and putting it into .rodata. Also use chars for interlaced and level while at it, as these are so small. Signed-off-by: Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCHv3] checkasm/lpc: test compute_autocorr

2024-05-27 Thread James Almer
On 5/27/2024 9:22 PM, James Almer wrote: On 5/27/2024 4:15 PM, James Almer wrote: On 5/27/2024 4:10 PM, James Almer wrote: On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote: --- Changes since v2: - Scale the error factor to length since this computes sums. - Check the last element from results

Re: [FFmpeg-devel] [PATCHv3] checkasm/lpc: test compute_autocorr

2024-05-27 Thread James Almer
On 5/27/2024 4:15 PM, James Almer wrote: On 5/27/2024 4:10 PM, James Almer wrote: On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote: --- Changes since v2: - Scale the error factor to length since this computes sums. - Check the last element from results. - Use fixed vector size for benchmarks

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:50 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote: On 5/27/2024 4:31 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:31 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:20 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows

Re: [FFmpeg-devel] [PATCHv3] checkasm/lpc: test compute_autocorr

2024-05-27 Thread James Almer
On 5/27/2024 4:10 PM, James Almer wrote: On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote: --- Changes since v2: - Scale the error factor to length since this computes sums. - Check the last element from results. - Use fixed vector size for benchmarks. ---   tests/checkasm/lpc.c | 51

Re: [FFmpeg-devel] [PATCHv3] checkasm/lpc: test compute_autocorr

2024-05-27 Thread James Almer
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote: --- Changes since v2: - Scale the error factor to length since this computes sums. - Check the last element from results. - Use fixed vector size for benchmarks. --- tests/checkasm/lpc.c | 51 +--- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 5:15 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed-off-by: Michael Niedermayer --- I am against this patch. Checksumm

Re: [FFmpeg-devel] [PATCH v2] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 10:51 PM, James Almer wrote: On 5/25/2024 10:42 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly. ---   libavcodec/x86/lpc.asm    | 91

Re: [FFmpeg-devel] [PATCH v2] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 10:42 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly. --- libavcodec/x86/lpc.asm| 91 +++ libavcodec/x86

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly. autocorr_10_c: 135525.8 autocorr_10_sse2: 50729.8 autocorr_10_fma3: 19007.8 autocorr_30_c: 39

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 9:02 PM, Lynne via ffmpeg-devel wrote: On 26/05/2024 00:45, James Almer wrote: On 5/25/2024 7:31 PM, James Almer wrote: On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 8:24 PM, Lynne via ffmpeg-devel wrote: On 26/05/2024 00:31, James Almer wrote: On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 7:31 PM, James Almer wrote: On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly. autocorr_10_c: 135525.8 autocorr_10_sse2: 50729.8

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

2024-05-25 Thread James Almer
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote: The inline asm function had issues running under checkasm. So I came to finish what I started, and wrote the last part of LPC computation in assembly. autocorr_10_c: 135525.8 autocorr_10_sse2: 50729.8 autocorr_10_fma3: 19007.8 autocorr_30_c: 39

Re: [FFmpeg-devel] [PATCH] checkasm: add h263dsp.{h,v}_loop_filter

2024-05-25 Thread James Almer
On 5/18/2024 3:44 PM, Rémi Denis-Courmont wrote: --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/h263dsp.c | 62 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 68 insertio

Re: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr

2024-05-25 Thread James Almer
On 5/25/2024 8:58 AM, Rémi Denis-Courmont wrote: -- Change since previous version: - Disable test on x86, since the x86 optimisation fails with a suspiciously large and regular error with 10-20% probability. Weird. The sse2 function is written using inline gcc, so it's pretty old. And it se

Re: [FFmpeg-devel] [PATCH] avcodec/flacdec: Remove unused variable

2024-05-24 Thread James Almer
On 5/24/2024 12:37 PM, Andreas Rheinhardt wrote: Forgotten in 0380a03f1f9d55e5690bb92bfa4897f2c728c1e5. LGTM. And sorry, i was sure i had amended it locally when you pointed it out. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [FFmpeg-devel] [PATCH 09/10] lavc/hevc_ps: reduce the size of ShortTermRPS.used

2024-05-24 Thread James Almer
On 5/24/2024 6:11 AM, Anton Khirnov wrote: Quoting James Almer (2024-04-10 15:42:51) On 4/10/2024 10:31 AM, Anton Khirnov wrote: diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c index 5d7c6b1b64..c2b65fc201 100644 --- a/libavcodec/vulkan_hevc.c +++ b/libavcodec/vulkan_hevc.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for writing SA3D boxes

2024-05-23 Thread James Almer
On 5/14/2024 10:08 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/movenc.c | 61 1 file changed, 61 insertions(+) Will apply the set. ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc

2024-05-23 Thread James Almer
On 5/22/2024 12:50 PM, Cosmin Stejerean via ffmpeg-devel wrote: From: Cosmin Stejerean These two fields are coded together into a single 16 bit integer with upper 8 bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8. Furthermore ext_mapping_idc has two components, upper 3 bits a

[FFmpeg-devel] [PATCH 5/5] x86/vvc_sad: reindent after the previous changes

2024-05-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_sad.asm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_sad.asm b/libavcodec/x86/vvc/vvc_sad.asm index 9881b1180d..14f7ce230e 100644 --- a/libavcodec/x86/vvc/vvc_sad.asm +++ b

[FFmpeg-devel] [PATCH 4/5] x86/vvc_sad: reduce gpr usage in all loop functions

2024-05-23 Thread James Almer
This way they can be assembled on x86_32 targets. Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_sad.asm | 22 ++ libavcodec/x86/vvc/vvcdsp_init.c | 16 +--- 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_sad.asm

[FFmpeg-devel] [PATCH 3/5] x86/vvc_sad: add sse4 versions of all functions

2024-05-23 Thread James Almer
257.3 sad_128x128_c: 12581.3 sad_128x128_sse4: 1560.8 sad_128x128_avx2: 1151.8 Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_sad.asm | 53 +--- libavcodec/x86/vvc/vvcdsp_init.c | 42 + 2 files changed, 65 insertions(+), 30 deletions(-) diff --

[FFmpeg-devel] [PATCH 2/5] x86/vvc_sad: optimize vvc_sad_16

2024-05-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_sad.asm | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_sad.asm b/libavcodec/x86/vvc/vvc_sad.asm index a20818530f..829dbce489 100644 --- a/libavcodec/x86/vvc/vvc_sad.asm

[FFmpeg-devel] [PATCH 1/5] avcodec/vvc_mc: split the SAD dsp prototype into one function per blocksize width

2024-05-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vvc/dsp.h | 2 +- libavcodec/vvc/inter.c | 6 -- libavcodec/vvc/inter_template.c | 6 +- libavcodec/x86/vvc/vvc_sad.asm | 32 ++-- libavcodec/x86/vvc/vvcdsp_init.c | 22

Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout

2024-05-23 Thread James Almer
On 5/23/2024 4:11 AM, Anton Khirnov wrote: Quoting James Almer (2024-05-15 03:08:28) Signed-off-by: James Almer --- libavutil/channel_layout.c | 17 - libavutil/channel_layout.h | 10 ++ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/libavutil

Re: [FFmpeg-devel] [PATCH v3 4/4] tests/checkasm/vvc_alf: add check_alf_classify

2024-05-22 Thread James Almer
On 5/14/2024 8:25 AM, Nuo Mi wrote: On Mon, May 13, 2024 at 8:32 PM wrote: From: Wu Jianhua Perforamnce Test (fps): clip before after delta Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% RitualDance_1920x1080_60_10_420_32_LD.266 272

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-22 Thread James Almer
On 5/21/2024 10:01 PM, Ronald S. Bultje wrote: Hi, On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote: Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even

Re: [FFmpeg-devel] [PATCH v5 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

2024-05-22 Thread James Almer
On 5/21/2024 10:12 PM, Ronald S. Bultje wrote: Hi, On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote: Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 50.3 vvc_sad_8x8_avx2: 0.3 vvc_sad_16x16_c: 250.3 vvc_sad_16x16_avx2: 10.3 vvc_sad_32x32_c: 1020.3 vvc

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-22 Thread James Almer
On 5/22/2024 2:02 AM, Andreas Rheinhardt wrote: Stone Chen: Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD is only calculated on even rows. This is calculated for all video bi

Re: [FFmpeg-devel] [PATCH] avformat/mov: store sample_sizes as unsigned ints

2024-05-22 Thread James Almer
On 5/19/2024 10:41 PM, James Almer wrote: As defined in Section 8.7.3.2.1 of ISO 14496-12. Any unsupported value will be rejected in mov_build_index() without outright aborting demuxing. Fixes ticket #11005. Signed-off-by: James Almer --- libavformat/isom.h | 2 +- libavformat/mov.c | 4

Re: [FFmpeg-devel] [PATCH] avformat/vvc: fix parsing sps_subpic_id

2024-05-22 Thread James Almer
On 5/19/2024 10:25 AM, James Almer wrote: The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 + 1 bits. Signed-off-by: James Almer --- libavformat/vvc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c

Re: [FFmpeg-devel] [PATCH v5 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

2024-05-21 Thread James Almer
On 5/21/2024 9:00 PM, Stone Chen wrote: Adds checkasm for DMVR SAD AVX2 implementation. Benchmarks ( AMD 7940HS ) vvc_sad_8x8_c: 50.3 vvc_sad_8x8_avx2: 0.3 vvc_sad_16x16_c: 250.3 vvc_sad_16x16_avx2: 10.3 vvc_sad_32x32_c: 1020.3 vvc_sad_32x32_avx2: 60.3 vvc_sad_64x64_c: 3850.3 vvc_sad_64x64_avx2:

[FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros

2024-05-21 Thread James Almer
Let its magic figure out the correct mnemonic based on target instruction set. Signed-off-by: James Almer --- libavcodec/x86/vvc/vvc_alf.asm | 202 - 1 file changed, 101 insertions(+), 101 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_alf.asm b/libavcodec/x86

[FFmpeg-devel] [PATCH] avformat/mov: store sample_sizes as unsigned ints

2024-05-19 Thread James Almer
As defined in Section 8.7.3.2.1 of ISO 14496-12. Any unsupported value will be rejected in mov_build_index() without outright aborting demuxing. Fixes ticket #11005. Signed-off-by: James Almer --- libavformat/isom.h | 2 +- libavformat/mov.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[FFmpeg-devel] [PATCH] avcodec/cbs_h266: read vps_ptl_max_tid before using it

2024-05-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h266_syntax_template.c | 28 ++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index 725cee5b03..38685704c5 100644 --- a

[FFmpeg-devel] [PATCH] avformat/vvc: fix parsing sps_subpic_id

2024-05-19 Thread James Almer
The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 + 1 bits. Signed-off-by: James Almer --- libavformat/vvc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index 34c0aaf58b..ac3209a01b 100644 --- a

[FFmpeg-devel] [PATCH] avformat/vvc: initialize some ptl flags

2024-05-19 Thread James Almer
Otherwise they will always be 0 when ANDed in vvcc_update_ptl(). Signed-off-by: James Almer --- libavformat/vvc.c | 2 ++ tests/ref/lavf-fate/vvc.mp4 | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index 449c933881

[FFmpeg-devel] [PATCH 3/3] configure: split ISOBMFF writer helpers into a separate component

2024-05-17 Thread James Almer
Signed-off-by: James Almer --- configure| 10 ++ libavformat/Makefile | 16 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 275fa59bfd..b16722d83d 100755 --- a/configure +++ b/configure @@ -2587,6 +2587,7

[FFmpeg-devel] [PATCH 2/3] avformat/vvc: include additional bits in general_constraint_info

2024-05-17 Thread James Almer
Based on code from cbs_h266. Signed-off-by: James Almer --- libavformat/vvc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/libavformat/vvc.c b/libavformat/vvc.c index 98177a7ad8..e8301d4247 100644 --- a/libavformat/vvc.c +++ b/libavformat

[FFmpeg-devel] [PATCH 1/3 v3] avformat/vvc: fix writing general_constraint_info bytes

2024-05-17 Thread James Almer
The existing implementation was completely broken. Signed-off-by: James Almer --- libavformat/Makefile| 2 +- libavformat/bitstream.c | 1 + libavformat/vvc.c | 38 -- tests/ref/fate/source | 1 + 4 files changed, 23 insertions(+), 19 deletions

[FFmpeg-devel] [PATCH v2] avformat/vvc: fix writing general_constraint_info bytes

2024-05-16 Thread James Almer
The existing implementation was completely broken. Signed-off-by: James Almer --- libavformat/Makefile| 2 +- libavformat/bitstream.c | 1 + libavformat/vvc.c | 28 ++-- tests/ref/fate/source | 1 + 4 files changed, 17 insertions(+), 15 deletions

[FFmpeg-devel] [PATCH] avformat/vvc: fix writing general_constraint_info bytes

2024-05-16 Thread James Almer
The existing implementation was completely broken. Signed-off-by: James Almer --- libavformat/Makefile| 2 +- libavformat/bitstream.c | 1 + libavformat/vvc.c | 33 - tests/ref/fate/source | 1 + 4 files changed, 19 insertions(+), 18 deletions

Re: [FFmpeg-devel] [PATCH] libsvtav1: Enable 2-pass encoding

2024-05-15 Thread James Almer
On 5/15/2024 11:14 AM, Fredrik Lundkvist via ffmpeg-devel wrote: Currently, libsvtav1 does not send pass number or stat buffer to SVT-AV1, which means that 2-pass encoding is not possible using FFMPEG; if a user wants to do 2-pass encoding using SVT-AV1, they have to use SvtAv1EncApp. This patc

[FFmpeg-devel] [PATCH] checkasm/h264dsp: use int64_t scale values

2024-05-14 Thread James Almer
Fixes "signed integer overflow: [varies] * 104858 cannot be represented in type 'int'" errors under ubsan. Signed-off-by: James Almer --- tests/checkasm/h264dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/h264dsp.c b/tests/chec

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for writing SA3D boxes

2024-05-14 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 61 1 file changed, 61 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index f907f67752..2aec9a8d17 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -916,6

[FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout

2024-05-14 Thread James Almer
Signed-off-by: James Almer --- libavutil/channel_layout.c | 17 - libavutil/channel_layout.h | 10 ++ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c index fd6718e0e7..e213f68666 100644 --- a

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread James Almer
On 5/13/2024 7:49 PM, Michael Niedermayer wrote: On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: On Mon, 13 May 2024, 02:32 Michael Niedermayer, wrote: On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: Fixes: CID1439574 Dereference after null check Sponsore

Re: [FFmpeg-devel] [PATCH v3 1/2] checkasm: add test for fdct

2024-05-13 Thread James Almer
On 5/6/2024 2:49 PM, Rémi Denis-Courmont wrote: Le maanantaina 6. toukokuuta 2024, 20.18.11 EEST Ramiro Polla a écrit : I'll send a similar patch to fix checkasm/idctdsp after this is merged. The idctdsp test does not actually test the iDCT, but only the trivial-ish add/put helpers, so it does

[FFmpeg-devel] [PATCH 10/10] checkasm/flacdsp: add a test for lpc33

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 32 1 file changed, 32 insertions(+) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index 96b7d05f7e..6f8e8817b5 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c

[FFmpeg-devel] [PATCH 09/10] avcodec/flacdsp: split off lpc33 into a dsp function

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/flacdec.c | 7 +-- libavcodec/flacdsp.c | 15 +++ libavcodec/flacdsp.h | 2 ++ 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index 6e6a2896b4..460d3bc01e 100644 --- a

[FFmpeg-devel] [PATCH 8/8 v2] x86/flacdsp: add an SSE4 version of wasted33

2024-05-12 Thread James Almer
flac_wasted_33_c: 214.1 flac_wasted_33_sse4: 103.2 Signed-off-by: James Almer --- Removed the AVX2 one as the lane crossing in pmovsxdq removed pretty much all speed up for processing twice the amount of data. libavcodec/x86/flacdsp.asm| 25 + libavcodec/x86

[FFmpeg-devel] [PATCH 6/8 v2] x86/flacdsp: add a SSE2 version of wasted32

2024-05-12 Thread James Almer
flac_wasted_32_c: 851.3 flac_wasted_32_sse2: 41.3 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 24 libavcodec/x86/flacdsp_init.c | 3 +++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/x86/flacdsp.asm b/libavcodec/x86/flacdsp.asm index

Re: [FFmpeg-devel] [PATCH 1/2] lavc/flacdsp: R-V V flac_wasted32

2024-05-12 Thread James Almer
On 5/12/2024 2:07 PM, Rémi Denis-Courmont wrote: T-Head C908: flac_wasted_32_c: 949.0 flac_wasted_32_rvv_i32: 278.7 --- libavcodec/riscv/flacdsp_init.c | 7 ++- libavcodec/riscv/flacdsp_rvv.S | 15 +++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/liba

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/flacdsp: split off wasted bit handling into dsp functions

2024-05-12 Thread James Almer
On 5/12/2024 1:15 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/flacdec.c | 8 ++-- libavcodec/flacdsp.c | 20 libavcodec/flacdsp.h | 3 +++ 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH 5/8 v2] checkasm/flacdsp: add a test for wasted32

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index d694c1093b..ee0897ed01 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c @@ -83,6

[FFmpeg-devel] [PATCH 8/8] x86/flacdsp: add SSE4 and AVX2 versions of wasted33

2024-05-12 Thread James Almer
flac_wasted_33_c: 214.1 flac_wasted_33_sse4: 133.6 flac_wasted_33_avx2: 93.1 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 24 libavcodec/x86/flacdsp_init.c | 6 ++ 2 files changed, 30 insertions(+) diff --git a/libavcodec/x86/flacdsp.asm b

[FFmpeg-devel] [PATCH 7/8] checkasm/flacdsp: add a test for wasted33

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index 343bee41ed..6abdd255a3 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c @@ -104,6

[FFmpeg-devel] [PATCH 6/8] x86/flacdsp: add a SSE2 version of wasted32

2024-05-12 Thread James Almer
flac_wasted_32_c: 851.3 flac_wasted_32_sse2: 53.3 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 15 +++ libavcodec/x86/flacdsp_init.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/libavcodec/x86/flacdsp.asm b/libavcodec/x86/flacdsp.asm index f38eb7db76

[FFmpeg-devel] [PATCH 5/8] checkasm/flacdsp: add a test for wasted32

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index d694c1093b..343bee41ed 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c @@ -83,6

[FFmpeg-devel] [PATCH 4/8] avcodec/flacdsp: split off wasted bit handling into dsp functions

2024-05-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/flacdec.c | 8 ++-- libavcodec/flacdsp.c | 20 libavcodec/flacdsp.h | 3 +++ 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index 91bbdc657d..6e6a2896b4 100644 --- a

[FFmpeg-devel] [PATCH 3/8] x86/flacdsp: add a SSE4 version of lpc16

2024-05-12 Thread James Almer
flac_lpc_16_13_c: 2841.3 flac_lpc_16_13_sse4: 2151.8 flac_lpc_16_16_c: 3382.8 flac_lpc_16_16_sse4: 2228.3 flac_lpc_16_29_c: 5800.3 flac_lpc_16_29_sse4: 3727.3 flac_lpc_16_32_c: 5972.8 flac_lpc_16_32_sse4: 4052.3 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 13

[FFmpeg-devel] [PATCH 2/2 v2] checkasm/flacdsp: sanitize lpc arguments

2024-05-11 Thread James Almer
Fixes signed integer overflows as reported by ubsan. Signed-off-by: James Almer --- Now allowing negative values. tests/checkasm/flacdsp.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index 6561b4ed20

[FFmpeg-devel] [PATCH 2/2] checkasm/flacdsp: sanitize lpc arguments

2024-05-11 Thread James Almer
Fixes signed integer overflows as reported by ubsan. Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index 6561b4ed20..bf25cea39c 100644 --- a/tests

[FFmpeg-devel] [PATCH 1/2] checkasm/flacdsp: run lpc benchmarks with an unmodified buffer

2024-05-11 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/flacdsp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c index b308237db1..6561b4ed20 100644 --- a/tests/checkasm/flacdsp.c +++ b/tests/checkasm/flacdsp.c @@ -58,6 +58,7

Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: Remove align dimension to fix crash

2024-05-10 Thread James Almer
On 5/10/2024 6:26 PM, Paul B Mahol wrote: On Fri, May 10, 2024 at 10:56 AM Zhao Zhili wrote: From: Zhao Zhili The alignment is handled by ff_default_get_video_buffer2. We shouldn't use the aligned width/height as FFFramePool width/height. It cause recreate FFFramePool inside ff_default_get_v

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/adts_header: Add ff_adts_header_parse_buf()

2024-05-10 Thread James Almer
On 5/10/2024 1:56 PM, Andreas Rheinhardt wrote: Most users of ff_adts_header_parse() don't already have an opened GetBitContext for the header, so add a convenience function for them. Also use a forward declaration of GetBitContext in adts_header.h as this avoids (implicit) inclusion of get_bits.

Re: [FFmpeg-devel] [PATCH] avformat/riffdec: add ch_layout used av_channel_layout_default.

2024-05-08 Thread James Almer
On 5/8/2024 11:28 PM, shiqizhu wrote: Signed-off-by: shiqizhu --- libavformat/riffdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c index b7a85a6ab2..89267e879d 100644 --- a/libavformat/riffdec.c +++ b/libavformat/riffdec

Re: [FFmpeg-devel] [PATCH 3/3] lavc/speedhqdec: Set AV_PICTURE_TYPE_I

2024-05-08 Thread James Almer
On 5/8/2024 5:01 PM, Marton Balint wrote: On Wed, 8 May 2024, Tomas Härdin wrote: What suprises me is that pict_type and the keyframe flag is not set already for decoding codecs with AV_CODEC_PROP_INTRA_ONLY flag. Is this intentional or just nobody had the time to set it up to work auto

Re: [FFmpeg-devel] [PATCH 1/3] lavc/speedhqdec: Add AV_CODEC_CAP_FRAME_THREADS

2024-05-08 Thread James Almer
On 5/8/2024 9:42 AM, Tomas Härdin wrote: Hi On a 36-core machine (Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz) with a 7 minute 125 Mbit/s 1080p sample and -thread_type frame -threads 36 this brings CPU utilization from 117% to 3174%, 58x realtime Without -threads 36 the utilization is only 16

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests

2024-05-07 Thread James Almer
On 5/7/2024 12:14 PM, Andreas Rheinhardt wrote: James Almer: The requirement is either 8 or 16 bytes alignment, not 32. This should help finding bugs in asm implementations. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 23 +-- 1 file changed, 9 insertions

<    1   2   3   4   5   6   7   8   9   10   >