Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Tue, Jul 12, 2016 at 1:47 PM, James Almer wrote: > What's the first libvpx version that supports vp8a and vp9a? > Configure currently checks for 0.9.1 as the oldest supported > version for vp8 decoding, 0.9.7 for vp8 encoding, and 1.3.0 for > both vp9 components. We then use a bunch of ifdeffer

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-15 Thread James Zern
On Thu, Jul 14, 2016 at 8:16 PM, James Zern wrote: > On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian > wrote: >> +ret = vpx_init( >> +avctx, >> +(avctx->

[FFmpeg-devel] [PATCH 0/3] bump libvpx-vp9 minimum to 1.4.0

2016-07-15 Thread James Zern
This compiles against 0.9.0->1.5.0 and tip of tree with checks at each for expected encoder/decoder availability and colorspaces. Note libvpxdec's ifdefs are within shared code, splitting set_pix_fmt() would be an option. James Zern (3): configure: require libvpx-1.4.0 for vp9 support

[FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-15 Thread James Zern
this will simplify libvpxenc/dec.c and ensure a more stable vp9 encoder is present. Signed-off-by: James Zern --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0c7b5e9..511ecfe 100755 --- a/configure +++ b/configure @@ -5717,13

[FFmpeg-devel] [PATCH 2/3] libvpx: remove pre-1.4.0 checks for vp9

2016-07-15 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index 1eca97a..36f915a 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -40,9 +40,7 @@ static const enum

[FFmpeg-devel] [PATCH 3/3] libvpxenc: remove pre-1.4.0 checks for vp9

2016-07-15 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c5b1b86..7489c2f 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -128,9 +128,7

Re: [FFmpeg-devel] [PATCH 2/3] libvpx: remove pre-1.4.0 checks for vp9

2016-07-18 Thread James Zern
On Fri, Jul 15, 2016 at 7:30 PM, James Almer wrote: > On 7/15/2016 10:15 PM, James Zern wrote: >> Signed-off-by: James Zern >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-18 Thread James Zern
On Sun, Jul 17, 2016 at 3:05 AM, Nicolas George wrote: > L'octidi 28 messidor, an CCXXIV, James Zern a écrit : >> this will simplify libvpxenc/dec.c and ensure a more stable vp9 encoder >> is present. >> >> Signed-off-by: James Zern >> --- >>

Re: [FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-18 Thread James Zern
On Mon, Jul 18, 2016 at 12:00 PM, James Zern wrote: > On Sun, Jul 17, 2016 at 3:05 AM, Nicolas George wrote: >> L'octidi 28 messidor, an CCXXIV, James Zern a écrit : >>> this will simplify libvpxenc/dec.c and ensure a more stable vp9 encoder >>> is present. &

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-19 Thread James Zern
On Fri, Jul 15, 2016 at 3:29 PM, James Zern wrote: > On Thu, Jul 14, 2016 at 8:16 PM, James Zern wrote: >> On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian >> wrote: >>> +ret = vpx_init( >>> +avctx, >>

[FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-20 Thread James Zern
+ the context struct Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index f7acc39..5204c99 100644 --- a/libavcodec/libvpxdec.c +++ b

[FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-20 Thread James Zern
+ the context struct Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c5b1b86..f3cff81 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH 0/3] bump libvpx-vp9 minimum to 1.4.0

2016-07-21 Thread James Zern
On Fri, Jul 15, 2016 at 7:31 PM, James Almer wrote: > On 7/15/2016 10:15 PM, James Zern wrote: >> This compiles against 0.9.0->1.5.0 and tip of tree with checks at each for >> expected encoder/decoder availability and colorspaces. >> Note libvpxdec's ifdefs are

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer wrote: > On Wed, Jul 20, 2016 at 09:05:14PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern >> --- >> libavcodec/libvpxdec.c | 28 ++-- >> 1 file

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer wrote: > On Wed, Jul 20, 2016 at 09:05:15PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern >> --- >> libavcodec/libvpxenc.c | 60 >> +-

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Avaoid vp8 transparency encoding with auto-alt-ref

2016-09-16 Thread James Zern
On Fri, Sep 16, 2016 at 5:23 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5815. > > +if (ctx->auto_alt_ref && ctx->is_alpha && avctx->codec_id == > AV_CODEC_ID_VP8) { > +av_log(avctx, AV_LOG_ERROR, "Transparency encoding with auto_alt_ref > does not work\n"); >

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Avaoid vp8 transparency encoding with auto-alt-ref

2016-09-16 Thread James Zern
On Fri, Sep 16, 2016 at 4:50 PM, Carl Eugen Hoyos wrote: > 2016-09-17 1:48 GMT+02:00 James Zern: >> On Fri, Sep 16, 2016 at 5:23 AM, Carl Eugen Hoyos wrote: > >>> Attached patch fixes ticket #5815. >> >>> +if (ctx->auto_alt_ref && ctx->i

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
Hi, On Thu, Feb 18, 2016 at 3:30 PM, Carl Eugen Hoyos wrote: > Please comment, Carl Eugen > diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c > index a60d186..1e7010b 100644 > --- a/libavcodec/libvpx.c > +++ b/libavcodec/libvpx.c > @@ -46,14 +46,14 @@ static const enum AVPixelFormat vp9_pix_

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
reprocessor checks. I think VPX_IMAGE_ABI_VERSION >= 3 > should do it, but better wait for James Zern for confirmation. That's correct. This would prevent the user from overriding the decision with unspecified/reserved, not sure it matters. ___

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:34 PM, Carl Eugen Hoyos wrote: >> Alternatively we could bump the minimum required version and remove most of >> the existing checks. 1.3.0 is pretty old by now and it would let us clean >> these files. > > I would prefer if this could be done independently (and afterward

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:02 PM, Hendrik Leppkes wrote: > On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: >> On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: >>> Initial patch by Carl Eugen Hoyos. >>> >>> Fix trac ticket #5249. >> >> Patch with (automatic) support for 8, 1

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: > On Friday 19 February 2016 07:59:37 am James Zern wrote: > >> The decoder won't change when built on a big-endian platform, so I don't >> think this is correct. > > New patch attached. > Sorry, I

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:00 AM, Carl Eugen Hoyos wrote: > James Zern google.com> writes: > >> On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos > > On Friday 19 February 2016 07:59:37 am James Zern wrote: >> > >> >> The decoder won't change

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:43 AM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> On Fri, Feb 19, 2016 at 8:47 AM, James Zern wrote: >> > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: >> >> On Friday 19 February 2016 07:59:37 a

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:17 PM, Carl Eugen Hoyos wrote: > Could you comment on ticket #3271 (is alpha possible in > vp9?) and #4105? I added some notes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-de

[FFmpeg-devel] [PATCH] libvpxenc: quiet unused-variable warning

2016-02-20 Thread James Zern
with older versions of libvpx since: 432be63 lavc/libvpx: Fix support for RGB colorspace. Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 1239103..b1114bc 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] libvpxenc: quiet unused-variable warning

2016-02-22 Thread James Zern
On Sat, Feb 20, 2016 at 11:39 AM, James Almer wrote: > On 2/20/2016 4:26 PM, James Zern wrote: >> with older versions of libvpx >> since: >> 432be63 lavc/libvpx: Fix support for RGB colorspace. >> >> Signed-off-by: James Zern >> --- >> libavc

Re: [FFmpeg-devel] [PATCH 1/2] libwebpenc_animencoder: zero initialize the WebPAnimEncoderOptions struct

2016-03-19 Thread James Zern
On Wed, Mar 16, 2016 at 9:03 PM, James Almer wrote: > This zeroes the WebPAnimEncoderOptions.verbose field, silencing library info > messages > printed to stderr. > > Signed-off-by: James Almer > --- > libavcodec/libwebpenc_animencoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 2/2] libwebpenc_animencoder: print library messages in verbose log levels

2016-03-19 Thread James Zern
On Wed, Mar 16, 2016 at 9:03 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libwebpenc_animencoder.c | 2 ++ > 1 file changed, 2 insertions(+) > lgtm. Not really sure if this logging in the lib was really necessary... > diff --git a/libavcodec/libwebpenc_animencoder.c

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-06-30 Thread James Zern
On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian wrote: > Chrome canary now supports decoding of VP9 streams with alpha > channel [1]. Add support to ffmpeg for creating such files. > > [1] https://codereview.chromium.org/2096813002/ > > Signed-off-by: Vignesh Venkatasubramanian > ---

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread James Zern
On Fri, Jul 1, 2016 at 10:07 AM, Carl Eugen Hoyos wrote: >> Do we have decoder support (for either vp8 or vp9) for these files? > > No, only encoding and muxing. > Seems like a feature request, but no reason to block this one if the vp8 one is here. ___

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread James Zern
On Fri, Jul 1, 2016 at 9:23 AM, Vignesh Venkatasubramanian wrote: > On Thu, Jun 30, 2016 at 10:37 PM, James Zern > wrote: >> On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian >> wrote: >>> Chrome canary now supports decoding of VP9 streams with alpha >

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-11 Thread James Zern
On Thu, Jul 7, 2016 at 11:43 AM, Vignesh Venkatasubramanian wrote: > VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the > ability to decode such files with alpha channel. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavcodec/libvpxdec.c | 111 +

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread James Zern
On Thu, Mar 2, 2017 at 11:00 AM, Kagami Hiiragi wrote: > From ae3856c302284d60761c3ad122ff49b7b9b68114 Mon Sep 17 00:00:00 2001 > From: Kagami Hiiragi > Date: Thu, 2 Mar 2017 21:19:09 +0300 > Subject: [PATCH] lavc/libvpxenc: add -row-mt option > > --- > libavcodec/libvpxenc.c | 11 +++ >

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-03 Thread James Zern
On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi wrote: > [...] > > Updated. I don't think -slices would fit logically because -row-mt is boolean > and -slices is integer. > > --- > libavcodec/libvpxenc.c | 11 +++ > 1 file changed, 11 insertions(+) > Looks all right, I'll submit it soon

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-06 Thread James Zern
On Fri, Mar 3, 2017 at 4:52 PM, James Zern wrote: > On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi wrote: >> [...] >> >> Updated. I don't think -slices would fit logically because -row-mt is >> boolean and -slices is integer. >> >> --- >>

[FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
this is undocumented in the vp9 bitstream and decoding specification doc, but matches libvpx Signed-off-by: James Zern --- libavcodec/vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7d8aced8c8..94430db9a3 100644 --- a

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
On Fri, Aug 18, 2017 at 8:31 PM, James Zern wrote: > this is undocumented in the vp9 bitstream and decoding specification > doc, but matches libvpx > this came up in comparing decode results of ffvp9 and libvpx with source from a hardware encoder. > Signed-off-by

[FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
this is undocumented in the vp9 bitstream and decoding specification doc, but matches libvpx Signed-off-by: James Zern --- libavcodec/vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7d8aced8c8..94430db9a3 100644 --- a

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-21 Thread James Zern
On Sat, Aug 19, 2017 at 8:04 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Aug 18, 2017 at 11:31 PM, James Zern wrote: >> >> this is undocumented in the vp9 bitstream and decoding specification >> doc, but matches libvpx >> >> Signed-off-by: James Zern &

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread James Zern
On Fri, Aug 22, 2014 at 10:53 AM, Deb Mukherjee wrote: > [...] > @@ -311,7 +316,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > } else { > if (enccfg.rc_end_usage == VPX_CQ) { > enccfg.rc_target_bitrate = 100; > -} else { > +} else if (enccf

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread James Zern
On Tue, Aug 26, 2014 at 10:30 AM, Deb Mukherjee wrote: > Changes in the parameter mapping for libvpx to support the constant > quality mode in VP9. The assumption in the patch is that if crf is > provided but bitrate is 0, then the 'constant quality' mode of VP9 > is used. However if both are pres

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-27 Thread James Zern
On Wed, Aug 27, 2014 at 1:04 PM, Deb Mukherjee wrote: > Changes in the parameter mapping for libvpx to support the constant > quality mode in VP9. The assumption in the patch is that if crf is > provided but bitrate is 0, then the 'constant quality' mode of VP9 > is used. However if both are prese

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG.

2020-11-18 Thread James Zern
Hi, On Mon, Nov 16, 2020 at 2:36 PM Wonkap Jang wrote: > > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > libavcodec/libvpxenc.c | 77

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > > Signed-off-by: James Almer > --- > There doesn't seem to be any proper API to check if an encoder is open. > true. > libavcodec/libaomenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > lgtm. > diff --git a/libavcodec/liba

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > > On 8/25/2022 2:34 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > >> > >> Signed-off-by: James Almer > >> --- > >> There doesn't seem to be any proper

[FFmpeg-devel] [PATCH] avcodec/libaomenc: fix compile after 5bab794

2022-08-25 Thread James Zern
encoder is a struct, not a pointer; use '.' to access iface. Signed-off-by: James Zern --- libavcodec/libaomenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index a82b933c18..1e89b7e3a8 100644 --- a/libavcodec/l

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 12:28 PM James Almer wrote: > > On 8/25/2022 4:21 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > >> > >> On 8/25/2022 2:34 PM, James Zern wrote: > >>> On Thu, Aug 25, 2022 at 10:16 AM James Almer

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: fix compile after 5bab794

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 12:30 PM James Zern wrote: > > encoder is a struct, not a pointer; use '.' to access iface. > > Signed-off-by: James Zern > --- > libavcodec/libaomenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Already fixed. >

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval

2022-09-13 Thread James Zern
this maps to the vpxenc argument with the same name and the VP9E_SET_MIN_GF_INTERVAL codec control Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 11 +++ libavcodec/version.h | 2 +- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread James Zern
On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian wrote: > > According to the HEIF specification Section 7.5.3.1, tracks with It might be worth adding ISO/IEC 23008-12 for added precision. > handler_type 'auxv' must contain a 'auxi' box in its > SampleEntry to notify the nature of the a

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-21 Thread James Zern
On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian wrote: > > According to the HEIF specification (ISO/IEC 23008-12) Section > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box > in its SampleEntry to notify the nature of the auxiliary track to the > decoder. > > The conte

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-22 Thread James Zern
On Wed, Sep 21, 2022 at 12:14 PM James Zern wrote: > > On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian > wrote: > > > > According to the HEIF specification (ISO/IEC 23008-12) Section > > 7.5.3.1, tracks with handler_type 'auxv' must contain a

[FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libaomdec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 378d638a89..53982559d9 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@ -113,15 +113,19

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread James Zern
On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > Signed-off-by: James Zern > --- > libavcodec/libaomdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > I was reminded that there was an earlier patch [1], which I had an open comment on. I think

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-31 Thread James Zern
On Tue, Oct 25, 2022 at 10:02 PM James Zern wrote: > > On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > > > Signed-off-by: James Zern > > --- > > libavcodec/libaomdec.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > &g

Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64

2022-11-21 Thread James Zern
On Tue, Oct 25, 2022 at 8:56 AM Dmitrii Ovchinnikov wrote: > > >> Why do you still impose an upper limit unconditionally even if the > >>user has set his preferred number of threads? > Libvpx-vp9 does not support number of threads greater than 64, so we impose > an upper limit of 64. > E.g. if we

Re: [FFmpeg-devel] [PATCH v2 05/31] avcodec/libvpxenc: use av_dict_iterate

2022-11-30 Thread James Zern
On Sat, Nov 26, 2022 at 6:47 AM Marvin Scholz wrote: > > --- > libavcodec/libvpxenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 667cffc200..9aa5510c28 100644 > --- a/libavcodec/libvpxenc.c > +++ b/l

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-09 Thread James Zern
On Thu, Jan 5, 2023 at 2:42 AM Dmitrii Ovchinnikov wrote: > > From: Dmitrii Ovchinnikov > > This change improves the performance and multicore > scalability of the vp9 codec for streaming single-pass encoded videos. The > current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in > pthr

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-10 Thread James Zern
On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > wrote: > [...] > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 9aa5510c28..0627e13973 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-17 Thread James Zern
On Tue, Jan 10, 2023 at 5:23 PM James Zern wrote: > > On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > > wrote: > > [...] > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxe

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG.

2020-11-25 Thread James Zern
On Mon, Nov 23, 2020 at 2:49 PM Wonkap Jang wrote: > > Hi James, > > On Wed, Nov 18, 2020 at 1:13 PM James Zern > wrote: > > > Hi, > > > > On Mon, Nov 16, 2020 at 2:36 PM Wonkap Jang > > wrote: > > > > > > In order to fine-control r

Re: [FFmpeg-devel] [PATCH v2] In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API throu

2020-12-14 Thread James Zern
Hi, On Mon, Dec 14, 2020 at 11:54 AM Wonkap Jang wrote: > > > > On Mon, Dec 7, 2020 at 11:57 PM Wonkap Jang wrote: >> >> --- >> doc/encoders.texi | 32 + >> libavcodec/libvpxenc.c | 79 ++ >> 2 files changed, 111 insertions(+) >> So

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-17 Thread James Zern
On Tue, Dec 15, 2020 at 9:24 AM Wonkap Jang wrote: > > Hi James > > On Tue, Dec 15, 2020 at 9:18 AM Wonkap Jang wrote: >> >> In order to fine-control referencing schemes in VP9 encoding, there >> is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit >> provides a way to use the API t

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-21 Thread James Zern
On Thu, Dec 17, 2020 at 2:43 PM Wonkap Jang wrote: > > > > On Thu, Dec 17, 2020 at 10:48 AM James Zern wrote: >> >> On Tue, Dec 15, 2020 at 9:24 AM Wonkap Jang wrote: >> > >> > Hi James >> > >> > On Tue, Dec 15, 2020 at 9:18

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-07 Thread James Zern
Hi, On Wed, Jan 6, 2021 at 8:59 AM Wonkap Jang wrote: > > HI JAmes, > > On Tue, Dec 29, 2020 at 11:54 AM Wonkap Jang < > wonkap-at-google@ffmpeg.org> wrote: > > > Hi James, > > > > On Tue, Dec 29, 2020 at 11:51 AM Wonkap Jang wrote: > > > > > In order to fine-control referencing schemes in V

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-08 Thread James Zern
On Thu, Jan 7, 2021 at 11:56 PM Wonkap Jang wrote: > > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders.texi | 32 +

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-12 Thread James Zern
On Fri, Jan 8, 2021 at 3:33 PM Wonkap Jang wrote: > > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders.texi | 32 ++

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-14 Thread James Zern
On Tue, Jan 12, 2021 at 3:28 PM James Zern wrote: > > On Fri, Jan 8, 2021 at 3:33 PM Wonkap Jang > wrote: > > > > In order to fine-control referencing schemes in VP9 encoding, there > > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > > prov

Re: [FFmpeg-devel] [PATCH] libvpx: add support for yuv440p and yuv440p10/12 encoding

2015-05-20 Thread James Zern
On Wed, May 20, 2015 at 2:05 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libvpx.c| 4 > libavcodec/libvpxenc.c | 24 +++- > 2 files changed, 27 insertions(+), 1 deletion(-) > lgtm ___ ffmpeg-dev

[FFmpeg-devel] [PATCH] doc/muxers.texi: properly insert {}s in example

2015-06-15 Thread James Zern
use '@{' / '@}', fixes compile errors: *** '{' without macro. Before: 1:-'.'} *** '}' without opening '{' before: since: 907ac20 avformat/hlsenc: added HLS encryption Signed-off-by: James Zern --- doc/muxers.texi | 2 +- 1 f

[FFmpeg-devel] [PATCH] libvpxenc: support setting colorspace for vp9

2015-06-17 Thread James Zern
the vp9 bitstream supports 8 values: unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved and sRGB. --- doc/encoders.texi | 12 libavcodec/libvpxenc.c | 29 + 2 files changed, 41 insertions(+) diff --git a/doc/encoders.texi b/doc/enco

Re: [FFmpeg-devel] [PATCH] libvpxenc: add color-space option for vp9

2015-06-17 Thread James Zern
On Tue, Jun 16, 2015 at 10:58 PM, James Almer wrote: > On 16/06/15 2:43 AM, James Zern wrote: >> the vp9 bitstream supports 8 values: >> unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved >> and sRGB. >> --- >> doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] libvpxenc: support setting colorspace for vp9

2015-06-20 Thread James Zern
On Sat, Jun 20, 2015 at 12:29 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jun 20, 2015 at 3:15 PM, James Zern wrote: > >> On Wed, Jun 17, 2015 at 12:20 PM, James Zern wrote: >> > the vp9 bitstream supports 8 values: >> > unknown (default), bt601, bt709,

[FFmpeg-devel] [PATCH 2/2] libvpxdec: report colorspace

2015-06-23 Thread James Zern
--- libavcodec/libvpxdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index b31e7b9..0e3ed6f 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -62,6 +62,13 @@ static av_cold int vpx_init(AVCodecContext *avctx, // re

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec: report profile for vp9

2015-06-23 Thread James Zern
On Tue, Jun 23, 2015 at 4:18 PM, Ronald S. Bultje wrote: > Hello, > > On Tue, Jun 23, 2015 at 6:21 PM, James Zern wrote: > >> --- >> libavcodec/libvpxdec.c | 20 >> 1 file changed, 20 insertions(+) >> > > lgtm. > > (This is p

Re: [FFmpeg-devel] [PATCH 2/2] libvpxdec: report colorspace

2015-06-24 Thread James Zern
On Tue, Jun 23, 2015 at 4:19 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 23, 2015 at 6:21 PM, James Zern wrote: > >> --- >> libavcodec/libvpxdec.c | 7 +++ >> 1 file changed, 7 insertions(+) > > > sgtm. > applied __

[FFmpeg-devel] [PATCH] vp9_parser: fix endless loop w/0-sized frame

2015-10-16 Thread James Zern
treat this the same as an over-sized superframe packet to break out of the parser loop and allow the decoder to fail. Signed-off-by: James Zern --- libavcodec/vp9_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c

Re: [FFmpeg-devel] [PATCH] vp9_parser: fix endless loop w/0-sized frame

2015-10-19 Thread James Zern
On Fri, Oct 16, 2015 at 4:05 PM, Ronald S. Bultje wrote: > > Hi, > > On Fri, Oct 16, 2015 at 6:46 PM, James Zern wrote: > > > treat this the same as an over-sized superframe packet to break out of > > the parser loop and allow the decoder to fail. > &

[FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

2015-10-19 Thread James Zern
VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed from libvpx and the remaining values were never used here Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 8 1 file changed, 8 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index

Re: [FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

2015-10-20 Thread James Zern
On Tue, Oct 20, 2015 at 7:02 AM, Michael Niedermayer wrote: > On Mon, Oct 19, 2015 at 10:49:16PM -0700, James Zern wrote: >> VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed >> from libvpx and the remaining values were never used here >> >> Signed-o

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-07 Thread James Zern
Hi, On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: >> Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION >> to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? > > Yes, bumping any of the defines would

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Improve documentation for cpu-used

2016-01-08 Thread James Zern
On Fri, Jan 8, 2016 at 1:58 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5140 here, seems to match: > https://github.com/webmproject/libvpx/commit/a16f07537501ac96531577d5af004ad0b591a705 > > Please comment, Carl Eugen > lgtm. thanks.

[FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

2016-01-11 Thread James Zern
since: cbcc88c libvpx: Support setting color range for vp9. Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index de72be9..b51bfa2 100644 --- a/libavcodec/libvpxdec.c +++ b

Re: [FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

2016-01-12 Thread James Zern
On Tue, Jan 12, 2016 at 5:40 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 1:43 AM, James Zern wrote: > >> since: >> cbcc88c libvpx: Support setting color range for vp9. >> >> Signed-off-by: James Zern >> -

Re: [FFmpeg-devel] [PATCH] libvpxenc: Allow setting tune parameter

2016-02-02 Thread James Zern
On Tue, Feb 2, 2016 at 6:10 PM, Timothy Gu wrote: > --- > doc/encoders.texi | 6 ++ > libavcodec/libvpxenc.c | 8 > 2 files changed, 14 insertions(+) > lgtm > diff --git a/doc/encoders.texi b/doc/encoders.texi > index c485f90..e9311eb 100644 > --- a/doc/encoders.texi > +++ b/d

[FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-28 Thread James Zern
--- libavcodec/libvpxenc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index fb412b7..1a1d55f 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -717,12 +717,16 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-28 Thread James Zern
--- libavcodec/libvpxenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 1a1d55f..3db617d 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -690,6 +690,7 @@ static int storeframe(AVCodecContext

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:50 AM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 12:47:08PM +0200, Michael Niedermayer wrote: >> On Tue, Jul 28, 2015 at 11:12:31PM -0700, James Zern wrote: >> > --- >> > libavcodec/libvpxenc.c | 8 ++-- >> > 1 file c

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:48 AM, Michael Niedermayer wrote: > On Tue, Jul 28, 2015 at 11:12:32PM -0700, James Zern wrote: >> --- >> libavcodec/libvpxenc.c | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) > > LGTM > applied > thanks &

Re: [FFmpeg-devel] [PATCH] libvpxenc: make flags i64 instead of dbl.

2015-08-17 Thread James Zern
On Mon, Aug 17, 2015 at 2:11 PM, Ronald S. Bultje wrote: > --- > libavcodec/libvpxenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 58e8f5d..5f39783 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavc

Re: [FFmpeg-devel] [PATCH] libvpxdec: explicitly signal RGB.

2015-09-03 Thread James Zern
On Thu, Sep 3, 2015 at 6:38 AM, Ronald S. Bultje wrote: > --- > libavcodec/libvpxdec.c | 15 +++ > 1 file changed, 15 insertions(+) > lgtm > diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c > index 52a89ca..eb05f26 100644 > --- a/libavcodec/libvpxdec.c > +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] vp9: reset segmentation information on context reset.

2015-09-03 Thread James Zern
On Tue, Sep 1, 2015 at 1:44 PM, Ronald S. Bultje wrote: > --- > libavcodec/vp9.c | 1 + > 1 file changed, 1 insertion(+) > lgtm > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 4503ed7..7035512 100644 > --- a/libavcodec/vp9.c > +++ b/libavcodec/vp9.c > @@ -707,6 +707,7 @@ static int d

Re: [FFmpeg-devel] [PATCH] libvpxdec: apply RGB to 444P16 instead of 422P16.

2015-09-11 Thread James Zern
On Fri, Sep 11, 2015 at 10:43 AM, Ronald S. Bultje wrote: > --- > libavcodec/libvpxdec.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > lgtm. sorry I wasn't paying attention with the last patch. > diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c > i

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-03-27 Thread James Zern
On Fri, Mar 27, 2015 at 6:58 PM, Debargha Mukherjee wrote: > [...] > +#if CONFIG_LIBVPX_VP9_ENCODER && defined(VPX_IMG_FMT_HIGHBITDEPTH) > +static int set_pix_fmt(AVCodecContext *avctx, struct vpx_codec_enc_cfg > *enccfg, > + vpx_codec_flags_t *flags, vpx_img_fmt_t *img_fmt

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-04-18 Thread James Zern
On Thu, Apr 16, 2015 at 6:19 PM, Debargha Mukherjee wrote: > Resolutions inline... > > From d84e140ed83bdc3889720e4a6af330198176b839 Mon Sep 17 00:00:00 2001 > From: Deb Mukherjee > Date: Wed, 25 Mar 2015 17:10:16 -0700 > Subject: [PATCH] Support for VP9 high-color/high-bit-depth encoding > > Pat

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-04-20 Thread James Zern
On Sat, Apr 18, 2015 at 1:06 PM, James Zern wrote: > On Thu, Apr 16, 2015 at 6:19 PM, Debargha Mukherjee > wrote: >> Resolutions inline... >> >> From d84e140ed83bdc3889720e4a6af330198176b839 Mon Sep 17 00:00:00 2001 >> From: Deb Mukherjee >> Date: Wed, 2

[FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-22 Thread James Zern
this quiets a warning: Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified internal error --- libavcodec/libvpxenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 2104876..159fbdd 100644 --- a/libavcod

[FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 8ece341..8f4a18b 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -330,7 +330,7 @@ git push Will push

Re: [FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
On Wed, Apr 22, 2015 at 8:59 PM, James Zern wrote: > s/Refer to and to sync/Refer to how to sync/ > --- > doc/git-howto.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/git-howto.texi b/doc/git-howto.texi > index 8ece341..8f4a18b 100644 >

<    1   2   3   4   5   >