[FFmpeg-devel] [PATCH 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7

[FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-23 Thread Josh de Kock
This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a full rewrite. I personally would like to

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-23 Thread Josh de Kock
On 2018/03/23 10:05, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. I personally think this will fix a lot of the weird interactions between the two libraries, and should

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 22:38, Michael Niedermayer wrote: > On Thu, Mar 22, 2018 at 02:01:27AM +0000, Josh de Kock wrote: > [...] >> +#ifdef CONFIG_AVDEVICE >> +opaque = 0; >> +if (muxdemuxers != SHOW_DEMUXERS) { >> +wh

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 12:07, Nicolas George wrote: Josh de Kock (2018-03-22): Merging lavd into lavf may be the best option here, as it allows us to change the return type of av_iterate_indev() etc to an AVDevice or another type which may represent an actual device as opposed to a purely input/output

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 11:37, wm4 wrote: On Thu, 22 Mar 2018 12:32:29 +0100 Nicolas George <geo...@nsup.org> wrote: Josh de Kock (2018-03-22): There is always the option to just merge lavf and lavd. The state of them being sort-of merged, but not really, isn't very good and adds a lot of comp

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 11:19, Nicolas George wrote: Josh de Kock (2018-03-22): I strongly oppose using the same loop. Separating devices' iteration is one of the first steps to separating lavf from lavd. And I oppose separating lavf from lavd, was it not clear enough? I have given technical arguments

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 10:29, Nicolas George wrote: Josh de Kock (2018-03-22): I have -ffunroll'd the macros for you Nicolas. That is not what I asked. The macros were just a way of making the poor API a little less poor, but the problem still remains: +#ifdef CONFIG_AVDEVICE +opaque = 0

[FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-21 Thread Josh de Kock
--- I have -ffunroll'd the macros for you Nicolas. fftools/cmdutils.c | 248 - 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..956eb7b974 100644 ---

[FFmpeg-devel] [PATCH 5/7] lavf, lavd: add AVClass for lavd & use iterate API

2018-03-21 Thread Josh de Kock
Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

[FFmpeg-devel] [PATCH v3 7/7] lavf/img2dec: use new iteration API

2018-03-19 Thread Josh de Kock
--- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int ff_img_read_header(AVFormatContext *s1)

[FFmpeg-devel] [PATCH v3 4/7] fftools/ff*.c: use iteration API to find formats

2018-03-19 Thread Josh de Kock
With the new API, if avdevice_register_all() isn't called av_find_input_format() wont find devices, so switch to the new API to make sure devices would always be checked if they are available even if devices are not registered through the old API. --- fftools/ffmpeg_opt.c | 25

[FFmpeg-devel] [PATCH v3 6/7] lav*, tests: remove several register_all() calls

2018-03-19 Thread Josh de Kock
--- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc/examples/transcoding.c | 2 -- fftools/ffmpeg.c | 6 -- fftools/ffplay.c | 7 --- fftools/ffprobe.c| 4

[FFmpeg-devel] [PATCH v3 0/7] Implementation of option one

2018-03-19 Thread Josh de Kock
ptions 2-4 wouldn't include this set as they would be replaced by other sets: 2) would change the way this patch has interactions between lavf and lavd. 3) would remove the interactions between lavf and lavd as they would just be the same library. 4) this set wouldnt exist. Josh de Kock (7): che

[FFmpeg-devel] [PATCH v3 3/7] cmdutils: use new iteration APIs

2018-03-19 Thread Josh de Kock
--- fftools/cmdutils.c | 239 + 1 file changed, 112 insertions(+), 127 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..2da313cc0a 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11

[FFmpeg-devel] [PATCH v3 5/7] lavf, lavd: add AVClass for lavd & use iterate API

2018-03-19 Thread Josh de Kock
Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

[FFmpeg-devel] [PATCH v3 2/7] lavfi: add new iteration API

2018-03-19 Thread Josh de Kock
--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 818 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7

[FFmpeg-devel] [PATCH v3 1/7] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-19 Thread Josh de Kock
--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS +=

[FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

2018-03-18 Thread Josh de Kock
Hi, The new iteration API to replace the old _next() is nearing the end of it's completion with the lavfi patch on the mailing list and only one outstanding issue: AVOptions would not be found for devices as there is no AVClass for lavd. At the moment it would work if you were to still call

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

2018-03-18 Thread Josh de Kock
On 2018/03/18 8:23, wm4 wrote: > On Sun, 18 Mar 2018 08:44:12 +0100 > Jörn Heusipp wrote: > >> On 03/04/2018 08:55 AM, Jörn Heusipp wrote: >>> On 02/21/2018 12:11 PM, Jörn Heusipp wrote: libavformat/libopenmpt.c | 57

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-18 Thread Josh de Kock
On Sun, Mar 18, 2018 at 01:42:12PM -0300, James Almer wrote: > On 3/18/2018 1:06 PM, Paul B Mahol wrote: > > [...] > > And how do you know that?, without even providing alternative? > > I provided an alternative. Look at my comment about the *_FFLIBS > variables. The build system already uses it

[FFmpeg-devel] [PATCH v2 1/2] lav*, tests: remove several register_all() calls

2018-03-18 Thread Josh de Kock
Because lavf and lavd being separated incrementally, some of the hacky behaviour in how options are found/parsed is being exposed. Basically, finding options works on some behaviour with iterating AVClasses, and making lavd not a hack-of-a-library incrementally (i.e. by separating iteration)

[FFmpeg-devel] [PATCH 2/2] lavf/img2dec: use new iteration API

2018-03-18 Thread Josh de Kock
--- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int ff_img_read_header(AVFormatContext *s1)

Re: [FFmpeg-devel] [PATCH 4/4] lavc, lavd, lavf, lavfi, tests: remove several register() calls

2018-03-18 Thread Josh de Kock
> On 18 Mar 2018, at 13:40, j...@itanimul.li wrote: > > From: Josh de Kock <j...@itanimul.li> > > --- > doc/examples/filter_audio.c | 2 -- > doc/examples/filtering_audio.c | 2 -- > doc/examples/filtering_video.c | 2 -- > doc/examples/transcoding.

[FFmpeg-devel] [PATCH 1/3] lavfi: add new iteration API

2018-02-18 Thread Josh de Kock
--- Managed to send the wrong version of the patch. FATE is still running, and will take a few hours on my machine, so I will update these patches if I find any issues. I wanted to get them on the ML earlier so that others could start taking a look. configure| 23 +-

[FFmpeg-devel] [PATCH 2/3] cmdutils: use new iteration APIs

2018-02-18 Thread Josh de Kock
--- fftools/cmdutils.c | 239 + 1 file changed, 112 insertions(+), 127 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 0c7d13c..c341f8f 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11 @@ int

[FFmpeg-devel] [PATCH 3/3] lavc, lavd, lavf, lavfi, tests: remove several register() calls

2018-02-18 Thread Josh de Kock
--- libavdevice/lavfi.c | 2 -- libavfilter/lavfutils.c | 2 -- libavfilter/src_movie.c | 2 -- libavfilter/tests/filtfmts.c | 2 -- libavformat/tests/movenc.c | 2 -- libavformat/tests/seek.c | 3 --- tests/api/api-band-test.c| 2 --

[FFmpeg-devel] [PATCH 1/3] lavfi: add new iteration API

2018-02-18 Thread Josh de Kock
--- configure| 23 +- doc/APIchanges | 4 + libavfilter/allfilters.c | 817 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 5 +- 6 files changed, 475 insertions(+),

[FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-18 Thread Josh de Kock
This should be the last of the major API changes. I'm not entirely sure if I missed anything. Josh -- configure| 23 --- doc/APIchanges | 4 ++ fftools/cmdutils.c | 239

[FFmpeg-devel] [PATCH] cmdutils: fix printing of codecs

2018-02-07 Thread Josh de Kock
Yes, my bad. It looked like it worked initially (was more worried about getting a fix out quickly), but it didnt. Try this one. --- fftools/cmdutils.c | 104 + 1 file changed, 58 insertions(+), 46 deletions(-) diff --git a/fftools/cmdutils.c

[FFmpeg-devel] [PATCH] cmdutils: fix finding next codec for id

2018-02-07 Thread Josh de Kock
--- fftools/cmdutils.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 0b06ccc71a..8bb9952016 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1424,11 +1424,14 @@ static char get_media_type_char(enum

Re: [FFmpeg-devel] [PATCH v4 1/7] lavc: add new API for iterating codecs and codec parsers

2018-02-06 Thread Josh de Kock
On Fri, Feb 02, 2018 at 07:44:12PM +, Josh de Kock wrote: > Based on an unfinished patch by atomnuker. > --- > [...] Set pushed with fixes for all other outstanding issues. lavfi device works for me on both macOS and Linux with this set. All passes FATE. -- Jos

Re: [FFmpeg-devel] [PATCH v4 4/7] lavf: move fifo test muxer into separate file

2018-02-05 Thread Josh de Kock
On Mon, Feb 05, 2018 at 07:59:56PM +0100, wm4 wrote: > On Mon, 5 Feb 2018 23:49:30 +0700 > Muhammad Faiz <mfc...@gmail.com> wrote: > > > On Sat, Feb 3, 2018 at 2:44 AM, Josh de Kock <j...@itanimul.li> wrote: > > > This fixes the fate-fifo-muxer test. &

Re: [FFmpeg-devel] [PATCH v4 5/7] lavd: add new API for iterating input and output devices

2018-02-05 Thread Josh de Kock
^ libavdevice. Yes, this just needs to use the lists which are registered from the avpriv function. I will fix that before I push. -- Josh de Kock ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v4 6/7] cmdutils: make use of new iteration APIs

2018-02-05 Thread Josh de Kock
On 2 Feb 2018, at 19:44, Josh de Kock <j...@itanimul.li> wrote: > > --- > fftools/cmdutils.c | 122 +++-- > 1 file changed, 43 insertions(+), 79 deletions(-) > > [...] Will push this set tomorrow if no one explicitl

Re: [FFmpeg-devel] [PATCH v4 7/7] lavc/bsf: make BSF iteration the same as other iterators

2018-02-04 Thread Josh de Kock
On Sun, Feb 04, 2018 at 02:46:09PM +0100, Nicolas George wrote: > Muhammad Faiz (2018-02-04): > > What about av*iterate(int index)? This makes no sense, it's then not an API for iteration of components. > > I like the idea of an index better than the other options evoked, > especially the

[FFmpeg-devel] [PATCH v4 7/7] lavc/bsf: make BSF iteration the same as other iterators

2018-02-02 Thread Josh de Kock
--- fftools/cmdutils.c | 2 +- libavcodec/avcodec.h | 6 +- libavcodec/bitstream_filter.c | 4 ++-- libavcodec/bitstream_filters.c | 29 ++--- 4 files changed, 26 insertions(+), 15 deletions(-) diff --git a/fftools/cmdutils.c

[FFmpeg-devel] [PATCH v4 6/7] cmdutils: make use of new iteration APIs

2018-02-02 Thread Josh de Kock
--- fftools/cmdutils.c | 122 +++-- 1 file changed, 43 insertions(+), 79 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 6920ca0..9ecc51b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11 @@ int

[FFmpeg-devel] [PATCH v4 5/7] lavd: add new API for iterating input and output devices

2018-02-02 Thread Josh de Kock
This also adds an avpriv function to register devices in libavformat --- Makefile | 3 +- configure| 27 +-- libavdevice/.gitignore | 2 + libavdevice/alldevices.c | 181 --- libavdevice/avdevice.c | 46

[FFmpeg-devel] [PATCH v4 4/7] lavf: move fifo test muxer into separate file

2018-02-02 Thread Josh de Kock
This fixes the fate-fifo-muxer test. --- libavformat/Makefile | 2 +- libavformat/allformats.c | 1 + libavformat/fifo_test.c| 150 + libavformat/tests/fifo_muxer.c | 115 +-- 4 files changed, 154

[FFmpeg-devel] [PATCH v4 3/7] lavf: add new API for iterating muxers and demuxers

2018-02-02 Thread Josh de Kock
--- Makefile | 3 +- configure| 6 +- doc/APIchanges | 7 +- libavformat/.gitignore | 2 + libavformat/allformats.c | 866 --- libavformat/avformat.h | 31 ++ libavformat/format.c | 68 +---

[FFmpeg-devel] [PATCH v4 1/7] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
Based on an unfinished patch by atomnuker. --- Makefile |3 +- configure | 12 +- doc/APIchanges |4 + libavcodec/.gitignore |2 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 +

[FFmpeg-devel] [PATCH v4 2/7] lavf/rtp: replace linked list with array

2018-02-02 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 9 +--- libavformat/rdt.h| 5 -- libavformat/rtpdec.c | 138 ++- libavformat/rtpdec.h | 25 +++-- 5 files changed, 100 insertions(+), 81 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
On Fri, Feb 2, 2018, at 6:53 PM, James Almer wrote: > On 2/2/2018 12:23 PM, Josh de Kock wrote: > > > >> On 1 Feb 2018, at 18:51, Muhammad Faiz <mfc...@gmail.com> wrote: > >> > >>> On Thu, Feb 1, 2018 at 3:25 AM, Josh de Kock <j...@itanimul.li>

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
> On 2 Feb 2018, at 15:41, Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > >> On 31 January 2018 at 20:25, Josh de Kock <j...@itanimul.li> wrote: >> >> Also replace linked list with an array. >> --- >> configure | 12 +-

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-02 Thread Josh de Kock
> On 1 Feb 2018, at 18:51, Muhammad Faiz <mfc...@gmail.com> wrote: > >> On Thu, Feb 1, 2018 at 3:25 AM, Josh de Kock <j...@itanimul.li> wrote: >> Also replace linked list with an array. >> --- >> configure | 12 +- >> doc/APIchanges

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-01 Thread Josh de Kock
> On 1 Feb 2018, at 03:03, Michael Niedermayer <mich...@niedermayer.cc> wrote: > >> On Wed, Jan 31, 2018 at 08:25:50PM +, Josh de Kock wrote: >> Also replace linked list with an array. >> --- >> configure | 12 +- >> doc/APIchanges

[FFmpeg-devel] [PATCH v3 6/6] cmdutils: make use of new iteration APIs

2018-01-31 Thread Josh de Kock
--- fftools/cmdutils.c | 122 +++-- 1 file changed, 43 insertions(+), 79 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 6920ca0..9ecc51b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11 @@ int

[FFmpeg-devel] [PATCH v3 5/6] lavd: add new API for iterating input and output devices

2018-01-31 Thread Josh de Kock
This also adds an avpriv function to register devices in libavformat --- configure| 27 +-- libavdevice/alldevices.c | 181 --- libavdevice/avdevice.c | 46 libavdevice/avdevice.h | 28

[FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-31 Thread Josh de Kock
Also replace linked list with an array. --- configure | 12 +- doc/APIchanges |4 + libavcodec/.gitignore |2 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 + libavcodec/parser.c| 84 ++-

[FFmpeg-devel] [PATCH v3 3/6] lavf: add new API for iterating muxers and demuxers

2018-01-31 Thread Josh de Kock
--- configure| 6 +- doc/APIchanges | 7 +- libavformat/.gitignore | 2 + libavformat/allformats.c | 866 --- libavformat/avformat.h | 31 ++ libavformat/format.c | 68 +--- libavformat/version.h| 3 + 7

[FFmpeg-devel] [PATCH v3 4/6] lavf: move fifo test muxer into separate file

2018-01-31 Thread Josh de Kock
This fixes the fate-fifo-muxer test. --- libavformat/Makefile | 2 +- libavformat/allformats.c | 1 + libavformat/fifo_test.c| 150 + libavformat/tests/fifo_muxer.c | 115 +-- 4 files changed, 154

[FFmpeg-devel] [PATCH v3 2/6] lavf/rtp: replace linked list with array

2018-01-31 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 9 +--- libavformat/rdt.h| 5 -- libavformat/rtpdec.c | 138 ++- libavformat/rtpdec.h | 25 +++-- 5 files changed, 100 insertions(+), 81 deletions(-) diff --git

[FFmpeg-devel] [PATCH 6/6] lavf: add avpriv function to register devices

2018-01-02 Thread Josh de Kock
--- libavdevice/alldevices.c | 6 +- libavformat/allformats.c | 44 +++- libavformat/avformat.h | 4 3 files changed, 48 insertions(+), 6 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index 6b2a512..041eb85

[FFmpeg-devel] [PATCH 4/6] lavf: move fifo test muxer into separate file

2018-01-02 Thread Josh de Kock
This fixes the fate-fifo-muxer test. --- libavformat/Makefile | 2 +- libavformat/allformats.c | 1 + libavformat/fifo_test.c| 150 + libavformat/tests/fifo_muxer.c | 115 +-- 4 files changed, 154

[FFmpeg-devel] [PATCH 5/6] lavd: add new API for iterating input and output devices

2018-01-02 Thread Josh de Kock
--- configure| 27 ++-- libavdevice/alldevices.c | 172 +++ libavdevice/avdevice.c | 46 - libavdevice/avdevice.h | 28 libavdevice/version.h| 4 ++ 5 files changed, 184 insertions(+), 93

[FFmpeg-devel] [PATCH 2/6] lavf/rtp: replace linked list with array

2018-01-02 Thread Josh de Kock
--- libavformat/allformats.c | 4 -- libavformat/rdt.c| 8 +-- libavformat/rdt.h| 3 + libavformat/rtpdec.c | 157 ++- libavformat/rtpdec.h | 29 - libavformat/version.h| 4 +- 6 files changed, 136

[FFmpeg-devel] [PATCH 3/6] lavf: add new API for iterating muxers and demuxers

2018-01-02 Thread Josh de Kock
--- configure| 6 +- doc/APIchanges | 5 + libavformat/allformats.c | 870 --- libavformat/avformat.h | 31 ++ libavformat/format.c | 56 +-- libavformat/version.h| 3 + 6 files changed, 564 insertions(+), 407

[FFmpeg-devel] [PATCH v2 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-02 Thread Josh de Kock
Also replace linked list with an array. --- configure | 12 +- doc/APIchanges |4 + libavcodec/allcodecs.c | 1473 libavcodec/avcodec.h | 31 + libavcodec/parser.c| 87 ++- libavcodec/utils.c | 105

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2017-12-29 Thread Josh de Kock
e" to the end of Windows executables is not rocket science, as you > said. > [...] I've been working on a patch to do this and fixup testing FATE with mingw cross compilation within WSL. I was planning on submitting it within the next

[FFmpeg-devel] [PATCH] lavc: add new API for iterating codecs and codec parsers

2017-12-23 Thread Josh de Kock
stuff so if that's incorrect some advice would be appreciated. -- Josh de Kock <j...@itanimul.li> >From 1d84641556eea563b82b17a6ffe54226e0e31c4e Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> Date: Fri, 22 Dec 2017 22:17:00 + Subject: [PATCH] lavc: add new AP

Re: [FFmpeg-devel] CoC enforcement activated

2017-12-17 Thread Josh de Kock
On Sun, 17 Dec 2017 17:12:24 -0500 Compn <te...@mi.rr.com> wrote: > On Sun, 17 Dec 2017 21:57:07 +0000, Josh de Kock <j...@itanimul.li> > wrote: > > > On Sun, 17 Dec 2017 15:36:53 -0500 > > Compn <te...@mi.rr.com> wrote: > > > > > [...]

Re: [FFmpeg-devel] CoC enforcement activated

2017-12-17 Thread Josh de Kock
ill not be tolerated. > Note that there is nothing on how the CoC should be 'enforced'. Also consider that the CoC in our case is more of guidelines than strict rules to be followed. There has also been no consensus on moderation being enabled under what circumstances. -

Re: [FFmpeg-devel] [PATCH] avutil/atomics: replace avpriv atomics with stdatomics

2017-12-15 Thread Josh de Kock
On Fri, 15 Dec 2017 18:08:02 + Josh de Kock <j...@itanimul.li> wrote: > [...] Attached again with the correct mime... -- Josh de Kock <j...@itanimul.li> >From 2c4771a24510adfb3f6346c3fbed0554034eab3b Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> D

[FFmpeg-devel] [PATCH] avutil/atomics: replace avpriv atomics with stdatomics

2017-12-15 Thread Josh de Kock
much about development on the platform, but I've been told that _Atomic may not be available on it. -- Josh de Kock <j...@itanimul.li> 0001-avutil-atomics-replace-avpriv-atomics-with-stdatomics.patch Description: plain/text ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] Added Turing codec to ffmpeg

2017-12-13 Thread Josh de Kock
s patch were to be merged and then turingcodec to actually go stale we'd be left with dead code for longer than is ideal (forever). My opinion is that you should just maintain this separately as an out-of-tree patch as it doesn't benefit us. -- Josh de Kock <j

Re: [FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
On 27/09/2017 13:33, wm4 wrote: > On Wed, 27 Sep 2017 13:09:02 +0100 > Josh de Kock <j...@itanimul.li> wrote: > >> Support for this device has been removed in kernel since v2.6.37. dv1394 >> has been superseded by libiec61883 which is functionally equivalent. >>

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:28, Carl Eugen Hoyos wrote: > 2017-09-27 17:21 GMT+02:00 Josh de Kock <j...@itanimul.li>: >> On 27/09/2017 16:17, Carl Eugen Hoyos wrote: >>> 2017-09-27 17:15 GMT+02:00 wm4 <nfx...@googlemail.com>: >>>> On Wed, 27 Sep 2017 17:08:06 +0200

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:17, Carl Eugen Hoyos wrote: > 2017-09-27 17:15 GMT+02:00 wm4 <nfx...@googlemail.com>: >> On Wed, 27 Sep 2017 17:08:06 +0200 >> Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >> >>> 2017-09-27 15:18 GMT+02:00 Josh de Kock <j...@itani

[FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
have been quick hacky in libavdevice for a long time. There are three patches attached to deprecate the SDL2, OpenGL, and libcaca devices. -- Josh From f950674e8893da8438ade6cee1050062d2bfb86c Mon Sep 17 00:00:00 2001 From: Josh de Kock <j...@itanimul.li> Date: Wed, 27 Sep 2017 13:26:19

[FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
Support for this device has been removed in kernel since v2.6.37. dv1394 has been superseded by libiec61883 which is functionally equivalent. Signed-off-by: Josh de Kock <j...@itanimul.li> --- configure| 3 - doc/indevs.texi | 25 libavdevice/Makefile

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

2017-09-26 Thread Josh de Kock
On 24/09/2017 15:35, Jörn Heusipp wrote: On 09/17/2017 03:35 PM, Jörn Heusipp wrote: Duration depends on the selected subsong and thus must be queried after selecting the subsong. There is no compelling reason to query other metadata earlier either. Signed-off-by: Jörn Heusipp

Re: [FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
On 18/02/2017 00:51, Marton Balint wrote: > > On Fri, 17 Feb 2017, Josh de Kock wrote: > >> Also add support for level 1.0 explicitly. >> > > What is the use case for this? Reducing the number of colors? > Pretty much. > I don't think you can reduce the n

[FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
Also add support for level 1.0 explicitly. Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 60 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/l

[FFmpeg-devel] [PATCH] lavf/mpegts: document DVB teletext PMT fields

2017-02-17 Thread Josh de Kock
Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavformat/mpegts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 590abb0..bcf2118 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -1718,6 +1718,11

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/02/2017 15:28, Marton Balint wrote: > > On Sun, 12 Feb 2017, Josh de Kock wrote: > >> Hi Carl, >> >> I'm not sure, 0.2.28 doesn't compile on my system. It has been >> tested with the latest version 0.2.3

[FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
Hi Carl, I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. Does the updated patch look better? Josh Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 15 +-- 1 file changed, 13 insertions

[FFmpeg-devel] [PATCH] lavc/libzvbi: remove deprecated API usage

2017-02-11 Thread Josh de Kock
Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavcodec/libzvbi-teletextdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index d1f0a9f..2ed4a82 100644 --- a/libavcodec/l

[FFmpeg-devel] [PATCH] lavf/vsrc_testsrc: fix SMPTE segfault with small output size

2016-12-15 Thread Josh de Kock
The memset (line 1336) in draw_bar is passed a negative size if the output width is less than 36 pixels Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavfilter/vsrc_testsrc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_tes

Re: [FFmpeg-devel] [PATCH] Added Turing codec interface for ffmpeg

2016-11-29 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 29/11/2016 17:18, Matteo Naccari wrote: > [...] Please send any later versions of this patch as a reply to the same thread with a v3 (or later). For example (for this email): [PATCH v3] Thanks, - -- Josh PGP fingerprint:

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2016/11/27 23:56, Rostislav Pehlivanov wrote: > On 27 November 2016 at 23:20, James Almer > wrote: > >> On 11/26/2016 6:00 PM, Rostislav Pehlivanov wrote: >>> On 26 October 2016 at 23:43, Rostislav Pehlivanov >>>

Re: [FFmpeg-devel] [PATCH] travis.yml: Whitelist "coverity" branch in preparation for Coverity integration

2016-11-27 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2016/11/27 23:47, Timothy Gu wrote: > --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) > > This patch will needed to be applied to all Git branches because of > a Travis CI restriction: >

Re: [FFmpeg-devel] coverity testing of FFmpeg

2016-11-27 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2016/11/27 19:00, Philip Langdale wrote: > On Sat, 26 Nov 2016 23:55:17 +0100 Michael Niedermayer > wrote: > >> Hi all > >> The machine on which the coverity stuff is is old, both hw and >> OS. the OS will no longer get

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-24 Thread Josh de Kock
On 29/10/2016 16:53, Andreas Cadhalpun wrote: > On 28.10.2016 19:31, compn wrote: >> On Thu, 27 Oct 2016 15:42:22 -0300 James Almer wrote: >>> On 10/27/2016 3:36 PM, Reynaldo H. Verdejo Pinochet wrote: On 10/27/2016 11:25 AM, James Almer wrote: > This is not how things were agreed. I

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:37, Andreas Cadhalpun wrote: > On 23.11.2016 00:01, Josh de Kock wrote: >> On 22/11/2016 22:22, Andreas Cadhalpun wrote: >>> On 10.11.2016 22:24, Andreas Cadhalpun wrote: >>>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:11, Andreas Cadhalpun wrote: On 22.11.2016 23:43, Josh de Kock wrote: On 22/11/2016 22:33, Andreas Cadhalpun wrote: Because it avoids confusing users. And the checks for other system libraries should do this, too. I see no real reason to add this, but neither a reason

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:22, Andreas Cadhalpun wrote: On 10.11.2016 22:24, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/sbgdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/sbgdec.c

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:43, Andreas Cadhalpun wrote: On 17.11.2016 22:55, Andreas Cadhalpun wrote: Metadata streams have priv_data set to NULL. Signed-off-by: Andreas Cadhalpun --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:33, Andreas Cadhalpun wrote: On 22.11.2016 23:30, Carl Eugen Hoyos wrote: 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun : disabled sdl && disable sdl2 +enabled sdl2 && sdl_requested=yes I consider this ugly That is very subjective.

Re: [FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-21 Thread Josh de Kock
On 21/11/2016 09:51, Carl Eugen Hoyos wrote: 2016-11-21 10:35 GMT+01:00 Josh de Kock <j...@itanimul.li>: On 20/11/2016 22:49, Carl Eugen Hoyos wrote: 2016-11-19 17:37 GMT+01:00 Josh de Kock <j...@itanimul.li>: I've mapped a fair amount of the CoreMedia FourCCs to their respectiv

Re: [FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-21 Thread Josh de Kock
On 20/11/2016 22:49, Carl Eugen Hoyos wrote: 2016-11-19 17:37 GMT+01:00 Josh de Kock <j...@itanimul.li>: I've mapped a fair amount of the CoreMedia FourCCs to their respective AVCodecIDs. The ones I didn't know or thought didn't exist in FFmpeg have been mapped to AV_CODEC_ID_NONE. Cou

[FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-19 Thread Josh de Kock
I've mapped a fair amount of the CoreMedia FourCCs to their respective AVCodecIDs. The ones I didn't know or thought didn't exist in FFmpeg have been mapped to AV_CODEC_ID_NONE. Signed-off-by: Josh de Kock <j...@itanimul.li> --- libavformat/Makefile| 1 + libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH] Added the interface for the Turing codec

2016-11-18 Thread Josh de Kock
On 18/11/2016 15:25, Matteo Naccari wrote: - The Turing codec is an open source HEVC encoder licensed under GPLv2 - More information at http://turingcodec.org/ --- LICENSE.md | 1 + configure | 5 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 +

Re: [FFmpeg-devel] [PATCH] ffplay: allow fallback to software renderer

2016-11-17 Thread Josh de Kock
On 17/11/2016 21:18, Marton Balint wrote: Signed-off-by: Marton Balint --- ffplay.c | 4 1 file changed, 4 insertions(+) diff --git a/ffplay.c b/ffplay.c index 12502f2..63c0e19 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1282,6 +1282,10 @@ static int video_open(VideoState

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Josh de Kock
On 20/10/2016 17:06, Ronald S. Bultje wrote: --- libavfilter/vf_colorspace.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index c74fe00..f64163f 100644 --- a/libavfilter/vf_colorspace.c +++

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-12 Thread Josh de Kock
On 11/10/2016 22:53, Moritz Barsnick wrote: On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** This commit message isn't very useful, it doesn't describe the change at all. See: https://www.ffmpeg.org/developer.html

[FFmpeg-devel] [PATCH v2] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock <j...@itanimul.li> --- >Would it

Re: [FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-11 Thread Josh de Kock
On 10/10/2016 03:50, Steven Liu wrote: Signed-off-by: Steven Liu --- doc/protocols.texi|3 +++ libavformat/udp.c | 19 ++- libavformat/version.h |3 +++ 3 files changed, 24 insertions(+), 1 deletions(-) diff --git a/doc/protocols.texi

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) This commit message isn't very useful, it doesn't describe the change at all. See:

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: --- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16

<    1   2   3   4   >