Re: [FFmpeg-devel] [PATCH 4/5] lavu/hwcontext_amf: Engine selection support for AMF context

2020-10-28 Thread Mark Thompson
On 15/10/2020 01:16, OvchinnikovDmitrii wrote: --- libavcodec/amfenc.c | 9 +++- libavcodec/amfenc.h | 1 + libavcodec/amfenc_h264.c | 8 +++ libavcodec/amfenc_hevc.c | 8 +++ libavutil/hwcontext_amf.c | 104 ++ libavutil/hwcontext_

Re: [FFmpeg-devel] [PATCH 2/5] lavu/hwcontext_amf: HWContext for AMF based components

2020-10-28 Thread Mark Thompson
On 15/10/2020 01:16, OvchinnikovDmitrii wrote: From: Alexander Kravchenko --- libavutil/Makefile | 2 + libavutil/hwcontext.c | 4 + libavutil/hwcontext.h | 1 + libavutil/hwcontext_amf.c | 284 + libavutil/hwcontext

Re: [FFmpeg-devel] [PATCH 1/5] lavc/amfenc: HWConfig for amf encoder.

2020-10-28 Thread Mark Thompson
On 15/10/2020 01:16, OvchinnikovDmitrii wrote: --- libavcodec/amfenc.c | 12 libavcodec/amfenc.h | 4 +++- libavcodec/amfenc_h264.c | 1 + libavcodec/amfenc_hevc.c | 1 + 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc.c b/libavcode

Re: [FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder

2020-10-28 Thread Mark Thompson
On 02/10/2020 15:28, Fei Wang wrote: Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- Changelog | 1 + configure

Re: [FFmpeg-devel] [PATCH] ffmpeg_qsv: respect hwaccel_output_format setting

2020-10-28 Thread Mark Thompson
On 22/10/2020 02:52, Haihao Xiang wrote: Without this change, the output pixel format from qsv decoder is always 'qsv' ... No it isn't. ffmpeg -loglevel verbose -hwaccel qsv -c:v h264_qsv -hwaccel_output_format yuv420p -i input.h264 -pix_fmt rgb24 -f null - The legacy decoders still use the

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: use color description for h264 and hevc

2020-10-28 Thread Mark Thompson
On 10/10/2020 18:27, Zivkovic, Milos wrote: Hello, I've attached a patch that forwards the color description from AVCodecContext to mfxExtVideoSignalInfo. It has been discussed on the #ffmpeg and #ffmpeg-devel IRC channel a couple of times in the last few days. > From 724c8e64f9ca9356464f1596bb

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: infer loop filter delta parameters from reference frames

2020-10-27 Thread Mark Thompson
On 27/10/2020 20:53, James Almer wrote: On 10/27/2020 5:38 PM, Mark Thompson wrote: On 21/10/2020 01:11, James Almer wrote: Partially implements of setup_past_independence() and load_previous(). These ensures they are always set, even if the values were not coded in the input bitstream and

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix loading PrevGmParams for frames with primary_ref_frame none

2020-10-27 Thread Mark Thompson
On 27/10/2020 21:01, James Almer wrote: On 10/27/2020 5:57 PM, Mark Thompson wrote: On 17/10/2020 20:30, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/av1dec.c | 9 +++--   1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix loading PrevGmParams for frames with primary_ref_frame none

2020-10-27 Thread Mark Thompson
On 17/10/2020 20:30, James Almer wrote: Signed-off-by: James Almer --- libavcodec/av1dec.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 54aeba1812..04aaf5d148 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1d

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_av1: infer segmentation parameters from reference frames

2020-10-27 Thread Mark Thompson
On 21/10/2020 01:11, James Almer wrote: Partially implements of setup_past_independence() and load_previous(). These ensures they are always set, even if the values were not coded in the input bitstream and will not be coded in the output bitstream. Signed-off-by: James Almer --- libavcodec/c

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add a range check to tg_end

2020-10-27 Thread Mark Thompson
On 27/10/2020 13:49, James Almer wrote: Section 6.10.1 of the AV1 spec states: It is a requirement of bitstream conformance that the value of tg_end is greater than or equal to tg_start. Signed-off-by: James Almer --- libavcodec/cbs_av1_syntax_template.c | 2 +- 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: infer loop filter delta parameters from reference frames

2020-10-27 Thread Mark Thompson
On 21/10/2020 01:11, James Almer wrote: Partially implements of setup_past_independence() and load_previous(). These ensures they are always set, even if the values were not coded in the input bitstream and will not be coded in the output bitstream. Signed-off-by: James Almer --- libavcodec/c

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Mark Thompson
On 26/10/2020 22:04, Bohan Li wrote: Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- doc/encoders.texi | 13 + libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_av1: add an option to select an operating point

2020-10-01 Thread Mark Thompson
On 20/09/2020 18:24, James Almer wrote: This implements the function drop_obu() as defined in Setion 6.2.1 from the spec. In a reading only scenario, units that belong to an operating point the caller doesn't want should not be parsed. Signed-off-by: James Almer --- libavcodec/cbs_av1.c

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-10-01 Thread Mark Thompson
On 20/09/2020 18:24, James Almer wrote: The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an undesirable way. And unlike preventing decomposition of units, discarding can be done base

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-10-01 Thread Mark Thompson
On 29/09/2020 19:49, Pavel Koshevoy wrote: On Tue, Sep 29, 2020 at 12:14 PM Mark Thompson wrote: On 29/09/2020 18:14, Pavel Koshevoy wrote: On Tue, Sep 29, 2020 at 10:09 AM Mark Thompson wrote: - Mark It's pretty much this use case, except I'm not using ffmpeg cli but th

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-10-01 Thread Mark Thompson
On 29/09/2020 19:23, James Almer wrote: On 9/29/2020 3:07 PM, Mark Thompson wrote: On 29/09/2020 17:17, James Almer wrote: On 9/29/2020 12:57 PM, Mark Thompson wrote: On 25/09/2020 15:43, James Almer wrote: Fixes: member access within null pointer of type 'TileGroupInfo' (a

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-09-29 Thread Mark Thompson
On 29/09/2020 18:14, Pavel Koshevoy wrote: On Tue, Sep 29, 2020 at 10:09 AM Mark Thompson wrote: On 28/09/2020 02:17, Pavel Koshevoy wrote: On Wed, Sep 23, 2020 at 1:32 PM Paul B Mahol wrote: On Mon, Sep 21, 2020 at 09:47:40PM -0600, Pavel Koshevoy wrote: Allow setparams to be used with

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/av1dec: parse dimensions from the sequence header in extradata

2020-09-29 Thread Mark Thompson
On 29/09/2020 17:23, James Almer wrote: On 9/29/2020 12:52 PM, Mark Thompson wrote: On 25/09/2020 15:43, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/av1dec.c | 10 ++   1 file changed, 10 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-09-29 Thread Mark Thompson
On 29/09/2020 17:17, James Almer wrote: On 9/29/2020 12:57 PM, Mark Thompson wrote: On 25/09/2020 15:43, James Almer wrote: Fixes: member access within null pointer of type 'TileGroupInfo' (aka 'struct TileGroupInfo') Fixes: 25725/clusterfuzz-testcase-minimized-ffmpeg_AV

Re: [FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder

2020-09-29 Thread Mark Thompson
On 09/09/2020 04:39, Fei Wang wrote: Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- Changelog | 1 + configure

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cbs: add a flush callback to CodedBitstreamType

2020-09-29 Thread Mark Thompson
On 25/09/2020 15:43, James Almer wrote: Used to reset the codec's private internal state. Signed-off-by: James Almer --- libavcodec/cbs.c | 6 ++ libavcodec/cbs.h | 5 + libavcodec/cbs_internal.h | 3 +++ 3 files changed, 14 insertions(+) diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-09-29 Thread Mark Thompson
On 28/09/2020 02:17, Pavel Koshevoy wrote: On Wed, Sep 23, 2020 at 1:32 PM Paul B Mahol wrote: On Mon, Sep 21, 2020 at 09:47:40PM -0600, Pavel Koshevoy wrote: Allow setparams to be used with hw backed frames and avoid an assertion failure in avfilter_config_links. --- libavfilter/vf_setpara

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/av1dec: call ff_cbs_flush() on decoder flush

2020-09-29 Thread Mark Thompson
On 25/09/2020 15:43, James Almer wrote: Signed-off-by: James Almer --- libavcodec/av1dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index a30a496b4c..07026b7aeb 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -854,6 +854,8 @

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-09-29 Thread Mark Thompson
On 25/09/2020 15:43, James Almer wrote: Fixes: member access within null pointer of type 'TileGroupInfo' (aka 'struct TileGroupInfo') Fixes: 25725/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5166692706287616 Found-by: continuous fuzzing process https://github.com/google/oss-f

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/av1dec: parse dimensions from the sequence header in extradata

2020-09-29 Thread Mark Thompson
On 25/09/2020 15:43, James Almer wrote: Signed-off-by: James Almer --- libavcodec/av1dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 0bb04a3e44..f6b9fbbac3 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -405,

Re: [FFmpeg-devel] [PATCH 1/6] qsv: add ${includedir}/mfx to the search path for old versions of libmfx

2020-09-29 Thread Mark Thompson
On 16/09/2020 07:44, Haihao Xiang wrote: ${includedir}/mfx has been added to Cflags in libmfx.pc for the current libmfx. We may add ${includedir}/mfx to the search path for olda versions of libmfx so that we may include foo.h instead of mfx/foo.h After applying this change, we won't need to chan

Re: [FFmpeg-devel] [PATCH 0/6] qsv: Fix compiler errors when using libmfx 2.0 (oneVPL)

2020-09-29 Thread Mark Thompson
On 16/09/2020 07:44, Haihao Xiang wrote: The oneAPI Video Processing Library (oneVPL) is a single interface for encode, decode and video processing, the obsolete features in Intel Media Software Development Kit are removed from oneVPL. The oneVPL specification: https://spec.oneapi.com/versions/l

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-09-29 Thread Mark Thompson
On 10/09/2020 07:42, Haihao Xiang wrote: Resend Linjie's patchset with the updates. As a part of the support for VA-API HEVC SCC decoding (gen12, Tiger Lake+). The full support could be accessed in: https://github.com/intel-media-ci/ffmpeg/pull/231 The VAAPI part would be provided later once t

Re: [FFmpeg-devel] [PATCH] ffmpeg_qsv: use -hwaccel_device to specify a device for VAAPI backend

2020-09-06 Thread Mark Thompson
On 03/09/2020 05:59, myp...@gmail.com wrote: On Thu, Sep 3, 2020 at 9:21 AM Xiang, Haihao wrote: On Wed, 2020-09-02 at 14:04 +, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Rogozhkin, Dmitry V Sent: Wednesday, September 2, 2020 3:54 PM To: ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: allow qsv decoders to use initialized device

2020-09-06 Thread Mark Thompson
On 04/09/2020 19:24, Rogozhkin, Dmitry V wrote: On Thu, 2020-09-03 at 01:02 +, Rogozhkin, Dmitry V wrote: (If you do implement it then you can delete all of the ad-hoc treatment in ffmpeg, like has been done for the other hardware codecs.) I like deleting code:). Ok, this sounds good. Let

Re: [FFmpeg-devel] qsv: question on CONFIG macros

2020-09-06 Thread Mark Thompson
On 04/09/2020 16:57, Rogozhkin, Dmitry V wrote: Hi, Can someone, please, help to clarify: 1. Where CONFIG_QSV and CONFIG_LIBMFX gets defined (I don't see that in the grep output - attached below)? By configure, they end up in config.h in the build directory. 2. What's relationship between

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: allow qsv decoders to use initialized device

2020-09-02 Thread Mark Thompson
On 02/09/2020 15:36, Rogozhkin, Dmitry V wrote: On Wed, 2020-09-02 at 14:21 +, Rogozhkin, Dmitry V wrote: On Wed, 2020-09-02 at 08:41 +, Soft Works wrote: ... Small suggestion: let's move discussion around -qsv_device and -hwaccel_device options entirely to the "ffmpeg_qsv: use -hwacc

Re: [FFmpeg-devel] [PATCH v2] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is set

2020-09-01 Thread Mark Thompson
On 01/09/2020 08:16, Wang, Fei W wrote: -Original Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Tuesday, September 1, 2020 5:01 AM To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is

Re: [FFmpeg-devel] [PATCH 1/8] cbs: Implement common parts of cbs-based bitstream filters separately

2020-09-01 Thread Mark Thompson
On 23/08/2020 23:33, Mark Thompson wrote: --- This series depends on the CBS unit table rewrite and following cleanups. Since comments on that series seem to have dried up, I will apply it in a few days if nothing further comes up. Applied the first half. I'm going to look into adding

[FFmpeg-devel] [PATCH v2] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is set

2020-08-31 Thread Mark Thompson
They are not explicitly in the bitstream in this case, but it is helpful to be able to use these values without always needing to check the flag beforehand. --- On 31/08/2020 08:31, Wang, Fei W wrote:>> -Original Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent:

Re: [FFmpeg-devel] [PATCH] hwcontext_vaapi: Don't require a render node when deriving from DRM

2020-08-31 Thread Mark Thompson
On 28/08/2020 23:15, Mark Thompson wrote: The V4L2 driver does not actually have an associated DRM device at all, so users work around the requirement by giving libva an unrelated display-only device instead (which is fine, because it doesn't actually do anything with that device).  Thi

Re: [FFmpeg-devel] [PATCH 1/3][GSoC] Add mutithread function for dnn_backend_native_layer_conv2d.c

2020-08-31 Thread Mark Thompson
On 31/08/2020 18:03, xuju...@sjtu.edu.cn wrote: From: Xu Jun Use pthread to multithread dnn_execute_layer_conv2d. Can be tested with command "./ffmpeg_g -i input.png -vf \ format=yuvj420p,dnn_processing=dnn_backend=native:model= \ espcn.model:input=x:output=y -y sr_native.jpg -benchmark" befor

[FFmpeg-devel] [PATCH] hwcontext_vaapi: Don't require a render node when deriving from DRM

2020-08-28 Thread Mark Thompson
The V4L2 driver does not actually have an associated DRM device at all, so users work around the requirement by giving libva an unrelated display-only device instead (which is fine, because it doesn't actually do anything with that device). This was broken by bc9b6358fb7315c0173de322472641766f628

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: infer frame sizes when not coded in the bitstream

2020-08-23 Thread Mark Thompson
On 23/08/2020 20:23, James Almer wrote: This makes them available for all frames within a Temporal Unit. Signed-off-by: James Almer --- libavcodec/cbs_av1_syntax_template.c | 43 +--- 1 file changed, 33 insertions(+), 10 deletions(-) Set LGTM. Thanks, - Mark _

[FFmpeg-devel] [PATCH 8/8] RFC: editing HDR properties in H.265 metadata BSF

2020-08-23 Thread Mark Thompson
--- Setting HDR properties is a useful feature, but it's very unclear what we want it to actually look like to the user. Not all encoders and decoders support it, so it's essentially required that the implementation happen at the bitstream filter level so that we can support all codecs in the s

[FFmpeg-devel] [PATCH 2/8] h264_metadata_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 225 +++-- 1 file changed, 45 insertions(+), 180 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 7d6d871240..4243a8da98 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h26

[FFmpeg-devel] [PATCH 5/8] vp9_metadata_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
--- libavcodec/vp9_metadata_bsf.c | 61 +-- 1 file changed, 16 insertions(+), 45 deletions(-) diff --git a/libavcodec/vp9_metadata_bsf.c b/libavcodec/vp9_metadata_bsf.c index 00a5580c4d..1d82a401d5 100644 --- a/libavcodec/vp9_metadata_bsf.c +++ b/libavcodec/vp9_met

[FFmpeg-devel] [PATCH 4/8] mpeg2_metadata_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
This adds support for updating new extradata. --- libavcodec/mpeg2_metadata_bsf.c | 94 + 1 file changed, 12 insertions(+), 82 deletions(-) diff --git a/libavcodec/mpeg2_metadata_bsf.c b/libavcodec/mpeg2_metadata_bsf.c index d0048c0e25..367aa1f9f5 100644 --- a/liba

[FFmpeg-devel] [PATCH 6/8] av1_metadata_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
--- libavcodec/av1_metadata_bsf.c | 176 -- 1 file changed, 21 insertions(+), 155 deletions(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c index 3158ba995b..31fd4f0f41 100644 --- a/libavcodec/av1_metadata_bsf.c +++ b/libavcodec/av1_me

[FFmpeg-devel] [PATCH 7/8] h264_redundant_pps_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
--- libavcodec/h264_redundant_pps_bsf.c | 99 ++--- 1 file changed, 21 insertions(+), 78 deletions(-) diff --git a/libavcodec/h264_redundant_pps_bsf.c b/libavcodec/h264_redundant_pps_bsf.c index cf41abe96c..fb91227eec 100644 --- a/libavcodec/h264_redundant_pps_bsf.c +++ b

[FFmpeg-devel] [PATCH 3/8] h265_metadata_bsf: Use common cbs bsf implementation

2020-08-23 Thread Mark Thompson
--- libavcodec/h265_metadata_bsf.c | 191 - 1 file changed, 22 insertions(+), 169 deletions(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index 504a75dac2..c3eadee92b 100644 --- a/libavcodec/h265_metadata_bsf.c +++ b/libavcodec/h26

[FFmpeg-devel] [PATCH 1/8] cbs: Implement common parts of cbs-based bitstream filters separately

2020-08-23 Thread Mark Thompson
--- This series depends on the CBS unit table rewrite and following cleanups. Since comments on that series seem to have dried up, I will apply it in a few days if nothing further comes up. libavcodec/Makefile | 2 +- libavcodec/cbs_bsf.c | 161 +++

Re: [FFmpeg-devel] [PATCH] cbs_av1: Fix test for presence of buffer_removal_time element

2020-08-23 Thread Mark Thompson
On 23/08/2020 18:31, James Almer wrote: On 8/23/2020 1:06 PM, Mark Thompson wrote: The OBU must be in both the spatial and temporal layers for the operating point, not just one of them. ---  libavcodec/cbs_av1_syntax_template.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH] cbs_av1: Fix test for presence of buffer_removal_time element

2020-08-23 Thread Mark Thompson
The OBU must be in both the spatial and temporal layers for the operating point, not just one of them. --- libavcodec/cbs_av1_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index 2c

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add derived frame size to AV1RawFrameHeader

2020-08-23 Thread Mark Thompson
On 23/08/2020 03:02, James Almer wrote: Same logic as tile_cols and tile_rows, this saves CBS users having to recalculate these values, and makes them available for all frames within a Temporal Unit. Signed-off-by: James Almer --- Not a fan of adding more derived values to "raw" structs, but mu

[FFmpeg-devel] [PATCH] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is set

2020-08-22 Thread Mark Thompson
They are not explicitly in the bitstream in this case, but it is helpful to be able to use these values without always needing to check the flag beforehand. --- On 22/08/2020 23:01, Mark Thompson wrote: On 21/08/2020 06:29, Fei Wang wrote: ... + +    if (s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-22 Thread Mark Thompson
On 21/08/2020 06:29, Fei Wang wrote: This av1 decoder is now only used for av1 hardware acceleration decoder. Consider it can be extend to a local decoder like hevc or vp9 in the future, so define its name as "av1" and put it into external libraries codec list. Signed-off-by: Fei Wang --- Cha

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-22 Thread Mark Thompson
On 21/08/2020 06:49, Moritz Barsnick wrote: On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: With this patch, -disable_auto_conversion_filters does what you want. [...] +if (!po->name) { +/* Try to match a boolean option with a negative prefix. */ +for (in

Re: [FFmpeg-devel] Curly braces around single statements (was avformat/avidec: Fix memleak when error) happens after creating DV stream

2020-08-20 Thread Mark Thompson
On 20/08/2020 22:20, Alexander Strasser wrote: Please pardon me for bringing this up in the context of this patch. No objections or particular opinion regarding this instance of the problem. Though thinking more globally, I believe it would have a beneficial impact to add the curly braces everyw

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

2020-08-20 Thread Mark Thompson
On 15/08/2020 09:48, myp...@gmail.com wrote: On Sun, Aug 9, 2020 at 6:07 AM Mark Thompson wrote: On 26/07/2020 13:26, Jun Zhao wrote: From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file

[FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-20 Thread Mark Thompson
In addition to "no", also allow "no_", "disable" and "disable_". --- On 20/08/2020 18:49, Nicolas George wrote: Alexander Strasser (12020-08-17): Here are some suggestions in no particular order: * auto_conversion_filters (from Marton) I can be ok with this one. I really dislike boolean optio

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

2020-08-15 Thread Mark Thompson
On 15/08/2020 16:03, Nicolas George wrote: Mark Thompson (12020-08-14): The relation to the existing -autorotate and -autoscale options is confusing - those aren't disabled by this (because they are applied differently), but it sounds like they would be. I updated the doc to: Di

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/v4l2_context: return EAGAIN to signal full buffers

2020-08-15 Thread Mark Thompson
On 17/07/2020 03:09, Andriy Gelman wrote: From: Andriy Gelman Return proper error when a frame buffers are full. This path is triggered on the DragonBoard 410c since the encoding API change in commit 827d6fe73d2f5472c1c2. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_context.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

2020-08-14 Thread Mark Thompson
On 14/08/2020 18:14, Nicolas George wrote: Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 5 + fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 2 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 11 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi

Re: [FFmpeg-devel] [PATCH 2/2] fate: disable automatic conversions on most filter tests.

2020-08-14 Thread Mark Thompson
On 14/08/2020 18:14, Nicolas George wrote: Explicitly insert the scale or aresample filter where it would have been inserted by the negotiation. If a conversion is needed in a test, we want to know about it. If the negotiation changes and makes new conversion necessary, we want to know about it

Re: [FFmpeg-devel] [PATCH v2 2/3] vaapi_encode: Rewrite slice/tile support

2020-08-14 Thread Mark Thompson
On 14/08/2020 10:30, Linjie Fu wrote: On Fri, Aug 14, 2020 at 5:51 AM Mark Thompson wrote: This precalculates all of the information we will need to define slice and tile positions at init time rather than rebuilding some of it with every slice. The control of tiles is generalised to match

Re: [FFmpeg-devel] [PATCH, RFC] lavc/hevcdec: add invalid for skip_frame to skip invalid nalus before IRAP

2020-08-14 Thread Mark Thompson
On 14/08/2020 11:35, Linjie Fu wrote: Add "-skip_frame invalid" option to allow user to request decoder to skip invalid nalus before an IRAP. This would benefit decoding pipeline of bitstreams who didn't start from an IRAP frame. NULL pointer pointing to missing reference may lead to unexpected

[FFmpeg-devel] [PATCH v2 2/3] vaapi_encode: Rewrite slice/tile support

2020-08-13 Thread Mark Thompson
This precalculates all of the information we will need to define slice and tile positions at init time rather than rebuilding some of it with every slice. The control of tiles is generalised to match slices, so that arbitrary tile and slice layouts are possible within the constraint that slices ca

[FFmpeg-devel] [PATCH v2 1/3] vaapi_encode_h265: Ensure that tile sizes conform to profile constraints

2020-08-13 Thread Mark Thompson
While libavcodec doesn't care about these constraints, the HM reference decoder does enforce them and other decoders may run into problems. --- libavcodec/vaapi_encode_h265.c | 35 +- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_enc

[FFmpeg-devel] [PATCH v2 3/3] vaapi_encode_h265: Set tiles_fixed_structure_flag

2020-08-13 Thread Mark Thompson
We only make one PPS, so the tile structure necessarily fixed. --- libavcodec/vaapi_encode_h265.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index d2bcb8d3db..dbd8c77f6d 100644 --- a/libavcodec/vaapi_encode_h265.c +++ b/libav

[FFmpeg-devel] [PATCH v7 21.2/23] h264_metadata_bsf: Refactor the filter function into smaller parts

2020-08-12 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 348 ++--- 1 file changed, 191 insertions(+), 157 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index e59b5b8369..d69713cbab 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h2

[FFmpeg-devel] [PATCH v7 21.1/23] h264_metadata: Move SEI user data parsing to init time

2020-08-12 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 91 -- 1 file changed, 43 insertions(+), 48 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index eb1503159b..e59b5b8369 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264

Re: [FFmpeg-devel] [PATCH v6 21/22] h264_metadata_bsf: Refactor the filter function into smaller parts

2020-08-12 Thread Mark Thompson
On 12/08/2020 02:55, Andreas Rheinhardt wrote: First of all: I only looked at the sei_user_data stuff yet. Mark Thompson: --- libavcodec/h264_metadata_bsf.c | 443 ++--- 1 file changed, 242 insertions(+), 201 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH v7 19.1/23] cbs_h265: Remove restrictions on MDCV values

2020-08-12 Thread Mark Thompson
Since this was originally written H.265 has changed to allow arbitrary values here, but leaves their meaning unspecified. --- On 12/08/2020 00:03, Andreas Rheinhardt wrote: > Obviously, the code for reading/writing the mastering display colour > volume SEI needs to be updated, too. Yeah. I don't

[FFmpeg-devel] [PATCH v7 19.2/23] cbs_h265: Add functions to turn HDR metadata into SEI

2020-08-12 Thread Mark Thompson
--- On 12/08/2020 00:03, Andreas Rheinhardt wrote: > ... Yep, all changed as you suggest. libavcodec/Makefile | 2 +- libavcodec/cbs_h265.c | 95 +++ libavcodec/cbs_h265.h | 18 3 files changed, 114 insertions(+), 1 deletion(-) create mode 10

Re: [FFmpeg-devel] [PATCH v6 15/22] cbs_h264: Add support for frame packing arrangement SEI messages

2020-08-12 Thread Mark Thompson
On 11/08/2020 21:13, Andreas Rheinhardt wrote: Mark Thompson: --- libavcodec/cbs_h264.h | 24 libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h264_syntax_template.c | 40 +++ 3 files changed, 65 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH v3 4/4] lavc, doc: add libuavs3d video decoder wrapper

2020-08-11 Thread Mark Thompson
On 05/08/2020 17:18, hwr...@126.com wrote: From: hwren Signed-off-by: hbj Signed-off-by: hwren --- Changelog | 1 + configure | 4 + doc/decoders.texi | 21 +++ doc/general.texi | 8 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c |

Re: [FFmpeg-devel] [PATCH v3 2/4] lavc/avs3_paeser: add avs3 parser

2020-08-11 Thread Mark Thompson
Typo "paeser" in the title. On 05/08/2020 17:18, hwr...@126.com wrote: From: hwren Signed-off-by: hbj Signed-off-by: hwren --- libavcodec/Makefile | 1 + libavcodec/avs3_parser.c | 184 +++ libavcodec/parsers.c | 1 + 3 files changed, 18

Re: [FFmpeg-devel] [PATCH 1/4] kmsgrab: Refactor and clean error cases

2020-08-09 Thread Mark Thompson
On 05/07/2020 16:49, Mark Thompson wrote: --- libavdevice/kmsgrab.c | 151 ++ 1 file changed, 93 insertions(+), 58 deletions(-) Thanks to Lynne on IRC for looking at this set. Applied with some minor fixups to error logging. - Mark

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: add 10-bit RGB support for QSV

2020-08-09 Thread Mark Thompson
On 09/08/2020 06:11, Linjie Fu wrote: After adding a copy pass through path inside MSDK, x2rgb10 is now available as an output of VPP. Command line for CSC: ffmpeg -hwaccel qsv -v verbose -c:v hevc_qsv -i p010.h265 -vf scale_qsv=format=x2rgb10,hwdownload,format=x2rgb10 -vframes 1 out.y

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

2020-08-08 Thread Mark Thompson
On 26/07/2020 13:26, Jun Zhao wrote: From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 71c9c8f..9032

Re: [FFmpeg-devel] [PATCH 5/5] lavc/vaapi_encode: export encoded frame stats

2020-08-08 Thread Mark Thompson
On 26/07/2020 13:26, Jun Zhao wrote: From: Jun Zhao Export choosen pict_type. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode.c | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 6766641..2352fdd 100

Re: [FFmpeg-devel] [PATCH v2] doc/developer: origin of tables should be documented.

2020-08-08 Thread Mark Thompson
On 08/08/2020 18:57, Nicolas George wrote: Tables that were not just written by the code author are not actually source code, otherwise, "recode data..x1 < proprietary.o > source.c" would be enough to launder a proprietary blob into the source code. Documenting the origin of the tables or the me

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: support dynamic resolution change

2020-08-08 Thread Mark Thompson
On 08/08/2020 12:22, Timo Rothenpieler wrote: On 07.08.2020 10:18, leozhang wrote: Allow dynamic resolution change, this is useful for real time video communication application. Use below commands to test it, ffmpeg -i reinit-large_420_8-to-small_420_8.h264 -noautoscale -c:v hevc_nvenc out.26

[FFmpeg-devel] [PATCH 5/5] kmsgrab: Add more supported formats

2020-08-01 Thread Mark Thompson
X2RGB10 tested on both Intel Gen9 and AMD Polaris 11. NV12 tested on Intel Gen9 only - since it has multiple planes, this requires GetFB2. Also add some comments to split the list up a bit. --- libavdevice/kmsgrab.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavdevice/kmsgra

Re: [FFmpeg-devel] [PATCH 3/6] vaapi_encode_h265: Don't require uniform_spacing_flag

2020-08-01 Thread Mark Thompson
On 29/07/2020 04:13, Xiang, Haihao wrote: On Tue, 2020-07-28 at 23:50 +0100, Mark Thompson wrote: Though still use it if the tile arrangement matches. Also try to keep the fields in the same order as the standard. --- libavcodec/vaapi_encode_h265.c | 39 -- 1

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox: let VideoToolbox choose a decoder for us

2020-08-01 Thread Mark Thompson
On 01/08/2020 16:25, Wang Chuan wrote: If we fail to create a decoder specified by ourself, then try to let VideoToolbox pick a proper one for us. Signed-off-by: Wang Chuan --- libavcodec/videotoolbox.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libav

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/libsvtav1: remove unneeded svt_av1_enc_deinit_handle()

2020-08-01 Thread Mark Thompson
On 01/08/2020 12:22, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index d34c6b3..eb6043b 100644 --- a/libavcodec/libsvtav1.c +++ b/

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/libsvtav1: remove the unsupported color format and profile

2020-08-01 Thread Mark Thompson
On 01/08/2020 12:22, lance.lmw...@gmail.com wrote: From: Limin Wang If you enable YUV422 or YUV444, SVT-AV1 library will report "only support 420 now" error, so it's better to remove the unsupported code. ... not that you can even get to that message at the moment, because the encoder wrapp

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/libsvtav1: fix copy and paste error

2020-08-01 Thread Mark Thompson
On 01/08/2020 12:22, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 40942c6..d34c6b3 100644 --- a/libavcodec/libsvta

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/libsvtav1: remove the auto thread flag

2020-08-01 Thread Mark Thompson
On 01/08/2020 12:22, lance.lmw...@gmail.com wrote: From: Limin Wang Please use the cores and socket for the setting of multi-thread. Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/libsvtav1: support cores and socket options for svt av1

2020-08-01 Thread Mark Thompson
On 01/08/2020 12:22, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 9 + libavcodec/libsvtav1.c | 9 + 2 files changed, 18 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 2f5457f..da0b68d 100644

Re: [FFmpeg-devel] [PATCH v2 1/3] libsvtav1: Rename without a -

2020-07-31 Thread Mark Thompson
On 31/07/2020 00:59, James Almer wrote: On 7/30/2020 6:31 PM, Mark Thompson wrote: The external library is called libsvtav1, so use this name everywhere. --- configure| 2 +- libavcodec/Makefile | 2 +- libavcodec/allcodecs.c

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-30 Thread Mark Thompson
On 30/07/2020 03:53, James Almer wrote: > The name could also be simply libsvtav1, same as the library (and the > configure option), since unlike libvpx and (in theory) libaom, no other > codec will be supported by it. HEVC is in a different library. That makes more sense. I'll use libsvtav1 eve

Re: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options

2020-07-30 Thread Mark Thompson
On 29/07/2020 07:08, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Wednesday, July 29, 2020 06:50 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options The tile_rows/cols options currently do a

[FFmpeg-devel] [PATCH] librav1e: Make tile options consistent with other encoders

2020-07-30 Thread Mark Thompson
In all other AV1 encoders these are set as log2 of the number of tile columns/rows to use. This does change not the accessible configuration, since librav1e already requires these numbers to be powers of two. --- Possibly this is too late to be acceptable without additional messing around, but I'

[FFmpeg-devel] [PATCH v2 1/3] libsvtav1: Rename without a -

2020-07-30 Thread Mark Thompson
The external library is called libsvtav1, so use this name everywhere. --- configure| 2 +- libavcodec/Makefile | 2 +- libavcodec/allcodecs.c | 2 +- libavcodec/{libsvt_av1.c => libsvtav1.c} | 8 4 files changed, 7 in

[FFmpeg-devel] [PATCH v2 2/3] libsvtav1: Use _ rather than - in options

2020-07-30 Thread Mark Thompson
--- libavcodec/libsvtav1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 0c951286c7..13d3adc0f8 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -536,8 +536,8 @@ static const AVOption options[] = {

[FFmpeg-devel] [PATCH v2 3/3] libsvtav1: Fix the documentation to match the actual options

2020-07-30 Thread Mark Thompson
--- doc/encoders.texi | 48 +++--- libavcodec/libsvtav1.c | 6 +++--- 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index af7d2ba983..2f5457fb26 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi

[FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

2020-07-29 Thread Mark Thompson
Matching libaom-av1. --- libavcodec/libsvt_av1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/libsvt_av1.c b/libavcodec/libsvt_av1.c index c7ae5f9691..3229551d2b 100644 --- a/libavcodec/libsvt_av1.c +++ b/libavcodec/libsvt_av1.c @@ -483,7 +483,7 @@ stat

[FFmpeg-devel] [PATCH 2/2] libsvt-av1: Fix the documentation to match the actual options

2020-07-29 Thread Mark Thompson
--- doc/encoders.texi | 44 +++-- libavcodec/libsvt_av1.c | 6 +++--- 2 files changed, 37 insertions(+), 13 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index af7d2ba983..d05ecca8db 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

[FFmpeg-devel] [PATCH 3/6] vaapi_encode_h265: Don't require uniform_spacing_flag

2020-07-28 Thread Mark Thompson
Though still use it if the tile arrangement matches. Also try to keep the fields in the same order as the standard. --- libavcodec/vaapi_encode_h265.c | 39 -- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcod

[FFmpeg-devel] [PATCH 4/6] vaapi_encode: Delete unused field

2020-07-28 Thread Mark Thompson
--- libavcodec/vaapi_encode.c | 12 libavcodec/vaapi_encode.h | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 4544090bcc..b3a02459f1 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.

[FFmpeg-devel] [PATCH 5/6] vaapi_encode: Rewrite slice/tile support

2020-07-28 Thread Mark Thompson
This precalculates all of the information we will need to define slice and tile positions at init time rather than rebuilding some of it with every slice. The control of tiles is generalised to match slices, so that arbitrary tile and slice layouts are possible within the constraint that slices ca

<    1   2   3   4   5   6   7   8   9   10   >