[FFmpeg-devel] [PATCH 8/8] avformat/assenc: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/assenc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 68c3396e5a..265b5996ac 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -156,16 +156,23

[FFmpeg-devel] [PATCH 7/8] avcodec/srtdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/srtdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/srtdec.c b/libavcodec/srtdec.c index 98f84ac673..37fb0d3173 100644 --- a/libavcodec/srtdec.c +++ b/libavcodec/srtdec.c @@ -62,6 +62,7 @@ static int

[FFmpeg-devel] [PATCH 6/8] avcodec/webvttdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/webvttdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 7b2d1750de..43caf3edbd 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -42,23 +42,23

[FFmpeg-devel] [PATCH 5/8] avcodec/subviewerdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/subviewerdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/subviewerdec.c b/libavcodec/subviewerdec.c index 805c7dd547..1016ac7ada 100644 --- a/libavcodec/subviewerdec.c +++ b/libavcodec/subviewerdec.c

[FFmpeg-devel] [PATCH 4/8] avcodec/realtextdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/realtextdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/realtextdec.c b/libavcodec/realtextdec.c index 5084781123..bdd9659235 100644 --- a/libavcodec/realtextdec.c +++ b/libavcodec/realtextdec.c @@ -29,11

[FFmpeg-devel] [PATCH 3/8] avcodec/mpl2dec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mpl2dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpl2dec.c b/libavcodec/mpl2dec.c index 409e4b3708..efeecb0d64 100644 --- a/libavcodec/mpl2dec.c +++ b/libavcodec/mpl2dec.c @@ -29,15 +29,15

[FFmpeg-devel] [PATCH 2/8] avcodec/samidec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/samidec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index e32f238c62..f03b5db958 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@ -38,12 +38,12 @@ typedef

[FFmpeg-devel] [PATCH 1/8] avcodec/assdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/assdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/assdec.c b/libavcodec/assdec.c index f0b1069cd2..655fc1365c 100644 --- a/libavcodec/assdec.c +++ b/libavcodec/assdec.c @@ -54,7 +54,7 @@ static int ass_decode_frame

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, James Almer wrote: I get a packet from a demuxer. It contains two independent portions (NALUs, OBUs, etc) i want to separate in order to feed them to something like a multi threaded decoder. And so I create a new reference to it, resulting in two packets pointing to th

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Sat, 13 Mar 2021, Paul B Mahol wrote: On Sat, Mar 13, 2021 at 5:56 PM Marton Balint wrote: On Fri, 12 Mar 2021, Paul B Mahol wrote: > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: > >> >> >> On Sun, 7 Mar 2021, Marton Balint wrote: >> >>

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, Paul B Mahol wrote: On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: On Sun, 7 Mar 2021, Marton Balint wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: >> >>> >>

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-13 Thread Marton Balint
On Sat, 16 Jan 2021, Mark Plomer wrote: Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, although it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this causes ffmpeg/VLC-player to produce/play corrupted

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-12 Thread Marton Balint
On Wed, 10 Mar 2021, Marton Balint wrote: On Sat, 6 Mar 2021, Marton Balint wrote: On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-12 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 7:40 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-11 Thread Marton Balint
On Sun, 7 Mar 2021, Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:40 PM, James Almer wrote: Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2 insertion

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctly handle non-writable packets. I don't think this is a good idea, av_shrink_packet canno

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: RTP support buffer_size&pkt_size option

2021-03-10 Thread Marton Balint
On Tue, 9 Mar 2021, gaojiang...@live.com wrote: From: Jiangjie Gao And forward it to udp. issue: https://trac.ffmpeg.org/ticket/7517 Could you add the buffer_size option to the documentation of the RTP protocol? Thanks, Marton Signed-off-by: Jiangjie Gao --- libavformat/rtsp.c | 5 +

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/gopher: Add support for Gopher over TLS.

2021-03-10 Thread Marton Balint
On Mon, 8 Mar 2021, Ivan J. wrote: Bump for review. Will apply the series. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-dev

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-10 Thread Marton Balint
On Tue, 9 Mar 2021, Stephen Hutchinson wrote: On 3/9/2021 3:47 PM, Michael Niedermayer wrote: Hi all I will branch release/4.4 soon then like always leave some time for testing, bugfixes, ... and then make FFmeg 4.4 from release/4.4, its too long since 4.3 These three AviSynth demuxer patc

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-10 Thread Marton Balint
On Sat, 6 Mar 2021, Marton Balint wrote: On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest of the series. Note that the approach in this

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-10 Thread Marton Balint
On Mon, 8 Mar 2021, Michael Niedermayer wrote: On Mon, Mar 08, 2021 at 09:56:38PM +0100, Marton Balint wrote: On Sun, 7 Mar 2021, Michael Niedermayer wrote: On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: If the window is resized it was possible that xpos pointed outside

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-08 Thread Marton Balint
On Sun, 7 Mar 2021, Michael Niedermayer wrote: On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: If the window is resized it was possible that xpos pointed outside the visualization texture. By rearranging the overflow check we make sure this (and a crash) does not happen

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-07 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> > On Sun, Mar 7, 2021 at 1:35 AM

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-07 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: On 3/6/2021 9:51 PM, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint wrote: > >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >>> How

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: How you tested this? with the librist tools. And why you have not asked nicely before taking working on this? You wrote you have given up. It is your behaviour which is not very nice. After your continuous ignorance of my requests, I try to help

[FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Marton Balint
Signed-off-by: Marton Balint --- Changelog | 1 + libavformat/version.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index b28a8c59f1..b4d3258be7 100644 --- a/Changelog +++ b/Changelog @@ -81,6 +81,7 @@ version : - TTML subtitle encoder

[FFmpeg-devel] [PATCH 6/7] avformat/librist: clarify and limit buffer_size

2021-03-06 Thread Marton Balint
As suggested by librist developers. Signed-off-by: Marton Balint --- doc/protocols.texi| 4 +++- libavformat/librist.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 45ef946efd..d6ecbd5bac 100644 --- a/doc/protocols.texi

[FFmpeg-devel] [PATCH 5/7] avformat/librist: increase default loglevel

2021-03-06 Thread Marton Balint
Also remove AV_LOG_SIMULATE from the list as it is not used directly, and do not use panic level on unknown loglevel, but make them warn. Also fix mapping of NOTICE/INFO/VERBOSE and add documentation about when the option should actually be used. Signed-off-by: Marton Balint --- doc

[FFmpeg-devel] [PATCH 4/7] avformat/librist: simplify secret strlcpy

2021-03-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/librist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/librist.c b/libavformat/librist.c index 3f74521cb4..2fb3162f86 100644 --- a/libavformat/librist.c +++ b/libavformat/librist.c @@ -158,7 +158,7 @@ static int

[FFmpeg-devel] [PATCH 3/7] avformat/librist: make packet size adjustable for writing, fix it for reading

2021-03-06 Thread Marton Balint
Maximum packet size is 1 (RIST_MAX_PACKET_SIZE, which is unfortunately private) minus the RIST protocol overhead which is 28 bytes for the unencrypted case, 36 for the encrypted case. Signed-off-by: Marton Balint --- doc/protocols.texi| 3 +++ libavformat/librist.c | 17

[FFmpeg-devel] [PATCH 2/7] avformat/librist: rework librist_read

2021-03-06 Thread Marton Balint
Queue tracking makes no difference so remove it, return EAGAIN of no data is available and rist data block needs to be freed even for zero sized packets. Signed-off-by: Marton Balint --- libavformat/librist.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 1/7] libavformat: add librist protocol

2021-03-06 Thread Marton Balint
From: Paul B Mahol This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 236 libavformat/protoc

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: Marton Balint: On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_ag

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-06 Thread Marton Balint
On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest of the series. Note that the approach in this patch makes 1/5 unneeded because constant frame

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was explicitly set) which leads to a leak of the

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: change toolkit_version metadata field to toolkit_version_num

2021-03-04 Thread Marton Balint
On Fri, 26 Feb 2021, Tomas Härdin wrote: lör 2021-02-20 klockan 00:17 +0100 skrev Marton Balint: It only got added recently, and the new name makes it consistent with product_version_num in the next patch. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +- tests

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/dvbsubdec: Support computing clut only once

2021-03-04 Thread Marton Balint
On Thu, 4 Mar 2021, Michael Niedermayer wrote: This avoids crafted files from consuming excessive resources recomputing the clut after each pixel change Signed-off-by: Michael Niedermayer --- libavcodec/dvbsubdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) PLease update do

[FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-03 Thread Marton Balint
xleft then the texture should be positioned accordingly when rendering. Signed-off-by: Marton Balint --- fftools/ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index b9a30cdb11..0cdadab293 100644 --- a/fftools/ffplay.c +++ b/ff

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Marton Balint
On Tue, 2 Mar 2021, Peter White wrote: On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although it is preferred. What they need to be i

[FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-01 Thread Marton Balint
Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Signed-off-by: Marton Balint --- libavdevice/alsa.c | 5 + libavdevice/alsa.h | 1 + libavdevice/alsa_dec.c | 22 -- 3 files changed

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-28 Thread Marton Balint
On Sun, 28 Feb 2021, Paul B Mahol wrote: On Sun, Feb 28, 2021 at 11:14 PM Marton Balint wrote: On Sun, 28 Feb 2021, Paul B Mahol wrote: > This work is sponsored by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > configure | 5 + >

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-28 Thread Marton Balint
On Sun, 28 Feb 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 236 +++

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-28 Thread Marton Balint
On Sun, 28 Feb 2021, Paul B Mahol wrote: On Fri, Feb 26, 2021 at 9:54 PM Marton Balint wrote: On Fri, 26 Feb 2021, Paul B Mahol wrote: > This work is sponsored by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > configure | 5 + >

Re: [FFmpeg-devel] [PATCH 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-02-28 Thread Marton Balint
On Sun, 28 Feb 2021, Nicolas George wrote: Marton Balint (12021-02-21): Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 18 ++ 1 file

Re: [FFmpeg-devel] [PATCH] avformat/movenccenc: Fix memory leak for muxing CENC-encrypted files

2021-02-27 Thread Marton Balint
On Sat, 27 Feb 2021, Вадим Бездушный wrote: Ping. This patch is very trivial and solves memory leak which makes CENC encryption quite hard to use on high load services. Thanks, applied. Regards, Marton вс, 31 янв. 2021 г. в 16:52, Vadym Bezdushnyi : Signed-off-by: Vadym Bezdushnyi --

Re: [FFmpeg-devel] [PATCH 1/5] avdevice/alsa_dec: do not set codecpar frame_size

2021-02-27 Thread Marton Balint
On Sun, 21 Feb 2021, Marton Balint wrote: Constant frame size is not guaranteed if the read call interrupted by a signal, or if non-blocking mode is used. Ping for the series. Thanks, Marton Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 1 - 1 file changed, 1 deletion

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: add support for getting product version number metadata

2021-02-27 Thread Marton Balint
On Sat, 20 Feb 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 3 +++ tests/ref/fate/mxf-d10-user-comments | 1 + tests/ref/fate/mxf-probe-dnxhd | 1 + 3 files changed, 5 insertions(+) Ping, will apply soon. Thanks, Marton diff

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avf_showcqt: use av_gettime_relative() instead of av_gettime()

2021-02-27 Thread Marton Balint
On Sun, 7 Feb 2021, Marton Balint wrote: av_gettime_relative() is using the monotonic clock therefore more suitable for relative time calculations. Applied. Regards, Marton Signed-off-by: Marton Balint --- libavfilter/avf_showcqt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [FFmpeg-devel] [PATCH 2/3] avdevice/timefilter: remove obsolete comments from the docs

2021-02-27 Thread Marton Balint
On Sun, 7 Feb 2021, Nicolas George wrote: Marton Balint (12021-02-07): Also rename the parameters of the function to match with the implementation. Signed-off-by: Marton Balint --- libavdevice/timefilter.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) Probably ok

Re: [FFmpeg-devel] [PATCH] avdevice: use av_gettime_relative() for elapsed time calculations

2021-02-26 Thread Marton Balint
On Fri, 19 Feb 2021, Marton Balint wrote: av_gettime_relative() is using the monotonic clock therefore more suitable for elapsed time calculations. Packet timestamps are still kept absolute, although that should be configurable in the future. Signed-off-by: Marton Balint --- libavdevice

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-26 Thread Marton Balint
On Fri, 26 Feb 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 248 +++

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

2021-02-23 Thread Marton Balint
On Sat, 20 Feb 2021, Dave Rice wrote: Hi, On Oct 31, 2020, at 5:15 PM, Marton Balint mailto:c...@passwd.hu>> wrote: On Sat, 31 Oct 2020, Dave Rice wrote: On Oct 31, 2020, at 3:47 PM, Marton Balint mailto:c...@passwd.hu>> wrote: On Sat, 31 Oct 2020, Dave Rice wrote: Hi Marton

Re: [FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2021-02-22 Thread Marton Balint
On Mon, 22 Feb 2021, Paul B Mahol wrote: On Mon, Feb 22, 2021 at 8:27 PM Marton Balint wrote: On Mon, 22 Feb 2021, Paul B Mahol wrote: > On Mon, Feb 22, 2021 at 9:10 AM Gijs Peskens wrote: > >> Hi, some feedback from one of the libRIST developers: >> >> Test

Re: [FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2021-02-22 Thread Marton Balint
On Mon, 22 Feb 2021, Paul B Mahol wrote: On Mon, Feb 22, 2021 at 9:10 AM Gijs Peskens wrote: Hi, some feedback from one of the libRIST developers: Testing this patch (via diff found on: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210126205145.20448-1-one...@gmail.com/ ) I've notice

Re: [FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2021-02-22 Thread Marton Balint
On Mon, 22 Feb 2021, Gijs Peskens wrote: Thanks for your swift reply! (and for your work on the patch, which I believe I forgot to thank you for) On 22-02-2021 09:17, Paul B Mahol wrote: On Mon, Feb 22, 2021 at 9:10 AM Gijs Peskens wrote: Hi, some feedback from one of the libRIST develop

[FFmpeg-devel] [PATCH 5/5] avdevice/pulse_audio_dec: do not read undersized frames

2021-02-21 Thread Marton Balint
get fragment_size amount of data is intentional. Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 71 --- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c index 0454a643dd

[FFmpeg-devel] [PATCH 4/5] avdevice/pulse_audio_dec: only set adjust latency flag if fragment_size is not set

2021-02-21 Thread Marton Balint
Otherwise fragment_size is ignored. Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c index 6dea332beb..0454a643dd 100644 --- a/libavdevice

[FFmpeg-devel] [PATCH 3/5] avdevice/pulse_audio_dec: query actual fragment size

2021-02-21 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c index 50a3c971ae..6dea332beb 100644 --- a/libavdevice/pulse_audio_dec.c +++ b/libavdevice/pulse_audio_dec.c

[FFmpeg-devel] [PATCH 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-02-21 Thread Marton Balint
Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavdevice/alsa_dec.c b/libavdevice

[FFmpeg-devel] [PATCH 1/5] avdevice/alsa_dec: do not set codecpar frame_size

2021-02-21 Thread Marton Balint
Constant frame size is not guaranteed if the read call interrupted by a signal, or if non-blocking mode is used. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavdevice/alsa_dec.c b/libavdevice/alsa_dec.c index 36494e921c

Re: [FFmpeg-devel] [PATCH 1/2 v2] avcodec/gifenc: Add global_palette option

2021-02-20 Thread Marton Balint
On Sat, 20 Feb 2021, Derek Buitenhuis wrote: This option will disable the writing of the global palette in global GIF header if it is set to 0, causing only the frame-level palette to ever be written. This will be useful later on when further frame-level palette optimizations are introduced.

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: change toolkit_version metadata field to toolkit_version_num

2021-02-19 Thread Marton Balint
It only got added recently, and the new name makes it consistent with product_version_num in the next patch. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +- tests/ref/fate/mxf-d10-user-comments | 2 +- tests/ref/fate/mxf-probe-applehdr10 | 2 +- tests/ref/fate/mxf

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: add support for getting product version number metadata

2021-02-19 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 3 +++ tests/ref/fate/mxf-d10-user-comments | 1 + tests/ref/fate/mxf-probe-dnxhd | 1 + 3 files changed, 5 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 3ce83dde54..bb00838a3f 100644

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-02-19 Thread Marton Balint
On Fri, 19 Feb 2021, Nicolas George wrote: hou...@uniontech.com (12021-02-19): From: Hou Lei Signed-off-by: Hou Lei --- libavdevice/xcbgrab.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) NAK. The correct fix is to use the monotonic clock for syncing. I just sent a

[FFmpeg-devel] [PATCH] avdevice: use av_gettime_relative() for elapsed time calculations

2021-02-19 Thread Marton Balint
av_gettime_relative() is using the monotonic clock therefore more suitable for elapsed time calculations. Packet timestamps are still kept absolute, although that should be configurable in the future. Signed-off-by: Marton Balint --- libavdevice/bktr.c | 4 ++-- libavdevice/fbdev_dec.c | 6

Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffplay: get rid of flush_pkt

2021-02-19 Thread Marton Balint
On Sun, 7 Feb 2021, Marton Balint wrote: The packet serial can be used instead to detect when a flush is needed. Signed-off-by: Marton Balint --- fftools/ffplay.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) Will apply the series. Regards, Marton

Re: [FFmpeg-devel] [PATCH 1/2] avformat/network: fix timeout inaccurate in wait_fd_timeout

2021-02-08 Thread Marton Balint
The wait_start was about POLLING_TIME larger which leads to timeout 100ms late than the option setting. --- libavformat/network.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 0f5a575f77..7a9a4be5bb 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] lavf/libsrt: deduplicate libsrt_network_wait_fd_timeout

2021-02-08 Thread Marton Balint
On Mon, 8 Feb 2021, "zhilizhao(赵志立)" wrote: On Feb 8, 2021, at 2:36 AM, Marton Balint wrote: On Mon, 8 Feb 2021, Zhao Zhili wrote: --- libavformat/libsrt.c | 45 +--- 1 file changed, 17 insertions(+), 28 deletions(-) Hmm, it seems

[FFmpeg-devel] [PATCH 4/4] fftools/ffplay: reindent and some minor cosmetics

2021-02-07 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffplay.c | 95 +++- 1 file changed, 45 insertions(+), 50 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index eab156c47a..b9a30cdb11 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c

[FFmpeg-devel] [PATCH 3/4] fftools/ffplay: use av_packet_alloc() to allocate packets

2021-02-07 Thread Marton Balint
Heavily based on a patch by James Almer. Signed-off-by: Marton Balint --- fftools/ffplay.c | 140 +-- 1 file changed, 76 insertions(+), 64 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0054fec076..eab156c47a 100644 --- a/fftools

[FFmpeg-devel] [PATCH 2/4] fftools/ffplay: use context AVPacket in decoder_decode_frame()

2021-02-07 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffplay.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 70d8548a64..0054fec076 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -589,8 +589,6 @@ static int

[FFmpeg-devel] [PATCH 1/4] fftools/ffplay: get rid of flush_pkt

2021-02-07 Thread Marton Balint
The packet serial can be used instead to detect when a flush is needed. Signed-off-by: Marton Balint --- fftools/ffplay.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 9ff0425163..70d8548a64 100644

Re: [FFmpeg-devel] [PATCH 2/2] lavf/libsrt: deduplicate libsrt_network_wait_fd_timeout

2021-02-07 Thread Marton Balint
On Mon, 8 Feb 2021, Zhao Zhili wrote: --- libavformat/libsrt.c | 45 +--- 1 file changed, 17 insertions(+), 28 deletions(-) Hmm, it seems my latest srt patches conflics with this a bit, and you will have to somewhat rebase this, sorry. On the bright si

Re: [FFmpeg-devel] [PATCH 1/3] avformat/libsrt: close listen fd immediately after accept

2021-02-07 Thread Marton Balint
On Sun, 31 Jan 2021, Marton Balint wrote: There is no reason to keep it open. Will apply the series. Regards, Marton Signed-off-by: Marton Balint --- libavformat/libsrt.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/libavformat/libsrt.c b

Re: [FFmpeg-devel] [PATCH 50/50] fftools/ffplay: use av_packet_alloc() to allocate packets

2021-02-07 Thread Marton Balint
On Thu, 4 Feb 2021, James Almer wrote: Signed-off-by: James Almer --- fftools/ffplay.c | 204 +-- 1 file changed, 127 insertions(+), 77 deletions(-) Thanks for this, I see a couple of things that can be simplified, maybe it is easier if I take ove

[FFmpeg-devel] [PATCH 3/3] avdevice: use av_gettime_relative() for timestamps

2021-02-06 Thread Marton Balint
av_gettime_relative() is using the monotonic clock therefore more suitable as a timestamp source and for relative time calculations. Probably fixes ticket #9089. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c| 2 +- libavdevice/bktr.c| 6 +++--- libavdevice

[FFmpeg-devel] [PATCH 1/3] avfilter/avf_showcqt: use av_gettime_relative() instead of av_gettime()

2021-02-06 Thread Marton Balint
av_gettime_relative() is using the monotonic clock therefore more suitable for relative time calculations. Signed-off-by: Marton Balint --- libavfilter/avf_showcqt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c

[FFmpeg-devel] [PATCH 2/3] avdevice/timefilter: remove obsolete comments from the docs

2021-02-06 Thread Marton Balint
Also rename the parameters of the function to match with the implementation. Signed-off-by: Marton Balint --- libavdevice/timefilter.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/libavdevice/timefilter.h b/libavdevice/timefilter.h index cb3d0a788f

Re: [FFmpeg-devel] [PATCH 09/10] fftools/ffplay: use av_packet_alloc() to allocate packets

2021-02-02 Thread Marton Balint
On Mon, 1 Feb 2021, James Almer wrote: Signed-off-by: James Almer --- fftools/ffplay.c | 222 --- 1 file changed, 135 insertions(+), 87 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 9ff0425163..ef954772ed 100644 [...] -stat

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread Marton Balint
On Mon, 1 Feb 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Please check the string of toolkit version with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf toolkit_version : 58.65.101 Signed-off-by: Limin Wang --- liba

[FFmpeg-devel] [PATCH 3/3] avformat/libsrt: fix race condition with libsrt_network_wait_fd and epoll

2021-01-31 Thread Marton Balint
till won't receive the event even if it wasn't serviced. Therefore we create the epoll and put the fd into it right after the connection is established. See http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-January/275334.html Signed-off-by: Marton Balint --- libav

[FFmpeg-devel] [PATCH 2/3] avformat/libsrt: fix or simplify some function return values

2021-01-31 Thread Marton Balint
Sometimes there was a confusion between srt_*() function return values and libavformat-style return values. Signed-off-by: Marton Balint --- libavformat/libsrt.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index

[FFmpeg-devel] [PATCH 1/3] avformat/libsrt: close listen fd immediately after accept

2021-01-31 Thread Marton Balint
There is no reason to keep it open. Signed-off-by: Marton Balint --- libavformat/libsrt.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index f73e7dbfa5..28c06f130e 100644 --- a/libavformat/libsrt.c +++ b

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-31 Thread Marton Balint
On Sun, 31 Jan 2021, Paul B Mahol wrote: On Sun, Jan 31, 2021 at 12:29 PM Marton Balint wrote: On Sun, 31 Jan 2021, Paul B Mahol wrote: > On Sun, Jan 31, 2021 at 12:00 PM Marton Balint wrote: > >> >> >> On Tue, 26 Jan 2021, Paul B Mahol wrote: >> >&

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-31 Thread Marton Balint
On Sun, 31 Jan 2021, Paul B Mahol wrote: On Sun, Jan 31, 2021 at 12:00 PM Marton Balint wrote: On Tue, 26 Jan 2021, Paul B Mahol wrote: > This work is sponsored by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > configure | 5 + >

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-31 Thread Marton Balint
On Tue, 26 Jan 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 + libavformat/Makefile| 1 + libavformat/librist.c | 251 +++

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-30 Thread Marton Balint
On Sun, 31 Jan 2021, Marton Balint wrote: On Tue, 26 Jan 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 + libavformat/Makefile| 1 + libavformat/librist.c

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-30 Thread Marton Balint
On Tue, 26 Jan 2021, Paul B Mahol wrote: This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 + libavformat/Makefile| 1 + libavformat/librist.c | 251 +++

Re: [FFmpeg-devel] Race condition in libavformat/libsrt.c causes EOF to be missed

2021-01-30 Thread Marton Balint
On Fri, 29 Jan 2021, Belabox Project wrote: Hi, The way SRT's async / epoll-based IO works is that the event status is stored in the epoll containers. That is, if an event occurs on an SRT socket, and that SRT socket isn't part of any epoll container, then that event is lost. If we later add

Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/mxf: add platform local tag

2021-01-30 Thread Marton Balint
On Sat, 30 Jan 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Please check the string of platform with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf application_platform: Lavf58.65.101 (linux) I think this should simp

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-29 Thread Marton Balint
On Thu, 28 Jan 2021, Tomas Härdin wrote: tor 2021-01-28 klockan 14:48 +0100 skrev Tomas Härdin: tor 2021-01-28 klockan 08:56 +0100 skrev Marton Balint: On Thu, 28 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 23:50 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Marton Balint
On Thu, 28 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 23:50 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote: > ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: > > ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: > > > On Wed,

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Marton Balint
On Thu, 28 Jan 2021, Gyan Doshi wrote: On 28-01-2021 05:08 am, Marton Balint wrote: So only timecode, convergence_duration and the pseudopal flag should be removed, because there is no replacement for those. Will timecode still be available from ffprobe after this patchset? Only mpeg2

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, James Almer wrote: On 1/27/2021 7:42 PM, Michael Niedermayer wrote: On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: Also drop the sections guarded by #if FF_API* These macros are private and should not be used by external callers. --- fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add Coding Equations and Color Primaries to local tags

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 22:07 +0100 skrev Marton Balint: Fixes ticket #9079. Signed-off-by: Marton Balint --- libavformat/mxfenc.c| 2 ++ tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/mxf-d10-user-comments| 2

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote: Hi Ticket #9079 brought this about. This should prevent accidentally adding local tags that are

[FFmpeg-devel] [PATCH] avformat/mxfenc: add Coding Equations and Color Primaries to local tags

2021-01-27 Thread Marton Balint
Fixes ticket #9079. Signed-off-by: Marton Balint --- libavformat/mxfenc.c| 2 ++ tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/mxf-d10-user-comments| 2 +- tests/ref/fate/mxf-opatom-user-comments | 2 +- tests/ref/fate/mxf-reel_name| 2

Re: [FFmpeg-devel] [PATCH] avcodec/flashsv2enc: Fix use of uninitialized value

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Andreas Rheinhardt wrote: Before 257a83b969157eb76c18158a4e503e908d8b1125, certain buffers were zero-allocated in the init function and only reallocated lateron if they turned out to be too small; now they are only allocated during init, leading to use-of-uninitialized val

<    5   6   7   8   9   10   11   12   13   14   >