Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: unbreak get_bits_le() with cached reader

2019-04-07 Thread Paul B Mahol
On 3/26/19, Paul B Mahol wrote: > On 3/26/19, Carl Eugen Hoyos wrote: >> 2019-03-26 11:34 GMT+01:00, Paul B Mahol : >>> On 3/26/19, Carl Eugen Hoyos wrote: >>>> 2019-03-26 11:13 GMT+01:00, Paul B Mahol : >>>>> Signed-off-by: Paul B Mahol

[FFmpeg-devel] [PATCH] avcodec/agm: add support for higher compression

2019-04-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 403 +++-- libavformat/riff.c | 4 + 2 files changed, 392 insertions(+), 15 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index cbd45e8095..e183b7f508 100644 --- a/libavcodec/agm.c

Re: [FFmpeg-devel] [PATCH] avcodec/agm: add support for higher compression

2019-04-08 Thread Paul B Mahol
On 4/8/19, Nicolas George wrote: > Paul B Mahol (12019-04-08): >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/agm.c | 403 +++-- >> libavformat/riff.c | 4 + >> 2 files changed, 392 insertions(+), 15 deletions

Re: [FFmpeg-devel] [PATCH] avcodec/agm: add support for higher compression

2019-04-08 Thread Paul B Mahol
On 4/8/19, James Almer wrote: > On 4/8/2019 12:42 PM, Paul B Mahol wrote: >>>> +static int decode_huffman2(AVCodecContext *avctx, int header, int size) >>>> +{ >>>> +AGMContext *s = avctx->priv_data; >>>> +GetBitContext *gb = &

[FFmpeg-devel] [PATCH 2/2] avcodec/agm: add support for non-dct coding

2019-04-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 332 +++-- libavformat/riff.c | 2 + 2 files changed, 291 insertions(+), 43 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index 1d6a277827..e465b22d41 100644 --- a/libavcodec/agm.c

[FFmpeg-devel] [PATCH 1/2] avcodec/agm: add support for higher compression

2019-04-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 404 +++-- libavformat/riff.c | 4 + 2 files changed, 392 insertions(+), 16 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index cbd45e8095..1d6a277827 100644 --- a/libavcodec/agm.c

[FFmpeg-devel] [PATCH 2/3] avcodec/agm: add support for non-dct coding

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 332 +++-- libavformat/riff.c | 2 + 2 files changed, 291 insertions(+), 43 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index 1d6a277827..e465b22d41 100644 --- a/libavcodec/agm.c

[FFmpeg-devel] [PATCH 3/3] avcodec: add ADPCM AGM decoder

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 58 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavformat/riff.c | 1 + 6 files changed, 69

[FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/agm.c | 404 +++-- libavformat/riff.c | 4 + 2 files changed, 392 insertions(+), 16 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index cbd45e8095..1d6a277827 100644 --- a/libavcodec/agm.c

Re: [FFmpeg-devel] [PATCH]download: Fix the release link

2019-04-10 Thread Paul B Mahol
On 3/29/19, Michael Niedermayer wrote: > On Fri, Mar 29, 2019 at 01:16:41AM +0100, Carl Eugen Hoyos wrote: >> 2019-03-28 20:52 GMT+01:00, Michael Niedermayer : >> > On Thu, Mar 28, 2019 at 06:47:52PM +0100, Carl Eugen Hoyos wrote: >> >> 2019-03-28 18:31 GMT+01:00, Michael Niedermayer >> >> : >> >>

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: add ADPCM AGM decoder

2019-04-10 Thread Paul B Mahol
On 4/10/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/adpcm.c | 58 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7

Re: [FFmpeg-devel] [PATCH] avcodec/agm: Check frame dimensions

2019-04-11 Thread Paul B Mahol
On 4/11/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 14110/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5649184864075776 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH] avcodec: add LSCR decoder

2019-04-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/pngdec.c | 135 libavformat/riff.c | 1 + 6 files changed, 146

Re: [FFmpeg-devel] [GSOC] [PATCH] avfilter: add panorama filter

2019-04-13 Thread Paul B Mahol
> > Signed-off-by: Eugene Lyapustin > > --- > > use bilinear from cubemap to equirectangular > Change cube faces order to match Youtube's > avfilter: add convertion to/from cubemap 6x1 > > Signed-off-by: Hazem Ashmawy > > --- >

Re: [FFmpeg-devel] [PATCH] avcodec: add LSCR decoder

2019-04-13 Thread Paul B Mahol
On 4/12/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 +++ > libavcod

[FFmpeg-devel] [PATCH] avfilter: add lagfun filter

2019-04-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_lagfun.c | 252 +++ 4 files changed, 269 insertions(+) create mode 100644 libavfilter/vf_lagfun.c diff

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

2019-04-16 Thread Paul B Mahol
On 4/16/19, Jun Zhao wrote: > From: Jun Zhao > > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed > the version bump and Changelog entry. > > Signed-off-by: Jun Zhao > --- > Changelog |1 + > libavformat/version.h |2 +- > 2 files changed, 2 insertions(+), 1 deletions

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-16 Thread Paul B Mahol
On 4/16/19, Tomas Härdin wrote: > tis 2019-04-16 klockan 00:41 +0200 skrev Carl Eugen Hoyos: >> > 2019-04-16 0:00 GMT+02:00, Tomas Härdin : >> > mån 2019-04-15 klockan 12:40 +0200 skrev Carl Eugen Hoyos: >> > > > > > > > 2019-04-15 10:30 GMT+02:00, Tomas Härdin >> > > > > > > > : >> > > > This isn

Re: [FFmpeg-devel] [PATCH 1/4] avutil/avstring: Fix bug and undefined behavior in av_strncasecmp()

2019-04-16 Thread Paul B Mahol
On 4/16/19, Michael Niedermayer wrote: > The function in case of n=0 would read more bytes than 0. > The end pointer could be beyond the allocated space, which > is undefined. > > Signed-off-by: Michael Niedermayer > --- > libavutil/avstring.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 dele

[FFmpeg-devel] [PATCH] avfilter: add audio soft clip filter

2019-04-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 libavfilter/Makefile | 1 + libavfilter/af_asoftclip.c | 206 + libavfilter/allfilters.c | 1 + 4 files changed, 230 insertions(+) create mode 100644 libavfilter/af_asoftclip.c

[FFmpeg-devel] [PATCH] avcodec/dvdec: add frame threads

2019-04-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dvdec.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index 7b16787e27..89864f2edc 100644 --- a/libavcodec/dvdec.c +++ b/libavcodec/dvdec.c @@ -49,6 +49,7 @@ #include

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: add frame threads

2019-04-18 Thread Paul B Mahol
On 4/18/19, Michael Niedermayer wrote: > On Thu, Apr 18, 2019 at 01:19:58AM +0200, Michael Niedermayer wrote: >> On Wed, Apr 17, 2019 at 06:16:39PM +0200, Paul B Mahol wrote: >> > Signed-off-by: Paul B Mahol >> > --- >> > libavcodec/dvdec.c | 19

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: add frame threads

2019-04-18 Thread Paul B Mahol
On 4/18/19, Michael Niedermayer wrote: > On Thu, Apr 18, 2019 at 10:30:49AM +0200, Paul B Mahol wrote: >> On 4/18/19, Michael Niedermayer wrote: >> > On Thu, Apr 18, 2019 at 01:19:58AM +0200, Michael Niedermayer wrote: >> >> On Wed, Apr 17, 2019 at 06:16:

Re: [FFmpeg-devel] [PATCH] aacdec: use float_dsp in apply_independent_coupling

2019-04-18 Thread Paul B Mahol
On 4/12/19, Lynne wrote: > Could not be used in apply_dependent_coupling because of alignment issues. > > Probably OK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH] add tests/ref/fate/hls-segment-size for the fate test

2019-04-18 Thread Paul B Mahol
On 4/18/19, Carl Eugen Hoyos wrote: > 2019-04-18 4:33 GMT+02:00, Steven Liu : >> Signed-off-by: Steven Liu >> --- >> tests/ref/fate/hls-segment-size | 772 >> >> 1 file changed, 772 insertions(+) >> create mode 100644 tests/ref/fate/hls-segment-size >> >

[FFmpeg-devel] [PATCH 1/3] avfilter: add audio soft clip filter

2019-04-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 27 + libavfilter/Makefile | 1 + libavfilter/af_asoftclip.c | 217 + libavfilter/allfilters.c | 1 + 4 files changed, 246 insertions(+) create mode 100644 libavfilter

[FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/af_aupsample.c | 159 + libavfilter/allfilters.c | 1 + 3 files changed, 161 insertions(+) create mode 100644 libavfilter/af_aupsample.c diff --git a/libavfilter/Makefile b

[FFmpeg-devel] [PATCH 3/3] avfilter: add audio downsample filter

2019-04-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 +++ libavfilter/Makefile | 1 + libavfilter/af_adownsample.c | 171 +++ libavfilter/allfilters.c | 1 + 4 files changed, 188 insertions(+) create mode 100644 libavfilter

Re: [FFmpeg-devel] [PATCH 0/3] v210dec checkasm test and avx2 function

2019-04-18 Thread Paul B Mahol
On 4/18/19, James Darnley wrote: > On 2019-04-10 14:47, James Darnley wrote: >> I am resending this my patches because I am not sure if I sent this >> version in >> the past. I split my changes into two patches because they do separate >> things. >> >> I also changed some tabs to spaces in Mike's

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Carl Eugen Hoyos wrote: > 2019-04-18 23:17 GMT+02:00, Paul B Mahol : >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/Makefile | 1 + >> libavfilter/af_aupsample.c | 159 + >> libavfilter/allfilters.c

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> This is used as part of other filtering. Namely when filter needs to >> oversample >> audio when processing - it then upsample audio before processing and >> downsample >> it by same factor af

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> Users that know what they are doing will do: >> >> upsample=4,some additional filtering,alimiter=parameters,some >> additional filtering,downsample=4 > > Bad design. We have sample rate negotiatio

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> This is not about sample rate negotiation. > > Yes it is. Give proof. No, you need to argue better your pathetic behavior. > >> Bad argumentation. > > Then argue better. > > Patches rejec

Re: [FFmpeg-devel] [PATCH] avfilter: add lagfun filter

2019-04-19 Thread Paul B Mahol
Hi, On 4/15/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_lagfun.c | 252 +++ > 4 files ch

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> Look, you are full of shit. > > Unacceptable. Excuses expected. I will ignore your one liners, snarky replies. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Gyan wrote: > > > On 19-04-2019 02:43 PM, Nicolas George wrote: >> Paul B Mahol (12019-04-19): >>> Users that know what they are doing will do: >>> >>> upsample=4,some additional filtering,alimiter=parameters,some >>> additional f

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > Hi, > > to libavfilter/vf_fillborders.c I've added the following: > === > typedef struct FillBordersContext { > [.] > uint16_t *filler; > > void (*fillborders)(struct FillBordersContext *s, AVFrame *fram

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > > Am 19.04.19 um 13:38 schrieb Paul B Mahol: >> >> Use either av_freep(&s->filler) or av_free(s->filler). > > It works fine without 'p'. Thanks! > > Do I really need the init function, as it has to do nothing in my c

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > > Am 19.04.19 um 14:35 schrieb Paul B Mahol: >>> Do I really need the init function, as it has to do nothing in my case? >> If it does nothing, you can safely remove it. > > Thanks! > >>> For performance testing I use the l

[FFmpeg-devel] [PATCH 1/2] avfilter: add audio soft clip filter

2019-04-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- With more sample formats support. --- doc/filters.texi | 27 libavfilter/Makefile | 1 + libavfilter/af_asoftclip.c | 289 + libavfilter/allfilters.c | 1 + 4 files changed, 318 insertions(+) create

[FFmpeg-devel] [PATCH 2/2] avfilter: add audio sampling filter

2019-04-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Now with 2 filters merged into one and more sample formats. --- doc/filters.texi | 18 +++ libavfilter/Makefile | 1 + libavfilter/af_asampling.c | 280 + libavfilter/allfilters.c | 1 + 4 files changed

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add audio sampling filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Still rejected. As ML administrator previously wrote you need to provide technical reasons for rejection to make rejection valid. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Michael Niedermayer (12019-04-19): >> As i have been asked to look into this > > Not to look into this: to take action. > >> Everyone, the subject of discussions should be FFmpeg and the >> technologies >> sorounding it. Insults, "Ad hominem" argumentation/attac

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> What you actually want? > > I demand, that you behave in a civil manner. I'm very civil here. If I'm not polite than that is because of your snarky comments. You already blocked several my patches fo

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> I'm very civil here. > > https://ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242839.html I'm really sorry if that hurt you. ___ ffmpeg-devel mailing list ffmp

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: add cineSpace 1D lut parsing

2019-04-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 2 ++ libavfilter/vf_lut3d.c | 77 ++ 2 files changed, 79 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 4dd1a5de85..606d682e84 100644 --- a/doc/filters.texi +++ b/doc

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: add cineSpace 3D lut support

2019-04-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 2 + libavfilter/vf_lut3d.c | 91 ++ 2 files changed, 93 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 606d682e84..aaa9163d89 100644 --- a/doc/filters.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> I'm really sorry if that hurt you. > > That's not excuses for the insult. I'm really sorry. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: add frame threads

2019-04-19 Thread Paul B Mahol
On 4/18/19, Tobias Rapp wrote: > On 18.04.2019 11:40, Michael Niedermayer wrote: >> On Thu, Apr 18, 2019 at 10:30:49AM +0200, Paul B Mahol wrote: >>> On 4/18/19, Michael Niedermayer wrote: >>>> On Thu, Apr 18, 2019 at 01:19:58AM +0200, Michael Niedermayer wrote: &g

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> I'm really sorry. > > For what, and what do you intend to do about it? I'm really sorry for insulting you, and I will try to not repeat it. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-19 Thread Paul B Mahol
On 4/19/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> I'm really sorry for insulting you, and I will try to not repeat it. > > Accepted, although I have a feeling that "try" is weak. > > Now, you have complained about what you call my "one lin

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Add a blank like at the end to avoid rollup reading from outside

2019-04-20 Thread Paul B Mahol
On 4/20/19, Michael Niedermayer wrote: > Fixes: index 20 out of bounds for type 'const char *[4][128]' > Fixes: > 14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304 > > 14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304 >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-20 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > On Wed, Apr 10, 2019 at 01:45:51PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/agm.c | 404 +++-- >> libavformat/riff.c | 4 + >> 2 fil

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf/frei0r: Fixes the compilation warnings

2019-04-21 Thread Paul B Mahol
Subject should be lavfi/frei0r On 4/21/19, Jun Zhao wrote: > From: Jun Zhao > > Fixes the compilation warnings > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_frei0r.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/agm: remove ;;

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/agm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/agm.c b/libavcodec/agm.c > index c9d7be5521..7dcfaff4ad 100644 > --- a/libavcodec/agm.c > +++ b/libavcodec/agm.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/agm: Check for too many too short codes in make_new_tree()

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > Fixes: SEGV on unknown address > Fixes: > 14198/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5723579234123776 > > untested due to lack of valid samples using this codepath > > Found-by: continuous fuzzing process > https://github.com/google/

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: Do not crash on invalid codes

2019-04-21 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer wrote: > I do not know if such vlc trees are allowed in agm, I have no specification > So i do not know if these should be treated as error, or not. > But the code does contain a check for idx < 0 already ... > > untested due to lack of valid samples using this code

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Paul B Mahol
On 4/21/19, Nicolas George wrote: > Paul B Mahol (12019-04-19): >> Generic resampling via aresample is completely another filtering that >> have >> nothing to do with this filters, for more info read: >> >> https://www.oblique-audio.com/technique/oversampling

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-21 Thread Paul B Mahol
On 4/21/19, Nicolas George wrote: > I apperciate the efforts to reply more than half a line. > > Paul B Mahol (12019-04-21): >> It is not kind of resampling. Resampling is specific and belongs to >> separate library. > > There is no doubt it IS a kind of resampl

Re: [FFmpeg-devel] [PATCH V2] lavfi/frei0r: Fixes the compilation warnings

2019-04-21 Thread Paul B Mahol
On 4/21/19, Jun Zhao wrote: > From: Jun Zhao > > Fixes the compilation warnings > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_frei0r.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c > index c775ed1..165fbd7 1

Re: [FFmpeg-devel] [PATCH v3] lavfi: add colorkey_opencl filter

2019-04-21 Thread Paul B Mahol
On 4/20/19, Mark Thompson wrote: > On 17/04/2019 03:08, Jarek Samic wrote: >> This is a direct port of the CPU filter. >> >> Signed-off-by: Jarek Samic >> --- >> More fixes based on the comments from the second version of the patch >> (moving sampler declaration into the program scope, `f`-suffix

[FFmpeg-devel] [PATCH] avfilter/af_astats: count number of NaNs/Infs/denormals for floating-point audio too

2019-04-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 6 +++ libavfilter/af_astats.c | 86 ++--- 2 files changed, 86 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index cfff9b1f4d..945c557e8f 100644 --- a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-22 Thread Paul B Mahol
On 4/22/19, Nicolas George wrote: > Paul B Mahol (12019-04-21): >> https://dspguru.com/dsp/faqs/multirate/resampling/ >> >> Resampling involves interpolation. >> If I do resampling with aresample and resampling with factor 2 from >> 44100 to 88200 >> I can s

Re: [FFmpeg-devel] [PATCH]lavfi/frei0r: Fix union and remove unneeded cast

2019-04-24 Thread Paul B Mahol
On 4/23/19, Carl Eugen Hoyos wrote: > Hi! > > I failed to test attached patch but it seems like a more useful fix for > the following (past) warning: > libavfilter/vf_frei0r.c:130:17: warning: assignment to ‘char **’ from > incompatible pointer type ‘char *’ > > Please comment, Carl Eugen > LGTM

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showwaves: Add draw mode also to showwavespic filter

2019-04-25 Thread Paul B Mahol
On 4/25/19, Martin Vobruba wrote: > See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29 > --- > doc/filters.texi| 15 +++ > libavfilter/avf_showwaves.c | 3 +++ > 2 files changed, 18 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index e9cbccc..9b921

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-25 Thread Paul B Mahol
Found 65x65x65 3D LUT in wild Signed-off-by: Paul B Mahol --- libavfilter/vf_lut3d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index 50ea5a8545..d1974b0e05 100644 --- a/libavfilter/vf_lut3d.c +++ b/libavfilter/vf_lut3d.c

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: fix range domain processing for .cube format

2019-04-25 Thread Paul B Mahol
The ranges are for input, not for output. Signed-off-by: Paul B Mahol --- libavfilter/vf_lut3d.c | 73 +- 1 file changed, 51 insertions(+), 22 deletions(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index d1974b0e05..c3dd6eb69f 100644

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-25 Thread Paul B Mahol
On 4/25/19, Moritz Barsnick wrote: > On Thu, Apr 25, 2019 at 14:57:25 +0200, Paul B Mahol wrote: >> Found 65x65x65 3D LUT in wild > [...] >> /* 3D LUT don't often go up to level 32, but it is common to have a Hald >> CLUT >> * of 512x512 (64x64x64) */ &

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-25 Thread Paul B Mahol
On 4/25/19, Reto Kromer wrote: > Paul B Mahol wrote: > >>Found 65x65x65 3D LUT in wild > > FYI: 128x128x128 3D LUTs do also exist in film production. > Thank you, changed locally. > Best regards, Reto > > ___ > ffmpeg-

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-25 Thread Paul B Mahol
On 4/22/19, Paul B Mahol wrote: > On 4/22/19, Nicolas George wrote: >> Paul B Mahol (12019-04-21): >>> https://dspguru.com/dsp/faqs/multirate/resampling/ >>> >>> Resampling involves interpolation. >>> If I do resampling with aresample and resamplin

Re: [FFmpeg-devel] [PATCH] avfilter/af_astats: count number of NaNs/Infs/denormals for floating-point audio too

2019-04-25 Thread Paul B Mahol
On 4/23/19, Alexander Strasser wrote: > Hi Paul, > > just three small comments from me... > > On 2019-04-22 11:51 +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi| 6 +++ >> libavfilter/af_astats.c | 86

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-25 Thread Paul B Mahol
On 4/25/19, Nicolas George wrote: > Paul B Mahol (12019-04-25): >> As there appears to be no more comments or valid arguments against this > > Saying it does not make it true. You haven't replied any more, and nothing that you said earlier is valid. > >> set I w

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-25 Thread Paul B Mahol
On 4/25/19, Nicolas George wrote: > Paul B Mahol (12019-04-25): >> You haven't replied any more, and nothing that you said earlier is valid. > > I have stated: rejected until it plays well with sample rate > negotiation. You have not reacted to it. I did reacted. It play

Re: [FFmpeg-devel] [PATCH] avcodec/gdv: Check input palette size before rescale()

2019-04-25 Thread Paul B Mahol
On 4/25/19, Michael Niedermayer wrote: > Fixes: Timeout (22sec -> 11sec) > Fixes: > 13576/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GDV_fuzzer-5681024577568768 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] x86/opusdsp: replace loads with shuffles

2019-04-25 Thread Paul B Mahol
On 4/24/19, Lynne wrote: > Has a slight speedup. > Can't be carried over to aarch64, since it has no shufps-like instruction. > > On what CPU? And by how much? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH] x86/opusdsp: replace loads with shuffles

2019-04-25 Thread Paul B Mahol
On 4/25/19, Paul B Mahol wrote: > On 4/24/19, Lynne wrote: >> Has a slight speedup. >> Can't be carried over to aarch64, since it has no shufps-like >> instruction. >> >> > > On what CPU? And by how much? > Patch should generally be OK if output

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-25 Thread Paul B Mahol
On 4/25/19, Nicolas George wrote: > Hendrik Leppkes (12019-04-25): >> The point of this kind of filtering is not that they are necessary to >> perform filtering, because you can filter at any sample rate, but that >> oversampling for certain filters, and downsampling after, improves >> quality. As

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-25 Thread Paul B Mahol
On 4/25/19, Nicolas George wrote: > Paul B Mahol (12019-04-25): >> The filter does not take sample rate as argument, but integer factor >> instead. >> So that make it impossible to be used with lswr. > > No need for an argument: the filter knows the negotiated input and

[FFmpeg-devel] [PATCH] avfilter/vf_stack: use time_base from framesync

2019-04-25 Thread Paul B Mahol
Fixes non-monotonous timestamps. Signed-off-by: Paul B Mahol --- libavfilter/vf_stack.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_stack.c b/libavfilter/vf_stack.c index 8731674aa7..b836d96bf0 100644 --- a/libavfilter/vf_stack.c +++ b/libavfilter

[FFmpeg-devel] [PATCH] avformat/subtitles: ignore extra '\r' at line endings

2019-04-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/microdvddec.c | 2 ++ libavformat/subtitles.c | 2 +- libavformat/subtitles.h | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/microdvddec.c b/libavformat/microdvddec.c index ef6bcfbc73..598093309c 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add audio soft clip filter

2019-04-26 Thread Paul B Mahol
Will apply this one. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/oggdec: improve playback of chained opus file

2019-04-26 Thread Paul B Mahol
Improves decoding of: https://jmvalin.ca/misc_stuff/chain_works.opus Signed-off-by: Paul B Mahol --- libavformat/oggdec.c | 10 +- libavformat/oggdec.h | 1 + libavformat/oggparseopus.c | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/ifv: added support for ifv cctv files

2019-04-27 Thread Paul B Mahol
On 4/20/19, Swaraj Hota wrote: > Fixes ticket #2956. > > Signed-off-by: Swaraj Hota > --- > I have tested it on all the samples provided in the ticket and > it works for all of them. > > Please comment. > --- > Changelog| 1 + > libavformat/Makefile | 1 + > libavformat/a

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-27 Thread Paul B Mahol
On 4/27/19, Clément Bœsch wrote: > On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: >> On 4/25/19, Reto Kromer wrote: >> > Paul B Mahol wrote: >> > >> >>Found 65x65x65 3D LUT in wild >> > >> > FYI: 128x128x128 3D LUTs do als

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: ignore extra '\r' at line endings

2019-04-27 Thread Paul B Mahol
On 4/27/19, Clément Bœsch wrote: > On Thu, Apr 25, 2019 at 11:22:47PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavformat/microdvddec.c | 2 ++ >> libavformat/subtitles.c | 2 +- >> libavformat/subtitles.h | 2 +- >> 3 file

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-27 Thread Paul B Mahol
On 4/27/19, Clément Bœsch wrote: > On Sat, Apr 27, 2019 at 12:29:44PM +0200, Paul B Mahol wrote: >> On 4/27/19, Clément Bœsch wrote: >> > On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: >> >> On 4/25/19, Reto Kromer wrote: >> >> > Paul

Re: [FFmpeg-devel] [PATCH] avcodec/pnm_parser: Remember the length already scanned for ascii images

2019-04-27 Thread Paul B Mahol
On 4/27/19, Michael Niedermayer wrote: > Fixes: speed regression with xmap_samsung_gear_2560x1280.pgm > Found-by: Michael Koch > Signed-off-by: Michael Niedermayer > --- > libavcodec/pnm_parser.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > This code does not apply

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pnm_parser: Remember the size of the image and do not reparse the header

2019-04-27 Thread Paul B Mahol
On 4/24/19, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 60ms) > Fixes: > 14270/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAM_fuzzer-5734809634078720 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avcodec/pnm_parser: Remember the length already scanned for ascii images

2019-04-27 Thread Paul B Mahol
On 4/27/19, Michael Niedermayer wrote: > On Sat, Apr 27, 2019 at 02:58:38PM +0200, Michael Niedermayer wrote: >> Fixes: speed regression with xmap_samsung_gear_2560x1280.pgm >> Found-by: Michael Koch >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/pnm_parser.c | 15 ++- >>

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-28 Thread Paul B Mahol
On 4/28/19, Nicolas George wrote: > Paul B Mahol (12019-04-27): >> Considering that some filtergraphs needs 64GB of RAM I consider that >> non-issue. > > Why was this pushed without leaving Clément time to reply? He replied on IRC. ___

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngdec: Check nb_blocks

2019-04-28 Thread Paul B Mahol
On 4/28/19, Michael Niedermayer wrote: > Fixes: Timeout (23sec -> 0.5sec) > Fixes: > 14329/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5679252923482112 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Paul B Mahol
On 4/28/19, Gyan wrote: > > > On 28-04-2019 03:52 PM, Nicolas George wrote: >> Gyan (12019-04-26): >>> From 5ec154870d9c559037598b41736bf5b216a756e0 Mon Sep 17 00:00:00 2001 >>> From: Gyan Doshi >>> Date: Fri, 26 Apr 2019 18:31:33 +0530 >>> Subject: [PATCH] avformat/mux: skip parameter and pts c

[FFmpeg-devel] [PATCH] avfilter: add bilateral filter

2019-04-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 25 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_gblur.c | 257 ++- 4 files changed, 280 insertions(+), 4 deletions(-) diff --git a/doc/filters.texi b/doc

[FFmpeg-devel] [PATCH] avfilter/avf_showspectrum: add log scale for frequency plot

2019-04-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 26 libavfilter/avf_showspectrum.c | 239 - 2 files changed, 200 insertions(+), 65 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 14c33ecf90..7cc3937b40 100644 --- a/doc

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: use correct type for chl

2019-04-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_ebur128.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index f613d8def2..f25d5f096e 100644 --- a/libavfilter/f_ebur128.c +++ b/libavfilter/f_ebur128.c @@ -420,7 +420,7 @@ static

Re: [FFmpeg-devel] [PATCH] libavfilter/af_astats: fix msvc compile error

2019-04-29 Thread Paul B Mahol
On 4/29/19, Matthias Troffaes wrote: > MSVC requires an explicit cast from void * to void when applying the > ternary conditional operator to switch between methods that return > void. The attached patch fixes the problem. > > For information, log of failed build: > > https://ci.appveyor.com/proje

[FFmpeg-devel] [PATCH] avfilter/vf_tonemap: add slice threading

2019-04-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_tonemap.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c index efd4af5466..d1728c8513 100644 --- a/libavfilter/vf_tonemap.c +++ b

Re: [FFmpeg-devel] [PATCH] lavfi: add gblur_opencl filter

2019-04-30 Thread Paul B Mahol
On 4/30/19, Dylan Fernando wrote: > > Anyone have any feedback? If I'm not mistaken there is already one available. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH v3] avfilter/avf_showwaves: Add draw mode also to showwavespic filter

2019-04-30 Thread Paul B Mahol
On 4/30/19, Martin Vobruba wrote: >> See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29 >> --- >> doc/filters.texi| 14 ++ >> libavfilter/avf_showwaves.c | 3 +++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/doc/filters.texi b/doc/filters.texi >> index e9cbccc

Re: [FFmpeg-devel] [PATCH] avfilter/f_realtime: add option to scale speed

2019-04-30 Thread Paul B Mahol
On 12/25/18, Moritz Barsnick wrote: > Signed-off-by: Moritz Barsnick > --- > This adds two double precision divisions per frame, which seems acceptable. > > I'm not sure scaling the limit by the factor is the correct idea. It feels > right regarding the discontinuities, but not according to the

<    1   2   3   4   5   6   7   8   9   10   >