Hi all,
Sample content is available at:
http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml
Looking forward to the feedback.
Best,
-- Pierre
On Thu, Sep 23, 2021 at 10:01 AM wrote:
>
> From: Pierre-Anthony L
I have reordered the patches so that each patch individually compiles,
when applied in order.
Let me know if this does not work.
Best,
-- Pierre
On Thu, Sep 23, 2021 at 11:13 AM Pierre-Anthony Lemieux
wrote:
>
> Hi Timo,
>
> > Every commit individually has to compile and pa
Hi Timo,
> Every commit individually has to compile and pass fate.
Ok. This will reduce the number of patches.
Best,
-- Pierre
On Thu, Sep 23, 2021 at 11:07 AM Timo Rothenpieler
wrote:
>
> On 23/09/2021 19:00, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
>
; >> > Can you be more specific?
> >> >
> >> > The file header we used look consistent with the header of other
> >> > BSD-licensed files, like aacdec.c.
> >> >
> >> > Thanks,
> >> >
> >> > -- Pierre
>
On Tue, Oct 12, 2021 at 12:29 PM Marton Balint wrote:
>
>
>
> On Tue, 12 Oct 2021, Tomas Härdin wrote:
>
> > mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud:
> >> ---
> >> libavformat/mxf.h| 1 +
> >> libavformat/mxfdec.c | 276
> >> ++-
On Thu, Oct 7, 2021 at 1:24 PM Pierre-Anthony Lemieux wrote:
>
> On Thu, Oct 7, 2021 at 1:03 PM Lynne wrote:
> >
> > 6 Oct 2021, 02:45 by p...@sandflow.com:
> >
> > > On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote:
> > >
> > >>
> > >>
, 2021 at 11:46 PM Jean-Baptiste Kempf wrote:
>
> Sorry, but why does this need a public header?
>
> On Wed, 29 Sep 2021, at 22:47, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
Hi Lynne,
Can you be more specific?
The file header we used look consistent with the header of other
BSD-licensed files, like aacdec.c.
Thanks,
-- Pierre
On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote:
>
> 29 Sept 2021, 22:47 by p...@sandflow.com:
>
> > From: Pierre-
e aacdec.c.
> >
> > Thanks,
> >
> > -- Pierre
> >
> > On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote:
> >
> >>
> >> 29 Sept 2021, 22:47 by p...@sandflow.com:
> >>
> >> > From: Pierre-Anthony Lemieux
> >> &g
On Tue, Nov 30, 2021 at 10:36 AM Marton Balint wrote:
>
>
>
> On Mon, 29 Nov 2021, Pierre-Anthony Lemieux wrote:
>
> > On Mon, Nov 29, 2021 at 11:20 AM Marton Balint wrote:
> >>
> >>
> >>
> >> On Sun, 28 Nov 2021, Pierre-Anthony Lemieux
On Mon, Dec 6, 2021 at 2:16 AM Anton Khirnov wrote:
>
> Quoting Lynne (2021-12-05 11:13:17)
> > 5 Dec 2021, 02:33 by p...@sandflow.com:
> >
> > > Hi all,
> > >
> > > Quick ping re: libavformat/imf demuxer patch set.
> > >
> > > All outstanding feedback (thanks!) has been addressed as far as I
On Mon, Dec 6, 2021 at 8:02 AM Lynne wrote:
>
> 6 Dec 2021, 16:58 by p...@sandflow.com:
>
> > On Mon, Dec 6, 2021 at 2:16 AM Anton Khirnov wrote:
> >
> >>
> >> Quoting Lynne (2021-12-05 11:13:17)
> >> > 5 Dec 2021, 02:33 by p...@sandflow.com:
> >> >
> >> > > Hi all,
> >> > >
> >> > > Quick ping
Hi all,
Quick ping re: libavformat/imf demuxer patch set.
All outstanding feedback (thanks!) has been addressed as far as I know.
What are the next steps?
It would be good to make progress while it is fresh in peoples' minds.
Latest patchset at [1] and tracking PR at [2] (including memory
On Fri, Dec 17, 2021 at 1:46 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The IMF demuxer accepts as input an IM
On Fri, Dec 17, 2021 at 12:54 PM Lynne wrote:
>
> Dec 17, 2021, 3:25 PM by an...@khirnov.net:
>
> > Quoting Pierre-Anthony Lemieux (2021-12-15 21:41:25)
> >
> >> On Wed, Dec 15, 2021 at 12:20 PM Anton Khirnov wrote:
> >> >
> >> &g
On Sat, Jan 1, 2022 at 5:11 PM Marton Balint wrote:
>
>
>
> On Sat, 1 Jan 2022, Pierre-Anthony Lemieux wrote:
>
> > Minor suggestion below.
> >
> > In addition, will sample file(s) be added to FATE? Below are two examples:
> >
> > http://ffmpeg-
Minor suggestion below.
In addition, will sample file(s) be added to FATE? Below are two examples:
http://ffmpeg-imf-samples-public.s3.us-west-1.amazonaws.com/callout_51_l_r_c_lfe_ls_rs.mxf
http://ffmpeg-imf-samples-public.s3.us-west-1.amazonaws.com/callout_51_l_c_r_ls_rs_lfe.mxf
On Sat, Jan 1,
On Sat, Jan 1, 2022 at 11:32 AM Marton Balint wrote:
>
>
>
> On Wed, 22 Dec 2021, Pierre-Anthony Lemieux wrote:
>
> > On Wed, Dec 22, 2021 at 4:38 AM Tomas Härdin wrote:
> >>
> >> tis 2021-12-21 klockan 21:24 +0100 skrev Marton Balint:
> >> >
On Sat, Jan 1, 2022 at 5:35 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > Minor suggestion below.
> >
> > In addition, will sample file(s) be added to FATE? Below are two examples:
> >
> > http://ffmpeg-imf-samples-public.s3.us-west-1.amazonaw
On Wed, Dec 22, 2021 at 4:38 AM Tomas Härdin wrote:
>
> tis 2021-12-21 klockan 21:24 +0100 skrev Marton Balint:
> >
> >
> > On Tue, 21 Dec 2021, Tomas Härdin wrote:
> >
> > > tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD:
> > > > Le ven. 17 déc. 2021 à 19:12, Marton Balint a
> > >
On Fri, Dec 24, 2021 at 4:08 PM Zane van Iperen wrote:
>
> Looks mostly alright, just some style nits. Once they're fixed, lgtm.
>
> On Wednesday, 22 December 2021 4:42:08 AM AEST p...@sandflow.com wrote:
>
> > +
> > +int ff_imf_xml_read_uuid(xmlNodePtr element, uint8_t uuid[16])
> > +{
> > +
On Sun, Jan 2, 2022 at 2:48 PM James Almer wrote:
>
>
>
> On 1/2/2022 3:54 PM, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The `fate-imf-cpl-with-rep
On Sun, Jan 2, 2022 at 3:42 PM James Almer wrote:
>
>
>
> On 1/2/2022 8:38 PM, Pierre-Anthony Lemieux wrote:
> > On Sun, Jan 2, 2022 at 3:28 PM James Almer wrote:
> >>
> >>
> >>
> >> On 1/2/2022 8:16 PM, p...@sandflow.com wrote:
>
On Sun, Jan 2, 2022 at 3:28 PM James Almer wrote:
>
>
>
> On 1/2/2022 8:16 PM, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The `fate-imf-cpl-with
On Tue, Jan 4, 2022 at 5:39 PM Zane van Iperen wrote:
>
>
>
> On 4/1/22 01:59, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > Found through manual fuzz
On Tue, Jan 4, 2022 at 4:58 PM Zane van Iperen wrote:
>
>
>
> On 4/1/22 16:10, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> > libavformat/imf_cpl.c | 51 +++---
On Mon, Dec 20, 2021 at 12:29 PM Lynne wrote:
>
> 20 Dec 2021, 20:48 by p...@sandflow.com:
>
> > On Mon, Dec 20, 2021 at 11:19 AM Lynne wrote:
> >
> >>
> >> 20 Dec 2021, 19:57 by p...@sandflow.com:
> >>
> >> > From: Pierre-Anthony
On Sun, Jan 2, 2022 at 11:13 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Sat, Jan 1, 2022 at 5:35 PM Andreas Rheinhardt
> > wrote:
> >>
> >> Pierre-Anthony Lemieux:
> >>> Minor suggestion below.
> >>>
> >&
> And then generate the appropriate reference file.
Done at v13 of the patchset.
I have also (separately) requested to samples-requ...@ffmpeg.org the
addition of an IMF sample -- in addition to the tests at
libavformat/tests/imf.c.
On Mon, Dec 20, 2021 at 7:06 AM Anton Khirnov wrote:
>
> As
On Mon, Dec 20, 2021 at 11:19 AM Lynne wrote:
>
> 20 Dec 2021, 19:57 by p...@sandflow.com:
>
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The IMF demuxer accepts as input an
Hi,
Just a quick ping on the v3 of the avformat/imf demuxer patch set.
Any major issues/blockers?
Best,
-- Pierre
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
On Sun, Nov 28, 2021 at 4:56 PM Marton Balint wrote:
>
>
>
> On Thu, 25 Nov 2021, Marc-Antoine Arnaud wrote:
>
> > ---
> > doc/demuxers.texi | 10 ++
> > libavformat/mxf.h | 1 +
> > libavformat/mxfdec.c | 293 +-
> > libavformat/version.h | 2 +-
Hi Paul,
Thanks for the review.
Are you saying that, in the event that any memory allocation fails
within the demuxer, the demuxer is responsible for cleaning-up already
previously allocated memory so that other parts of the pipeline can
continue operating? In other words, ffmpeg is not expected
On Mon, Nov 22, 2021 at 12:37 PM Paul B Mahol wrote:
>
>
>
> On Mon, Nov 22, 2021 at 5:35 PM Pierre-Anthony Lemieux
> wrote:
>>
>> Hi Paul,
>>
>> Thanks for the review.
>>
>> Are you saying that, in the event that any memory allocation fail
On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote:
>
>
>
> On Fri, Oct 8, 2021 at 1:42 AM wrote:
>>
>> From: Pierre-Anthony Lemieux
>>
>> Signed-off-by: Pierre-Anthony Lemieux
>> ---
>>
>> Notes:
>> I
On Wed, Oct 27, 2021 at 12:57 AM Paul B Mahol wrote:
>
>
>
> On Wed, Oct 20, 2021 at 4:55 PM wrote:
>>
>> From: Pierre-Anthony Lemieux
>>
>> Signed-off-by: Pierre-Anthony Lemieux
>> ---
>>
>> Notes:
>> Implements IMF Compositio
The comments have been addressed in v3 of the patch.
On Sun, Oct 31, 2021 at 1:22 PM Pierre-Anthony Lemieux
wrote:
>
> On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote:
> >
> > On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote:
> > >>> The functio
On Thu, Oct 28, 2021 at 12:56 AM Paul B Mahol wrote:
>
>
>
> On Thu, Oct 28, 2021 at 6:34 AM Pierre-Anthony Lemieux
> wrote:
>>
>> On Wed, Oct 27, 2021 at 12:57 AM Paul B Mahol wrote:
>> >
>> >
>> >
>> > On Wed, Oct 20, 2
On Thu, Oct 28, 2021 at 12:58 AM Paul B Mahol wrote:
>
>
>
> On Thu, Oct 28, 2021 at 6:32 AM Pierre-Anthony Lemieux
> wrote:
>>
>> On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote:
>> >
>> >
>> >
>> > On Fri, Oct 8, 2
On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote:
>
> On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote:
> >>> The functions are not static and are defined in imf_internal.h. They
> >>> are used in both libavformat/imfdec.c and the tests at
>
On Sun, Oct 31, 2021 at 11:35 AM Paul B Mahol wrote:
>
>
>
> On Sun, Oct 31, 2021 at 5:48 PM Pierre-Anthony Lemieux
> wrote:
>>
>> On Thu, Oct 28, 2021 at 12:56 AM Paul B Mahol wrote:
>> >
>> >
>> >
>> > On Thu, Oct 28, 2021 at
On Mon, Dec 6, 2021 at 12:55 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The IMF demuxer accepts as input an IM
On Mon, Dec 6, 2021 at 9:45 AM Lynne wrote:
>
> 6 Dec 2021, 04:18 by p...@sandflow.com:
>
> > From: Pierre-Anthony Lemieux
> > +
> > +/**
>
> Please don't NIH-parse UUIDs. They're more complicated
> than this. Use libuuid, it's stable, bug-free and universa
On Sun, Dec 12, 2021 at 7:58 PM Zane van Iperen wrote:
>
>
> On 9/12/21 13:55, p...@sandflow.com wrote:
>
> > +
> > +#define FF_UUID_FORMAT\
> > +"urn:uuid:%02hhx%02hhx%02hhx%02hhx-%02hhx%02hhx-" \
> > +
On Sun, Dec 5, 2021 at 2:13 AM Lynne wrote:
>
> 5 Dec 2021, 02:33 by p...@sandflow.com:
>
> > Hi all,
> >
> > Quick ping re: libavformat/imf demuxer patch set.
> >
> > All outstanding feedback (thanks!) has been addressed as far as I know.
> >
> > What are the next steps?
> >
> > It would be
On Tue, Dec 14, 2021 at 2:31 AM Anton Khirnov wrote:
>
> Quoting p...@sandflow.com (2021-12-13 06:43:35)
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The IMF demuxer ac
On Tue, Dec 14, 2021 at 2:33 AM Anton Khirnov wrote:
>
> Quoting p...@sandflow.com (2021-12-13 06:43:35)
> > +static int parse_assetmap(AVFormatContext *s, const char *url, AVIOContext
> > *in)
>
> in is always NULL, might as well make it a local variable
Addressed by v11 of the patchset.
>
>
On Wed, Dec 15, 2021 at 12:20 PM Anton Khirnov wrote:
>
> Quoting Pierre-Anthony Lemieux (2021-12-15 01:17:26)
> > >
> > > Now the question is whether a malicious attacker can craft those two
> > > files to get access to anything they shouldn't. I suppose at the
Hi all,
I have posted v9 of the IMF demuxer patch. The small changes are the
result of my running the demuxer through valgrind and failing
individual heap allocation calls.
Outstanding issues (I know of):
- it was suggested that libuuid be used to parse UUIDs in the IMF CPL.
As detailed at [1],
>
> Now the question is whether a malicious attacker can craft those two
> files to get access to anything they shouldn't. I suppose at the very
> least the attacker can get information that the user opened the file (by
> adding an asset on an attacker's server) but that will be a danger with
>
Ok. Thanks. Submitted V2 of the patch at:
http://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282414.html
On Sun, Jul 18, 2021 at 12:07 AM Marton Balint wrote:
>
>
>
> On Sat, 17 Jul 2021, Pierre-Anthony Lemieux wrote:
>
> > You mean something like this?
>
&
1-07-11 klockan 09:47 -0700 skrev p...@sandflow.com:
> >> From: Pierre-Anthony Lemieux
> >>
> >> Signed-off-by: Pierre-Anthony Lemieux
> >> ---
> >>
> >> Notes:
> >> For JPEG 2000 essence, the MXF input format module currently uses
gt; > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> >For JPEG 2000 essence, the MXF input format module currently uses the
> > value of byte 14 of the essence container UL to determine
> >
On Fri, Jan 7, 2022 at 12:15 AM Paul B Mahol wrote:
>
> On Fri, Dec 31, 2021 at 2:25 PM Zane van Iperen
> wrote:
>
> >
> >
> > On 31/12/21 21:19, Paul B Mahol wrote:
> > > ++i instead of i++
> > >
> >
> > You're right, I missed that. I'll submit a patch.
> >
>
> Still not posted/fixed.
>
> This
On Sat, Jan 8, 2022 at 10:49 AM Marton Balint wrote:
>
>
>
> On Sat, 1 Jan 2022, Marton Balint wrote:
>
> > Signed-off-by: Marton Balint
> > ---
> > libavformat/imfdec.c | 15 ---
> > 1 file changed, 4 insertions(+), 11 deletions(-)
> >
> > diff --git a/libavformat/imfdec.c
t; > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavformat/concatdec.c | 19 +--
> > 1 file changed, 5 insertions(+), 14 deletions(-)
>
> LGTM.
>
> Regards,
>
> --
> Nicolas George
__
On Fri, Mar 4, 2022 at 12:13 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Refactors a function used by avformat/concat and avformat/imf.
> >
> > ---
> > libavutil/mathematics.c | 10 ++
On Fri, Mar 4, 2022 at 12:40 PM Pierre-Anthony Lemieux
wrote:
>
> On Fri, Mar 4, 2022 at 12:13 PM Andreas Rheinhardt
> wrote:
> >
> > p...@sandflow.com:
> > > From: Pierre-Anthony Lemieux
> > >
> > > Refactors a f
On Wed, Feb 16, 2022 at 3:45 AM Zane van Iperen wrote:
>
>
>
>
> On 3/2/22 14:07, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavformat/imfdec.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
Hi Michael,
What is the typical size of a successful GSOC project? Any good
example(s) from the past?
Best,
-- Pierre
On Mon, Feb 21, 2022 at 4:12 AM Michael Niedermayer
wrote:
>
> Hi all
>
> We have 0 project ideas on our gsoc 2022 page
> well we have 2 now as i copied my two from last year
Hi all,
Quick ping on patchset #5873 [1], which address trac #9611 and #9623
[2-3]. These two issues are major IMHO.
The single comment filed against the initial version of the patchset
has been addressed and the patchset has been revised to update the
FATE reference files.
Any further
On Tue, Feb 22, 2022 at 6:21 AM James Almer wrote:
>
>
>
> On 2/22/2022 10:01 AM, Zane van Iperen wrote:
> > Loosely based on libuuid
> >
> > Co-authored-by: Pierre-Anthony Lemieux
> > Signed-off-by: Pierre-Anthony Lemieux
> > Signed-off-by: Zane va
On Mon, Jan 31, 2022 at 8:51 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Sun, Jan 30, 2022 at 2:16 PM Andreas Rheinhardt
> > wrote:
> >>
> >> p...@sandflow.com:
> >>> From: Pierre-Anthony Lemieux
> >>>
> >>
Works for me.
There are several other IMF-related patches waiting, some of them
rather trivial. Should they be combined and/or merged together?
On Mon, Jan 31, 2022 at 3:13 PM Marton Balint wrote:
>
> Similar to the earlier patch applied to imfdec.
>
> Signed-off-by: Marton Balint
> ---
>
On Fri, Feb 4, 2022 at 6:03 PM Zane van Iperen wrote:
>
>
>
>
> On 7/1/22 13:55, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> > libavformat/tests/.gitignore | 1 +
> >
On Thu, Feb 3, 2022 at 11:58 PM Paul B Mahol wrote:
>
> Never apply this.
I am not a maintainer and so cannot apply the patch.
There is another minor patch that has also been outstanding for some time now:
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5700
> Very sorry state of
On Sun, Jan 30, 2022 at 2:16 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > The IMF demuxer does not set the DTS and PTS of packets accurately in all
> > scenarios. Moreover, audio packets are not trimmed whe
On Sun, Feb 6, 2022 at 11:52 AM Paul B Mahol wrote:
>
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi| 28 +++
> libavfilter/Makefile| 1 +
> libavfilter/af_dialoguenhance.c | 407
> libavfilter/allfilters.c| 1 +
>
Just a ping now that 5.0 has been released.
-- Pierre
On Fri, Jan 7, 2022 at 3:10 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Signed-off-by: Pierre-Anthony Lemieux
> ---
>
> Notes:
> The `fate-imf-cpl-with-repeat` target requires following files (<10
Hi all,
It was recently suggested that UUID functionality in the codebase
could be refactored into a single library.
Below is short explainer.
I would appreciate your review/feedback before I/we start writing code.
Best,
-- Pierre
# Common UUID library
## Why
In the course of the IMF
On Mon, Jan 3, 2022 at 12:57 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > Signed-off-by: Pierre-Anthony Lemieux
> > ---
> >
> > Notes:
> > The `fate-imf-cpl-with-repeat` target requires f
On Wed, Sep 13, 2023 at 2:35 AM Tomas Härdin wrote:
>
> ons 2023-09-06 klockan 16:16 -0300 skrev James Almer:
> > On 9/6/2023 2:53 PM, Tomas Härdin wrote:
> > > ons 2023-09-06 klockan 11:38 -0300 skrev James Almer:
> > > > Signed-off-by: James Almer
> > > > ---
> > > > This is an initial proof
FYI. This is the qualification task for the GSOC project at [1].
[1]
https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2022#AddsupportforPart15totheJPEG2000decoder
On Tue, Apr 19, 2022 at 1:17 AM caleb wrote:
>
> ---
> This patch adds support for detecting Part 15 codeblocks to JPEG2000
>
On Wed, May 11, 2022 at 8:02 AM Zane van Iperen wrote:
>
>
>
> On 10/5/22 23:18, Andreas Rheinhardt wrote:
>
> >> +int av_uuid_parse_range(const char *in_start, const char *in_end, AVUUID
> >> uu)
> >> +{
> >> +int i;
> >> +const char *cp;
> >> +char buf[3];
> >> +
> >> +if
On Wed, May 11, 2022 at 8:03 AM Zane van Iperen wrote:
>
>
>
> On 11/5/22 21:53, Anton Khirnov wrote:
> > Quoting Zane van Iperen (2022-04-24 12:14:03)
> >> +void av_uuid_nil_set(AVUUID uu)
> > ^^^
> > sounds weird
> >
> > av_uuid_zero()?
> > av_uuid_reset()?
> >
>
> Good
> > 3 files changed, 291 insertions(+)
> > create mode 100644 libavutil/uuid.c
> > create mode 100644 libavutil/uuid.h
> >
> > diff --git a/libavutil/uuid.c b/libavutil/uuid.c
> > new file mode 100644
> > index 00..8943212f3
On Tue, May 31, 2022 at 12:10 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavfilter/vf_showinfo.c | 17 +
> > 1 file changed, 5 insertions(+), 12 deletions(-)
> >
> > diff
On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does
> > not
> > currently preserve stream information such as langu
On Sun, Jul 3, 2022 at 12:15 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
> > wrote:
> >>
> >> p...@sandflow.com:
> >>> From: Pierre-Anthony Lemieux
> >>>
> &
On Sun, Jul 3, 2022 at 2:13 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Sun, Jul 3, 2022 at 12:15 PM Andreas Rheinhardt
> > wrote:
> >>
> >> Pierre-Anthony Lemieux:
> >>> On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhar
LGTM.
On Sun, Jul 24, 2022 at 9:43 PM Andreas Rheinhardt
wrote:
>
> It conflicts with the name of the test using the testtool
> in libavformat.mak.
>
> Fixes ticket #9841.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> Other naming suggestions welcome.
>
> tests/fate/imf.mak | 2 +-
> 1 file
On Fri, Jul 29, 2022 at 4:19 PM Tomas Härdin wrote:
>
> fre 2022-07-29 klockan 14:14 +0200 skrev Pierre-Anthony Lemieux:
> > On Fri, Jul 29, 2022 at 6:15 AM Tomas Härdin
> > wrote:
> > >
> > > fre 2022-07-29 klockan 01:18 +0200 skrev Michael Niedermayer:
&
On Fri, Jul 29, 2022 at 6:15 AM Tomas Härdin wrote:
>
> fre 2022-07-29 klockan 01:18 +0200 skrev Michael Niedermayer:
> > On Tue, Jul 19, 2022 at 03:48:59PM +0200, Tomas Härdin wrote:
> > > mån 2022-07-11 klockan 23:44 +0200 skrev Michael Niedermayer:
> > > >
> > > > +{ {
> > > >
On Tue, Jul 26, 2022 at 8:17 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > As discussed at
> > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298491.html.
> > Note that ff_stream_params_copy()
On Sat, Apr 30, 2022 at 10:31 AM Mark Thompson wrote:
>
> On 24/04/2022 11:14, Zane van Iperen wrote:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > libavcodec/cbs_sei.h | 3 ++-
> > libavcodec/vaapi_encode_h264.c | 8
> > 2 f
On Sat, Apr 30, 2022 at 12:26 PM Mark Thompson wrote:
>
> On 30/04/2022 18:53, Pierre-Anthony Lemieux wrote:
> > On Sat, Apr 30, 2022 at 10:31 AM Mark Thompson wrote:
> >>
> >> On 24/04/2022 11:14, Zane van Iperen wrote:
> >>> From: Pierre-Anthony Le
LGTM
On Thu, May 5, 2022 at 11:56 PM caleb wrote:
>
> ---
> libavcodec/jpeg2000.h| 2 ++
> libavcodec/jpeg2000dec.c | 4
> 2 files changed, 6 insertions(+)
>
> diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h
> index d06313425e..e5ecb4cbf9 100644
> --- a/libavcodec/jpeg2000.h
Hi Caleb,
There is a space missing in the commit message before "fast-fail".
Few minor comments below.
Looks good otherwise -- it works as expected on an MXF file that
contains JPEG 2000 Part 15 code-blocks.
Looking forward to the full implementation!
Best,
-- Pierre
On Tue, Apr 19, 2022 at
On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
> > wrote:
> >>
> >> Steven Liu:
> >>> fix CID: 1512414
> >>> And return AVERROR_INVALIDDAT
On Fri, Aug 26, 2022 at 1:22 AM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
> > wrote:
> >>
> >> Improves the test; also should fix Coverity issue #1512408.
> >>
> >> Signed-
On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt
wrote:
>
> Steven Liu:
> > fix CID: 1512414
> > And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp
> > incorrect in imf_read_packet;
> >
> > Signed-off-by: Steven Liu
> > ---
> > libavformat/imfdec.c | 7 +--
> > 1
On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > tests/fate/mxf.mak | 4 ++
> > tests/ref/fate/mxf-probe-j2k | 78
> > 2 f
On Tue, Sep 6, 2022 at 2:33 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt
> > wrote:
> >>
> >> p...@sandflow.com:
> >>> From: Pierre-Anthony Lemieux
> >>>
> >>&g
Ping.
This fixes Coverity issue #1512406.
On Thu, Aug 25, 2022 at 8:22 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> Fixes Coverity issue #1512406
>
> ---
> libavformat/imfdec.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/liba
On Sat, Sep 3, 2022 at 11:26 AM Tomas Härdin wrote:
>
> sön 2022-08-28 klockan 08:31 -0700 skrev p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > The MXF demuxer does not currently set AVStream::avg_frame_rate and
> > ::r_frame_rate
> > when J2K e
Just a quick ping.
Looking forward to feedback.
This patchset is intended to address https://trac.ffmpeg.org/ticket/9842.
On Mon, Aug 22, 2022 at 10:11 PM wrote:
>
> From: Pierre-Anthony Lemieux
>
> The IMF CPL contains an optional timecode start address. This patch reads
On Sat, Aug 27, 2022 at 5:25 AM Steven Liu wrote:
>
> Pierre-Anthony Lemieux 于2022年8月27日周六 00:06写道：
> >
> > On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt
> > wrote:
> > >
> > > Pierre-Anthony Lemieux:
> > > > On Fri, Aug
LGTM
On Thu, Aug 25, 2022 at 2:01 PM Andreas Rheinhardt
wrote:
>
> Fixes Coverity issue #1512407.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/imf_cpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index
Since we are protecting against the algorithm within
get_next_track_with_minimum_timestamp() return NULL, should this patch
also include immediately returning from imf_read_packet() if
get_next_track_with_minimum_timestamp() returns NULL?
On Thu, Aug 25, 2022 at 7:53 PM Steven Liu wrote:
>
> fix
On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
wrote:
>
> Improves the test; also should fix Coverity issue #1512408.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/tests/imf.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git
1 - 100 of 165 matches
Mail list logo
