Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 13:25:23 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > > --- > > doc/muxers.texi | 30 ++ > > 1 file changed, 30 insertions(+) > > [...] > I do not think that this muxer should be publically documente

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Use ff_tget_long() where appropriate

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 15:49:45 +0100, Andreas Rheinhardt wrote: > No need to use the generic ff_tget() when we know the type. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) LGTM,

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/sccdec: remove unused bprint.h include

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:05 -0500, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/sccdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c > index 5f2f95d80e..f6d5f29a0a 100644 > --- a/libavformat/sccdec.c > +++ b/libavform

Re: [FFmpeg-devel] [PATCH v3 4/6] avcodec/rcwtenc: canonize name and refresh documentation

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:03 -0500, Marth64 wrote: > The formal title of the muxer according to the specification > is "RCWT (Raw Captions With Time)", so canonize this > in the long name of the codec and docs. > > In the documentation section, point #2 was wrong: ccextractor > extracts the

Re: [FFmpeg-devel] [PATCH v3 3/6] avcodec/ccaption_dec: ignore leading non-breaking spaces

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote: > In Closed Captions (US), the non-breaking space (0xA0) can be used to > align text horizontally from the left when used as a leading character. > However, CC decoder does not ignore it as a leading character > like it does an ordinary spac

Re: [FFmpeg-devel] [PATCH v3 2/6] avcodec/ccaption_dec: don't print multiple \an and \pos tags

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:01 -0500, Marth64 wrote: > Closed Captions decoder prints multiple \pos ASS tags per cue, > and preceding the \pos tag is a fixed \an7 that fixes rendering > position from the top left corner and enforces justification. > > Printing multiple \an and \pos tags in th

Re: [FFmpeg-devel] [PATCH v3 1/6] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:00 -0500, Marth64 wrote: > In MPEG-2 user data, there can be different types of Closed Captions > formats embedded (A53, SCTE-20, or DVD). The current behavior of the > CC extraction code in the MPEG-2 decoder is to not be aware of > multiple formats if multiple exi

[FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0aaef2b520..ccbb741992 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1556,6 +1556,36 @@ ffmpeg -re -i ... -c:v libx264 -c:a aac -f fifo -fifo_fo

[FFmpeg-devel] [PATCH 2/3] lavf/fifo_test: use FifoTest in place of Failing

2024-03-12 Thread Stefano Sabatini
Use a more consistent and sensible prefix for the muxer structs and functions. --- libavformat/fifo_test.c | 45 - 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c index 84b762db5f..903f4bc34b

[FFmpeg-devel] [PATCH 1/3] lavf/fifo_test: sort options by name

2024-03-12 Thread Stefano Sabatini
--- libavformat/fifo_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c index 3861c4aee4..84b762db5f 100644 --- a/libavformat/fifo_test.c +++ b/libavformat/fifo_test.c @@ -122,12 +122,12 @@ static void failing_deinit(AVF

[FFmpeg-devel] [PATCH] doc/muxers: add ffmetadata

2024-03-12 Thread Stefano Sabatini
--- doc/metadata.texi | 1 + doc/muxers.texi | 16 2 files changed, 17 insertions(+) diff --git a/doc/metadata.texi b/doc/metadata.texi index be91059a98..e081da7735 100644 --- a/doc/metadata.texi +++ b/doc/metadata.texi @@ -1,3 +1,4 @@ +@anchor{metadata} @chapter Metadata @c

Re: [FFmpeg-devel] [PATCH 1/3] lavf/fifo: sort options by name

2024-03-12 Thread Stefano Sabatini
On date Monday 2024-03-11 11:31:15 -0500, Marth64 wrote: > LGTM. Options before are the same as after change. Applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers/fifo: review documentation

2024-03-12 Thread Stefano Sabatini
On date Monday 2024-03-11 11:32:29 -0500, Marth64 wrote: > LGTM from readability perspective. Nice catch on the command missing slash. Thanks, applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-12 Thread Stefano Sabatini
On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote: > On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing List wrote: > > Great, thank you very much! > > I'm attaching the (hopefully) final version of the patch. > > > > > MD studio w

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dvdvideodec: add menu demuxing support

2024-03-12 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:27:52 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 43 +- > libavformat/dvdvideodec.c | 314 -- > 2 files changed, 339 insertions(+), 18 deletions(-) Will push soon with the other patch,

Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_decode.c: remove unused config.h header file

2024-03-12 Thread Stefano Sabatini
On date Monday 2024-03-11 13:41:43 +, hung kuishing wrote: > > 在 2024年3月10日,21:55,Stefano Sabatini 写道: > > > > On date Saturday 2024-03-09 02:17:19 +, hung kuishing wrote: > >> > >> Signed-off-by: clarkh > >> mailto:hungkuish...@outlook.

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: honor transparency of leading non-breaking space

2024-03-11 Thread Stefano Sabatini
On date Sunday 2024-03-10 19:44:11 -0500, Marth64 wrote: > In Closed Captions (US), the non-breaking space (0xA0) can be used to align > text horizontally from the left by using it as a leading character. > However, CC decoder does not ignore it as a leading character like it does > an ordinary spa

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: don't print multiple \pos tags per cue

2024-03-11 Thread Stefano Sabatini
On date Sunday 2024-03-10 19:40:47 -0500, Marth64 wrote: > Currently, Closed Captions decoder prints multiple \pos ASS tags per line, > per cue. This is invalid behavior, because only the first \pos tag in a cue > is honored by ASS anyway. Don't write multiple \pos tags. > > Signed-off-by: Marth64

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-11 Thread Stefano Sabatini
On date Sunday 2024-03-10 19:18:56 -0500, Marth64 wrote: > In MPEG-2 user data, there can be different types of Closed Captions > formats embedded (A53, SCTE-20, or DVD). The current behavior of the > CC extraction code in the MPEG-2 decoder is to not be aware of > multiple formats if multiple exis

[FFmpeg-devel] [PATCH 3/3] doc/muxers/fifo: review documentation

2024-03-11 Thread Stefano Sabatini
--- doc/muxers.texi | 138 ++-- 1 file changed, 74 insertions(+), 64 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 2104cc4a95..34de187f5e 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1421,104 +1421,114 @@ ffmpeg -i INPUT -s

[FFmpeg-devel] [PATCH 2/3] lavf/fifo: fix check on last_recovery_ts

2024-03-11 Thread Stefano Sabatini
Correct check on PTS nullness. --- libavformat/fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index a3d41ba0d3..fcd80f217a 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -345,7 +345,7 @@ static int fifo_thread_attempt

[FFmpeg-devel] [PATCH 1/3] lavf/fifo: sort options by name

2024-03-11 Thread Stefano Sabatini
--- libavformat/fifo.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 074a46485c..a3d41ba0d3 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -663,36 +663,36 @@ static void fifo_deinit(AVFo

[FFmpeg-devel] [PATCH 3/3] doc/muxers/fifo: review documentation

2024-03-11 Thread Stefano Sabatini
--- doc/muxers.texi | 138 ++-- 1 file changed, 74 insertions(+), 64 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 2104cc4a95..34de187f5e 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1421,104 +1421,114 @@ ffmpeg -i INPUT -s

[FFmpeg-devel] [PATCH 1/3] lavf/fifo: sort options by name

2024-03-11 Thread Stefano Sabatini
--- libavformat/fifo.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 074a46485c..a3d41ba0d3 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -663,36 +663,36 @@ static void fifo_deinit(AVFo

[FFmpeg-devel] [PATCH 2/3] lavf/fifo: fix check on last_recovery_ts

2024-03-11 Thread Stefano Sabatini
Correct check on PTS nullness. --- libavformat/fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index a3d41ba0d3..fcd80f217a 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@ -345,7 +345,7 @@ static int fifo_thread_attempt

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions

2024-03-11 Thread Stefano Sabatini
On date Sunday 2024-03-10 17:06:18 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > >> diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h > >> index e67c59abad..2dd21dea52 100644 > >> --- a/libavcodec/tiff.h > >> +++ b/libavcodec/tiff.h > >>

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters.texi: Document types used by filter_units

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 16:34:23 +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > doc/bitstream_filters.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 61539d2473..3351625225 100644

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 15:15:02 +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegdec.c | 1 - > libavcodec/tiff.c | 1 + > libavcodec/tiff.h | 3 --- > libavcodec/tiffenc.c | 3 +-- > 4 files changed, 2 insertions(+), 6 deletions(-) > > dif

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/tiff: Don't check before av_freep()

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 15:15:01 +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) LGTM, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 15:15:00 +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index 4c7460cf41..afa1289e27 100644 > --- a/libavco

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Fix handling of av_strdup() failures

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 15:12:16 +0100, Andreas Rheinhardt wrote: > For unknown geokey values, get_geokey_val() returns > "Unknown-%d" with val being used for %d. This string > is allocated and therefore all the known geokey values > (static strings) are strdup'ed. In case this fails > it is eith

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-10 Thread Stefano Sabatini
On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing List wrote: > Great, thank you very much! > I'm attaching the (hopefully) final version of the patch. > > MD studio was a piece of software created by a company called "EDL", > which in combination with alternative firmware for the So

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 19:56:49 -0600, Marth64 wrote: > Following up on this from December 2023. I simplified the content and > hopefully addressed the feedback. > > Signed-off-by: Marth64 > --- > doc/bitstream_filters.texi | 15 +++ > 1 file changed, 15 insertions(+) > > diff

Re: [FFmpeg-devel] [PATCH v3] avformat/dvdvideodec: add menu demuxing support

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 13:17:23 -0600, Marth64 wrote: > Fixes compiler warning introduced in v2 due to incorrect printf format for > ssize_t. > > Apologies for the inconvenience. > > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 43 +- > libavformat/dvdvideodec.c | 314 +

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as dvdvideo demuxer, rcwt muxer maintainer

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:48:22 -0600, Marth64 wrote: > I am willing to maintain these into the future as needed. Thank you. > > Signed-off-by: Marth64 > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) Will apply (not sure if there is a more formal process to add a maintainer,

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/ccaption_dec: use consistent naming convention of Closed Captions

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:39:56 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavcodec/ccaption_dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index d03413265a..faf058ce97 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ccaption_dec: clarify log message when out-of-display columns are ignored

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:39:55 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavcodec/ccaption_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index 1550e4b253..d03413265a 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/dvdvideodec: add CLUT utilities and subtitle color support

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:27:51 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/Makefile | 2 +- > libavformat/dvdclut.c | 75 +++ > libavformat/dvdclut.h | 37 +++ > libavformat/dvdvideodec.c | 14

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/dvdvideodec: assign mono channel layout explicitly

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 12:27:50 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index b3cc32b864..ca85aa8d3d 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 17:20:49 +, ffmpeg-devel Mailing List wrote: > Thank you both for the suggestions. I've updated the code as requested, and I > apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an > oversight on my part. > I have also added the stream codec check, a

Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_decode.c: remove unused config.h header file

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 02:17:19 +, hung kuishing wrote: > > Signed-off-by: clarkh > mailto:hungkuish...@outlook.com>> > --- > doc/examples/qsv_decode.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/doc/examples/qsv_decode.c b/doc/examples/qsv_decode.c > index cc2662d5bd..901e

Re: [FFmpeg-devel] [PATCH v2 3/9] avformat/daudenc: force 2000 sample packet size with a bsf

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 01:53:27 +0100, Marton Balint wrote: > The samples I found all have 2000 sample packets, and by forcing the packet > size with a bsf we could automagically make muxing work for packets containing > more than 3640 samples. > > Signed-off-by: Marton Balint > --- > configu

Re: [FFmpeg-devel] [PATCH v2 2/9] avcodec/bsf/pcm_rechunk: add some more supported PCM formats

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 01:53:26 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) LGTM (although I didn't check that the *LAW values for 0 match), thanks. ___

Re: [FFmpeg-devel] [PATCH v2 1/9] avcodec/bsf/pcm_rechunk: reorder supported codec list

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 01:53:25 +0100, Marton Balint wrote: > Use lexical order. > > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) LGTM, thanks. ___

Re: [FFmpeg-devel] [PATCH 2/2] all: harmonise "{Decoding, Encoding, Audio, Video}:" comments

2024-03-09 Thread Stefano Sabatini
On date Thursday 2024-02-29 16:23:07 +, Andrew Sayers wrote: > There seems to be a convention for documenting meanings: > > /** > * Encoding: (meaning in encoding context) > * Decoding: (meaning in decoding context) > */ > > At a glance, these are confusingly similar to ow

Re: [FFmpeg-devel] [PATCH 1/2] avformat: harmonise "- {decoding, encoding, demuxing, muxing}: " comments

2024-03-09 Thread Stefano Sabatini
Hi, sorry for the slow reply. On date Thursday 2024-02-29 16:23:06 +, Andrew Sayers wrote: > There seems to be a convention for documenting ownership: I find "ownership" a bit confusing, probably it's better to talk about context usage. > > /** > * - encoding: (who sets this in en

Re: [FFmpeg-devel] [PATCH 2/2 v2] fftools/ffprobe: export IAMF Stream Group parameters

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 17:24:48 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 39 ++ > fftools/ffprobe.c | 160 +++- > tests/fate/iamf.mak | 12 +- > tests/fate/mov.ma

Re: [FFmpeg-devel] [PATCH 1/2 v3] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 17:24:47 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 50 + > fftools/ffprobe.c | 53 --- > tests/fate/mov.mak| 6 +-

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-09 Thread Stefano Sabatini
On date Friday 2024-03-08 13:50:59 +, ffmpeg-devel Mailing List wrote: > Thank you for your incredibly thorough and fast response. I've applied all > the corrections you requested. Please let me know if there's anything else > wrong with my patch, and thank you for your time. > > - asivery

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-07 Thread Stefano Sabatini
On date Thursday 2024-03-07 17:17:06 +0100, Stefano Sabatini wrote: > On date Wednesday 2024-03-06 21:49:51 -0300, James Almer wrote: > > Signed-off-by: James Almer > > --- > > fftools/ffprobe.c | 53 --- &g

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: export IAMF Stream Group parameters

2024-03-07 Thread Stefano Sabatini
On date Wednesday 2024-03-06 21:49:52 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 157 +++- > tests/fate/iamf.mak | 8 +- > tests/fate/mov.mak | 8 +- > tests/ref/fate/iam

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-07 Thread Stefano Sabatini
On date Wednesday 2024-03-06 21:49:51 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 53 --- > tests/fate/mov.mak| 6 +-- > .../ref/fate/mov-heic-demux-still-image-grid | 29 ++ >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support

2024-03-06 Thread Stefano Sabatini
On date Wednesday 2024-03-06 09:43:26 -0600, Marth64 wrote: > It is true that this is necessary when muxing to Matroska, but it is also > the case for MOV - the MOV muxer expects RGB prior to converting to YUV > again. So this would be needed for MOV also, despite the awkward conversion > circle. I

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: add missing linebreaks in error messages

2024-03-06 Thread Stefano Sabatini
On date Wednesday 2024-03-06 09:02:50 +0100, Anton Khirnov wrote: > --- > libavformat/matroskadec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 5d3d18a146..6d6a60c552 100644 > --- a/libavformat/matros

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dvdvideodec: add menu demuxing support

2024-03-06 Thread Stefano Sabatini
On date Wednesday 2024-03-06 01:19:12 -0600, Marth64 wrote: > Many DVDs have valuable assets in their menu structures, including background > video or music. Some discs also abuse the menu feature to include actual > feature footage that needs to change aspect ratio (in order to trick the DVD > pl

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dvdvideodec: assign mono channel layout explicitly

2024-03-06 Thread Stefano Sabatini
On date Wednesday 2024-03-06 01:19:13 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index 2c7ffdd148..6136060288 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support

2024-03-06 Thread Stefano Sabatini
On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote: > Since last iteration: removes unused variable in dvdclut.c > > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 5 +++ > libavformat/Makefile | 2 +- > libavformat/dvdclut.c | 75 ++

Re: [FFmpeg-devel] [PATCH 3/9] avformat/daudenc: force 2000 sample packet size with a bsf

2024-03-06 Thread Stefano Sabatini
On date Tuesday 2024-03-05 23:51:41 +0100, Marton Balint wrote: > The samples I found all have 2000 sample packets, and by forcing the packet > size with a bsf we could automagically make muxing work for packets containing > more than 3640 samples. > > Signed-off-by: Marton Balint > --- > config

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/bsf/pcm_rechunk: add some more supported PCM formats

2024-03-06 Thread Stefano Sabatini
On date Tuesday 2024-03-05 23:51:40 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/bsf/pcm_rechunk.c b/libavcodec/bsf/pcm_rechunk.c > index 9

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/bsf/pcm_rechunk: reorder supported codec list

2024-03-06 Thread Stefano Sabatini
On date Tuesday 2024-03-05 23:51:39 +0100, Marton Balint wrote: > Should be easier to add new codecs by using the same order as in > av_get_exact_bits_per_sample(). > > Signed-off-by: Marton Balint > --- > libavcodec/bsf/pcm_rechunk.c | 21 + > 1 file changed, 13 insertions(+

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-06 Thread Stefano Sabatini
On date Tuesday 2024-03-05 12:50:09 -0300, James Almer wrote: > On 3/5/2024 12:24 PM, Stefano Sabatini wrote: > > On date Tuesday 2024-03-05 12:14:53 -0300, James Almer wrote: > > > On 3/4/2024 9:00 PM, James Almer wrote: > > > > Signed-off-by: James Almer > >

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 12:14:53 -0300, James Almer wrote: > On 3/4/2024 9:00 PM, James Almer wrote: > > Signed-off-by: James Almer > > --- > > fftools/ffprobe.c | 41 - > > 1 file changed, 36 insertions(+), 5 deletions(-) [...] > I think I'll withdr

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:26 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 41 - > 1 file changed, 36 insertions(+), 5 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index ff05c4c1db..e73602

Re: [FFmpeg-devel] [PATCH 5/9 v2] fate/mov: print stream group information for iamf tests

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:25 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/mov.mak | 12 +- > tests/ref/fate/mov-mp4-iamf-5_1_4 | 318 + > tests/ref/fate/mov-mp4-iamf-7_1_4 | 362 > te

Re: [FFmpeg-devel] [PATCH 4/9 v2] fate/iamf: print stream group information

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:24 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/iamf.mak | 8 ++-- > tests/ref/fate/iamf-5_1_4 | 60 + > tests/ref/fate/iamf-7_1_4 | 68 + > tests/ref/

Re: [FFmpeg-devel] [PATCH 3/9 v3] fftools/ffprobe: add support for Stream Groups

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:23 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Changelog | 1 + > doc/ffprobe.xsd | 1 + > fftools/ffprobe.c | 147 -- > tests/ref/f

Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 15:50:23 +0100, Stefano Sabatini wrote: > On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: > > Signed-off-by: James Almer > > --- > > Missing version bump and APIChanges entry. > > > > libavformat/avformat.c | 10 ++

Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Missing version bump and APIChanges entry. > > libavformat/avformat.c | 10 ++ > libavformat/avformat.h | 5 + > 2 files changed, 15 insertions(+) > > diff --git a/libavformat/avformat

Re: [FFmpeg-devel] [PATCH 1/9 v2] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:21 -0300, James Almer wrote: > Components and pieces are side data specific fields and there's a variable > amount of them. > They also need to be identified in some form, so print a type too. > > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 32 +

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 11:38:20 -0300, James Almer wrote: > On 3/5/2024 11:34 AM, Stefano Sabatini wrote: > > On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: > > > Components and pieces are side data specific fields and there's a variable > > > amou

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: > Components and pieces are side data specific fields and there's a variable > amount of them. > They also need to be identified in some form, so print a type too. > > Signed-off-by: James Almer > --- > You can see the difference with >

Re: [FFmpeg-devel] [PATCH 0/3] Fix /// comments that should be ///

2024-03-04 Thread Stefano Sabatini
On date Monday 2024-03-04 17:49:27 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Wednesday 2024-02-28 17:09:38 +, Andrew Sayers wrote: > >> This is the first in a planned series of patch series aimed at > >> fixing documentation issues, especiall

Re: [FFmpeg-devel] [PATCH] all: fix "@param foo[in/out]" to "@param[in, out] foo"

2024-03-04 Thread Stefano Sabatini
On date Thursday 2024-02-29 15:58:58 +, Andrew Sayers wrote: > Fix a few invalid doxygen comments: > > /** > * @param[in,out] correctly_formatted > * @param incorrect1[in] - [in] must come immediately after @param > * @param incorrect2[in/out] - '/' must be ',' > */ >

Re: [FFmpeg-devel] [PATCH] all: fix "param"s that should be "@param"

2024-03-04 Thread Stefano Sabatini
On date Thursday 2024-02-29 15:51:33 +, Andrew Sayers wrote: > Actual command: sed -i -e "s/\(^ *\\* \)\(param[^a-z]\)/\1@\2/" $( git grep > -l "^ *\\* param[^a-z]" ) > > Signed-off-by: Andrew Sayers > --- > libavcodec/evrcdec.c | 10 +- > libavutil/bprint.h | 12 ++-- > 2

Re: [FFmpeg-devel] [PATCH 0/3] Fix /// comments that should be ///

2024-03-04 Thread Stefano Sabatini
On date Wednesday 2024-02-28 17:09:38 +, Andrew Sayers wrote: > This is the first in a planned series of patch series aimed at > fixing documentation issues, especially doxygen rendering. > I hope to post more as time allows in the coming days. > > The first patch reflects the output of a `sed

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: Inline print_error()

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 23:46:24 +0100, Andreas Rheinhardt wrote: > It is only used by ffprobe (once) and ffplay (twice); > inlining it avoids including it unnecessarily into ffmpeg. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 5 - > fftools/cmdutils.h | 5 - > 2

Re: [FFmpeg-devel] [PATCH] doc/demuxers: emphasize that DVD demuxer does not do decryption

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 14:49:36 -0600, Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/demuxers.texi b/doc/demuxers.texi > index 905828d852..f4bac8f3b3 100644 > --- a/doc/demuxers.texi > +++ b/doc/demuxers.texi

Re: [FFmpeg-devel] [PATCH 1/8 v2] fftools/ffprobe: add support for Stream Groups

2024-03-04 Thread Stefano Sabatini
On date Sunday 2024-03-03 15:09:19 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 1 + > fftools/ffprobe.c | 145 -- > tests/ref/fate/cavs-demux | 2 +- > tests/ref/

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix -pgc and -pg options

2024-03-04 Thread Stefano Sabatini
On date Monday 2024-03-04 10:24:42 +0100, Stefano Sabatini wrote: > On date Saturday 2024-03-02 20:29:13 -0600, Marth64 wrote: > > In merged DVD patch, -pgc and -pg options were broken. While these are > > rather advanced options, they are the only means to get content for >

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix -pgc and -pg options

2024-03-04 Thread Stefano Sabatini
On date Saturday 2024-03-02 20:29:13 -0600, Marth64 wrote: > In merged DVD patch, -pgc and -pg options were broken. While these are > rather advanced options, they are the only means to get content for > some strangely authored discs. > > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: print some basic Tile Grid Stream Group parameters

2024-03-04 Thread Stefano Sabatini
On date Saturday 2024-03-02 16:03:21 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index ec3c713849..6e66f4dfa8 100644 > --- a/fftools/ffprobe.c > +++ b/fft

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: add support for Stream Groups

2024-03-04 Thread Stefano Sabatini
On date Saturday 2024-03-02 16:03:20 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 186 ++ > 1 file changed, 157 insertions(+), 29 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index ea225f14

Re: [FFmpeg-devel] [PATCH 2/2] doc/ffprobe.xsd: add and

2024-03-03 Thread Stefano Sabatini
On date Wednesday 2024-02-28 14:23:50 +0100, Niklas Haas wrote: > From: Niklas Haas > > Originally introduced for dovi side data printing, but not properly > reflected in the xsd. > --- > doc/ffprobe.xsd | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/doc/ff

Re: [FFmpeg-devel] [PATCH 1/2] doc/ffprobe.xsd: add frameSideDatumType entry

2024-03-03 Thread Stefano Sabatini
On date Wednesday 2024-02-28 14:23:49 +0100, Niklas Haas wrote: > From: Niklas Haas > > Frame-level side data attributes are printed with the same key/value > structure as packet-level side data attributes, but this is not > reflected in the XSD. > --- > doc/ffprobe.xsd | 6 ++ > 1 file chan

Re: [FFmpeg-devel] [PATCH] web: Add spi.txt

2024-03-03 Thread Stefano Sabatini
On date Tuesday 2024-02-27 20:01:26 +0100, Michael Niedermayer wrote: > This explains how to request refunds and what can be funded by SPI > > Co-Author: Stefano Sabatini > --- > Makefile | 2 +- > src/spi| 98 ++

Re: [FFmpeg-devel] [PATCH 2/2] avutil/opt: add an unsigned option type

2024-03-03 Thread Stefano Sabatini
On date Tuesday 2024-02-27 10:59:47 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/opt.c | 20 > libavutil/opt.h | 1 + > libavutil/tests/opt.c | 9 + > tests/ref/fate/opt| 32 ++-- > 4 files chan

Re: [FFmpeg-devel] [PATCH 1/2] avutil/tests/opt: test negative values for INT and INT64 types

2024-03-03 Thread Stefano Sabatini
On date Tuesday 2024-02-27 10:59:46 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/tests/opt.c | 11 +-- > tests/ref/fate/opt| 35 ++- > 2 files changed, 39 insertions(+), 7 deletions(-) > > diff --git a/libavutil/tests/opt.c

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: add AVFilmGrainParams printing

2024-03-03 Thread Stefano Sabatini
On date Tuesday 2024-02-27 14:43:13 +0100, Niklas Haas wrote: > From: Niklas Haas > > So we can add a FATE test for this. > --- > fftools/ffprobe.c | 118 ++ > 1 file changed, 118 insertions(+) Looks good to me, probably you can add an entry to the Ch

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_showinfo: add AVFilmGrainAOMParams support

2024-03-03 Thread Stefano Sabatini
On date Tuesday 2024-02-27 14:43:12 +0100, Niklas Haas wrote: > From: Niklas Haas > > For my own testing purposes. You can drop "my own". > --- > libavfilter/vf_showinfo.c | 42 +-- > 1 file changed, 40 insertions(+), 2 deletions(-) > > diff --git a/libavf

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM 2024

2024-02-23 Thread Stefano Sabatini
Il ven 23 feb 2024, 11:00 J. Dekker ha scritto: > Hi, > > I attended FOSDEM for ffmpeg and would like to request travel > reimbursement. > > Flight | 162,46 EUR > === > Total | 162,46 EUR > Looks good on my side, but keep in mind you can also ask accomodation expenses refund if you

Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread

2024-02-12 Thread Stefano Sabatini
On date Sunday 2024-02-11 12:09:16 -0600, Marth64 wrote: > No critical changes since v12. > - Removes unused context variable > - Removes unnecessary if statement > - Whitespace cleanup > - Rebase with master > > Signed-off-by: Marth64 > --- > Changelog |2 + > configure

Re: [FFmpeg-devel] [PATCH v7 1/2] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-06 Thread Stefano Sabatini
On date Sunday 2024-02-04 23:48:25 -0600, Marth64 wrote: > Sorry for the quick follow-up to v6, I wanted to get this update out now > hopefully > before v6 is actually reviewed. v7 fixes a few documentation typos, options > descriptions, > and log messages: nothing major. I also flattened this ou

Re: [FFmpeg-devel] [PATCH v2] doc/formats: clarify meaning of igndts as per definition in avformat.h

2024-02-06 Thread Stefano Sabatini
On date Monday 2024-02-05 01:27:07 +0100, Stefano Sabatini wrote: > On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > > This updates the documentation to be more clear about igndts, > > as per feedback in December variant of this patch (thank you) > > >

Re: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Add durationprobesize AVOption

2024-02-06 Thread Stefano Sabatini
On date Tuesday 2024-02-06 11:52:09 +0100, Nicolas Gaullier wrote: > Yet another probesize used to get the last pts (and thus the duration) > of mpegts/ps files. It is aimed at users interested in better durations > probing > for itself, or because using avformat_find_stream_info indirectly and >

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM '24 Expenses

2024-02-06 Thread Stefano Sabatini
On date Tuesday 2024-02-06 17:36:40 +, Frank Plowman wrote: > Hello, > > I am requesting reimbursement for the following expenses made attending > FOSDEM 2024, where I delivered a talk about the FFmpeg VVC decoder and > met with FFmpeg developers. > > Expense | Amount (GBP)

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM'24 Travel

2024-02-06 Thread Stefano Sabatini
On date Tuesday 2024-02-06 14:35:31 +0100, Niklas Haas wrote: > Hi, > > Due to unforeseen circumstances (DB cancelling my train), I had to take > an Uber to the train station to just barely get there in time for the > alternative connection. > > 248,40 EUR: ICE Ulm <-> Bruxelle-Midi > 18.16 EUR:

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: reformat options table indentation and descriptions

2024-02-05 Thread Stefano Sabatini
On date Monday 2024-02-05 08:32:04 -0600, Marth64 wrote: > Clear and consistent formatting enhances code comprehension and reduces the > likelihood of misinterpretation or errors. As is now, it’s challenging to > read. But I digress +1 > > I do not really see the point of this. It will just inter

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Stefano Sabatini
On date Monday 2024-02-05 21:55:04 +0100, Niklas Haas wrote: > On Mon, 05 Feb 2024 21:31:45 +0100 Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-02-05 21:27:27) > > > please wait a bit with applying this so we understand better what it > > > affects > > > > Sure, but I'd like it to g

Re: [FFmpeg-devel] [PATCH v2] doc/formats: clarify meaning of igndts as per definition in avformat.h

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > This updates the documentation to be more clear about igndts, > as per feedback in December variant of this patch (thank you) > > Signed-off-by: Marth64 > --- > doc/formats.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: reformat options table indentation and descriptions

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 12:30:01 -0600, Marth64 wrote: > matroskaenc options table has grown packed over time, and is now challenging > to read. The purpose of this patch is to reformat the table, indentation-wise, > and to make the capitalization/endings of each description at least > consisten

<    1   2   3   4   5   6   7   8   9   10   >