[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: prefer DXGI 1.1 factory when available

2024-03-13 Thread Timo Rothenpieler
A lot of modern stuff straight up fails on the old 1.0 factory, which is masked by the fact that it's only used when an explicit adapter is specified. --- libavutil/hwcontext_d3d11va.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support

2024-03-06 Thread Timo Rothenpieler
On 06/03/2024 16:09, Stefano Sabatini wrote: On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote: Since last iteration: removes unused variable in dvdclut.c Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile | 2 +- libavformat/dvdclut.c |

Re: [FFmpeg-devel] [PATCH] configure: do not specify -ldvdread, as pkg-config check is already done

2024-03-04 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simd align

2024-02-27 Thread Timo Rothenpieler
On 26.02.2024 17:58, Timo Rothenpieler wrote: On 11/02/2024 18:40, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the

Re: [FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simd align

2024-02-26 Thread Timo Rothenpieler
On 11/02/2024 18:40, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

2024-02-14 Thread Timo Rothenpieler
On 14/02/2024 02:55, Dmitrii Ovchinnikov wrote: From: Evgeny Pavlov This commit adds two AMF filters: scale_amf & scale_amf_hq. Both filters are using AMF hardware acceleration. scale_amf supports simple scaling algorithms & color conversion. scale_amf_hq supports advanced scaling algorithms &

[FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simd align

2024-02-11 Thread Timo Rothenpieler
FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself is also 32 byte aligned. This might make the co

Re: [FFmpeg-devel] [PATCH v2] avutil/mem: limit alignment to maximum simd align

2024-02-11 Thread Timo Rothenpieler
On 11.02.2024 15:00, Andreas Rheinhardt wrote: Timo Rothenpieler: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the

Re: [FFmpeg-devel] [PATCH v2] avutil/mem: limit alignment to maximum simd align

2024-02-11 Thread Timo Rothenpieler
On 11.02.2024 15:22, Rémi Denis-Courmont wrote: Le perjantaina 9. helmikuuta 2024, 21.22.17 EET Timo Rothenpieler a écrit : On 13.01.2024 16:46, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any

Re: [FFmpeg-devel] [PATCH v2] avutil/mem: limit alignment to maximum simd align

2024-02-09 Thread Timo Rothenpieler
On 13.01.2024 16:46, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Constify bitstream pointee

2024-02-07 Thread Timo Rothenpieler
On 07.02.2024 16:04, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavcodec/nvdec.c | 2 +- libavcodec/nvdec.h | 2 +- libavcodec/nvdec_av1.c | 4 ++-- libavcodec/nvdec_h264.c | 4 ++-- libavcodec/nvdec_hevc.c | 4 ++-- 5 files changed, 8 insertions(+), 8 de

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: don't free NVDECContext->bitstream

2024-02-06 Thread Timo Rothenpieler
On 07.02.2024 00:05, James Almer wrote: On 2/6/2024 8:00 PM, Timo Rothenpieler wrote: On 06.02.2024 23:57, James Almer wrote: Ensure all hwaccels that allocate a buffer use NVDECContext->bitstream_internal. Signed-off-by: James Almer ---   libavcodec/nvdec.c  | 2 +-   libavco

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: don't free NVDECContext->bitstream

2024-02-06 Thread Timo Rothenpieler
On 07.02.2024 00:00, Timo Rothenpieler wrote: On 06.02.2024 23:57, James Almer wrote: Ensure all hwaccels that allocate a buffer use NVDECContext->bitstream_internal. Signed-off-by: James Almer ---   libavcodec/nvdec.c  | 2 +-   libavcodec/nvdec_h264.c | 4 ++--   libavcodec/nvdec_hev

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: don't free NVDECContext->bitstream

2024-02-06 Thread Timo Rothenpieler
On 06.02.2024 23:57, James Almer wrote: Ensure all hwaccels that allocate a buffer use NVDECContext->bitstream_internal. Signed-off-by: James Almer --- libavcodec/nvdec.c | 2 +- libavcodec/nvdec_h264.c | 4 ++-- libavcodec/nvdec_hevc.c | 4 ++-- 3 files changed, 5 insertions(+), 5 de

Re: [FFmpeg-devel] configure doesn't seem to use pkg-config flags?

2024-01-31 Thread Timo Rothenpieler
On 31/01/2024 14:07, epira...@gmail.com wrote: On 31 Jan 2024, at 13:03, Timo Rothenpieler wrote: On 31/01/2024 05:31, Roger Pack wrote: On Thu, Jan 18, 2024 at 6:31 AM Timo Rothenpieler wrote: On 18/01/2024 04:38, Roger Pack wrote: Hello. After compiling libx265 as a "static li

Re: [FFmpeg-devel] configure doesn't seem to use pkg-config flags?

2024-01-31 Thread Timo Rothenpieler
On 31/01/2024 05:31, Roger Pack wrote: On Thu, Jan 18, 2024 at 6:31 AM Timo Rothenpieler wrote: On 18/01/2024 04:38, Roger Pack wrote: Hello. After compiling libx265 as a "static library" (mingw cross compiling targeting win64) $ pkg-config --libs --static x265 -L/home/rdp/n

Re: [FFmpeg-devel] [PATCH] lavfi/vsrc_ddagrab: add an option to avoid duplicating frames

2024-01-29 Thread Timo Rothenpieler
On 29.01.2024 20:03, Anton Khirnov wrote: Tested-by: Jiří Eliášek, Misha Aizatulin --- doc/filters.texi | 15 +++ libavfilter/vsrc_ddagrab.c | 7 ++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1d70f4d934

Re: [FFmpeg-devel] [PATCH v2] lavfi/vsrc_ddagrab: add an option to avoid duplicating frames

2024-01-29 Thread Timo Rothenpieler
On 29.01.2024 19:31, Anton Khirnov wrote: Tested-by: Jiří Eliášek, Misha Aizatulin --- Now requested an infinite timeout from IDXGIOutputDuplication_AcquireNextFrame() when a frame is required. --- doc/filters.texi | 15 +++ libavfilter/vsrc_ddagrab.c | 9 +++-- 2 f

Re: [FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags

2024-01-22 Thread Timo Rothenpieler
On 22/01/2024 07:51, Matthew White via ffmpeg-devel wrote: Since glslang 14.0.0, OGLCompiler and HLSL stub libraries have been fully removed from the build. This fixes the configuration by detecting if the stub libraries are still present (glslang releases before version 14.0.0). ffbuild/config

Re: [FFmpeg-devel] configure doesn't seem to use pkg-config flags?

2024-01-18 Thread Timo Rothenpieler
On 18/01/2024 04:38, Roger Pack wrote: Hello. After compiling libx265 as a "static library" (mingw cross compiling targeting win64) $ pkg-config --libs --static x265 -L/home/rdp/new/sandbox/win64_static/build_files/lib -lx265 /usr/lib/gcc/x86_64-w64-mingw32/10-win32/libstdc++.a -lgcc I get t

[FFmpeg-devel] [PATCH v2] avutil/mem: limit alignment to maximum simd align

2024-01-13 Thread Timo Rothenpieler
FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself is also 32 byte aligned. This might make the co

Re: [FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simg align

2024-01-13 Thread Timo Rothenpieler
On 13.01.2024 01:57, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simg align

2024-01-12 Thread Timo Rothenpieler
On 13.01.2024 01:57, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

[FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simg align

2024-01-12 Thread Timo Rothenpieler
FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself is also 32 byte aligned. This might make the co

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2024-01-12 Thread Timo Rothenpieler
On 09.12.2023 06:23, Andreas Rheinhardt wrote: Timo Rothenpieler: On 08.12.2023 11:01, Andreas Rheinhardt wrote: Timo Rothenpieler: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2024-01-03 Thread Timo Rothenpieler
On 16.12.2023 16:35, Stefano Sabatini wrote: Ping, if there are no objections or comments I plan to push this in a week or something. This broke the build: libavfilter/vf_drawtext.c: In function 'shape_text': libavfilter/vf_drawtext.c:687:13: error: implicit declaration of function 'is_newli

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-08 Thread Timo Rothenpieler
On 08.12.2023 11:01, Andreas Rheinhardt wrote: Timo Rothenpieler: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-07 Thread Timo Rothenpieler
On 06.12.2023 14:25, Martin Storsjö wrote: On Sun, 3 Dec 2023, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 14:25, Martin Storsjö wrote: On Sun, 3 Dec 2023, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 13:31, James Almer wrote: On 12/3/2023 5:10 PM, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler

Re: [FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-06 Thread Timo Rothenpieler
On 03/12/2023 21:10, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Set default bitrate to 2M

2023-12-06 Thread Timo Rothenpieler
On 06/12/2023 07:51, Xiang, Haihao wrote: On Di, 2023-12-05 at 12:47 +0100, Timo Rothenpieler wrote: On 05.12.2023 09:15, Xiang, Haihao wrote: From: Haihao Xiang 2M is suitable for more cases, e.g. 4K video. Signed-off-by: Haihao Xiang ---   libavcodec/qsvenc_av1.c   | 2 +-   libavcodec

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Set default bitrate to 2M

2023-12-05 Thread Timo Rothenpieler
On 05.12.2023 09:15, Xiang, Haihao wrote: From: Haihao Xiang 2M is suitable for more cases, e.g. 4K video. Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_av1.c | 2 +- libavcodec/qsvenc_h264.c | 2 +- libavcodec/qsvenc_hevc.c | 2 +- libavcodec/qsvenc_mpeg2.c | 2 +- libavcodec/q

[FFmpeg-devel] [PATCH] avutil/mem: always align by at least 32 bytes

2023-12-03 Thread Timo Rothenpieler
FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself is also 32 byte aligned. This might make the co

Re: [FFmpeg-devel] [PATCH] Fixed nvenc release dump

2023-11-24 Thread Timo Rothenpieler
I don't quite understand the commit message. It should start with "avcodec/nvenc:" and then state what it's changing and why. On 24/11/2023 08:04, GOOR, Jean-Noel wrote: Signed-off-by: GOOR, Jean-Noël --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [IMPORTANT] banned on irc

2023-11-24 Thread Timo Rothenpieler
On 24/11/2023 10:38, Paul B Mahol wrote: Can not access irc anymore. Does it tell you which specific ban affects you? A bunch of likely way too broad bans were installed yesterday. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.o

Re: [FFmpeg-devel] [PATCH 4/6] libavformat/webrtc: add common code for WebRTC streaming

2023-11-06 Thread Timo Rothenpieler
On 06.11.2023 16:19, Michael Riedl wrote: Signed-off-by: Michael Riedl --- libavformat/webrtc.c | 398 +++ libavformat/webrtc.h | 70 2 files changed, 468 insertions(+) create mode 100644 libavformat/webrtc.c create mode 100644 libavforma

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Timo Rothenpieler
On 22.10.2023 13:57, Gyan Doshi wrote: On 2023-10-22 05:04 pm, Timo Rothenpieler wrote: On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: add option for file format specification

2023-10-22 Thread Timo Rothenpieler
On 22.10.2023 13:24, Gyan Doshi wrote: The vidstab library added support in Nov 2020 for writing/reading the transforms data in binary in addition to ASCII. The library default was changed to binary format but no changes were made to the AVfilters resulting in data file for writing or reading bei

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Timo Rothenpieler
On 14.10.2023 19:24, Stefano Sabatini wrote: Fix rendering of int values within a side data element, which was broken since commit d2d3a83ad93, where the side data element was correctly marked as a variable fields element. Logic to render a string variable was implemented already, but it was not

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-07 Thread Timo Rothenpieler
On 06.10.2023 18:43, Hendrik Leppkes wrote: On Fri, Oct 6, 2023 at 3:47 PM Timo Rothenpieler wrote: I'm quite confused why this specific instance suddenly causes so much upset. Because its bad form to break compilation of master, if all it took to avoid that is change the order of push

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Timo Rothenpieler
On 06/10/2023 15:31, Hendrik Leppkes wrote: On Fri, Oct 6, 2023 at 3:07 PM Timo Rothenpieler wrote: On 06/10/2023 14:29, Hendrik Leppkes wrote: On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler wrote: On 01.10.2023 04:06, James Almer wrote: Fixes compilation after

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-06 Thread Timo Rothenpieler
On 06/10/2023 14:29, Hendrik Leppkes wrote: On Sun, Oct 1, 2023 at 1:39 PM Timo Rothenpieler wrote: On 01.10.2023 04:06, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 It's expected behaviour to break compilation with random inter-release versio

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_cuda: check that the SDK defines cuCtxGetCurrent()

2023-10-01 Thread Timo Rothenpieler
On 01.10.2023 04:06, James Almer wrote: Fixes compilation after 05f8b2ca0f7e28775837a572c65ce9218f534ee2 It's expected behaviour to break compilation with random inter-release versions of ffnvcodec. It's only reliable exactly on release versions. I had planned to draw a release of the header

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: Fix double-free on error

2023-09-30 Thread Timo Rothenpieler
On 29.09.2023 19:28, Andreas Rheinhardt wrote: After the AVFrame has been wrapped into a buffer, it is owned by the buffer and must not be freed manually any more. Yet this happens on subsequent errors. This bug was introduced in 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b. Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] configure: disable vulkan if min version insufficient

2023-09-29 Thread Timo Rothenpieler
On 29.09.2023 20:10, Tristan Matthews wrote: On Fri, Sep 29, 2023 at 1:37 PM Timo Rothenpieler wrote: On 29.09.2023 15:52, Tristan Matthews wrote: Fixes: https://trac.ffmpeg.org/ticket/10596 --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b

Re: [FFmpeg-devel] [PATCH] configure: disable vulkan if min version insufficient

2023-09-29 Thread Timo Rothenpieler
On 29.09.2023 15:52, Tristan Matthews wrote: Fixes: https://trac.ffmpeg.org/ticket/10596 --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 20db1801ed..50ba6f772f 100755 --- a/configure +++ b/configure @@ -7154,7 +7154,8 @@ enabled c

Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context

2023-09-28 Thread Timo Rothenpieler
On 14.09.2023 18:52, Roman Arzumanyan wrote: Got it, thanks. Please find the patches in attachment. Just for my own understanding - could you please explain how this magic works in the configure script? I mean this section: if ! disabled ffnvcodec; then ffnv_hdr_list="ffnvcodec/nvEncodeAP

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-25 Thread Timo Rothenpieler
On 25.09.2023 14:18, Kyle Swanson wrote: Hi, On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler wrote: On 23.09.2023 11:50, Kyle Swanson wrote: Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler < t...@rothenpieler.org> wrote: Or it needs to be a sub-feature of libvmaf, wh

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-23 Thread Timo Rothenpieler
On 23.09.2023 11:50, Kyle Swanson wrote: Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler wrote: Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, support for CUDA is checked for, and then the vmaf_cuda filter needs to depend on that check. This previous patch

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-20 Thread Timo Rothenpieler
On 20.09.2023 22:06, Kyle Swanson wrote: Hi, On Mon, Sep 18, 2023 at 2:39 PM Kyle Swanson wrote: Hi, On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler wrote: On 18.09.2023 21:21, Marvin Scholz wrote: I am far from an expert with the configure script but won't that cause --e

Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context

2023-09-19 Thread Timo Rothenpieler
ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2" "$ffnv_hdr_list" "" fi To me it looks like any ffnvcodec package of version in range between 8.1.24.14 and 12.1.14.0 will pass this check. чт, 14 сент. 2023 г. в 18:04, Timo Roth

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-18 Thread Timo Rothenpieler
On 18.09.2023 21:21, Marvin Scholz wrote: enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0" libvmaf.h vmaf_init +enabled libvmaf && require_pkg_config libvmaf_cuda "libvmaf >= 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init enabled libvo_amrwbenc&& require

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-15 Thread Timo Rothenpieler
On 15.09.2023 22:31, Kyle Swanson wrote: Hi, On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler wrote: This looks more complicated than necessary to me. My idea would have been to change, in the previous original patch, > libvmaf_cuda_filter_deps="libvmaf ffnvco

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-14 Thread Timo Rothenpieler
On 14.09.2023 20:59, Kyle Swanson wrote: Problem was slightly different, there is no `libvmaf_cuda`, just `libvmaf` built with the cuda apis optionally enabled. `./configure` is fixed now and I've tested all the possible combinations, updated patch attached. This looks more complicated than nec

Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context

2023-09-14 Thread Timo Rothenpieler
On 14.09.2023 18:52, Roman Arzumanyan wrote: Got it, thanks. Please find the patches in attachment. Just for my own understanding - could you please explain how this magic works in the configure script? I mean this section: if ! disabled ffnvcodec; then ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h

Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context

2023-09-14 Thread Timo Rothenpieler
On 14/09/2023 15:29, Roman Arzumanyan wrote: Thanks for the swift reply Timo, you're right about versioning. However, I didn't find any existing CUDA API versioning macro unlike that for Video Codec SDK API. So I basically did the same thing as that in previous commit to nvcodec-headers which b

Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context

2023-09-14 Thread Timo Rothenpieler
This will either need updates to the ffnvcodec version checks in configure, to ensure the new symbol always exists, or some kind of more selective check to only build those parts of the code if the new function is present. As it is now, this would fail all current builds. _

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-11 Thread Timo Rothenpieler
On 11.09.2023 19:53, Kyle Swanson wrote: Hi, On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote: I'll merge this in a few days. Not merged yet because I noticed a bug in the configure script. Setting only `--enable-libvmaf` will enable both `libvmaf` and `libvmaf_cuda`. Anyone familiar with

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Timo Rothenpieler
On 08.09.2023 20:55, Kacper Michajlow wrote: On Fri, 8 Sept 2023 at 01:35, Timo Rothenpieler via ffmpeg-devel wrote: On 07.09.2023 23:38, Kacper Michajlow wrote: On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis wrote: On 9/6/2023 6:31 PM, Kacper Michajlow wrote: What would be a downside of

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-07 Thread Timo Rothenpieler via ffmpeg-devel
On 07.09.2023 23:38, Kacper Michajlow wrote: On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis wrote: On 9/6/2023 6:31 PM, Kacper Michajlow wrote: What would be a downside of preferring CXX always if it exists? FFmpeg runs in a multitude of environments with a multitude of portability requirem

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Timo Rothenpieler
On 06.09.2023 18:54, Kacper Michajlow wrote: On Wed, 6 Sept 2023 at 12:15, Timo Rothenpieler wrote: On 06/09/2023 01:26, Kacper Michajłow wrote: Other C++ standard libraries exist. Also, this is not a proper way to link the standard library anyway. Instead when a C++ dependency is detected

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Timo Rothenpieler
On 06/09/2023 01:26, Kacper Michajłow wrote: Other C++ standard libraries exist. Also, this is not a proper way to link the standard library anyway. Instead when a C++ dependency is detected, switch to the C++ compiler driver to properly link everything. Signed-off-by: Kacper Michajłow --- co

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-28 Thread Timo Rothenpieler
From f6f0afffadfc5fae97b11b0feb7c1d740b7c86ab Mon Sep 17 00:00:00 2001 From: Kyle Swanson Date: Mon, 28 Aug 2023 11:49:34 -0700 Subject: [PATCH] avfilter: add libvmaf_cuda --- configure| 4 + doc/filters.texi | 26 + libavfilter/Makefile | 1 + libavfilter/a

[FFmpeg-devel] [PATCH] configure: fix --custom-allocator

2023-08-26 Thread Timo Rothenpieler
The custom-allocator logic has been completely defunct since a while, since nothing depends on those targets, they never get used. This updates jemalloc to pkg-config, adds the fallback option for potential arbitrary allocators, and finally actually adds the libraries to LDFLAGS. --- configure | 1

Re: [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek

2023-08-19 Thread Timo Rothenpieler
On 15.08.2023 22:53, Timo Rothenpieler wrote: The mp4 demuxer gets very upset when it gets flushed and not re-fed this data. --- libavformat/hls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 2a2fe28a54..c625e30291 100644 --- a/libavformat

[FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek

2023-08-15 Thread Timo Rothenpieler
The mp4 demuxer gets very upset when it gets flushed and not re-fed this data. --- libavformat/hls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 2a2fe28a54..c625e30291 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2506,6 +2506,9 @

Re: [FFmpeg-devel] [PATCH] Add NVENC "Maximum encoded slice size in bytes" for H.264/HEVC codecs.

2023-08-14 Thread Timo Rothenpieler
On 14.08.2023 01:08, Kieran Kunhya wrote: On Sun, 13 Aug 2023 at 18:36, Timo Rothenpieler wrote: Did you actually get this to work? I'm testing it right now, and at stupid low values like 10 bytes I get a working but heavily artifacted video. If I set it to something like 2048 all I get

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-14 Thread Timo Rothenpieler
From 2665b7ddaefe6739bfeef4573183981582bdb995 Mon Sep 17 00:00:00 2001 From: Kyle Swanson Date: Mon, 7 Aug 2023 10:38:12 -0700 Subject: [PATCH] avfilter: add libvmaf_cuda --- configure| 4 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_lib

Re: [FFmpeg-devel] [PATCH] Add NVENC "Maximum encoded slice size in bytes" for H.264/HEVC codecs.

2023-08-13 Thread Timo Rothenpieler
Did you actually get this to work? I'm testing it right now, and at stupid low values like 10 bytes I get a working but heavily artifacted video. If I set it to something like 2048 all I get is a full size video that VLC decodes to a black screen. ___

Re: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces

2023-08-11 Thread Timo Rothenpieler
On 11.08.2023 19:50, Random Joe wrote: Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c. Signed-off-by: Random Joe ---  libavcodec/cuviddec.c | 13 +++--  1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/nvdec_(mjpeg|vp8): Constify AVHWAccels

2023-08-02 Thread Timo Rothenpieler
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Add NVENC "Maximum encoded slice size in bytes" for H.264/HEVC codecs.

2023-07-27 Thread Timo Rothenpieler
Looks sensible to me. I'm curious, what is the use case for this mode? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] flvdec: fix size desync when reading timestamp offsets

2023-07-24 Thread Timo Rothenpieler
On 25.07.2023 01:41, Hendrik Leppkes wrote: The size offset was previously being accounted for in flv_set_video_codec for h264 and mpeg4, instead of being directly accounted for in the spot where its read, which desynced on HEVC streams. For clarity, move the size offset directly to the parsing,

[FFmpeg-devel] [PATCH] avformat/flvenc: write proper timestamps when muxing hevc

2023-07-24 Thread Timo Rothenpieler
--- libavformat/flvenc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 335d900415..41636ba1b8 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -863,6 +863,9 @@ static int flv_write_packet(AVFormatContext

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
On 20.07.2023 23:09, Martin Storsjö wrote: Hmm, geez we have many similar-looking and randomly named timeout options here... The av_opt_copy() call in ffurl_open_whitelist() should only iterate over the options within the URLContext itself, not recurse into the protocol private options (as th

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
On 20.07.2023 22:47, Martin Storsjö wrote: On Thu, 20 Jul 2023, Timo Rothenpieler wrote: --- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Hmm, I would have somewhat expected that rw_timeout should be honored here already... Note that URLContext

[FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
--- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index f0ef223f05..a18cc78eac 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -127,6 +127,7 @@ typedef struct RTMPContex

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

2023-07-14 Thread Timo Rothenpieler
On 14/07/2023 11:44, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-07-14 01:11:07) On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: When the user explicitly specifies a pixel format that is not supported by the encoder, ffmpeg CLI will currently use some heuristics to pic

[FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible

2023-07-07 Thread Timo Rothenpieler
Newer versions of the library added a new binary output format, and prefer using it by default. Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read back the trf file it has just written itself. My guess is that this might be because of the fopen-mo

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix intraRefreshPeriod setting

2023-07-06 Thread Timo Rothenpieler
On 06/07/2023 14:00, Zhao Zhili wrote: From: Zhao Zhili Regression since 99dfdb45. intraRefreshPeriod access cc->gopLength, which has been overwritten to NVENC_INFINITE_GOPLENGTH before. Fixes #10445. --- libavcodec/nvenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback

2023-06-06 Thread Timo Rothenpieler
On 05.06.2023 14:29, Roman Arzumanyan wrote: Thanks for the review, Anton. Please find the updated patch attached. BTW - what do you mean by "you should also forward the actual error code"? Within the cuvid_handle_video_sequence() function in case of error, function still returns 0 and sets inter

Re: [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg

2023-05-12 Thread Timo Rothenpieler
On 12/05/2023 12:47, Steven Liu wrote: Timo Rothenpieler 于2023年5月12日周五 18:30写道: Hi Timo, On 12/05/2023 05:58, Steven Liu wrote: Reference file: https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf The Enhanced flv has been supported by OBS, Simple Realtime Server

Re: [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg

2023-05-12 Thread Timo Rothenpieler
On 12/05/2023 05:58, Steven Liu wrote: Reference file: https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf The Enhanced flv has been supported by OBS, Simple Realtime Server, mpegts.js. you can publish hevc, av1 or vp9 codec stream to Youtube over rtmp. The enhanced flv docum

Re: [FFmpeg-devel] [PATCH] Add functions to identify devices in more ways

2023-05-09 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Add functions to identify devices in more ways

2023-05-09 Thread Timo Rothenpieler
On 09/05/2023 12:11, rcombs wrote: - cuDeviceGetUuid_v2, giving distinct IDs for different MIG instances - cuDeviceGetLuid, giving a Win32 LUID to match with DXGI and other APIs - cuDeviceGetByPCIBusId, retrieving a device that matches a PCI bus ID string - cuDeviceGetPCIBusId, giving a PCI bus I

Re: [FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

2023-05-03 Thread Timo Rothenpieler
On 03.05.2023 21:08, Michael Niedermayer wrote: A quick check for example shows that even something as simple as the HLS BBC Radio streams will fail _all_ checks, since the playlists are hosted on another host entirely as the media, thanks to akamai live streaming. Playlist here, as an example: h

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: deprecate -re

2023-05-02 Thread Timo Rothenpieler
On 02.05.2023 15:43, Anton Khirnov wrote: It is exactly equivalent to -readrate 1.0 --- Changelog | 1 + doc/ffmpeg.texi| 2 +- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_demux.c | 5 + fftools/ffmpeg_opt.c | 4 +++- 5 files changed, 13 insertions(+), 2 delet

Re: [FFmpeg-devel] Embedded documentation?

2023-05-01 Thread Timo Rothenpieler
On 01.05.2023 12:13, Nicolas George wrote: Hi. Three years ago, I shared some brief thoughts about embedding the documentation in the libraries. For example, that would allow GUI applications to open help dialogs about specific options. To see what it would need, I wrote the following header. I

Re: [FFmpeg-devel] Please, clarify -r/-fps_mode usage for YUV encoding

2023-03-15 Thread Timo Rothenpieler
On 15.03.2023 21:36, Rogozhkin, Dmitry V wrote: Hi, Can someone, please, help to clarify ffmpeg behavior after one of the recent changes [1]. This commit turns warning into error to prevent usage of conflicting options. Error printed out is: “One of -r/-fpsmax was specified together a non-CFR -v

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Timo Rothenpieler
On 28.02.2023 16:03, Zhao Zhili wrote: I can move the check from here to close(). assert is helpful if it can catch bugs during development. It doesn't help much here since this is a rare case which doesn't triggered during development. Crashing with an assertion is still much better than deref

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference

2023-02-28 Thread Timo Rothenpieler
On 28.02.2023 19:43, Zhao Zhili wrote: From: Zhao Zhili This can happen if encoder init failed before setup the queue, then reorder_queue_flush() is called by close(). Fix ticket #10221 Signed-off-by: Zhao Zhili --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

Re: [FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 21:41, Drew Abbott wrote: Hello, I am trying to build Chromium 110 with ffmpeg version 5.1.2. One of the errors I get while building has to do with the API for accessing first_dts. It looks like previously it was just a member of AVStream, but now it can only be accessed with av_st

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 17:46, Gyan Doshi wrote: On 2023-02-22 10:12 pm, Timo Rothenpieler wrote: On 22.02.2023 17:33, Gyan Doshi wrote: From fftools\ffmpeg_mux_init.c 619:    ost->enc_ctx->global_quality = FF_QP2LAMBDA * qscale Regards, Gyan But that's only if you set the old

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 17:33, Gyan Doshi wrote: From fftools\ffmpeg_mux_init.c 619:    ost->enc_ctx->global_quality = FF_QP2LAMBDA * qscale Regards, Gyan But that's only if you set the old qscale CLI options. If you set the global_quality option directly, there is no factor applied. By dividing b

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 03:12, JonHGee wrote: libavcodec/libfdk-aacenc: VBR mode currently does not account for scaling when using -aq options with libfdk, resulting in clamping to vbr mode 5 whenever a value >0 is provided. Adjusting for the scaling factor for proper VBR support. --- libavcodec/libf

Re: [FFmpeg-devel] Proposed change to NVDEC ulNumOutputSurfaces initialization

2023-02-14 Thread Timo Rothenpieler
On 14.02.2023 18:27, Miller, Adrian wrote: Hi, I'm considering a proposing a change to libavcodec/nvdec.c but wanted to run it by you first as I'm new to FFmpeg development to make sure I've gotten things right (this is not a patch). We use the NVDEC decoder as part of our live transcoder. T

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Timo Rothenpieler
On 09.02.2023 17:10, Nicolas George wrote: Timo Rothenpieler (12023-02-09): How do you get access to the d3d hwdevice, given this lives in lavd, which has no provisions for that? Would it work better if it was in the same library? It's not so much about in which library it is, but

Re: [FFmpeg-devel] [PATCH] avdevice: add dxgigrab

2023-02-09 Thread Timo Rothenpieler
On 09.02.2023 15:22, aline.gondimsan...@savoirfairelinux.com wrote: From: Aline Gondim Santos A dxgi grab device may be either a display or a window. Differently from the existing gdigrab, this new device does not make the mouse to flick and also allows proper grabbing of accelerated windows, s

Re: [FFmpeg-devel] [RFC PATCH] avcodec/nvenc: add alpha layer encoding support

2022-12-30 Thread Timo Rothenpieler
On 30.12.2022 18:50, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili --- I need help. A lot of things doesn't work as Nvidia's doc: 1. Global header is broken. NV_ENC_SEQUENCE_PARAM_PAYLOAD doesn't work with multi SPS/PPS. It output VPS, SPS_0, SPS_1, PPS_0, with PPS_1 missin

<    1   2   3   4   5   6   7   8   9   10   >