Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: check ctx->hwctx->internal null pointer

2021-04-09 Thread Timo Rothenpieler
On 09.04.2021 12:34, Steven Liu wrote: -if (ctx->hwctx && ctx->cu_module) { +if (ctx->hwctx && ctx->cu_module && ctx->hwctx->internal) { CUcontext dummy; CudaFunctions *cu = ctx->hwctx->internal->cuda_dl; CHECK_CU(cu->cuCtxPushCurrent(ctx->cu_ctx)); How ca

Re: [FFmpeg-devel] [PATCH] avfilter/overlay_cuda: fix framesync with embedded PGS subtitle

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] avfilter/hwupload_cuda: add YUVA420P format support

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] avcodec/libdavs2: unbreak compilation failure

2021-03-17 Thread Timo Rothenpieler
applied this one, since this broke my builds. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmp

Re: [FFmpeg-devel] [PATCH] nvenc: Use frameIntervalP instead of max_b_frames for offsetting output dts

2021-03-12 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] CUDA - make it work for multiple GPU architectures

2021-03-12 Thread Timo Rothenpieler
On 12.03.2021 16:14, Patrick Ecord wrote: Tried that and ran configure and it failed with Option '--ptx (-ptx)' is not allowed when compiling for multiple GPU architectures" So I removed the `-ptx` flag and I was able to run configure and make and make install without any errors. FFmpeg embe

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use no-narrowing for cuda_llvm compilation.

2021-02-22 Thread Timo Rothenpieler
Both your patches are mangled and do not apply. Please use git send-email to send raw patches, or attach them as a file. I manually applied them now, but in the future please make sure your patches don't get mangled. smime.p7s Description: S/MIME Cryptographic Signature _

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-22 Thread Timo Rothenpieler
On 22.02.2021 12:20, Ricardo Monteiro wrote: Hi Timo, Thank you for your reply! The main intention of this patch is to allow FFmpeg to respect the presets that are available. Without this patch if for example one of our users wants to use preset p5 for example, FFmpeg will not allow it to use

Re: [FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 23:33, clime wrote: ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; -ctx->cuparseinfo.ulMaxDisplayDelay = 4; +ctx->cuparseinfo.ulMaxDisplayDelay = avctx->flags & AV_CODEC_FLAG_LOW_DELAY ? 0 : 4; I'd prefer this with proper braces, to make sure no compile

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 16:29, Ricardo Monteiro wrote: Hello, The patch fixes a bug regarding the number of B frames being used: The default number of B frames is now -1 for both h264_nvenc and hevc_nvenc. This allows the number of B frames to be determined based on the coding preset or overwritten usi

Re: [FFmpeg-devel] [PATCH 1/2] cuda_runtime.h: Correct ushort4 to use ushort.

2021-02-12 Thread Timo Rothenpieler
LGTM I wonder if the compiler even cares? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] is there a trick to building ffmpeg with sdl2 2.0.14 ? (2.0.12 works)

2021-01-31 Thread Timo Rothenpieler
On 31.01.2021 10:06, hydra3...@gmail.com wrote: When cross-compiling ffmpeg and sdl2 under ubuntu/mingw64 - ffmpeg builds with sdl2 2.0.12 ok however it fails to build with sdl2 2.0.14 If someone has done it, any advice on how to build with sdl2 2.0.14 would be appreciated. Works perfectly f

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding monochrome av1

2020-12-06 Thread Timo Rothenpieler
nvdec change is simple enough. Can't really say too much about the av1dec changes, other than they look generally sensible. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

Re: [FFmpeg-devel] [PATCH] avfilter/vf_hwupload_cuda: add transparent pix_fmts

2020-12-04 Thread Timo Rothenpieler
On 03.12.2020 16:56, Daniel Raniz Raneland wrote: Signed-off-by: Daniel Raniz Raneland --- libavfilter/vf_hwupload_cuda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 33906f2515..83b7babeaa 100644 --- a/libavfilter/v

Re: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: fix CUDA_ERROR_INVALID_CONTEXT error found by cuda-memcheck tool

2020-11-21 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix CUDA_ERROR_INVALID_CONTEXT error found by cuda-memcheck tool

2020-11-19 Thread Timo Rothenpieler
On 18.11.2020 09:24, leozhang wrote: Test command like below: cuda-memcheck ./ffmpeg -hwaccel cuvid -c:v h264_cuvid -i input_file -c:v h264_nvenc -f null - Signed-off-by: leozhang --- libavcodec/cuviddec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/cuvid

Re: [FFmpeg-devel] [PATCH v2] nv-codec-headers: add cuMemcpy

2020-11-16 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

2020-11-14 Thread Timo Rothenpieler
On 14.11.2020 16:08, James Almer wrote: On 11/14/2020 12:01 PM, Timo Rothenpieler wrote: I still strongly dislike this whole thing. The same logic is ran essentially twice. But I also really don't like putting all this stuff into the hwaccel. That's way more logic than a hwaccel i

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

2020-11-14 Thread Timo Rothenpieler
I still strongly dislike this whole thing. The same logic is ran essentially twice. But I also really don't like putting all this stuff into the hwaccel. That's way more logic than a hwaccel integration should have to do. ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-13 Thread Timo Rothenpieler
On 13.11.2020 02:23, lance.lmw...@gmail.com wrote: On Fri, Nov 13, 2020 at 02:14:05AM +0100, Timo Rothenpieler wrote: On 13.11.2020 02:05, lance.lmw...@gmail.com wrote: On Thu, Nov 12, 2020 at 05:56:57PM +0100, Timo Rothenpieler wrote: Technically, libvmaf itself does not, but our filter does

Re: [FFmpeg-devel] [PATCH] nv-codec-headers: add cuMemcpy

2020-11-13 Thread Timo Rothenpieler
Please also add cuMemcpyAsync while at it. What for and where is this needed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.

Re: [FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-12 Thread Timo Rothenpieler
On 13.11.2020 02:05, lance.lmw...@gmail.com wrote: On Thu, Nov 12, 2020 at 05:56:57PM +0100, Timo Rothenpieler wrote: Technically, libvmaf itself does not, but our filter does, and there is no other sensible way to prevent a build with --enable-libvmaf from succeeding while not actually

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
On 12.11.2020 22:23, James Almer wrote: On 11/12/2020 6:19 PM, Timo Rothenpieler wrote: Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. This is not about apply_grain == 0, but about apply_grain == 1 && update_grain == 0.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
On 12.11.2020 22:19, Timo Rothenpieler wrote: Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. As in, just always set them, and just move the fg_header definition to the top. ___ ffmpeg

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

[FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-12 Thread Timo Rothenpieler
Technically, libvmaf itself does not, but our filter does, and there is no other sensible way to prevent a build with --enable-libvmaf from succeeding while not actually enabling the filter. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure i

Re: [FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-11 Thread Timo Rothenpieler
On 11.11.2020 13:58, Timo Rothenpieler wrote: Will push series soon if no one objects. applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

Re: [FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-11 Thread Timo Rothenpieler
Will push series soon if no one objects. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-10 Thread Timo Rothenpieler
On 10.11.2020 15:19, James Almer wrote: On 11/10/2020 10:42 AM, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 80 +   libavcodec/av1dec.h |  3 ++   2 files changed, 83 insertions

[FFmpeg-devel] [PATCH v2 2/4] avcodec/av1dec: expose coded_lossless

2020-11-10 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 33 + libavcodec/av1dec.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1afed66499..87fd6bb2e3 100644 --- a

[FFmpeg-devel] [PATCH v2 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-10 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 80 + libavcodec/av1dec.h | 3 ++ 2 files changed, 83 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 56712279aa..1afed66499 100644

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 23:30, Mark Thompson wrote: On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 89 +   libavcodec/av1dec.h |  3 ++   2 files changed, 92 insertions

[FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: expose coded_lossless

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 32 +++- libavcodec/av1dec.h | 2 ++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 83295699e1..bde1124434 100644

[FFmpeg-devel] [PATCH 4/4] avcodec/nvdec: add av1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- Changelog | 1 + configure | 2 + libavcodec/Makefile| 1 + libavcodec/av1dec.c| 11 +- libavcodec/hwaccels.h | 1 + libavcodec/nvdec.c | 4 + libavcodec/nvdec.h | 1

[FFmpeg-devel] [PATCH 3/4] avcodec/nvdec: add support for separate reference frame

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler --- libavcodec/nvdec.c | 40 ++-- libavcodec/nvdec.h | 3 +++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index 6168a7e3f1..52a431c54d 100644 --- a/libavcodec/nvdec.c

[FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Timo Rothenpieler (4): avcodec/av1dec: expose skip mode frame index avcodec/av1dec: expose coded_lossless avcodec/nvdec: add support for separate reference frame avcodec/nvdec: add av1 hwaccel Changelog | 1 + configure | 2 + libavcodec/Makefile| 1

[FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 89 + libavcodec/av1dec.h | 3 ++ 2 files changed, 92 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 56712279aa..83295699e1 100644

Re: [FFmpeg-devel] build ffmpeg.so with h264 and h265 codec support

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 12:59, Budi wrote: I tried to build ffmpeg.so with h264 and h265 codec so go to compile as on: https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu but cannot find the exact need of this dynamic link build as all refer to build standalone executable binary How is actually the defin

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-04 Thread Timo Rothenpieler
On 04.11.2020 10:55, Joakim Tjernlund wrote: On Wed, 2020-11-04 at 10:51 +0100, Michael Niedermayer wrote: On Tue, Nov 03, 2020 at 02:38:52PM +0100, Andreas Rheinhardt wrote: Timo Rothenpieler: Given the multitude of recent serious security issues in Chromium-Based Browsers, is this even

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-03 Thread Timo Rothenpieler
Given the multitude of recent serious security issues in Chromium-Based Browsers, is this even still an issue? Anything not up to date enough to have already been fixed has serious security issues and should be updated ASAP, which also fixes this issue in turn. I'd rather see downstream users

Re: [FFmpeg-devel] [RFC] support half-precision float in *_cuda filters

2020-10-22 Thread Timo Rothenpieler
On 22.10.2020 05:43, leozhang wrote: Half precision float is supported for those devices sm capacity =5.3. Theoretically, half float can achieve 2x performance speed up. So is there any plan to support half float in FFmpeg? Or any problem so that half float can't be met up? I'm not aware of

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale_cuda: unload cuModule when uninit

2020-10-12 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/utils: do not fallback to av1dec for probing

2020-10-06 Thread Timo Rothenpieler
Made obsolete via 214998c55ff99586b57c1ccd34a7e6f15c4fcdb8 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "un

Re: [FFmpeg-devel] [PATCH] avformat/utils: do not fallback to av1dec for probing

2020-10-06 Thread Timo Rothenpieler
On 06.10.2020 15:38, Nicolas George wrote: Timo Rothenpieler (12020-10-06): --- libavformat/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index a2e701ea1a..871e655e13 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c

[FFmpeg-devel] [PATCH] avformat/utils: do not fallback to av1dec for probing

2020-10-06 Thread Timo Rothenpieler
--- libavformat/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index a2e701ea1a..871e655e13 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -222,6 +222,10 @@ static const AVCodec *find_probe_decoder(AVFormatContext *s, const

Re: [FFmpeg-devel] [PATCH] nv-codec-headers: Fix CUdeviceptr definition for ARM64 CPU

2020-09-29 Thread Timo Rothenpieler
applied, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Timo Rothenpieler
Consider just not using libwavpack at all. The ffmpeg native wavpack code has more features. There even is a patch on this list for its removal. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

[FFmpeg-devel] [PATCH] web: link GH Actions based Windows-Builds by BtbN

2020-09-16 Thread Timo Rothenpieler
--- src/download | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/download b/src/download index 706d402..0f090b8 100644 --- a/src/download +++ b/src/download @@ -79,6 +79,9 @@ Windows EXE Files + https://github.com/BtbN/FFmpeg-Builds/releases";>

Re: [FFmpeg-devel] .NET video processing with FFMPEG

2020-09-16 Thread Timo Rothenpieler
The ffmpeg project does not provide any bindings for other languages that can't interact with a C API on their own. You will have to find and talk to the author of that wrapper. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH] avfilter: add http video filter.

2020-09-10 Thread Timo Rothenpieler
Entirely outside of this filter being acceptable at all, pulling in libcurl is not an option without major safeguards for every single overlapping tls library both ffmpeg and curl support. If both are using the same library, there is a huge potential for libcurl being linked at all breaks ffmpeg

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Timo Rothenpieler
On 21.08.2020 14:35, Nicolas George wrote: 1. What would you think about putting the documentation for libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead of into huge doc/filters.texi (25k lines!)? And same for codecs, formats, etc. We can adopt this for new docu

Re: [FFmpeg-devel] ffmpeg software and patch management

2020-08-19 Thread Timo Rothenpieler
On 19.08.2020 20:25, Carter, Tenisha [USA] wrote: Hello, Ffmpeg is currently being used on a system that I support and I need clarification that version 3.4 is still being maintained and patched on a daily basis. Can you please provide me a statement indicating that this software is still suppor

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: support dynamic resolution change

2020-08-08 Thread Timo Rothenpieler
On 07.08.2020 10:18, leozhang wrote: Allow dynamic resolution change, this is useful for real time video communication application. Use below commands to test it, ffmpeg -i reinit-large_420_8-to-small_420_8.h264 -noautoscale -c:v hevc_nvenc out.265 -loglevel verbose -y ffmpeg -i reinit-large_4

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: support dynamic resolution change

2020-08-08 Thread Timo Rothenpieler
On 08.08.2020 02:48, Linjie Fu wrote: On Fri, Aug 7, 2020 at 4:19 PM leozhang wrote: Allow dynamic resolution change, this is useful for real time video communication application. Use below commands to test it, ffmpeg -i reinit-large_420_8-to-small_420_8.h264 -noautoscale -c:v hevc_nvenc ou

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Timo Rothenpieler
On 01.08.2020 08:47, Julio César Rocha wrote: Friendly ping. Are these changes acceptable now? I still don't see why they are neccesary. I did a test-build just yesterday with current git master, and it succeeded just fine with --toolchain=msvc in WSL launched via msvc cli. ___

Re: [FFmpeg-devel] Building with WSL instead of MSYS?

2020-07-31 Thread Timo Rothenpieler
On 31.07.2020 14:11, Julio César Rocha wrote: You would, if you had to or wanted to use the Microsoft compilers, as in my case. Just tested with msvc in WSL(i.e. launch wsl.exe from within a x64 native tools cmd), and it works just fine as well without any modifications made. ___

Re: [FFmpeg-devel] Building with WSL instead of MSYS?

2020-07-31 Thread Timo Rothenpieler
On 31.07.2020 13:17, Julio César Rocha wrote: Do you use the MSVC compilers? If so, how do you get around compiling linux-type absolute paths with cl.exe? (i.e. /home/user/src/ffmpeg/dir/file.c). Microsoft's CL.EXE does not accept paths beginning with a forward slash. I don't, why would I? I j

Re: [FFmpeg-devel] Building with WSL instead of MSYS?

2020-07-31 Thread Timo Rothenpieler
On 31.07.2020 09:41, Julio César Rocha wrote: Hi. I recently submitted a patch to enable building the Windows flavor with Windows Subsystem for Linux as an alternative to MSYS / CYGWIN. I got the feedback that people are already able to achieve this. Has anyone achieved this without patching th

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-23 Thread Timo Rothenpieler
On 23/07/2020 10:13, zhilizhao wrote: On Jul 17, 2020, at 5:47 AM, Steinar H. Gunderson wrote: On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; +static const uint8_t usa_country_code = 0xB5; +static const uint16_t smpte_provide

Re: [FFmpeg-devel] [PATCH 1/3] nvenc: use runtime api version to support old drivers

2020-07-16 Thread Timo Rothenpieler
On 16.07.2020 04:16, Wang Bin wrote: What happens if a struct gets updated, and ffmpeg wants to use the new fields when available, like happened plenty of times? Upgrade nvEncodeAPI.h like we've already done. Part of reserved bits will become a struct member and have a name. These bits will b

Re: [FFmpeg-devel] [PATCH 3/3] nvenc: check sdk 10.0 ptrs at runtime

2020-07-15 Thread Timo Rothenpieler
On 15.07.2020 16:34, wangbin wrote: From: wang-bin --- libavcodec/nvenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index cec59f02f3..c421c292c8 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1248,11

Re: [FFmpeg-devel] [PATCH 2/3] nvenc: check runtime 9.1 function ptrs before use

2020-07-15 Thread Timo Rothenpieler
On 15.07.2020 16:34, wangbin wrote: From: wang-bin --- libavcodec/nvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index ac35cb9f48..cec59f02f3 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -140,7 +140,7 @@

Re: [FFmpeg-devel] [PATCH 1/3] nvenc: use runtime api version to support old drivers

2020-07-15 Thread Timo Rothenpieler
On 15.07.2020 16:34, wangbin wrote: From: wang-bin There are reserved bit fields in nvEncoderAPI.h structs, so driver's abi is stable. Requesting runtime version of these structs should work. I've compared 7.0~9.x headers, and confirmed on some devices. --- libavcodec/nvenc.c | 72 +++

Re: [FFmpeg-devel] [PATCH] tools/coverity: override av_dict_set

2020-07-11 Thread Timo Rothenpieler
On 11.07.2020 22:17, Andreas Rheinhardt wrote: Timo Rothenpieler: Coverity thinks av_dict_set frees the key and value parameter, because it has the (rarely used) option to do so, and it's not smart enough to figure out it depends on the flags parameter. So lets provide a custom implement

[FFmpeg-devel] [PATCH] tools/coverity: override av_dict_set

2020-07-11 Thread Timo Rothenpieler
Coverity thinks av_dict_set frees the key and value parameter, because it has the (rarely used) option to do so, and it's not smart enough to figure out it depends on the flags parameter. So lets provide a custom implementation that does not free them. --- tools/coverity.c | 9 + 1 file ch

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Timo Rothenpieler
On 06.07.2020 01:18, Michael Niedermayer wrote: On Sun, Jul 05, 2020 at 09:56:02PM +, Soft Works wrote: ... A significant part of code reviews are code-style violations. This is really not something where humans should need to spend time for when reviewing a patch. you are correct but that

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Timo Rothenpieler
On 05.07.2020 17:46, Jan Engelhardt wrote: On Sunday 2020-07-05 16:43, Timo Rothenpieler wrote: LIBAVCODEC_58 { global: av_foo; av_bar; av_whatever_else_there_is;... local: *; }; LIBAVCODEC_58.91 { global: avpriv_mpeg4audio_get_config2; } LIBAVCODEC_58

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Timo Rothenpieler
On 05.07.2020 16:18, Carl Eugen Hoyos wrote: Am So., 5. Juli 2020 um 01:38 Uhr schrieb Andreas Rheinhardt : This crash is due to Chromium using av_max_alloc in an undocumented way; more exactly, the Chromium FFmpeg fork changes the allocation functions so that if max_alloc_size is zero, the lim

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Timo Rothenpieler
On 05.07.2020 14:10, Jan Engelhardt wrote: On Sunday 2020-07-05 13:39, Tomas Härdin wrote: Downgrading to a .so file with a lower minor version number than the program is built against can never be expected to work. Else we couldn't add new functions without a major bump. It requires the use

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-07-02 Thread Timo Rothenpieler
On 02.07.2020 17:42, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Timo Rothenpieler Sent: Thursday, July 2, 2020 3:51 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support On 01.07.2020 06:03

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-07-02 Thread Timo Rothenpieler
On 01.07.2020 06:03, Soft Works wrote: From: Roman Arzumanyan Sent: Tuesday, June 30, 2020 10:23 PM To: Soft Works ; FFmpeg development discussions and patches Cc: Yogender Gupta Subject: RE: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support Hello, nice to meet you.

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-07-01 Thread Timo Rothenpieler
On 30.06.2020 16:08, Roman Arzumanyan wrote: Hello, This patch adds Video Codec SDK 10 features support: * Presets and tuning info * Multipass encode modes * Low Delay Key Frame Scale Applied with some stylistic amendments and minor fixes. Thanks! We now need to figure somethi

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Timo Rothenpieler
On 30.06.2020 16:08, Roman Arzumanyan wrote: Hello, This patch adds Video Codec SDK 10 features support: * Presets and tuning info * Multipass encode modes * Low Delay Key Frame Scale How does one get the new multipass option to work? With the new preset, I get: InitializeEn

Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-23 Thread Timo Rothenpieler
On 23.06.2020 16:44, lance.lmw...@gmail.com wrote: On Thu, Jun 18, 2020 at 12:32:57PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 17 + libavcodec/nvenc.h | 1 + libavcodec/nvenc_hevc.c | 1 + 3 file

Re: [FFmpeg-devel] [PATCH v2 4/4] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-17 Thread Timo Rothenpieler
On 17.06.2020 18:07, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- I failed to find any document about nvenc so that I can update for new option. libavcodec/nvenc.c | 53 + libavcodec/nvenc.h | 1 +

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-12 Thread Timo Rothenpieler
On 12.06.2020 00:31, Gavin Smith wrote: On 11/06/2020 22:03, Timo Rothenpieler wrote: On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724.  The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-11 Thread Timo Rothenpieler
On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724. The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or pixels that were semi-tranparent would appear opaque. What is the performance impact for

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: maxBitrate is honored in CQ mode if set by user

2020-06-04 Thread Timo Rothenpieler
applied, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] compat/cuda/ptx2c: remove shell loop; fix BSD sed compat

2020-06-01 Thread Timo Rothenpieler
On 26.05.2020 19:42, rcombs wrote: This improves build times dramatically, and fixes building on macOS --- compat/cuda/ptx2c.sh | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/compat/cuda/ptx2c.sh b/compat/cuda/ptx2c.sh index 0750e7a3b7..c41875a2d4 100755 --- a/comp

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: set average and max bitrate values to zero when in CQ rate control mode

2020-06-01 Thread Timo Rothenpieler
applied and backported to 4.2, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: set average and max bitrate values to zero when in CQ rate control mode

2020-05-21 Thread Timo Rothenpieler
On 18.05.2020 09:54, Roman Arzumanyan wrote: Hello, The patch fixes bug with CQ RC mode: max and average bitrate values were not set to zero. How to reproduce: #CQ 30 file ffmpeg \ -i big_buck_bunny_1080p_h264.mov -c:v h264_nvenc -preset medium \ -cq 30 -y output_cq30.mp4 #CQ 10 file ffm

Re: [FFmpeg-devel] [WIP] XComposite window capture demuxer (Linux)

2020-05-20 Thread Timo Rothenpieler
On 20.05.2020 14:31, Nicolas George wrote: Anton Khirnov (12020-05-20): You said it: "from the user". The user chose it. The documentation says "this demuxer user OpenGL, don't use it if applications are not ready for it", the user chose to use it. That means we are now forcing all the applica

Re: [FFmpeg-devel] [WIP] XComposite window capture demuxer (Linux)

2020-05-19 Thread Timo Rothenpieler
Out of curiosity if I was proposing/using the native NVidia proprietary library for screen capture (linked at runtime dynamically), would that be more acceptable in terms of conflicts (I wouldn't like it because it wouldn't support AMD/Intel based hardware)? Are the headers for those libraries

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Update the encoder to use the framerate (if available) in the codec context

2020-05-14 Thread Timo Rothenpieler
applied, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: add FF_CODEC_CAP_INIT_CLEANUP caps for encoders

2020-05-03 Thread Timo Rothenpieler
On 31.03.2020 17:34, Linjie Fu wrote: ff_vaapi_encode_close() is not enough to free the resources like cbs if initialization failure happens after codec->configure (except for vp8/vp9). We need to call avctx->codec->close() to deallocate, otherwise memory leak happens. Add FF_CODEC_CAP_INIT_CLE

Re: [FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-27 Thread Timo Rothenpieler
fixed version applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-27 Thread Timo Rothenpieler
On 13.04.2020 17:33, Mark Thompson wrote: NOT TESTED. Fails to build: In file included from libavcodec/nvenc_hevc.c:24: libavcodec/nvenc.h:220:14: error: unknown type name ‘AVCodecHWConfigInternal’ 220 | extern const AVCodecHWConfigInternal *ff_nvenc_hw_configs[]; | ^~~~

Re: [FFmpeg-devel] ffmpeg.org down

2020-04-26 Thread Timo Rothenpieler
Trac and Website are working fine for me. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for aarch64

2020-04-23 Thread Timo Rothenpieler
On 23.04.2020 06:03, ManojGuptaBonda wrote: Adding the support to build FFMPEG with HW accelerated decode(nvdec) and encode on aarch64 architecture. Applied, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new internal encode API

2020-04-19 Thread Timo Rothenpieler
On 09.04.2020 20:27, James Almer wrote: Signed-off-by: James Almer --- Version with the flush() callback left in place. But it will need the changes i originally added to avcodec_flush_buffers() and then removed for the latest iteration of this set, in some form or another. libavcodec/nvenc.c

Re: [FFmpeg-devel] How to satisfy two codecs with one decoder?

2020-04-18 Thread Timo Rothenpieler
On 18.04.2020 00:53, James Almer wrote: See mpeg12dec.c and how both the mpeg1 and mpeg2 AVCodec entries are essentially the same for an example. Or the nvenc encoders. The old cuviddec is probably an even better example. The same decoder handles half a dozen codecs. _

Re: [FFmpeg-devel] How to improve GPU command to improve picture quality is the same as CPU transcoding quality

2020-04-16 Thread Timo Rothenpieler
Please ask user questions on the respective user mailing list. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] avfilter: add vf_overlay_cuda

2020-04-01 Thread Timo Rothenpieler
On 01.04.2020 17:12, Alex wrote: Driver is ok (I just updated it and same result), and nvenc working without  without cuda filters. But with overlay_cuda or scale_cuda ffmpeg is failing. Then I try to install ffmpeg on linux machine and looks like all working ok, but not on windows for me. D

Re: [FFmpeg-devel] [PATCH] avfilter: add vf_overlay_cuda

2020-04-01 Thread Timo Rothenpieler
On 01.04.2020 16:14, Alex wrote: Driver 445.75 (Win 10) I just tested a similar commandline on the same driver: ./ffmpeg_g.exe -v verbose -init_hw_device cuda=cuda -filter_hw_device cuda -hwaccel_output_format cuda -hwaccel cuda -i recode.mkv -i test.png -filter_complex "[1:v]format=nv12,hw

Re: [FFmpeg-devel] [PATCH] avfilter: add vf_overlay_cuda

2020-04-01 Thread Timo Rothenpieler
How does the NVDEC path work out? It fails to even initialize the filter on his hardware, no path will work any differently. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visi

Re: [FFmpeg-devel] [PATCH] avfilter: add vf_overlay_cuda

2020-04-01 Thread Timo Rothenpieler
On 01.04.2020 15:43, Alex wrote: Hi!Is it working? I try everything but constantly get error from overlay_cuda: ffmpeg -y -init_hw_device cuda=cuda -filter_hw_device cuda -hwaccel cuvid -c:v h264_cuvid -resize 1920x1080 -i 720p.mp4 -i watermark.png -filter_complex "[1:v]format=nv12,hwupload[i

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-28 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: make frame copy functions hwframe aware

2020-03-27 Thread Timo Rothenpieler
On 27.03.2020 21:53, James Almer wrote: On 3/27/2020 5:43 PM, Timo Rothenpieler wrote: --- libavutil/frame.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index e4038096c2..0c64f4a422 100644 --- a/libavutil

[FFmpeg-devel] [PATCH 3/3] libavutil/hwcontext: correctly set extended_data on hwframe_get_buffer

2020-03-27 Thread Timo Rothenpieler
--- libavutil/hwcontext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c index d09a15a249..b01612de05 100644 --- a/libavutil/hwcontext.c +++ b/libavutil/hwcontext.c @@ -557,6 +557,8 @@ int av_hwframe_get_buffer(AVBufferRef *hwframe_ref, AVFrame

[FFmpeg-devel] [PATCH 2/3] nvdec: attach real hw_frames to post-processed frames

2020-03-27 Thread Timo Rothenpieler
--- libavcodec/nvdec.c | 92 +- 1 file changed, 75 insertions(+), 17 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index b60da24301..6168a7e3f1 100644 --- a/libavcodec/nvdec.c +++ b/libavcodec/nvdec.c @@ -44,6 +44,7 @@ typedef struct

<    1   2   3   4   5   6   7   8   9   10   >