Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Timo Rothenpieler
On 05.07.2020 14:10, Jan Engelhardt wrote: On Sunday 2020-07-05 13:39, Tomas Härdin wrote: Downgrading to a .so file with a lower minor version number than the program is built against can never be expected to work. Else we couldn't add new functions without a major bump. It requires the use

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding monochrome av1

2020-12-06 Thread Timo Rothenpieler
nvdec change is simple enough. Can't really say too much about the av1dec changes, other than they look generally sensible. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH] avfilter/vf_hwupload_cuda: add transparent pix_fmts

2020-12-04 Thread Timo Rothenpieler
On 03.12.2020 16:56, Daniel Raniz Raneland wrote: Signed-off-by: Daniel Raniz Raneland --- libavfilter/vf_hwupload_cuda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 33906f2515..83b7babeaa 100644 ---

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 23:30, Mark Thompson wrote: On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 89 +   libavcodec/av1dec.h |  3 ++   2 files changed, 92 insertions

[FFmpeg-devel] [PATCH v2 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-10 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 80 + libavcodec/av1dec.h | 3 ++ 2 files changed, 83 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 56712279aa..1afed66499 100644

[FFmpeg-devel] [PATCH v2 2/4] avcodec/av1dec: expose coded_lossless

2020-11-10 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 33 + libavcodec/av1dec.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1afed66499..87fd6bb2e3 100644

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-10 Thread Timo Rothenpieler
On 10.11.2020 15:19, James Almer wrote: On 11/10/2020 10:42 AM, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 80 +   libavcodec/av1dec.h |  3 ++   2 files changed, 83 insertions

Re: [FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-11 Thread Timo Rothenpieler
Will push series soon if no one objects. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-12 Thread Timo Rothenpieler
Technically, libvmaf itself does not, but our filter does, and there is no other sensible way to prevent a build with --enable-libvmaf from succeeding while not actually enabling the filter. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure

Re: [FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-11 Thread Timo Rothenpieler
On 11.11.2020 13:58, Timo Rothenpieler wrote: Will push series soon if no one objects. applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
On 12.11.2020 22:23, James Almer wrote: On 11/12/2020 6:19 PM, Timo Rothenpieler wrote: Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. This is not about apply_grain == 0, but about apply_grain == 1 && update_grain == 0.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

2020-11-12 Thread Timo Rothenpieler
On 12.11.2020 22:19, Timo Rothenpieler wrote: Are you sure this is necessary at all? If apply_grain is 0, the value of those should be entirely irrelevant. As in, just always set them, and just move the fg_header definition to the top. ___ ffmpeg

Re: [FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-12 Thread Timo Rothenpieler
On 13.11.2020 02:05, lance.lmw...@gmail.com wrote: On Thu, Nov 12, 2020 at 05:56:57PM +0100, Timo Rothenpieler wrote: Technically, libvmaf itself does not, but our filter does, and there is no other sensible way to prevent a build with --enable-libvmaf from succeeding while not actually

Re: [FFmpeg-devel] [PATCH] configure: libvmaf requires pthreads

2020-11-13 Thread Timo Rothenpieler
On 13.11.2020 02:23, lance.lmw...@gmail.com wrote: On Fri, Nov 13, 2020 at 02:14:05AM +0100, Timo Rothenpieler wrote: On 13.11.2020 02:05, lance.lmw...@gmail.com wrote: On Thu, Nov 12, 2020 at 05:56:57PM +0100, Timo Rothenpieler wrote: Technically, libvmaf itself does not, but our filter does

Re: [FFmpeg-devel] [PATCH] nv-codec-headers: add cuMemcpy

2020-11-13 Thread Timo Rothenpieler
Please also add cuMemcpyAsync while at it. What for and where is this needed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

2020-11-14 Thread Timo Rothenpieler
I still strongly dislike this whole thing. The same logic is ran essentially twice. But I also really don't like putting all this stuff into the hwaccel. That's way more logic than a hwaccel integration should have to do. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

2020-11-14 Thread Timo Rothenpieler
On 14.11.2020 16:08, James Almer wrote: On 11/14/2020 12:01 PM, Timo Rothenpieler wrote: I still strongly dislike this whole thing. The same logic is ran essentially twice. But I also really don't like putting all this stuff into the hwaccel. That's way more logic than a hwaccel integration

Re: [FFmpeg-devel] [PATCH v2] nv-codec-headers: add cuMemcpy

2020-11-16 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix CUDA_ERROR_INVALID_CONTEXT error found by cuda-memcheck tool

2020-11-19 Thread Timo Rothenpieler
On 18.11.2020 09:24, leozhang wrote: Test command like below: cuda-memcheck ./ffmpeg -hwaccel cuvid -c:v h264_cuvid -i input_file -c:v h264_nvenc -f null - Signed-off-by: leozhang --- libavcodec/cuviddec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [FFmpeg-devel] build ffmpeg.so with h264 and h265 codec support

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 12:59, Budi wrote: I tried to build ffmpeg.so with h264 and h265 codec so go to compile as on: https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu but cannot find the exact need of this dynamic link build as all refer to build standalone executable binary How is actually the

[FFmpeg-devel] [PATCH 3/4] avcodec/nvdec: add support for separate reference frame

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler --- libavcodec/nvdec.c | 40 ++-- libavcodec/nvdec.h | 3 +++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index 6168a7e3f1..52a431c54d 100644 --- a/libavcodec/nvdec.c

[FFmpeg-devel] [PATCH 4/4] avcodec/nvdec: add av1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- Changelog | 1 + configure | 2 + libavcodec/Makefile| 1 + libavcodec/av1dec.c| 11 +- libavcodec/hwaccels.h | 1 + libavcodec/nvdec.c | 4 + libavcodec/nvdec.h | 1

[FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Timo Rothenpieler (4): avcodec/av1dec: expose skip mode frame index avcodec/av1dec: expose coded_lossless avcodec/nvdec: add support for separate reference frame avcodec/nvdec: add av1 hwaccel Changelog | 1 + configure | 2 + libavcodec/Makefile| 1

[FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 89 + libavcodec/av1dec.h | 3 ++ 2 files changed, 92 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 56712279aa..83295699e1 100644

[FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: expose coded_lossless

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 32 +++- libavcodec/av1dec.h | 2 ++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 83295699e1..bde1124434 100644

Re: [FFmpeg-devel] [PATCH v2] avcodec/cuviddec: fix CUDA_ERROR_INVALID_CONTEXT error found by cuda-memcheck tool

2020-11-21 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-03 Thread Timo Rothenpieler
Given the multitude of recent serious security issues in Chromium-Based Browsers, is this even still an issue? Anything not up to date enough to have already been fixed has serious security issues and should be updated ASAP, which also fixes this issue in turn. I'd rather see downstream users

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-04 Thread Timo Rothenpieler
On 04.11.2020 10:55, Joakim Tjernlund wrote: On Wed, 2020-11-04 at 10:51 +0100, Michael Niedermayer wrote: On Tue, Nov 03, 2020 at 02:38:52PM +0100, Andreas Rheinhardt wrote: Timo Rothenpieler: Given the multitude of recent serious security issues in Chromium-Based Browsers, is this even

Re: [FFmpeg-devel] [PATCH] BugFix #9283: correct setting of key_frame flag in AVFrame using cuviddec on interlaced h264

2021-06-11 Thread Timo Rothenpieler
On 11.06.2021 12:27, stuhlo wrote: From: stuhlo This fixes setting of `key_frame` flag in AVFrame when input h264 packets represents individual fields of interlaced video. In this case, pairs of two consecutive fields represents a single decoded picture and have identical `CurrPicIdx`,

[FFmpeg-devel] [PATCH] avfilter: add format_cuda filter

2021-06-11 Thread Timo Rothenpieler
--- configure | 2 + doc/filters.texi| 46 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/cuda/vector_helpers.cuh | 14 +- libavfilter/version.h | 2 +-

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Timo Rothenpieler
On 08.06.2021 21:24, Kevin LaFlamme wrote: For streaming mode with fragmented MP4 the intention is to have the client read a partial file since it’s broken up into sequential boxes that are playable independently. This doesn’t change the segment files themselves or how they are written, it

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Timo Rothenpieler
On 08.06.2021 21:03, Kevin LaFlamme wrote: When streaming mode is enabled with fMP4/CMAF for DASH output, the segment files are available to read by players as soon as the first byte is written instead of only after the file is fully written. The DASH manifest currently only gets written when

Re: [FFmpeg-devel] [PATCH] avfilter: add format_cuda filter

2021-06-11 Thread Timo Rothenpieler
On 11.06.2021 17:33, Steven Liu wrote: 在 2021年6月11日,22:43,Timo Rothenpieler 写道: Hi Timo, --- configure | 2 + doc/filters.texi| 46 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/cuda

Re: [FFmpeg-devel] [PATCH] avfilter: compress CUDA PTX code if possible

2021-06-11 Thread Timo Rothenpieler
On 12.06.2021 00:42, Timo Rothenpieler wrote: +#include +#include +#include + +int main(int argc, char **argv) +{ +const char *name = NULL; +unsigned int length = 0; +unsigned char data; + +if (argc != 2) { +return 1; +} else { +int arglen = strlen(argv[1

[FFmpeg-devel] [PATCH] avfilter: compress CUDA PTX code if possible

2021-06-11 Thread Timo Rothenpieler
--- .gitignore | 1 + compat/cuda/bin2c.c | 58 compat/cuda/ptx2c.sh| 34 configure | 17 ++ ffbuild/.gitignore | 1 + ffbuild/common.mak | 28 --

[FFmpeg-devel] [PATCH] configure: msys also has .exe suffix

2021-06-12 Thread Timo Rothenpieler
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bdd23479ba..41449eac5f 100755 --- a/configure +++ b/configure @@ -4424,7 +4424,7 @@ fi exesuf() { case $1 in -

Re: [FFmpeg-devel] [PATCH] configure: msys also has .exe suffix

2021-06-12 Thread Timo Rothenpieler
On 12.06.2021 18:08, Hendrik Leppkes wrote: On Sat, Jun 12, 2021 at 2:31 PM Timo Rothenpieler wrote: --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bdd23479ba..41449eac5f 100755 --- a/configure +++ b/configure @@ -4424,7

Re: [FFmpeg-devel] [PATCH] configure: bump default nvcc arch to compute_35

2021-06-12 Thread Timo Rothenpieler
On 12.06.2021 12:43, Anton Khirnov wrote: From: Matthieu Patou compute_30 seems to be removed from CUDA SDK 11.0 It is, that's why just a few lines below there is a check that tests for that and upgrades the version if necessary. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH] avfilter: add format_cuda filter

2021-06-12 Thread Timo Rothenpieler
On 12.06.2021 07:07, Lynne wrote: Jun 12, 2021, 00:26 by t...@rothenpieler.org: On 11.06.2021 17:33, Steven Liu wrote: 在 2021年6月11日,22:43,Timo Rothenpieler 写道: Hi Timo, --- configure | 2 + doc/filters.texi| 46 ++ libavfilter/Makefile

[FFmpeg-devel] [PATCH v2] avfilter: compress CUDA PTX code if possible

2021-06-12 Thread Timo Rothenpieler
--- .gitignore | 1 + compat/cuda/ptx2c.sh| 34 configure | 17 ++ ffbuild/.gitignore | 1 + ffbuild/bin2c.c | 76 ++ ffbuild/common.mak | 28 --

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_overlay_cuda: support expression of x y position

2021-06-10 Thread Timo Rothenpieler
Applied, thanks! smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

[FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-17 Thread Timo Rothenpieler
--- doc/filters.texi | 6 ++ libavfilter/f_select.c | 18 ++ libavfilter/version.h | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index da8f7d7726..db6ecd7c2a 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH] avfilter: add format_cuda filter

2021-06-19 Thread Timo Rothenpieler
On 11.06.2021 16:43, Timo Rothenpieler wrote: --- configure | 2 + doc/filters.texi| 46 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/cuda/vector_helpers.cuh | 14 +- libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-18 Thread Timo Rothenpieler
On 18.06.2021 06:19, Gyan Doshi wrote: Instead of a specific option for silencedetect, it would be future-proof if it was an option called, say, metadata with a constant for silencedetect to start with. There are multiple per-frame analysis filters like blackframe, blackdetect,

Re: [FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-18 Thread Timo Rothenpieler
On 18.06.2021 13:46, Gyan Doshi wrote: On 2021-06-18 17:02, Timo Rothenpieler wrote: On 18.06.2021 06:19, Gyan Doshi wrote: Instead of a specific option for silencedetect, it would be future-proof if it was an option called, say, metadata with a constant for silencedetect to start

Re: [FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-18 Thread Timo Rothenpieler
On 18.06.2021 14:35, Gyan Doshi wrote: The drawtext filter does not use expression evaluation for its text parameter. It implements its own logic for that, and it's purely text-replace. The expression parser does support functions, but only functions with one or two numeric arguments. So

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: remove unused AVCodec.decode() callback

2021-06-21 Thread Timo Rothenpieler
On 21.06.2021 19:56, James Almer wrote: On 6/17/2021 2:45 PM, James Almer wrote: The AVCodec.receive_frame() callback takes precedence. Signed-off-by: James Almer ---   libavcodec/cuviddec.c | 32   1 file changed, 32 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/select: add metadata detection function

2021-06-22 Thread Timo Rothenpieler
On 18.06.2021 14:50, Timo Rothenpieler wrote: --- doc/filters.texi | 18 ++ libavfilter/f_select.c | 79 -- libavfilter/version.h | 2 +- 3 files changed, 96 insertions(+), 3 deletions(-) Will push this soon smime.p7s Description

Re: [FFmpeg-devel] Hardware purchase request

2021-06-25 Thread Timo Rothenpieler
On 25.06.2021 10:14, Lynne wrote: The prices have dropped a little, but the biggest difference is that stuff is *actually* available now. Unfortunately, now is not a good time to build an entire system. Socket AM4's finished, so if I build an AMD system, it'll be obsolete within a year or so,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: support expression of x y position

2021-06-08 Thread Timo Rothenpieler
It'd probably make sense to also copy over the option for evaluating the expression per-frame or on init. Given that this is usually going to run much faster than the software overlay filter, the slight overhead from the expression could be much more severe. Looks good otherwise, and for what

[FFmpeg-devel] [PATCH] avfilter/select: add metadata detection function

2021-06-18 Thread Timo Rothenpieler
--- doc/filters.texi | 18 ++ libavfilter/f_select.c | 79 -- libavfilter/version.h | 2 +- 3 files changed, 96 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index da8f7d7726..05fec04b55 100644 ---

Re: [FFmpeg-devel] [PATCH v2] avfilter: compress CUDA PTX code if possible

2021-06-18 Thread Timo Rothenpieler
On 18.06.2021 22:45, Philip Langdale wrote: On Sat, 12 Jun 2021 18:47:50 +0200 Timo Rothenpieler wrote: --- .gitignore | 1 + compat/cuda/ptx2c.sh| 34 configure | 17 ++ ffbuild/.gitignore | 1

Re: [FFmpeg-devel] [PATCH v5 3/3] avcodec/nvenc: write out user data unregistered SEI

2021-05-17 Thread Timo Rothenpieler
On 17.05.2021 17:52, Marton Balint wrote: Don't we have av_fast_realloc for this? Yes, but you still need to save the pointer for that somewhere. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: #define TARGET_CPU_ARM64 to 0 if not provided by the SDK

2021-05-15 Thread Timo Rothenpieler
On 15.05.2021 11:45, Zane van Iperen wrote: Fixes build failure on older SDKs without it. Fixes #9242 Signed-off-by: Zane van Iperen --- libavcodec/videotoolboxenc.c | 5 + 1 file changed, 5 insertions(+) NB: This is untested, I do not have a Mac to try it on. diff --git

Re: [FFmpeg-devel] [PATCH v5 3/3] avcodec/nvenc: write out user data unregistered SEI

2021-05-17 Thread Timo Rothenpieler
On 17.05.2021 10:19, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 64 ++ 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99c..e22fdfb5a8 100644 ---

Re: [FFmpeg-devel] ffprobe as library rather than CLI

2021-05-12 Thread Timo Rothenpieler
On 12.05.2021 15:19, Samuel Marks wrote: Started hacking around to make it work. So I changed the `main` to a: extern int ffprobe(int argc, char **argv); Then I added a header with a prototype of the same, and started messing with vcpkg + CMake to try and get it to build correctly. That's

Re: [FFmpeg-devel] Builds for MAC

2021-05-16 Thread Timo Rothenpieler
On 16.05.2021 19:46, Jan Ekström wrote: If you have interest in figuring out building binaries for distribution, I would recommend contributing to one of the public and automated build systems such as https://github.com/BtbN/FFmpeg-Builds . Currently it has Windows and 64bit Linux in there, and

Re: [FFmpeg-devel] Builds for MAC

2021-05-16 Thread Timo Rothenpieler
On 16.05.2021 21:26, Jan Ekström wrote: On Sun, May 16, 2021 at 10:02 PM Timo Rothenpieler wrote: On 16.05.2021 19:46, Jan Ekström wrote: If you have interest in figuring out building binaries for distribution, I would recommend contributing to one of the public and automated build systems

Re: [FFmpeg-devel] [PATCH] web/contact: Add libera.chat

2021-05-26 Thread Timo Rothenpieler
On 26.05.2021 12:43, Gyan Doshi wrote: On 2021-05-25 16:37, Timo Rothenpieler wrote: I'm in favour of switching over to Libera.chat. Freenodes business model is more than questionable, and some recent actions of the new staff are questionable at best. The old Freenode staff have switched

Re: [FFmpeg-devel] [PATCH v6] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Timo Rothenpieler
On 25/05/2021 12:11, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 73 +- libavcodec/nvenc.h | 2 ++ 2 files changed, 62 insertions(+), 13 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index

Re: [FFmpeg-devel] [PATCH] web/contact: Add libera.chat

2021-05-25 Thread Timo Rothenpieler
I'm in favour of switching over to Libera.chat. Freenodes business model is more than questionable, and some recent actions of the new staff are questionable at best. The old Freenode staff have switched to Libera in their entirety, so it seems only natural to follow along than to stay on a

Re: [FFmpeg-devel] [PATCH v7] avcodec/nvenc: write out user data unregistered SEI

2021-06-01 Thread Timo Rothenpieler
On 02.06.2021 00:29, Brad Hards wrote: Is that consistent with the problem you are seeing? Brad It matches the backtrace on both linux and Windows. Something deep inside the nvidia driver is doing an invalid read. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH v7] avcodec/nvenc: write out user data unregistered SEI

2021-06-01 Thread Timo Rothenpieler
On 01.06.2021 11:51, Brad Hards wrote: Anything more on this version? Brad No, but we're investigating weird crashes that are caused by the s12m timecodes _somehow_, so I'm holding off on merging any other changes in that area until it's figured out. smime.p7s Description: S/MIME

Re: [FFmpeg-devel] Unable to compile with cuda

2021-05-23 Thread Timo Rothenpieler
On 24.05.2021 00:08, Dylan Fernando wrote: I got it to work, with --enable-cuda as well, using: PKG_CONFIG_PATH="/home/dylan/Files/nv-codec-headers" ./configure --enable-opencl --enable-vulkan --enable-libglslang --disable-stripping --enable-nonfree --enable-cuda --enable-cuda-nvcc

Re: [FFmpeg-devel] Unable to compile with cuda

2021-05-22 Thread Timo Rothenpieler
On 22.05.2021 20:54, Dylan Fernando wrote: I'm unable to compile on Arch Linux with cuda enabled. Command: ./configure --enable-opencl --enable-vulkan --enable-libglslang --disable-stripping --enable-nonfree --enable-cuda-nvcc --extra-c flags=-I/opt/local/cuda/include Error: ERROR: failed

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: add hsub and vsub compute x and y positions

2021-06-07 Thread Timo Rothenpieler
Missed this one, will give it a test. Looks good to me so far. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH v7] avcodec/nvenc: write out user data unregistered SEI

2021-06-04 Thread Timo Rothenpieler
Pushed a very much refactored version of this patch and some more refactoring on top of it. It still shows the crash, but both the previous code and this code seem fine to me in that regard. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH v7] avcodec/nvenc: write out user data unregistered SEI

2021-06-01 Thread Timo Rothenpieler
On 01.06.2021 12:46, Brad Hards wrote: On Tuesday, 1 June 2021 8:01:13 PM AEST Timo Rothenpieler wrote: No, but we're investigating weird crashes that are caused by the s12m timecodes _somehow_, so I'm holding off on merging any other changes in that area until it's figured out. Do you have

Re: [FFmpeg-devel] Hardware purchase request

2021-06-25 Thread Timo Rothenpieler
On 26.06.2021 01:28, Lynne wrote: Jun 25, 2021, 13:25 by t...@rothenpieler.org: On 25.06.2021 10:14, Lynne wrote: The prices have dropped a little, but the biggest difference is that stuff is *actually* available now. Unfortunately, now is not a good time to build an entire system. Socket

Re: [FFmpeg-devel] Unable to use sqrt() and exp() in CUDA

2021-06-26 Thread Timo Rothenpieler
On 26.06.2021 15:35, Dylan Fernando wrote: I can't seem to be able to use exp() and sqrt() in CUDA. I get: NVCClibavfilter/try_cuda.ptx clang-11: warning: Unknown CUDA version. cuda.h: CUDA_VERSION=11030. Assuming the latest supported version 10.1 [-Wunknown-cuda-version]

Re: [FFmpeg-devel] Unable to use sqrt() and exp() in CUDA

2021-06-27 Thread Timo Rothenpieler
On 27.06.2021 18:42, Dylan Fernando wrote: Yeah, I was using enable-cuda-llvm. I haven't been including cuda.h in my cuda file. Could it be from the include in hwcontext_cuda.h possibly? I was using: Are you including hwcontext_cuda.h in your Kernel Code? That's a C side file. You shouldn't

Re: [FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-11 Thread Timo Rothenpieler
On 11.07.2021 14:01, Derek Buitenhuis wrote: Hi Brad, On 7/8/2021 4:31 AM, Brad Hards wrote: About a month ago, I submitted a patch to add User Data Unregistered SEI writing to the x265 implementation. See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1] and

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-09 Thread Timo Rothenpieler
On 10.07.2021 00:53, Andrii wrote: Hi, I am working on porting a Kodi player to an NVidia Jetson Nano device. I've been developing a decoder for quite some time now, and realized that the best approach would be to have it inside of ffmpeg, instead of embedding the decoder into Kodi as it

Re: [FFmpeg-devel] [PATCH 4/5] libavcodec: write out user data unregistered SEI for nvenc

2021-04-30 Thread Timo Rothenpieler
On 30.04.2021 13:34, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99c..1a895a64f4 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@

Re: [FFmpeg-devel] [PATCH 4/5] libavcodec: write out user data unregistered SEI for nvenc

2021-04-30 Thread Timo Rothenpieler
On 01.05.2021 01:30, Brad Hards wrote: I don't understand this comment. The existing code defines a fixed size array, and I don't want to change it because I couldn't find an authoritative source as to why that size or approach. I assume it could be a hardware limitation on at least some

Re: [FFmpeg-devel] is there a trick to building ffmpeg with sdl2 2.0.14 ? (2.0.12 works)

2021-01-31 Thread Timo Rothenpieler
On 31.01.2021 10:06, hydra3...@gmail.com wrote: When cross-compiling ffmpeg and sdl2 under ubuntu/mingw64 - ffmpeg builds with sdl2 2.0.12 ok however it fails to build with sdl2 2.0.14 If someone has done it, any advice on how to build with sdl2 2.0.14 would be appreciated. Works perfectly

Re: [FFmpeg-devel] [PATCH] avfilter/hwupload_cuda: add YUVA420P format support

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] avfilter/overlay_cuda: fix framesync with embedded PGS subtitle

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] CUDA - make it work for multiple GPU architectures

2021-03-12 Thread Timo Rothenpieler
On 12.03.2021 16:14, Patrick Ecord wrote: Tried that and ran configure and it failed with Option '--ptx (-ptx)' is not allowed when compiling for multiple GPU architectures" So I removed the `-ptx` flag and I was able to run configure and make and make install without any errors. FFmpeg

Re: [FFmpeg-devel] [PATCH] nvenc: Use frameIntervalP instead of max_b_frames for offsetting output dts

2021-03-12 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] avcodec/libdavs2: unbreak compilation failure

2021-03-17 Thread Timo Rothenpieler
applied this one, since this broke my builds. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: check ctx->hwctx->internal null pointer

2021-04-09 Thread Timo Rothenpieler
On 09.04.2021 12:34, Steven Liu wrote: -if (ctx->hwctx && ctx->cu_module) { +if (ctx->hwctx && ctx->cu_module && ctx->hwctx->internal) { CUcontext dummy; CudaFunctions *cu = ctx->hwctx->internal->cuda_dl; CHECK_CU(cu->cuCtxPushCurrent(ctx->cu_ctx)); How

Re: [FFmpeg-devel] [PATCH] Added Closed caption support for cuviddec for preserving a53 data n GPU decoding

2021-04-13 Thread Timo Rothenpieler
On 13.04.2021 01:41, James Almer wrote: You have ff_parse_a53_cc() in atsc_a53.c for this I'm pretty sure I NAKed this or a very similar patch in the past, asking to not re-implement an entire parser in cuviddec. Same applies here: I'm not going to accept a patch that implements a complex,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: check ctx->hwctx->internal null pointer

2021-04-10 Thread Timo Rothenpieler
Can you test if https://github.com/BtbN/FFmpeg/commit/454d5c5d3eda7b5356f961a0e1b66f3a56d95363 Also fixes the issue? I'm unable to reproduce the crash. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

2021-04-17 Thread Timo Rothenpieler
I think I'd much prefer to stop relying on the order of this enum entirely. nvenc_map_preset already sets a lossless flag. But it's called way too late for the capability check. I see no reason the call to nvenc_map_preset can't be moved to much earlier. Like, right into ff_nvenc_encode_init.

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

2021-04-18 Thread Timo Rothenpieler
pushed a refactor of the entire logic, since I realized that another piece of code (the options parsing logic) relies on the new presets being last. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] cuda_runtime.h: Correct ushort4 to use ushort.

2021-02-12 Thread Timo Rothenpieler
LGTM I wonder if the compiler even cares? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 16:29, Ricardo Monteiro wrote: Hello, The patch fixes a bug regarding the number of B frames being used: The default number of B frames is now -1 for both h264_nvenc and hevc_nvenc. This allows the number of B frames to be determined based on the coding preset or overwritten

Re: [FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 23:33, clime wrote: ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; -ctx->cuparseinfo.ulMaxDisplayDelay = 4; +ctx->cuparseinfo.ulMaxDisplayDelay = avctx->flags & AV_CODEC_FLAG_LOW_DELAY ? 0 : 4; I'd prefer this with proper braces, to make sure no

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-22 Thread Timo Rothenpieler
On 22.02.2021 12:20, Ricardo Monteiro wrote: Hi Timo, Thank you for your reply! The main intention of this patch is to allow FFmpeg to respect the presets that are available. Without this patch if for example one of our users wants to use preset p5 for example, FFmpeg will not allow it to

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use no-narrowing for cuda_llvm compilation.

2021-02-22 Thread Timo Rothenpieler
Both your patches are mangled and do not apply. Please use git send-email to send raw patches, or attach them as a file. I manually applied them now, but in the future please make sure your patches don't get mangled. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-22 Thread Timo Rothenpieler
If nobody wants to review the algorithm being implemented, I'm gonna apply this soon. It looks fine by all I can tell, but I never touched the software version of this filter. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-27 Thread Timo Rothenpieler
There still are some issues in the C side of this filter: You're allocating a lot of stuff on init (integral_img, ...) but never free it. So the filter leaks those. You define a list of supported formats at the top, listing practically all formats that can be in a CUDA frame as of right now.

Re: [FFmpeg-devel] Missing sudo on make install in INSTALL.md

2021-08-26 Thread Timo Rothenpieler
On 26.08.2021 06:34, "zhilizhao(赵志立)" wrote: I tried try `make install` on my machine and I got: install: cannot create regular file '/usr/local/share/man/man1/ffmpeg.1': Permission denied install: cannot create regular file '/usr/local/share/man/man1/ffprobe.1': Permission denied

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Timo Rothenpieler
On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "double exp(double x)" and calculates the base e exponential. While __nvvm_ex2_approx_f reads to me like it does so

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Timo Rothenpieler
On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Missing license header in both new files (please re-send for this). Missing version bump, though I can add this when pushing as well. The code looks fine to me, though I have no experience with this algorithm at all, so if

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-14 Thread Timo Rothenpieler
On 14.08.2021 07:49, Dylan Fernando wrote: On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler wrote: On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "doubl

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-14 Thread Timo Rothenpieler
On 14.08.2021 07:49, Dylan Fernando wrote: On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler wrote: On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "doubl

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/nvenc: Add intra refresh support

2021-09-03 Thread Timo Rothenpieler
On 02.09.2021 12:38, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 24 +--- libavcodec/nvenc.h | 1 + libavcodec/nvenc_h264.c | 2 ++ libavcodec/nvenc_hevc.c | 2 ++ 4 files changed, 26 insertions(+), 3

<    4   5   6   7   8   9   10   11   12   13   >