[FFmpeg-devel] [RFC] Funded Task Ideas

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list -- [email protected] To

[FFmpeg-devel] [PATCH] avformat/mccenc: use Lavf version string instead of FFmpeg (PR #20655)

2025-10-18 Thread James Almer via ffmpeg-devel
creation_program = LIBAVFORMAT_IDENT; } else if (strchr(creation_program, '\n')) { av_log(avf, AV_LOG_FATAL, "creation_program must not contain multiple lines of text\n"); return AVERROR(EINVAL); -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [RFC] Issue tracker

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Gyan On Tue, Sep 16, 2025 at 10:09:14AM +0530, Gyan Doshi via ffmpeg-devel wrote: > > > On 2025-09-16 03:16 am, Michael Niedermayer via ffmpeg-devel wrote: > > > What can happen is that if an existing open trac issue is taken up for > > > active resolution, then a

[FFmpeg-devel] Re: [PATCH] avformat/whip: Drop invalid group:BUNDLE from SDP in single-stream cases

2025-10-18 Thread Jack Lau via ffmpeg-devel
> On Oct 6, 2025, at 16:06, baigao via ffmpeg-devel > wrote: > > --- > libavformat/whip.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 472c6dbf16..6ace9240f9 100644 > --- a/libavfor

[FFmpeg-devel] Re: [POLL] [VOTE] code.ffmpeg.org vs. ML

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi On Tue, Sep 16, 2025 at 10:49:00AM +0200, Michael Niedermayer via ffmpeg-devel wrote: > Hi all > > 2 months ago we voted on testing Forgejo vs Gitlab, we picked and tested > Forgejo. And as said in that vote, (and surprisingly, i have not forgotten it) > heres the "after

[FFmpeg-devel] Re: [POLL][VOTE] Sponsors & Funding

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Ronald On Sat, Oct 11, 2025 at 05:05:44PM -0400, Ronald S. Bultje via ffmpeg-devel wrote: > Hi Michael, > > On Thu, Oct 9, 2025 at 11:01 AM Michael Niedermayer via ffmpeg-devel < > [email protected]> wrote: > > > The number of people voting was a bit disapp

[FFmpeg-devel] trac ticket statistics Was: Re: Re: [RFC] Issue tracker

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Gyan On Tue, Sep 16, 2025 at 10:09:14AM +0530, Gyan Doshi via ffmpeg-devel wrote: > > > On 2025-09-16 03:16 am, Michael Niedermayer via ffmpeg-devel wrote: [...] > > And what do we gain by avoiding "wholesale migration" ? > > Added bloat of thousands of dorm

[FFmpeg-devel] Re: [RFC] FFlabs Sponsor

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Devin On Fri, Oct 10, 2025 at 10:07:16AM -0400, Devin Heitmueller via ffmpeg-devel wrote: > On Fri, Oct 10, 2025 at 10:03 AM Kieran Kunhya via ffmpeg-devel > wrote: > > Posts about the business operations of FFlabs, a private company, are > > off-topic on this mailing li

[FFmpeg-devel] Re: [PATCH] WIP: avfilter: add Bungee audio stretch filter (PR #20697)

2025-10-18 Thread Nicolas George via ffmpeg-devel
kupix via ffmpeg-devel (HE12025-10-13): > This adds an audio filter using the > [Bungee](https://github.com/bungee-audio-stretch/bungee) open source > audio timescale manipulation library. It also adds support for the > proprietary "Bungee Pro" variant. Hi. Thanks for

[FFmpeg-devel] Re: [RFC] Issue tracker

2025-10-18 Thread Jacob Lifshay via ffmpeg-devel
On September 28, 2025 2:18:40 AM PDT, Michael Niedermayer via ffmpeg-devel wrote: > On Sun, Sep 28, 2025 at 10:54:14AM +0300, Rémi Denis-Courmont via > ffmpeg-devel wrote: > > Otherwise, I don't really see any benefit to Trac. Forgejo would allow us > > to >

[FFmpeg-devel] Re: [POLL][VOTE] Sponsors & Funding

2025-10-18 Thread Kieran Kunhya via ffmpeg-devel
since a deranged email on this mailing list: 0 Kieran _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [PATCH] avfilter: add avfilter_forward_command API for recursive command processing. (PR #20621)

2025-10-18 Thread Nicolas George via ffmpeg-devel
cenzhanquan1 via ffmpeg-devel (HE12025-09-28): > PR #20621 opened by cenzhanquan1 > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20621 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20621.patch > > This commit introduces a new API that allows commands to be recursiv

[FFmpeg-devel] [PATCH] movenc: Check for more options incompatible with hybrid_fragmented (PR #20651)

2025-10-18 Thread Martin Storsjö via ffmpeg-devel
"with faststart, delay_moov and moov_size.\n"); return AVERROR(EINVAL); } -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Soliciting sponsorship (was: WIP: avfilter: add Bungee audio stretch filter (PR #20697))

2025-10-18 Thread Nicolas George via ffmpeg-devel
we considered accepting, it should not be as an extra filter with its own set of options. It should be as a single filter with an option to choose the implementation but common options for the shared features. Regards, -- Nicolas George _______ ffmpeg-devel

[FFmpeg-devel] Re: [RFC] Funded Task Ideas

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Nicolas, Kieran On Wed, Oct 15, 2025 at 10:31:35AM +0200, Nicolas George via ffmpeg-devel wrote: > Kieran Kunhya via ffmpeg-devel (HE12025-10-15): > > FFmpeg should move to an LTS and development version like Ubuntu. > > > > Then companies can pay for older versions

[FFmpeg-devel] Re: [PATCH] WIP: avfilter: add Bungee audio stretch filter (PR #20697)

2025-10-18 Thread Kieran Kunhya via ffmpeg-devel
On Mon, 13 Oct 2025, 09:27 Nicolas George via ffmpeg-devel, < [email protected]> wrote: > kupix via ffmpeg-devel (HE12025-10-13): > > This adds an audio filter using the > > [Bungee](https://github.com/bungee-audio-stretch/bungee) open source > > audio timesca

[FFmpeg-devel] Re: Soliciting sponsorship (was: WIP: avfilter: add Bungee audio stretch filter (PR #20697))

2025-10-18 Thread Kieran Kunhya via ffmpeg-devel
On Tue, Oct 14, 2025 at 12:39 PM Zhao Zhili wrote: > > > > > On Oct 14, 2025, at 18:53, Kieran Kunhya via ffmpeg-devel > > wrote: > > > > On Tue, Oct 14, 2025 at 11:32 AM Nicolas George via ffmpeg-devel > > wrote: > >> > >> michaelni (

[FFmpeg-devel] [PATCH] libavutil/hwcontext_amf: Simplified blocking before frame submission (PR #20660)

2025-10-18 Thread Dmitrii Ovchinnikov via ffmpeg-devel
ntext_amf.h +++ b/libavutil/hwcontext_amf.h @@ -26,6 +26,7 @@ #include #include #include +#include "thread.h" /** * This struct is allocated as AVHWDeviceContext.hwctx @@ -38,6 +39,7 @@ typedef struct AVAMFDeviceContext { int64_t version; ///< version of AMF runtime AMFContext *context; AMF_MEMORY_TYPE memory_type; + AVMutex mutex; } AVAMFDeviceContext; enum AMF_SURFACE_FORMAT av_av_to_amf_format(enum AVPixelFormat fmt); -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] configure: add intial Windows platform install files for debug with .pdb symbols

2025-10-18 Thread Roger Johnson via ffmpeg-devel
m 644 $$< "$(LIBDIR)" @@ -119,6 +125,7 @@ uninstall-libs:: -$(RM) "$(SHLIBDIR)/$(SLIBNAME_WITH_MAJOR)" \ "$(SHLIBDIR)/$(SLIBNAME)"\ "$(SHLIBDIR)/$(SLIBNAME_WITH_VERSION)" + -$(RM) $(SLIB_INSTALL_EXTRA_S

[FFmpeg-devel] Re: [GASPP PATCH 1/2] Pass "-machine" options through to armasm

2025-10-18 Thread Martin Storsjö via ffmpeg-devel
--enable-shared build. Thanks - then I'll go ahead and apply these two patches on gas-preprocessor. // Martin ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [RFC] FFlabs Sponsor

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
alternatives. -- Abba Eban signature.asc Description: PGP signature ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [RFC] Funded Task Ideas

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
On Tue, Oct 14, 2025 at 04:40:06AM +0200, Michael Niedermayer via ffmpeg-devel wrote: > Hi Everyone > > As we are now looking for sponsors, we also should look for tasks to fund. > I suggest, we first do some brainstorming and make a list, and then figure > out which > tasks

[FFmpeg-devel] [PATCH] movenc: Fix two interactions between delay_moov and hybrid_fragmented (PR #20704)

2025-10-18 Thread Martin Storsjö via ffmpeg-devel
->mdat_size = avio_tell(pb) - mov->mdat_pos - 8; for (i = 0; i < mov->nb_tracks; i++) { MOVTrack *track = &mov->tracks[i]; -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [RFC] Funded Task Ideas

2025-10-18 Thread Kieran Kunhya via ffmpeg-devel
On Wed, 15 Oct 2025, 09:32 Nicolas George via ffmpeg-devel, < [email protected]> wrote: > Kieran Kunhya via ffmpeg-devel (HE12025-10-15): > > FFmpeg should move to an LTS and development version like Ubuntu. > > > > Then companies can pay for older versions to

[FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: use macros to set QP range and max frame size (PR #20666)

2025-10-18 Thread Tong Wu via ffmpeg-devel
G_ENABLE_QP_RANGE; -} - -if (ctx->max_frame_size > 0) { -qvbr_ctl->MaxFrameBitSize = ctx->max_frame_size * 8; -ctx->rc.Flags |= D3D12_VIDEO_ENCODER_RATE_CONTROL_FLAG_ENABLE_MAX_FRAME_SIZE; -} +SET_QP_RANGE(qvbr_ctl); + SET_MAX_FRAME_SIZE

[FFmpeg-devel] Re: New mailing-list archive

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
HI Nicolas On Thu, Oct 16, 2025 at 01:56:59PM +0200, Nicolas George via ffmpeg-devel wrote: > Michael Niedermayer via ffmpeg-devel (HE12025-10-13): > > theres also: > > https://lists.ffmpeg.org/lore/ffmpeg-devel/ > > This is a lot better. I do not find how to get a threaded

[FFmpeg-devel] [PATCH] tests/checkasm: add a test for dcadsp (PR #20646)

2025-10-18 Thread James Almer via ffmpeg-devel
asm-exrdsp\ fate-checkasm-fdctdsp \ -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [PATCH] libavcodec/g723_1enc: Fix crash

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi On Fri, Oct 03, 2025 at 03:49:36PM +, Kovacs, Zsolt via ffmpeg-devel wrote: > Hi All, > > We had crashes in prod while compressing audio with G.723.1 using ffmpeg as a > library. The callstack was: > > fcb_search, line 1027 > ff_encode_encode_cb, line 253 > enco

[FFmpeg-devel] Re: Soliciting sponsorship (was: WIP: avfilter: add Bungee audio stretch filter (PR #20697))

2025-10-18 Thread Zhao Zhili via ffmpeg-devel
> On Oct 14, 2025, at 18:53, Kieran Kunhya via ffmpeg-devel > wrote: > > On Tue, Oct 14, 2025 at 11:32 AM Nicolas George via ffmpeg-devel > wrote: >> >> michaelni (HE12025-10-13): >>> Also you would have to convince the community, that we want this. iam

[FFmpeg-devel] Re: [PATCH 01/10] libavcodec/cbs_apv_syntax_template: limit tile to 2gb

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri signature.asc Description: PGP signature _______________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] ffv1enc_vulkan: fix empty struct build error on msvc

2025-10-17 Thread Koushik Dutta via ffmpeg-devel
gb) { -- 2.50.1 (Apple Git-155) _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] Fix for `apad` output getting stuck issue (PR #20600)

2025-10-17 Thread Niklas Haas via ffmpeg-devel
44, 44,1, 230400, 0x5891ab1c +0, 45, 45,1, 230400, 0x2dcfe2d0 +0, 46, 46,1, 230400, 0x2b86236a +0, 47, 47,1, 230400, 0xea3a5e63 +0, 48, 48, 1, 230400, 0x8748993d +0, 49,

[FFmpeg-devel] [PATCH] configure: Check for the AArch64 CRC extension (PR #20682)

2025-10-17 Thread Martin Storsjö via ffmpeg-devel
+#define DISABLE_CRC .arch_extension nocrc +#else +#define ENABLE_CRC +#define DISABLE_CRC +#endif + #if HAVE_AS_ARCHEXT_DOTPROD_DIRECTIVE #define ENABLE_DOTPROD .arch_extension dotprod #define DISABLE_DOTPROD .arch_extension nodotprod @@ -72,6 +80,7 @@ #define DISABLE_SVE2 #endif +DISABLE_CRC DISABLE_DOTPROD DISABLE_I8MM DISABLE_SVE -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avutil/csp: correct gamma approximation to match BT.1886 EOTF (PR #20690)

2025-10-17 Thread Kacper Michajłow via ffmpeg-devel
] = 2.4, +[AVCOL_TRC_BT1361_ECG] = 2.4, +[AVCOL_TRC_BT2020_10] = 2.4, +[AVCOL_TRC_BT2020_12] = 2.4, [AVCOL_TRC_GAMMA22] = 2.2, [AVCOL_TRC_IEC61966_2_1] = 2.2, [AVCOL_TRC_GAMMA28] = 2.8, -- 2.49.1 ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] configure: add intial Windows platform install files for debug with .pdb symbols

2025-10-17 Thread Roger Johnson via ffmpeg-devel
_WITH_VERSION)" + -$(RM) $(SLIB_INSTALL_EXTRA_SYM:%="$(SHLIBDIR)/%") -$(RM) $(SLIB_INSTALL_EXTRA_SHLIB:%="$(SHLIBDIR)/%") -$(RM) $(SLIB_INSTALL_EXTRA_LIB:%="$(LIBDIR)/%") -$(RM) "$(LIBDIR)/$(LIBNAME)" -- 2.51.0.windows.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] movenc: Make the hybrid_fragmented mode more robust (PR #20652)

2025-10-17 Thread Martin Storsjö via ffmpeg-devel
return res; } -- 2.49.1 ___________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avfilter/vf_scale: don't atempt to rescale AV_NOPTS_VALUE (PR #20603)

2025-10-17 Thread James Almer via ffmpeg-devel
= av_rescale_q(fs->pts, fs->time_base, outlink->time_base); +out->pts = fs->pts == AV_NOPTS_VALUE ? fs->pts : av_rescale_q(fs->pts, fs->time_base, outlink->time_base); return ff_filter_frame(outlink, out); err: -- 2.49.1 _________

[FFmpeg-devel] Re: [DISCUSSION] Adding ARM64EC support to FFmpeg

2025-10-17 Thread Martin Storsjö via ffmpeg-devel
time. Also, don't top post. // Martin _______________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avutil/crc: add arm64 crc32 asm (PR #20654)

2025-10-17 Thread Zhao Zhili via ffmpeg-devel
case CRC32: { +int err = av_crc_get(AV_CRC_32_IEEE_LE, &res->crcctx); +if (err < 0) { + av_free(res); + return err; +} +} +break; case ADLER32: break; } if (i != ADLER32 && i != CRC32 && !res->ctx) { @@ -185,7 +192,7 @@ void av_hash_update(AVHashContext *ctx, const uint8_t *src, size_t len) case SHA512_256: case SHA384: case SHA512: av_sha512_update(ctx->ctx, src, len); break; -case CRC32: ctx->crc = av_crc(ctx->crctab, ctx->crc, src, len); break; +case CRC32: ctx->crc = av_crc2(&ctx->crcctx, ctx->crc, src, len); break; case ADLER32: ctx->crc = av_adler32_update(ctx->crc, src, len); break; } } -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: New mailing-list archive

2025-10-13 Thread Michael Niedermayer via ffmpeg-devel
Hi Nicolas On Mon, Oct 13, 2025 at 11:09:20AM +0200, Nicolas George via ffmpeg-devel wrote: > Nicolas George via ffmpeg-devel (HE12025-10-13): > > Thanks. It sucks a little less than the first impression. But it still > > sucks. The fact that it defaults to a non-monospace fon

[FFmpeg-devel] New mailing-list archive

2025-10-13 Thread Nicolas George via ffmpeg-devel
Hi. I just went to the new archive for this mailing-list. Is it just me or does it suck? I am looking at <https://lists.ffmpeg.org/archives/list/[email protected]/thread/OU7LIDH65GJLH7IXSU7TBUCEUNDBRNQW/> and I am not seeing any way to make a link to my own mail. Regards, -- N

[FFmpeg-devel] Re: New mailing-list archive

2025-10-13 Thread Nicolas George via ffmpeg-devel
Diederick C. Niehorster via ffmpeg-devel (HE12025-10-13): > The little chain icon in the lower right, next to the thumbs up and > thumbs down, generates: > https://lists.ffmpeg.org/archives/list/[email protected]/message/LHST53IEEVLV7ZFNAA3274N652WHRVA6/ Thanks. It sucks a little

[FFmpeg-devel] [PATCH] avcodec: make use of av_zero_extend() in a few modules (PR #20628)

2025-10-17 Thread James Almer via ffmpeg-devel
1] + get_vlc2(gb, tab, ATRAC9_SF_VLC_BITS, 1); -c->scalefactors[i] = val & ((1 << len) - 1); +c->scalefactors[i] = av_zero_extend(val, len); } for (int i = 0; i < unit_cnt; i++) -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [RFC] FFlabs Sponsor

2025-10-17 Thread Kieran Kunhya via ffmpeg-devel
On Fri, Oct 10, 2025 at 10:58 PM Michael Niedermayer via ffmpeg-devel wrote: > > Hi Everyone > > The FFmpeg community decided, that we should actively look for sponsors. > And to do that, i will use my influence as shareholder of FFlabs to: > > Authorize the use of excess

[FFmpeg-devel] Re: [REFUND-REQUEST] code.ffmpeg.org hosting cost

2025-10-17 Thread Stefano Sabatini via ffmpeg-devel
On Tue, Sep 16, 2025 at 12:41 AM Michael Niedermayer via ffmpeg-devel wrote: > > Hi Timo > > On Mon, Sep 15, 2025 at 10:20:30PM +0200, Timo Rothenpieler via ffmpeg-devel > wrote: > > These are the hosting costs for code.ffmpeg.org so far: > > > > Each months b

[FFmpeg-devel] Re: Soliciting sponsorship (was: WIP: avfilter: add Bungee audio stretch filter (PR #20697))

2025-10-17 Thread Kieran Kunhya via ffmpeg-devel
On Tue, Oct 14, 2025 at 11:32 AM Nicolas George via ffmpeg-devel wrote: > > michaelni (HE12025-10-13): > > Also you would have to convince the community, that we want this. iam > > not sure how the community would think about it, but for example you > > could offer to don

[FFmpeg-devel] [PATCH] avcodec/libdav1d: bump minimum supported version to 1.0.0 (PR #20625)

2025-10-17 Thread James Almer via ffmpeg-devel
delay", OFFSET(max_frame_delay), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, DAV1D_MAX_FRAME_DELAY, VD }, { "filmgrain", "Apply Film Grain", OFFSET(apply_grain), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, VD | AV_OPT_FLAG_DEPRECATED }, { "oppoint", "Select an operating point of the scalable bitstream", OFFSET(operating_point), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 31, VD }, -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [PATCH] swscale/output: Fix unsigned cast position in yuv2* (PR #20698)

2025-10-17 Thread Michael Niedermayer via ffmpeg-devel
On Mon, Oct 13, 2025 at 05:20:55PM +0100, Kieran Kunhya via ffmpeg-devel wrote: > On Mon, 13 Oct 2025, 14:28 michaelni via ffmpeg-devel, < > [email protected]> wrote: > > > PR #20698 opened by michaelni > > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls

[FFmpeg-devel] [PATCH] avformat/mov: fix missing video size when some decoders are disabled (PR #20669)

2025-10-17 Thread Zhao Zhili via ffmpeg-devel
t->codecpar->codec_id == AV_CODEC_ID_MP3 -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [PATCH] avutil/crc: add arm64 crc32 asm (PR #20654)

2025-10-18 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Oct 6, 2025 at 10:31 PM Zhao Zhili via ffmpeg-devel wrote: > > PR #20654 opened by Zhao Zhili (quink) > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20654 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20654.patch > > > >From ab6fd7a273b88080e878c0c6

[FFmpeg-devel] [PATCH] fate-recv.sh: count warnings also in test.log

2025-10-18 Thread Kacper Michajłow via ffmpeg-devel
t;/dev/null | wc -l) echo "stats:$ntest:$npass:$nwarn" >>summary -- 2.50.1 ___________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avformat/rtsp: set AVFMTCTX_UNSEEKABLE flag (PR #20598)

2025-09-24 Thread Kaarle Ritvanen via ffmpeg-devel
x_flags |= AVFMTCTX_UNSEEKABLE; + return 0; } #endif /* CONFIG_RTPDEC */ -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avformat/movenc_ttml: fix memleaks (PR #20586)

2025-09-23 Thread Zhao Zhili via ffmpeg-devel
t, pkt)) { ret = avpriv_packet_list_put(&track->squashed_packet_queue, pkt, av_packet_ref, -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [RFC] dormant tickets

2025-09-23 Thread Michael Niedermayer via ffmpeg-devel
the very wise cannot see all ends. -- Gandalf signature.asc Description: PGP signature ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] Few MSVC warnings fixes (PR #20619)

2025-09-26 Thread Kacper Michajłow via ffmpeg-devel
ptrdiff_t line_size); -void ff_put_signed_pixels_clamped_sse2(const int16_t *block, uint8_t *pixels, +void ff_put_signed_pixels_clamped_sse2(const int16_t *block, uint8_t *restrict pixels, ptrdiff_t line_size); -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] configure: suppress C4267 warnings from MSVC (PR #20607)

2025-09-25 Thread Kacper Michajłow via ffmpeg-devel
-wd4554 -wd4267 ;; -Wextra) echo -W4 -wd4244 -wd4127 -wd4018 -wd4389 \ -wd4146 -wd4057 -wd4204 -wd4706 -wd4305 \ -wd4152 -wd4324 -we4013 -wd4100 -wd4214 \ -- 2.49.1 ___

[FFmpeg-devel] [PATCH] forgejo/workflows: cache debug (PR #20609)

2025-09-25 Thread Kacper Michajłow via ffmpeg-devel
uses: actions/cache/save@v4 -- 2.49.1 ___________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] avutil/attributes: use standard attributes when they are available (PR #20608)

2025-09-25 Thread Kacper Michajłow via ffmpeg-devel
PR #20608 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20608 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20608.patch From 08b798dd52b743221bc3023fbff3db4fc8925156 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Thu, 25

[FFmpeg-devel] Re: [PATCH] Fix 3 bigsleep issues in exr (PR #20550)

2025-09-27 Thread Michael Niedermayer via ffmpeg-devel
On Thu, Sep 18, 2025 at 11:23:47PM -, michaelni via ffmpeg-devel wrote: > PR #20550 opened by michaelni > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20550 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20550.patch > > > >From 38d62a1a51a84e220b6dbeaefd9

[FFmpeg-devel] Re: trac ticket statistics Was: Re: Re: [RFC] Issue tracker

2025-09-27 Thread Michael Niedermayer via ffmpeg-devel
Hi Gyan On Wed, Sep 24, 2025 at 04:26:53PM +0530, Gyan Doshi via ffmpeg-devel wrote: > > > On 2025-09-24 03:20 am, Michael Niedermayer via ffmpeg-devel wrote: > > Hi Gyan > > > > On Tue, Sep 16, 2025 at 10:09:14AM +0530, Gyan Doshi via ffmpeg-devel wrote: > >

[FFmpeg-devel] [PATCH] avcodec/exif: avoid printing errors for makernote non-IFD parsing (PR #20604)

2025-09-24 Thread Leo Izen via ffmpeg-devel
nit(&gb, buf, size); -ret = exif_parse_ifd_list(logctx, &gb, le, depth, &ifd); +ret = exif_parse_ifd_list(logctx, &gb, le, depth, &ifd, 0); if (ret < 0) return ret; ret = av_exif_ifd_to_dict(logctx, &ifd, metadata); -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] configure: unbreak glslang build (PR #20622)

2025-09-28 Thread Gyan Doshi via ffmpeg-devel
ibgme libgme gme/gme.h gme_new_emu || require libgme gme/gme.h gme_new_emu -lgme -lstdc++; } enabled libgsm&& { for gsm_hdr in "gsm.h" "gsm/gsm.h"; do -- 2.49.1 _______ ffmpeg-devel maili

[FFmpeg-devel] Re: [RFC] Sponsors & Funding

2025-09-28 Thread Kieran Kunhya via ffmpeg-devel
ats MUCH more expensive. They get vote power but they have to pay in contributions to FFmpeg. Really if voting power is not proportional to effort by the developer then all kinds of problems arise. (as shown above) " Kieran ___________ ffmpeg-devel

[FFmpeg-devel] Re: [RFC] Sponsors & Funding

2025-09-28 Thread Michael Niedermayer via ffmpeg-devel
Hi Everyone On Tue, Sep 09, 2025 at 10:19:26AM +0200, Michael Niedermayer via ffmpeg-devel wrote: > Hi Everyone > > The subject of funding and sponsors came up a few times recently. > > I think FFmpeg needs a clear guideline on this matter. To avoid > confusion, to avoid di

[FFmpeg-devel] Re: [RFC] Funded Task Ideas

2025-10-18 Thread Timo Rothenpieler via ffmpeg-devel
On 14.10.2025 04:40, Michael Niedermayer via ffmpeg-devel wrote: Hi Everyone As we are now looking for sponsors, we also should look for tasks to fund. I suggest, we first do some brainstorming and make a list, and then figure out which tasks we want to sponsor (or maybe someone wants to do

[FFmpeg-devel] Re: Soliciting sponsorship (was: WIP: avfilter: add Bungee audio stretch filter (PR #20697))

2025-10-18 Thread Michael Niedermayer via ffmpeg-devel
Hi Nicolas On Tue, Oct 14, 2025 at 12:32:00PM +0200, Nicolas George via ffmpeg-devel wrote: [...] > Hi. I procrastinated replying about soliciting sponsorships, but if it > looks like that I cannot anymore. Also, it must not be discussed in the > dark of an obscure pull request, it ne

[FFmpeg-devel] [PATCH] doc: indicate libmpeghdec is non-free (PR #20630)

2025-10-18 Thread Gyan Doshi via ffmpeg-devel
ree} to configure to enable it. @subsection LC3 library -- 2.49.1 ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] ffmpeg: unbreak max_error_rate application (PR #20724)

2025-10-20 Thread Gyan Doshi via ffmpeg-devel
0.f; if (err_rate > max_error_rate) { av_log(dp, AV_LOG_FATAL, "Decode error rate %g exceeds maximum %g\n", err_rate, max_error_rate); -- 2.49.1 ___________ ffmpeg-devel mailing list -- [email protected]

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: actually limit number of queues (PR #20725)

2025-10-20 Thread Niklas Haas via ffmpeg-devel
_multiplane; if (!p->disable_multiplane) { -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Support merging HEIF tiled images automatically (PR #20727)

2025-10-20 Thread James Almer via ffmpeg-devel
PR #20727 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20727 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20727.patch >From a7d280cec74796ebd6581ad263202e4526b32e3c Mon Sep 17 00:00:00 2001 From: James Almer Date: Sat, 18 Oct 2025 20:07:15 -0300 Subj

[FFmpeg-devel] [POLL][VOTE] Preferred Issue Tracker

2025-10-20 Thread Michael Niedermayer via ffmpeg-devel
Hi everyone We currently have 2 issue trackers (trac and forgejo), Previous discussion: "[RFC] Issue tracker" and "trac ticket statistics" https://lists.ffmpeg.org/archives/list/[email protected]/thread/HS46O6K62MHRHJDJC45XLRMR64RE5IB7/#LMXCTJDF5SIUSX43X7YZ4347U5YHWW33

[FFmpeg-devel] Re: [POLL][VOTE] Preferred Issue Tracker

2025-10-20 Thread Timo Rothenpieler via ffmpeg-devel
On 20.10.2025 18:14, Michael Niedermayer via ffmpeg-devel wrote: Hi everyone We currently have 2 issue trackers (trac and forgejo), Previous discussion: "[RFC] Issue tracker" and "trac ticket statistics" https://lists.ffmpeg.org/archives/list/ffmpeg-dev

[FFmpeg-devel] [PATCH] avcodec/vvc: fix false alarm of missing ref on RASL (PR #20729)

2025-10-20 Thread Zhao Zhili via ffmpeg-devel
& AV_CODEC_FLAG_OUTPUT_CORRUPT) && -- 2.49.1 _______ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] Re: [RFC] C++

2025-10-21 Thread Niklas Haas via ffmpeg-devel
On Mon, 20 Oct 2025 19:50:33 +0200 Tomas Härdin via ffmpeg-devel wrote: > Hi > > I'm writing this email to get a feel for how everyone feels about > making more use of C++ in the codebase. I am only proposing using C++ > *internally*, and only where it makes sense. I am not

[FFmpeg-devel] Re: libtheora maintainer ?

2025-10-21 Thread Tristan Matthews via ffmpeg-devel
ary is still maintained (albeit at a slow pace), the last release was 6 months ago. Best, Tristan ___ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]

[FFmpeg-devel] [RFC] C++

2025-10-20 Thread Tomas Härdin via ffmpeg-devel
Hi I'm writing this email to get a feel for how everyone feels about making more use of C++ in the codebase. I am only proposing using C++ *internally*, and only where it makes sense. I am not suggesting a "move" to C++, merely using features already present in the compilers we target: gcc, clang

[FFmpeg-devel] Re: [POLL][VOTE] Preferred Issue Tracker

2025-10-20 Thread Michael Niedermayer via ffmpeg-devel
Hi Timo On Mon, Oct 20, 2025 at 06:41:17PM +0200, Timo Rothenpieler via ffmpeg-devel wrote: > On 20.10.2025 18:14, Michael Niedermayer via ffmpeg-devel wrote: > > Hi everyone > > > > We currently have 2 issue trackers (trac and forgejo), > > > > Previous dis

Re: [FFmpeg-devel] FFmpeg 8.0 Release

2025-08-21 Thread Kacper Michajlow via ffmpeg-devel
On Tue, 19 Aug 2025 at 23:13, Michael Niedermayer via ffmpeg-devel wrote: > > Hi all > > On Fri, Aug 01, 2025 at 06:16:18PM -0500, Romain Beauxis wrote: > > Le mer. 23 juil. 2025 à 06:43, Michael Niedermayer > > a écrit : > > > > > > Hi everyone >

Re: [FFmpeg-devel] [POLL][RFC] Merge vs Cherry pick for integration of changes

2025-08-21 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 21 Aug 2025, 01:32 Michael Niedermayer via ffmpeg-devel, < [email protected]> wrote: > Hi > > Should we use a Merge or Cherry picks for integrating Pauls work ? > > Following are 2 plans, as we execute either we may run into issues > and of course adapt

Re: [FFmpeg-devel] [PATCH] swscale: Disable avx2 hscale 8to15 on IceLake and below due to Intel Gather Data Sampling mitigation performance loss

2025-08-21 Thread Alan Kelly via ffmpeg-devel
.0 ( 1.00x) > hscale_8_to_15__fs_4_dstW_512_sse2:287.9 ( 6.39x) > hscale_8_to_15__fs_4_dstW_512_ssse3: 293.8 ( 6.26x) > hscale_8_to_15__fs_4_dstW_512_avx2:219.2 ( 8.40x) > > > Hi, Are there any objections to the patch? The performance impact is huge, so it should be patched quickly. Thanks, Alan ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter/setpts: also preserve duration when not stripping fps (PR #20304)

2025-08-21 Thread Niklas Haas via ffmpeg-devel
RId64" PTS:%s T:%f", -- 2.49.1 _______________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: add bwdif option (PR #20303)

2025-08-21 Thread Niklas Haas via ffmpeg-devel
i64 = PL_DEINTERLACE_BWDIF}, 0, 0, STATIC, .unit = "deinterlace" }, +#endif { "skip_spatial_check", "Skip yadif spatial check", OFFSET(skip_spatial_check), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, DYNAMIC }, { "send_fields", "Output a frame for each fie

[FFmpeg-devel] [POLL][RFC] Merge vs Cherry pick for integration of changes

2025-08-21 Thread Michael Niedermayer via ffmpeg-devel
ot; and details about what you want to say/discuss. thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some Animals are More Equal Than Others. - George Orwell's book Animal Farm signature.asc Description: PGP signature __________

[FFmpeg-devel] [PATCH] WIP: avcodec/sanm: blubb-1 (PR #20307)

2025-08-21 Thread Manuel Lauss via ffmpeg-devel
ored_frame) = size; -bytestream2_get_bufferu(&ctx->gb, ctx->stored_frame + 4, size); + bytestream2_get_bufferu(&ctx->gb, ctx->stored_frame, size); bytestream2_seek(&ctx->gb, pos2, SEEK_

Re: [FFmpeg-devel] CI

2025-08-21 Thread Michael Niedermayer via ffmpeg-devel
Hi On Thu, Aug 21, 2025 at 06:03:12PM +0200, Kacper Michajlow via ffmpeg-devel wrote: [...] > Also on the topic of CI, I suspect we might add more jobs as needed. > Probably depends on priorities, to not overload existing runners > capacity. > > I was wondering about integratin

Re: [FFmpeg-devel] CI

2025-08-21 Thread Michael Niedermayer via ffmpeg-devel
Hi On Thu, Aug 21, 2025 at 12:31:46AM +0200, Timo Rothenpieler via ffmpeg-devel wrote: > On 8/20/2025 9:25 PM, Michael Niedermayer via ffmpeg-devel wrote: > > Hi > > > > On Wed, Aug 20, 2025 at 05:56:27PM +0200, Timo Rothenpieler via > > ffmpeg-devel wrote: > >

Re: [FFmpeg-devel] [POLL][RFC] Merge vs Cherry pick for integration of changes

2025-08-21 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 21 Aug 2025, 07:53 Michael Niedermayer via ffmpeg-devel, < [email protected]> wrote: > Hi Kieran > > On Thu, Aug 21, 2025 at 06:56:14AM -1000, Kieran Kunhya via ffmpeg-devel > wrote: > [...] > > For the record, Paul had a note saying changes are under G

Re: [FFmpeg-devel] [POLL][RFC] Merge vs Cherry pick for integration of changes

2025-08-21 Thread Michael Niedermayer via ffmpeg-devel
Hi Kieran On Thu, Aug 21, 2025 at 06:56:14AM -1000, Kieran Kunhya via ffmpeg-devel wrote: [...] > For the record, Paul had a note saying changes are under GPL. As I > understand you are ignoring legal advice saying this is a valid statement. > > Can you confirm the legal advice yo

[FFmpeg-devel] [PATCH] avcodec/atrac3: fix inconsistent band num calculation (PR #20308)

2025-08-21 Thread Daniil Cherednik via ffmpeg-devel
pcm FATE_ATRAC3 += fate-atrac3-3 fate-atrac3-3: CMD = pcm -i $(TARGET_SAMPLES)/atrac3/mc_sich_at3_132_small.wav -- 2.49.1 _______ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Add an option to clamp trc LUT output

2025-08-21 Thread Michael Niedermayer via ffmpeg-devel
On Tue, Aug 19, 2025 at 02:17:05PM +, Drew Dunne via ffmpeg-devel wrote: [...] > @@ -1000,6 +1005,11 @@ static const AVOption colorspace_options[] = { > ENUM("vonkries", WP_ADAPT_VON_KRIES, "wpadapt"), > ENUM("identity", WP_ADAPT_IDENT

[FFmpeg-devel] [PATCH] AVCodec documentation style improvements (PR #20312)

2025-08-21 Thread Marvin Scholz via ffmpeg-devel
const struct AVCodecParameters *par); -- 2.49.1 ___________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

Re: [FFmpeg-devel] Would it be possible to load xattr-related media-files like a container?

2025-08-21 Thread Peter B. via ffmpeg-devel
__ ffmpeg-user mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-user To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe". OpenPGP_0xE429ADDBF0F47726.asc Descript

[FFmpeg-devel] [PATCH] [8.0] avformat/hlsproto: explicitly deprecate it (PR #20311)

2025-08-21 Thread Marvin Scholz via ffmpeg-devel
"To use the demuxer, simply use %s as url.\n", s->playlisturl); if ((ret = parse_playlist(h, s->playlisturl)) < 0) -- 2.49.1 ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-de

[FFmpeg-devel] [PATCH] avcodec/hevc_metadata_bsf: add HDR SEI message support

2025-08-21 Thread Miklos Juhasz via ffmpeg-devel
offsetof(H265MetadataContext, x) @@ -574,6 +731,11 @@ static const AVOption h265_metadata_options[] = { { LEVEL("8.5", 255) }, #undef LEVEL +{ "master_display", "Set mastering display colour volume SEI (G(x,y)B(x,y)R(x,y)WP(x,y)L(max,min))", + OFFSET(master_display), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS }, +{ "max_cll", "Set content light level info SEI (MaxCLL,MaxFALL)", + OFFSET(max_cll), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS }, + { NULL } }; -- 2.39.5 (Apple Git-154) ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Announce FFmpeg 8.0

2025-08-21 Thread Frank Plowman via ffmpeg-devel
On 21/08/2025 06:47, Lynne via ffmpeg-devel wrote: > --- > src/index | 42 ++ > 1 file changed, 42 insertions(+) > > diff --git a/src/index b/src/index > index 52829e1..a07f4b8 100644 > --- a/src/index > +++ b/src/index > @@

[FFmpeg-devel] [PATCH] avformat: remove HLS protocol (PR #20310)

2025-08-21 Thread Marvin Scholz via ffmpeg-devel
_protocol = { -.name = "hls", -.url_open = hls_open, -.url_read = hls_read, - .url_close = hls_close, -.flags = URL_PROTOCOL_FLAG_NESTED_SCHEME, -.priv_data_size = sizeof(HLSContext), -}; diff --git a/libavformat/protocols.c b/libavformat/protocols.c index d394454d41..207b6bf8d9 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocols.c @@ -39,7 +39,6 @@ extern const URLProtocol ff_file_protocol; extern const URLProtocol ff_ftp_protocol; extern const URLProtocol ff_gopher_protocol; extern const URLProtocol ff_gophers_protocol; -extern const URLProtocol ff_hls_protocol; extern const URLProtocol ff_http_protocol; extern const URLProtocol ff_httpproxy_protocol; extern const URLProtocol ff_https_protocol; -- 2.49.1 ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

Re: [FFmpeg-devel] CI

2025-08-21 Thread Kacper Michajlow via ffmpeg-devel
On Thu, 21 Aug 2025 at 00:32, Timo Rothenpieler via ffmpeg-devel wrote: > > On 8/20/2025 9:25 PM, Michael Niedermayer via ffmpeg-devel wrote: > > Hi > > > > On Wed, Aug 20, 2025 at 05:56:27PM +0200, Timo Rothenpieler via > > ffmpeg-devel wrote: > >> On 8/2

[FFmpeg-devel] [PATCH] checkasm/vf_colordetect: test non-aligned width (PR #20301)

2025-08-21 Thread Zhao Zhili via ffmpeg-devel
void check_range_detect(int depth) { -- 2.49.1 _______ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter/vf_colordetect: Reorder to avoid null pointer check (PR #20299)

2025-08-20 Thread Zhao Zhili via ffmpeg-devel
lpha16_full_c : ff_detect_alpha_full_c; -} else { -dsp->detect_alpha = depth > 8 ? ff_detect_alpha16_limited_c : ff_detect_alpha_limited_c; -} -} } static const AVFilterPad colordetect_inputs[] = { -- 2.49.1 _______________ ffmp

[FFmpeg-devel] [PATCH] avcodec/sanm: handle xpal cmd 0 (PR #20300)

2025-08-21 Thread Manuel Lauss via ffmpeg-devel
d == 2) { if (size < PALETTE_DELTA * 2 + 4) { av_log(ctx->avctx, AV_LOG_ERROR, "Incorrect palette change block size %"PRIu32".\n", size); -- 2.49.1 _______ ffmpeg-devel mailing list [email protected]

<    21   22   23   24   25   26   27   28   29   30   >