Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

2019-12-04 Thread
se above SIMD code

Here may not be modified too.

Xu Jun

> 
> 
>>+xor sumd, sumd
>>+xor iq, iq
>>+.loopr_i:
>>+mov ciq, [ptrq + iq * gprsize]
>>+movzx rd, byte [ciq + c_offq]
>>+imul rd, [matrixq + 4*iq]
>>+add sumd, rd
>>+
>>+add iq, 1
>>+cmp iq, radq
>>+jl .loopr_i
>>+
>>+pxor m4, m4
>>+cvtsi2ss m4, sumd
>>+mulss m4, m0 ; sum *= rdiv
>>+addss m4, m1 ; sum += bias
>>+addss m4, m5 ; sum += 0.5
>>+cvttps2dq m4, m4
>>+packssdw m4, m4
>>+packuswb m4, m4
>>+movd sumd, m4
>>+mov [dstq + dst_offq], sumb
>>+add c_offq, 1
>>+add dst_offq, 1
>>+add off16q, 1
>>+cmp off16q, widthq
>>+jl .loopr
>>+
>>+.paraend:
>>+sub c_offq, widthq
>>+sub dst_offq, widthq
>>+add c_offq, strideq
>>+add dst_offq, dstrideq
>>+
>>+sub heightq, 1
>>+cmp heightq, 0
>>+jg .loopy
>>+
>>+.end:
>>+RET
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

-- 
敬颂钧安, 
徐鋆 
电子信息与电气工程学院 
上海交通大学 
邮箱:xuju...@sjtu.edu.cn 
地址:上海市闵行区东川路800号 

Yours sincerely, 
Xu Jun 
School of Electronic, Information and Electrical Engineering 
Shanghai Jiao Tong University 
Email: xuju...@sjtu.edu.cn 
No. 800, Dongchuan Road, Minhang District, Shanghai 200240, China 

宜しくお愿いたします 
徐鋆 
電子情報と電気工程学院 
上海交通大学 
メールアドレス :xuju...@sjtu.edu.cn 
住所:上海市閔行区ドンチュワンルー800号
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation for filter_column() to prepare for x86 SIMD.

2019-12-01 Thread
Hi, Steven

- 原始邮件 -
发件人: "Steven Liu" 
收件人: "FFmpeg development discussions and patches" 
抄送: "Steven Liu" 
发送时间: 星期一, 2019年 12 月 02日 上午 10:44:48
主题: Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation 
for filter_column() to prepare for x86 SIMD.

> 在 2019年12月2日,10:42,徐鋆  写道:
> 
> I'm sorry not to reply in time.
> 
> The performance of this C code is about 10% better than the existing C code.
> 
> It will have a bigger improvement after X86 SIMD optimizations.

1. How to test?
1. 怎么测试的?
1. どうやってテストしたの?

I tested using this command:

./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 
6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 
9:1/45:1/45:1/45:1/45:1:2:3:4:column:column:column:column" -an -vframes 2000 -f 
null /dev/null 

The FPS increases from 329 to 365 on my local machine.

2. Don’t TOP-Posting: https://en.wikipedia.org/wiki/Top-posting
2. 回邮件要在你回的那一条的下面回复,别再最上面回复,人家看不懂你是针对的哪一条
2. 返信メールは、あなたが返信した項目の下にある。一番上に返信しないと、あなたが何を狙っているのか分からない

Thank you for reminding me. I'm new here. Forgive me for not knowing the rules:)

> 
> Xu Jun
> 
> - 原始邮件 -
> 发件人: "Carl Eugen Hoyos" 
> 收件人: "FFmpeg development discussions and patches" 
> 发送时间: 星期四, 2019年 11 月 28日 上午 12:19:44
> 主题: Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column 
> operation for filter_column() to prepare for x86 SIMD.
> 
> Am Mi., 27. Nov. 2019 um 15:56 Uhr schrieb :
> 
>> From: Xu Jun 
>> 
>> In order to add x86 SIMD for filter_column(), I write a C function which 
>> processes 16 columns at a time.
> 
> How does this perform compared to the existing C code?
> 
> Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> -- 
> 敬颂钧安, 
> 徐鋆 
> 电子信息与电气工程学院 
> 上海交通大学 
> 邮箱:xuju...@sjtu.edu.cn 
> 地址:上海市闵行区东川路800号 
> 
> Yours sincerely, 
> Xylem(Jun Xu) 
> School of Electronic, Information and Electrical Engineering 
> Shanghai Jiao Tong University 
> Email: xuju...@sjtu.edu.cn 
> No. 800, Dongchuan Road, Minhang District, Shanghai 200240, China 
> 
> 宜しくお愿いたします 
> 徐鋆 
> 電子情報と電気工程学院 
> 上海交通大学 
> メールアドレス :xuju...@sjtu.edu.cn 
> 住所:上海市閔行区ドンチュワンルー800号
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Thanks
Steven





___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
-- 
敬颂钧安, 
徐鋆 
电子信息与电气工程学院 
上海交通大学 
邮箱:xuju...@sjtu.edu.cn 
地址:上海市闵行区东川路800号 

Yours sincerely, 
Xu Jun
School of Electronic, Information and Electrical Engineering 
Shanghai Jiao Tong University 
Email: xuju...@sjtu.edu.cn 
No. 800, Dongchuan Road, Minhang District, Shanghai 200240, China 

宜しくお愿いたします 
徐鋆 
電子情報と電気工程学院 
上海交通大学 
メールアドレス :xuju...@sjtu.edu.cn 
住所:上海市閔行区ドンチュワンルー800号
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation for filter_column() to prepare for x86 SIMD.

2019-12-01 Thread
I'm sorry not to reply in time.

The performance of this C code is about 10% better than the existing C code.

It will have a bigger improvement after X86 SIMD optimizations.

Xu Jun

- 原始邮件 -
发件人: "Carl Eugen Hoyos" 
收件人: "FFmpeg development discussions and patches" 
发送时间: 星期四, 2019年 11 月 28日 上午 12:19:44
主题: Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation 
for filter_column() to prepare for x86 SIMD.

Am Mi., 27. Nov. 2019 um 15:56 Uhr schrieb :

> From: Xu Jun 
>
> In order to add x86 SIMD for filter_column(), I write a C function which 
> processes 16 columns at a time.

How does this perform compared to the existing C code?

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
-- 
敬颂钧安, 
徐鋆 
电子信息与电气工程学院 
上海交通大学 
邮箱:xuju...@sjtu.edu.cn 
地址:上海市闵行区东川路800号 

Yours sincerely, 
Xylem(Jun Xu) 
School of Electronic, Information and Electrical Engineering 
Shanghai Jiao Tong University 
Email: xuju...@sjtu.edu.cn 
No. 800, Dongchuan Road, Minhang District, Shanghai 200240, China 

宜しくお愿いたします 
徐鋆 
電子情報と電気工程学院 
上海交通大学 
メールアドレス :xuju...@sjtu.edu.cn 
住所:上海市閔行区ドンチュワンルー800号
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".