[FFmpeg-devel] [PATCH] libavcodec/rscc.c: add missing semicolon

2019-01-31 Thread Mateusz
Signed-off-by: Mateusz Brzostek --- libavcodec/rscc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rscc.c b/libavcodec/rscc.c index e4b51973d8..7d4e842cd3 100644 --- a/libavcodec/rscc.c +++ b/libavcodec/rscc.c @@ -64,7 +64,7 @@ typedef struct RsccContext

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix dithers table for DITHER_COPY macro

2018-02-02 Thread Mateusz
W dniu 24.10.2017 o 10:02, Mateusz pisze: > The Bayer matrix 8x8 used in DITHER_COPY macro is table dithers[5]. > Remaining dithers[] matrixes are generated from this matrix by > downshift or upshift. > > This patch fixes dithers[6] and dithers[7] matrixes -- they were > too dar

[FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix packed_rgb case

2017-12-17 Thread Mateusz
Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> --- libavfilter/vf_overlay.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index a7d3906016..aa5835ae3a 100644 --- a/libavfilter/vf_ove

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
w patch in attach, with an add in fate/checkasm.mak My bad, sorry for misinformation. The old patch that broke fate was in fate, next wasn't and I checked only end of fate tests (I wrongly assume that it passes fate) but 32-bit VS 2017 hangs at 'fate-api-png-codec-param' and I saw that it was no vf_hfli

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
W dniu 11.12.2017 o 11:00, Martin Vignali pisze: > 2017-12-11 10:49 GMT+01:00 Mateusz <mateu...@poczta.onet.pl>: > >> W dniu 11.12.2017 o 00:51, Mateusz pisze: >>> W dniu 10.12.2017 o 21:13, Martin Vignali pisze: >>>>> >>>>> For me th

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
W dniu 11.12.2017 o 00:51, Mateusz pisze: > W dniu 10.12.2017 o 21:13, Martin Vignali pisze: >>> >>> For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c >>> >>> You pass start of the src buffer but you should pass end of the

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Mateusz
New patch in attach. Now it is OK in my system (mingw 32/64-bit, VS 2017 64-bit). Thanks! Mateusz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Mateusz
>flip_line[plane](inrow, outrow, width); and now at part from tests/checkasm/vf_hflip.c: call_ref(src, dst_ref, w); call_new(src, dst_new, w); For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c You pass start of the src buffer but you shou

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Mateusz
W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze: > Am 07.12.2017 20:40 schrieb "Mateusz" <mateu...@poczta.onet.pl>: > > W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: >> On Thu, Dec 7, 2017 at 2:02 AM, Mateusz <mateu...@poczta.onet.pl> wrote: >>>

[FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Mateusz
After commit 3701d49 'error_resilience: remove avpriv_atomic usage' we have included windows.h in much more files and we should avoid conflicts with defines/function declarations. Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> --- libavcodec/jpegls.h | 2 ++ libavcodec/mjpe

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-07 Thread Mateusz
W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze: > On Thu, Dec 7, 2017 at 2:02 AM, Mateusz <mateu...@poczta.onet.pl> wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> a

[FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-06 Thread Mateusz
in atomic_compare_exchange* macro. Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> --- libavcodec/jpegls.h | 2 ++ libavcodec/mjpegdec.h | 2 ++ libavcodec/mss2.c | 6 +++--- libavcodec/utils.c| 12 libavformat/mxfenc.c | 2 +- 5 files changed, 20 insertions(+), 4 del

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 12:12, Hendrik Leppkes pisze: > On Tue, Dec 5, 2017 at 12:31 AM, Mateusz <mateu...@poczta.onet.pl> wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LO

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 17:44, James Almer pisze: > On 12/5/2017 1:40 PM, Mateusz wrote: >> W dniu 05.12.2017 o 15:20, James Almer pisze: >>> On 12/4/2017 8:31 PM, Mateusz wrote: >>>> After some tests: >>>> 1) #undef far >>>> after #include is

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-05 Thread Mateusz
W dniu 05.12.2017 o 15:20, James Almer pisze: > On 12/4/2017 8:31 PM, Mateusz wrote: >> After some tests: >> 1) #undef far >> after #include is wrong -- in oleauto.h is declaration >> WINOLEAUTAPI VarUI1FromI8(LONG64 i64In, _Out_ BYTE FAR* pbOut); >> and 'FAR' is

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Mateusz
t) return 0; Mateusz W dniu 04.12.2017 o 20:27, Mateusz pisze: > W dniu 04.12.2017 o 15:02, Derek Buitenhuis pisze: >> On 12/4/2017 8:03 AM, Mateusz wrote: >>> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >>> we have included windo

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Mateusz
W dniu 04.12.2017 o 15:02, Derek Buitenhuis pisze: > On 12/4/2017 8:03 AM, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts with defines/function declarati

[FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-04 Thread Mateusz
After commit 3701d49 'error_resilience: remove avpriv_atomic usage' we have included windows.h in much more files and we should avoid conflicts with defines/function declarations. Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> --- libavcodec/jpegls.h | 4 libavcodec/

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-03 Thread Mateusz
W dniu 03.12.2017 o 22:26, Michael Niedermayer pisze: > On Sat, Dec 02, 2017 at 09:50:26PM +0100, Mateusz wrote: >> After commit 3701d49 'error_resilience: remove avpriv_atomic usage' >> we have included windows.h in much more files and we should >> avoid conflicts

[FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-02 Thread Mateusz
After commit 3701d49 'error_resilience: remove avpriv_atomic usage' we have included windows.h in much more files and we should avoid conflicts with defines/function declarations. Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> --- libavcodec/jpegls.h | 4 libavcodec/

Re: [FFmpeg-devel] configure: ERROR: x265 not found using pkg-config

2017-11-12 Thread Mateusz
Please apply patch https://patches.videolan.org/patch/18630/ to x265 and recheck. Mateusz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix dithers table for DITHER_COPY macro

2017-11-11 Thread Mateusz
W dniu 24.10.2017 o 10:02, Mateusz pisze: > The Bayer matrix 8x8 used in DITHER_COPY macro is table dithers[5]. > Remaining dithers[] matrixes are generated from this matrix by > downshift or upshift. > > This patch fixes dithers[6] and dithers[7] matrixes -- they were &g

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpeg: add gray9/10/12 support

2017-10-26 Thread Mateusz
W dniu 2017-10-07 o 21:41, Paul B Mahol pisze: > On 10/7/17, Mateusz <mateu...@poczta.onet.pl> wrote: >> Lately ffmpeg supports gray9/10/12 pixel formats. >> >> This patch adds gray9/10/12 pixel formats to y4m. >> >> It also moves gray16 to 'strict -1' sect

[FFmpeg-devel] [PATCH 1/2] swscale: fix dithers table for DITHER_COPY macro

2017-10-24 Thread Mateusz
The Bayer matrix 8x8 used in DITHER_COPY macro is table dithers[5]. Remaining dithers[] matrixes are generated from this matrix by downshift or upshift. This patch fixes dithers[6] and dithers[7] matrixes -- they were too dark. Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet

[FFmpeg-devel] [PATCH 2/2] swscale: use dithering in DITHER_COPY only if not set -sws_dither none

2017-10-24 Thread Mateusz
This patch uses dithering in DITHER_COPY macro only if it was not used option '-sws_dither none'. With option '-sws_dither none' it uses downshift. For human eye dithering is OK, for video codecs not necessarily. If user don't want to use dithering, we should respect that. Signed-off-by: Mateusz

Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-23 Thread Mateusz
W dniu 2017-10-20 o 20:07, Jan Ekstrom pisze: > On Fri, Oct 20, 2017 at 10:26 AM, Mateusz <mateu...@poczta.onet.pl> wrote: >> W dniu 2017-10-06 o 17:33, Mateusz pisze: >>> Fixed DITHER_COPY macro (only C code), updated FATE tests. >>> >>> PSNR in tests

Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-20 Thread Mateusz
W dniu 2017-10-06 o 17:33, Mateusz pisze: > Fixed DITHER_COPY macro (only C code), updated FATE tests. > > PSNR in tests that needed update goes from 50 to 999.99 -- the quality is > there. Ping. ___ ffmpeg-devel mailing list ffmpeg-deve

[FFmpeg-devel] [PATCH] avformat/yuv4mpeg: add gray9/10/12 support

2017-10-07 Thread Mateusz
Lately ffmpeg supports gray9/10/12 pixel formats. This patch adds gray9/10/12 pixel formats to y4m. It also moves gray16 to 'strict -1' section. Please review. Mateusz From f2b31ef66931e02a355e3140d47b17f0d307dec7 Mon Sep 17 00:00:00 2001 From: Mateusz <mateu...@poczta.onet.pl> Date:

[FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-06 Thread Mateusz
Fixed DITHER_COPY macro (only C code), updated FATE tests. PSNR in tests that needed update goes from 50 to 999.99 -- the quality is there. Please review. Mateusz From d870ba10aa4b3520fc30215fbbd57565faa13df4 Mon Sep 17 00:00:00 2001 From: Mateusz <mateu...@poczta.onet.pl> Date: Fri,

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Mateusz
indows 10. >> The resulted libraries link correctly to my application. >> > This would break the workflow for everyone that is currently working > with the current names, however. For gcc it breaks nothing (it still makes lib..

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-27 Thread Mateusz
W dniu 2017-09-26 o 13:31, Carl Eugen Hoyos pisze: > 2017-09-26 1:33 GMT+02:00 Mateusz <mateu...@poczta.onet.pl>: > >> I've sent C code patch 2017-09-06 (and nothing) so I thought that the >> problem is with speed. For simplicity I've attached this patch. > >

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-25 Thread Mateusz
W dniu 2017-09-25 o 22:53, Carl Eugen Hoyos pisze: > 2017-09-23 19:18 GMT+02:00 Mateusz <mateu...@poczta.onet.pl>: >> W dniu 2017-09-23 o 17:01, Michael Niedermayer pisze: >>> On Fri, Sep 22, 2017 at 02:10:01AM +0200, Mateusz wrote: >>>> To reduce bit depth

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-25 Thread Mateusz
W dniu 2017-09-25 o 01:42, Carl Eugen Hoyos pisze: > 2017-09-23 19:18 GMT+02:00 Mateusz <mateu...@poczta.onet.pl>: > >> In reality -- current version of DITHER_COPY mess >> up the average color tone. > > You could explain how we can reproduce this. Please take any

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-23 Thread Mateusz
W dniu 2017-09-23 o 17:01, Michael Niedermayer pisze: > On Fri, Sep 22, 2017 at 02:10:01AM +0200, Mateusz wrote: >> To reduce bit depth in planar YUV or gray pixel formats ffmpeg uses >> DITHER_COPY macro. >> Now it makes images greener and with visible dither pattern

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix and speed up DITHER_COPY macro for x86 with SSE2

2017-09-22 Thread Mateusz
W dniu 2017-09-22 o 17:47, James Almer pisze: > On 9/22/2017 12:23 PM, Mateusz wrote: >> New version of the patch -- now it uses the same logic independent of the >> target bitdepth. >> >> For x86_64 it is much faster than current code (with perfect quality), for >

[FFmpeg-devel] [PATCH] swscale_unscaled: fix and speed up DITHER_COPY macro for x86 with SSE2

2017-09-22 Thread Mateusz
lower than current code but with better quality) Please review/test. Mateusz From 8eaa76fc82550f62f1a22e9388a51dc61c031a2c Mon Sep 17 00:00:00 2001 From: Mateusz <mateu...@poczta.onet.pl> Date: Fri, 22 Sep 2017 14:54:53 +0200 Subject: [PATCH] swscale_unscaled: fix and speed up DITHER_CO

[FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-21 Thread Mateusz
ode faster (I don't see any Intel Intrinsics in ffmpeg so it's probably for testing only). Please review. Mateusz From a52417a3817ac774eb364bbef20c954a3d278d45 Mon Sep 17 00:00:00 2001 From: Mateusz <mateu...@poczta.onet.pl> Date: Fri, 22 Sep 2017 01:22:59 +0200 Subject: [PATCH] swscale

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-09-11 Thread Mateusz
W dniu 2017-09-06 o 09:27, Mateusz pisze: > W dniu 2017-09-06 o 02:07, Michael Niedermayer pisze: >> On Wed, Sep 06, 2017 at 01:25:45AM +0200, Mateusz wrote: >>> W dniu 2017-09-05 o 23:37, Michael Niedermayer pisze: >>>> On Tue, Sep 05, 2017 at 04:42:06PM +0200, Mateu

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-09-06 Thread Mateusz
W dniu 2017-09-06 o 02:07, Michael Niedermayer pisze: > On Wed, Sep 06, 2017 at 01:25:45AM +0200, Mateusz wrote: >> W dniu 2017-09-05 o 23:37, Michael Niedermayer pisze: >>> On Tue, Sep 05, 2017 at 04:42:06PM +0200, Mateusz wrote: >>>> W dniu 2017-09-05 o 15

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-09-05 Thread Mateusz
W dniu 2017-09-05 o 23:37, Michael Niedermayer pisze: > On Tue, Sep 05, 2017 at 04:42:06PM +0200, Mateusz wrote: >> W dniu 2017-09-05 o 15:40, Michael Niedermayer pisze: >>> On Mon, Sep 04, 2017 at 09:33:34AM +0200, Mateusz wrote: >>>> If ffmpeg reduces bit-d

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-09-05 Thread Mateusz
W dniu 2017-09-05 o 15:40, Michael Niedermayer pisze: > On Mon, Sep 04, 2017 at 09:33:34AM +0200, Mateusz wrote: >> If ffmpeg reduces bit-depth to 8-bit or more, it uses DITHER_COPY macro. >> The problem is DITHER_COPY macro make images darker (on all planes). >> >> In

[FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-09-04 Thread Mateusz
If ffmpeg reduces bit-depth to 8-bit or more, it uses DITHER_COPY macro. The problem is DITHER_COPY macro make images darker (on all planes). In x265 project there is issue #365 which is caused by this DITHER_COPY bug. I think it is time to fix -- there are more and more high bit-depth sources.

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-20 Thread Mateusz Brzostek
W dniu 2017-03-20 o 10:00, Carl Eugen Hoyos pisze: > 2017-03-15 22:52 GMT+01:00 Mateusz Brzostek <mate...@msystem.waw.pl>: >> Hello! >> >> There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: >> 1) there is overflow in dithering fr

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-20 Thread Mateusz Brzostek
In previous patch there was missing braces {} in for (; j < length; j++) loop. Please ignore that patch. New patch with braces and without FFMIN macro. Mateusz W dniu 2017-03-18 o 21:28, Mateusz Brzostek pisze: > W dniu 2017-03-16 o 19:17, Michael Niedermayer pisze: >> On Wed,

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-18 Thread Mateusz Brzostek
W dniu 2017-03-16 o 19:17, Michael Niedermayer pisze: > On Wed, Mar 15, 2017 at 10:52:29PM +0100, Mateusz Brzostek wrote: >> Hello! >> >> There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: >> 1) there is overflow in dithering from 12-

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-16 Thread Mateusz Brzostek
W dniu 2017-03-16 o 19:17, Michael Niedermayer pisze: > On Wed, Mar 15, 2017 at 10:52:29PM +0100, Mateusz Brzostek wrote: >> Hello! >> >> There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: >> 1) there is overflow in dithering from 12-

[FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-15 Thread Mateusz Brzostek
c_depth-dst_depth-1][i&7];\ For bugs 2) and 3) it is needed formula that do not make images darker (in attachment). So please review. Mateusz diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c index ba3d688..429c98c 100644 --- a/libswscale/swscale_unscaled.c +++ b