Re: [FFmpeg-devel] [PATCH v4] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-11 Thread Shivam Goyal
On 11-05-2019 04:27, Reimar Döffinger wrote: > On Thu, May 09, 2019 at 11:45:59PM +0530, Shivam Goyal wrote: > >> @@ -117,4 +120,128 @@ static int h264_probe(const AVProbeData *p) >> return 0; >> } >> >> +static const uint8_t arecont_sign[] = {0x2D, 0x2D, 0x

Re: [FFmpeg-devel] [PATCH v9] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-10 Thread Shivam Goyal
On 11-05-2019 03:21, Reimar Döffinger wrote: > On 10.05.2019, at 15:10, Shivam Goyal wrote: > >> -> Making two avio contexts and one calling the other ( I am not sure if >> i implemented it in the right way, but still i reached low level ). > > Can't you at

[FFmpeg-devel] [PATCH v9] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-10 Thread Shivam Goyal
there can be another approach ( i know this is an easy task but just due to those 0x400 bytes it is tricky ). Thank you, Shivam GoyalFrom b9dde21af273c8137df370399ade79c0c59a4046 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Fri, 10 May 2019 17:53:26 +0530 Subject: [PATCH] lavf/flv:

[FFmpeg-devel] [PATCH v4] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-09 Thread Shivam Goyal
s. also as the packet can contain partial header at the beginning and end of the pkt, i took extra size to read from the input stream Please review Thank You Shivam GoyalFrom deb859ff488c500b7e6005e350f04c200f2853a4 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Thu, 9 May 2019 23:18:13 +053

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-09 Thread Shivam Goyal
On 09-05-2019 15:00, Moritz Barsnick wrote: > On Thu, May 09, 2019 at 07:28:20 +0530, Shivam Goyal wrote: +//Extra to > find the http header > +size = 2 * ARECONT_H264_MIME_SIZE + RAW_PACKET_SIZE; > +data = av_malloc(size); > + > +if (av_new_pac

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Shivam Goyal
On 09-05-2019 02:16, Michael Niedermayer wrote: > On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote: > >> The patch is for ticket #5154. >> >> I have improved the patch as suggested. >> >> Please review. >> >>

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Shivam Goyal
On 09-05-2019 02:16, Michael Niedermayer wrote: > On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote: > >> The patch is for ticket #5154. >> >> I have improved the patch as suggested. >> >> Please review. >> >>

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Shivam Goyal
On 09-05-2019 01:15, Reimar Döffinger wrote: > On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote: > >> +static int arecont_h264_probe(const AVProbeData *p) >> +{ >> +int i, j, k, o = 0; >> +int ret = h264_probe(p); >> +const uint8_t

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Shivam Goyal
On 07-05-2019 10:05, Shivam Goyal wrote: > The patch is for ticket #5154. > > I have improved the patch as suggested. > > Please review. > > Thank you, > > Shivam Goyal Ping, Please review. Thank you Shivam Goyal _

[FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-06 Thread Shivam Goyal
The patch is for ticket #5154. I have improved the patch as suggested. Please review. Thank you, Shivam GoyalFrom 2aa843626f939218179d3ec252f76f9991c33ed6 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 7 May 2019 10:01:15 +0530 Subject: [PATCH] lavf/h264: Add support for h264

Re: [FFmpeg-devel] [PATCH v2] lavf/h264: Add support for raw h264 stream from Arecont camera, fixes ticket #5154

2019-05-04 Thread Shivam Goyal
On 04-05-2019 15:15, Hendrik Leppkes wrote: > On Sat, May 4, 2019 at 10:52 AM Shivam Goyal wrote: > >> The improved patch is for ticket #5154. >> >> Support for Raw h264 stream from Arecont Camera. >> >> Suggest any changes required.

[FFmpeg-devel] [PATCH v2] lavf/h264: Add support for raw h264 stream from Arecont camera, fixes ticket #5154

2019-05-04 Thread Shivam Goyal
The improved patch is for ticket #5154. Support for Raw h264 stream from Arecont Camera. Suggest any changes required. Shivam GoyalFrom c9e03c2460630686c6942b2078c64f82143d76f8 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Sat, 4 May 2019 14:04:36 +0530 Subject: [PATCH] lavf/h264: Add

[FFmpeg-devel] [PATCH] lavf/h264: Add support for raw h264 stream from Arecont camera, fixes ticket #5154

2019-05-04 Thread Shivam Goyal
The patch is for ticket #5154. https://trac.ffmpeg.org/ticket/5154 Suggest any changes required. Shivam GoyalFrom 8416b130d461da117ca2d0b64e805c8e9cbe675c Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Sat, 4 May 2019 12:46:39 +0530 Subject: [PATCH] lavf/h264: Add support for raw h264

[FFmpeg-devel] [PATCH v8] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-02 Thread Shivam Goyal
The patch fixes ticket #3720. Add Xunlei video support. Suggestions are appreciated. Thank you Shivam GoyalFrom 0f0d87b499c1e91bf2b6265a61e964c1a16da8de Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Thu, 2 May 2019 23:27:24 +0530 Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support

Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-05-02 Thread Shivam Goyal
ON_MINOR 27 >> +#define LIBAVFORMAT_VERSION_MINOR 28 >> #define LIBAVFORMAT_VERSION_MICRO 103 > > When bumping MINOR, you need to reset MICRO to 100. Would reset it to 100. Sending another patch with the documentation too. Thank you Shivam Goyal

[FFmpeg-devel] [PATCH v6] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. >From 605dc262abf948813c26d58f51d5e2d7f498d9cd Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 23:36:27 +0530 Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. --- Change

Re: [FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
On 09-04-2019 08:32 PM, Moritz Barsnick wrote: Some minor nitpicking remarks from me: Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720. Basically, the second sentence belongs into the body of the commit message, after a single empty line separator. (It may not matt

[FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-04-09 Thread Shivam Goyal
lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720 I have fixed the minor mistakes in the patch. I have also checked the patch with patcheck. >From a64698a11c10ec62968a5d853d7db0fed956c0d3 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 19:25:23 +0530 Subj

Re: [FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Shivam Goyal
On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote: 2019-04-09 11:36 GMT+02:00, Shivam Goyal : flv: Add XV (Xunlie Video) Support. Updated patch for ticket #3720. Above is an acceptable commit message, slightly better would be: " lavf/flv: Add XV (Xunlie Video) Support. Fixes ticket #3720

[FFmpeg-devel] [Patch v4] flv: Add XV (Xunlie Video) Support, Updated patch for ticket #3720

2019-04-09 Thread Shivam Goyal
flv: Add XV (Xunlie Video) Support. Updated patch for ticket #3720. >From 4e976186059b0fc41de7b65f538c352d264477d4 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 15:00:49 +0530 Subject: [PATCH] Updated patch for ticket #3720. flv: Add XV (Xunlei Video) supp

[FFmpeg-devel] [PATCH v3] Added XV Support

2019-04-08 Thread Shivam Goyal
Updated patch for ticket #3720 . I have tried to improve the patch as suggested. >From 8c4cd8cfc2b7b07cebbfefb96fc9bb9e92668385 Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Tue, 9 Apr 2019 02:01:17 +0530 Subject: [PATCH] Added XV Support v3 --- libavformat/Makefile |

[FFmpeg-devel] [PATCH v2] Added XV Support

2019-04-06 Thread Shivam Goyal
This time i modified the initial buffer at the time of reading header instead of changing the IO layer. Suggest any changes required. >From 277a4267f8cbb68c5fa57a0bddd215e04ca662bd Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Sun, 7 Apr 2019 12:13:21 +0530 Subject: [PATCH] Added

Re: [FFmpeg-devel] Added support for XV video files

2019-03-25 Thread Shivam Goyal
On 3/25/19 3:59 PM, Michael Niedermayer wrote: On Sun, Mar 24, 2019 at 04:35:40PM +0530, Shivam Goyal wrote: The attached patch is for ticket #3720     https://trac.ffmpeg.org/ticket/3720 I have tested this demuxer on the files 1.xv and 5.xv attached with the ticket http

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
On 3/25/19 4:47 AM, Moritz Barsnick wrote: On Sun, Mar 24, 2019 at 13:39:09 +0100, Moritz Barsnick wrote: Another thing: On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: libavformat/xvdec.c | 1395 ++ libavformat/xvtools.h| 95

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
On 3/24/19 6:09 PM, Moritz Barsnick wrote: On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: libavformat/xvdec.c | 1395 ++ libavformat/xvtools.h| 95 +++ This looks like a 90% copy of flvdec, with some modifications. I believe it

[FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
p 17 00:00:00 2001 From: Shivam Goyal Date: Sun, 24 Mar 2019 16:19:05 +0530 Subject: [PATCH] Added XV file support --- libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/xvdec.c | 1395 ++ libavformat/xvtools.h| 95