While the native jpeg2000 decoder can determine pixel format correctly
from the codestream, libopenjpeg wrapper cannot. To make sure that
the output is correct when using libopenjpeg to decode digital
cinema files, we do detection from the metadata included in the MXF
wrapper.
If the container has
On Wed, Mar 4, 2015 at 4:48 PM, Michael Niedermayer wrote:
> i did not mean to suggest to leave libopenjpeg broken.
It is not technically broken, it just relies on guessing in some cases
which might not always be correct. It think there should be a warning
that this is happening and a way to over
On Wed, Mar 4, 2015 at 10:08 AM, Vilius Grigaliūnas
wrote:
> On Wed, Mar 4, 2015 at 1:03 AM, Michael Niedermayer wrote:
>> this detects codestreams_profile0/p0_08.j2k as xyz, is this intended?
>
> No, this seems to be a regression. At the moment there is not enough
> informatio
On Wed, Mar 4, 2015 at 1:03 AM, Michael Niedermayer wrote:
> this detects codestreams_profile0/p0_08.j2k as xyz, is this intended?
No, this seems to be a regression. At the moment there is not enough
information in openjpeg data structures (opj_image_t specifically) to
reliably determine whether
> Overall, looks good to me. Maybe the "+ desc->comp[x].shift;" part should be
> moved inside the FFMIN macro? Seems okay as is, though.
I looked how it is implemented in jpeg200dec.c and there is no FFMIN there.
___
ffmpeg-devel mailing list
ffmpeg-deve
On Tue, Mar 3, 2015 at 9:49 PM, Michael Bradshaw wrote:
> That seems like the least intrusive fix, and the logic looks right to me. I
> don't know if 8-bit per component XYZ will ever be supported in ffmpeg, but
> if so then deciding between rgb24 and xyz8 will need a different method. The
> mixin
The reason for this change is that the native jpeg2000 decoder does
not yet support 4K digital cinema files (#2586). The workaround for
that is to use libopenjpeg decoder, which sort of works but
incorrectly detects pixel format as rgb48le instead of xyz12le. This
produces wrong colors in the outpu
On Tue, Mar 3, 2015 at 4:35 AM, Michael Bradshaw wrote:
> You can use the -pix_fmt option to specify the pixel format of the source.
> The openjpeg decoder will try that pixel format first before iterating
> through its (prioritized) list of pixel formats. That should provide a way
> to work aroun
On Tue, Mar 3, 2015 at 2:05 PM, Carl Eugen Hoyos wrote:
> Why don't you just move XYZ_PIXEL_FORMATS in front
> of the list?
Then the rgb24/rgba would not be detected correctly.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mail
On Tue, Mar 3, 2015 at 11:40 AM, Carl Eugen Hoyos wrote:
> Doesn't this break rgb48 images?
No, it does not break rgb48. They are not affected by this change. Due
to the way libopenjpeg_matches_pix_fmt is implemented, rgb48 can match
xyz12, but xyz12 can not match rgb48. So the order of formats m
On Tue, Mar 3, 2015 at 10:19 AM, Vilius Grigaliūnas
wrote:
> This fixes pixel values not being properly shifted in
> libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods.
>
> Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift
> to get the corre
This fixes pixel values not being properly shifted in
libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods.
Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift
to get the correct values.
---
libavcodec/libopenjpegdec.c |6 --
1 file changed, 4 insertions
Input files in XYZ color space are incorrecly detected as RGB which results
in incorrect output colors.
This fixes pixel format detection order (in increasing bit depth to
match libopenjpeg_matches_pix_fmt) when color space provided by
libopenjepg is unknown.
---
libavcodec/libopenjpegdec.c |
Input files in XYZ color space are incorrecly detected as RGB which results
in incorrect output colors.
This fixes pixel format detection order (in increasing bit depth to
match libopenjpeg_matches_pix_fmt) when color space provided by
libopenjepg is unknown.
---
libavcodec/libopenjpegdec.c |
This fixes pixel values not being properly shifted in
libopenjpeg_copyto16 and libopenjpeg_copy_to_packed16 methods.
Pixel formats like xyz12le need to be shifted by AVComponentDescriptor::shift
to get the correct values.
---
libavcodec/libopenjpegdec.c |6 [32m[m[31m--[m
1 file chang
Input files in XYZ color space are incorrecly detected as RGB which results
in incorrect output colors.
This changes pixel format detection to try XYZ before RGB when
color space provided by libopenjepg is unknown.
---
libavcodec/libopenjpegdec.c | 12 +++-
1 file changed, 7 insertions(
16 matches
Mail list logo
