On 12/10/17, Nicolas George wrote:
> Paul B Mahol (2017-12-10):
>> See vf_aspect.c, it changes inlink parameters.
>>
>> This patch is required for example if one change sar of first input
>> and that value is not propagated to next links.
>
> I had not noticed that. The code in
Paul B Mahol (2017-12-10):
> See vf_aspect.c, it changes inlink parameters.
>
> This patch is required for example if one change sar of first input
> and that value is not propagated to next links.
I had not noticed that. The code in vf_aspect.c looks invalid to me, I
think the change should be
On 12/10/17, Nicolas George wrote:
> Paul B Mahol (2017-12-10):
>> > "May need" is not always a good way of designing changes. It would be
>> > much better if you actually changed these filters at the same time to
>> > use it. That way you can be more sure that you did not mess
Paul B Mahol (2017-12-10):
> > "May need" is not always a good way of designing changes. It would be
> > much better if you actually changed these filters at the same time to
> > use it. That way you can be more sure that you did not mess things up in
> > a subtle way.
> Is changing inlink
On 12/10/17, Nicolas George wrote:
> Paul B Mahol (2017-12-09):
>> No new patches require it, it is for case such stereo3d and setsar and
>> bunch
>> of others that may need to explicitly set sample aspect ratio to each
>> frame.
>
> "May need" is not always a good way of
Paul B Mahol (2017-12-09):
> No new patches require it, it is for case such stereo3d and setsar and bunch
> of others that may need to explicitly set sample aspect ratio to each frame.
"May need" is not always a good way of designing changes. It would be
much better if you actually changed these
On 12/9/17, Nicolas George wrote:
> Paul B Mahol (2017-12-09):
>> >> It should not be needed for each filter that sets sample aspect ratio
>> >> to set it explicitly also for each and every frame, instead that is
>> >> automatically done in get_buffer call.
>> > Is this message
Paul B Mahol (2017-12-09):
> >> It should not be needed for each filter that sets sample aspect ratio
> >> to set it explicitly also for each and every frame, instead that is
> >> automatically done in get_buffer call.
> > Is this message ok? If yes then I will push this patch shortly.
Ok,
On 12/8/17, Paul B Mahol wrote:
> On 12/7/17, Paul B Mahol wrote:
>> On 12/7/17, Nicolas George wrote:
>>> Paul B Mahol (2017-12-07):
Signed-off-by: Paul B Mahol
---
libavfilter/video.c | 9 -
1
On 12/7/17, Paul B Mahol wrote:
> On 12/7/17, Nicolas George wrote:
>> Paul B Mahol (2017-12-07):
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> libavfilter/video.c | 9 -
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> Please
On 12/7/17, Nicolas George wrote:
> Paul B Mahol (2017-12-07):
>> Signed-off-by: Paul B Mahol
>> ---
>> libavfilter/video.c | 9 -
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Please explain (in the commit message) why you think this patch is
Paul B Mahol (2017-12-07):
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/video.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
Please explain (in the commit message) why you think this patch is
needed.
Regards,
--
Nicolas George
signature.asc
Signed-off-by: Paul B Mahol
---
libavfilter/video.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavfilter/video.c b/libavfilter/video.c
index 6f9020b9fe..7a8e587798 100644
--- a/libavfilter/video.c
+++ b/libavfilter/video.c
@@ -43,6 +43,7 @@
13 matches
Mail list logo