Re: [FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

2014-11-28 Thread Reimar Döffinger
On Thu, Nov 27, 2014 at 10:38:01PM +1100, Matt Oliver wrote: The patch lavf: Use wchar functions for filenames on windows for mkdir/rmdir/rename/unlink that was recently added has broken msvc/icl builds. see:

Re: [FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

2014-11-28 Thread Derek Buitenhuis
On 11/28/2014 4:47 PM, Reimar Döffinger wrote: That doesn't explain why the patch changes the zlib / bz2 include position? They include it. e.g.: https://github.com/madler/zlib/blob/master/zconf.h#L321-339 - Derek ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

2014-11-27 Thread Matt Oliver
The patch lavf: Use wchar functions for filenames on windows for mkdir/rmdir/rename/unlink that was recently added has broken msvc/icl builds. see: http://fate.ffmpeg.org/report.cgi?time=20141126233318slot=x86_32-msvc12-windows-native This is because winsock2.h must be included before windows.h.

Re: [FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

2014-11-27 Thread Michael Niedermayer
On Thu, Nov 27, 2014 at 10:38:01PM +1100, Matt Oliver wrote: The patch lavf: Use wchar functions for filenames on windows for mkdir/rmdir/rename/unlink that was recently added has broken msvc/icl builds. see: