Andrey Utkin andrey.krieger.utkin at gmail.com writes:
+if (av_strstart(p-filename, /dev/video, NULL))
+return AVPROBE_SCORE_MAX;
I took the freedom to apply this patch with MAX - 1.
Carl Eugen
___
ffmpeg-devel mailing list
2014-10-25 2:28 GMT+04:00 Timothy Gu timothyg...@gmail.com:
Those URLs are very explicit, while `/dev/` can mean anything,
including `/dev/stdin`.
Could you elaborate what this practically means? BTW there's no /dev
in my patch, but /dev/video.
--
Andrey Utkin
On Fri, 24 Oct 2014 19:50:25 +0400
Andrey Utkin andrey.krieger.ut...@gmail.com wrote:
---
libavdevice/v4l2.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index cf7a92c..ebc50bb 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
Those URLs are very explicit, while `/dev/` can mean anything,
including `/dev/stdin`.
Andrey quoted these bits of code to show that checking filename for NULL is
not necessary. I believe his proof is conclusive for that point.
wm4 :
IMHO
On Sat, 25 Oct 2014 11:43:12 +0200
Nicolas George geo...@nsup.org wrote:
Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
Those URLs are very explicit, while `/dev/` can mean anything,
including `/dev/stdin`.
Andrey quoted these bits of code to show that checking filename for NULL is
Le quartidi 4 brumaire, an CCXXIII, wm4 a écrit :
Don't present your extremely bad ideas as mine. Thanks.
Sorry, I had not realized you wanted him to check whether it's really a
video device by the application of careful handwaving and accurate magic.
Regards,
--
Nicolas George
On Sat, Oct 25, 2014 at 01:10:20PM +0200, wm4 wrote:
On Sat, 25 Oct 2014 11:43:12 +0200
Nicolas George geo...@nsup.org wrote:
Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
Those URLs are very explicit, while `/dev/` can mean anything,
including `/dev/stdin`.
Andrey quoted
On Sat, 25 Oct 2014 13:14:26 +0200
Reimar Döffinger reimar.doeffin...@gmx.de wrote:
On Sat, Oct 25, 2014 at 01:10:20PM +0200, wm4 wrote:
On Sat, 25 Oct 2014 11:43:12 +0200
Nicolas George geo...@nsup.org wrote:
Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
Those URLs are
On Sat, Oct 25, 2014 at 01:40:11PM +0200, wm4 wrote:
On Sat, 25 Oct 2014 13:14:26 +0200
Reimar Döffinger reimar.doeffin...@gmx.de wrote:
wm4, if you have a simple way of doing this check, please explain it.
Otherwise I think EXTENSION score is good enough to signal well, we
guess that's
On Sat, 25 Oct 2014 13:50:58 +0200
Reimar Döffinger reimar.doeffin...@gmx.de wrote:
On Sat, Oct 25, 2014 at 01:40:11PM +0200, wm4 wrote:
On Sat, 25 Oct 2014 13:14:26 +0200
Reimar Döffinger reimar.doeffin...@gmx.de wrote:
wm4, if you have a simple way of doing this check, please explain
Reimar Döffinger Reimar.Doeffinger at gmx.de writes:
It should be possible to override the other way via
file:///dev/video/... I believe?
Of course.
Could the original patch please be applied?
If really necessary with MAX - 1, we have
32bit probe functions that return MAX and
no user will
Le quartidi 4 brumaire, an CCXXIII, Reimar Döffinger a écrit :
That would end up trying a v4l ioctl on each and every file that
FFmpeg tries to open (unless you mean only after the /dev/video check,
but that would not solve the issue you mention later).
That feels a bit heavy-weight.
That
On Sat, Oct 25, 2014 at 02:15:47PM +0200, wm4 wrote:
I admittedly just assumed that v4l2:///dev/video/... would work
currently. If not, that sounds like something that can and should
be fixed.
However as a convenience feature, I think it is good that /dev/video
just ends up picking the
On Sat, Oct 25, 2014 at 12:35:11PM +, Carl Eugen Hoyos wrote:
Reimar Döffinger Reimar.Doeffinger at gmx.de writes:
It should be possible to override the other way via
file:///dev/video/... I believe?
Of course.
Could the original patch please be applied?
I think I agree,
On Sat, 25 Oct 2014 14:43:39 +0200
Nicolas George geo...@nsup.org wrote:
Le quartidi 4 brumaire, an CCXXIII, Reimar Döffinger a écrit :
That would end up trying a v4l ioctl on each and every file that
FFmpeg tries to open (unless you mean only after the /dev/video check,
but that would not
Le quartidi 4 brumaire, an CCXXIII, wm4 a écrit :
Then there's no sane way to handle this. Basically, you need to know:
yes, this is a video device.
And that does not exist.
Such a flag might probably work...
Actually, probably not without more changes, because the devices do not
remove the
Le quartidi 4 brumaire, an CCXXIII, Reimar Döffinger a écrit :
Such a special protocol that doesn't need /dev/video magic would probably be
a good idea.
We could agree on a global convention that states something like this:
Whenever it makes sense, demuxers that use the file name directly
On Sat, Oct 25, 2014 at 03:08:10PM +0200, wm4 wrote:
On Sat, 25 Oct 2014 14:43:39 +0200
Nicolas George geo...@nsup.org wrote:
That would not be heavy-weight, that would be outright irresponsible:
ioctl() opcodes are not globally unique. An opcode that maps to a harmless
probe on v4l
Reimar Döffinger Reimar.Doeffinger at gmx.de writes:
I think this is a bit Linux/Unix/centric.
Of course, as it is quite difficult to compile
the demuxer on anything else...
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On Fri, Oct 24, 2014 at 07:50:25PM +0400, Andrey Utkin wrote:
---
libavdevice/v4l2.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index cf7a92c..ebc50bb 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -806,6 +806,13 @@
---
libavdevice/v4l2.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index cf7a92c..ebc50bb 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -806,6 +806,13 @@ static int device_try_init(AVFormatContext *ctx,
return ret;
}
Le tridi 3 brumaire, an CCXXIII, Andrey Utkin a écrit :
---
libavdevice/v4l2.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index cf7a92c..ebc50bb 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -806,6 +806,13 @@ static
2014-10-24 20:34 GMT+04:00 Benoit Fouet benoit.fo...@free.fr:
Shouldn't this also test p-filename for non-NULLness?
LGTM otherwise.
The code was copied from lavf/rtspdec.c
There're places with same code.
If this is really needed, then we should update it in other places.
On Fri, Oct 24, 2014 at 11:50 AM, Andrey Utkin
andrey.krieger.ut...@gmail.com wrote:
2014-10-24 20:34 GMT+04:00 Benoit Fouet benoit.fo...@free.fr:
Shouldn't this also test p-filename for non-NULLness?
LGTM otherwise.
The code was copied from lavf/rtspdec.c
There're places with same code.
If
24 matches
Mail list logo
