Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-21 Thread Carl Eugen Hoyos
2018-04-19 12:15 GMT+02:00, Martin Dørum : > Anotehr point is that some applications make assumptions about the > pix_fmt the decoder they get from `avcodec_find_decoder` uses. (Unrelated to your patch afaict) This assumption is invalid, FFmpeg has changed pix_fmt (and

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread Hendrik Leppkes
On Thu, Apr 19, 2018 at 4:45 PM, wm4 wrote: > On Thu, 19 Apr 2018 16:33:09 +0200 > Hendrik Leppkes wrote: > >> On Thu, Apr 19, 2018 at 12:40 PM, wm4 wrote: >> > >> > Regarding this patch, personally I don't think using getenv()

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread wm4
On Thu, 19 Apr 2018 16:33:09 +0200 Hendrik Leppkes wrote: > On Thu, Apr 19, 2018 at 12:40 PM, wm4 wrote: > > > > Regarding this patch, personally I don't think using getenv() to > > configure what is pretty much API semantics is acceptable. But a new

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread James Almer
On 4/19/2018 11:19 AM, Derek Buitenhuis wrote: > On 4/19/2018 11:40 AM, wm4 wrote: >> Regarding this patch, personally I don't think using getenv() to >> configure what is pretty much API semantics is acceptable. But a new >> API function that restricts what codecs are used based on a string >>

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread Hendrik Leppkes
On Thu, Apr 19, 2018 at 12:40 PM, wm4 wrote: > > Regarding this patch, personally I don't think using getenv() to > configure what is pretty much API semantics is acceptable. But a new > API function that restricts what codecs are used based on a string > argument might be

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread Derek Buitenhuis
On 4/19/2018 11:40 AM, wm4 wrote: > Regarding this patch, personally I don't think using getenv() to > configure what is pretty much API semantics is acceptable. But a new > API function that restricts what codecs are used based on a string > argument might be ok. Then applications could use it to

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread wm4
On Thu, 19 Apr 2018 12:15:07 +0200 Martin Dørum wrote: > When a program uses FFmpeg to decode or encode media, and uses > `avcodec_find_decoder` or `avcodec_find_encoder`, I interpret that as > the program not caring a whole lot what AVCodec is used; it just wants >

[FFmpeg-devel] [PATCH] avcodec/allcodecs: add FFMPEG_PREFER_* env vars

2018-04-19 Thread Martin Dørum
When a program uses FFmpeg to decode or encode media, and uses `avcodec_find_decoder` or `avcodec_find_encoder`, I interpret that as the program not caring a whole lot what AVCodec is used; it just wants something which can encode or decode the desired format. I think it makes sense for the user