Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix range of values for Mastering Display Color Volume Metadata OBUs

2019-03-25 Thread James Almer
On 3/23/2019 2:30 PM, James Almer wrote: > Signed-off-by: James Almer > --- >> Does something like >> FFMIN(((uint64_t)current->luminance_max << 6) - 1, MAX_UINT_BITS(32)) >> do the right thing? > > Yes. Fixed and a comment added. > > libavcodec/cbs_av1_syntax_template.c | 13 - >

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix range of values for Mastering Display Color Volume Metadata OBUs

2019-03-23 Thread James Almer
Signed-off-by: James Almer --- > Does something like > FFMIN(((uint64_t)current->luminance_max << 6) - 1, MAX_UINT_BITS(32)) > do the right thing? Yes. Fixed and a comment added. libavcodec/cbs_av1_syntax_template.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix range of values for Mastering Display Color Volume Metadata OBUs

2019-03-23 Thread James Almer
On 3/23/2019 9:46 AM, Mark Thompson wrote: > On 21/03/2019 18:37, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1_syntax_template.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/libavcodec/cbs_av1_syntax_template.c >>

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix range of values for Mastering Display Color Volume Metadata OBUs

2019-03-23 Thread Mark Thompson
On 21/03/2019 18:37, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_av1_syntax_template.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/cbs_av1_syntax_template.c > b/libavcodec/cbs_av1_syntax_template.c > index

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix range of values for Mastering Display Color Volume Metadata OBUs

2019-03-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_av1_syntax_template.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index 48f4fab514..93bba1e5ad 100644 ---