Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-26 Thread Michael Niedermayer
On Sat, May 25, 2019 at 06:31:14PM -0300, James Almer wrote: > On 5/25/2019 6:03 PM, James Almer wrote: > > On 5/25/2019 12:50 PM, Derek Buitenhuis wrote: > >> On 25/05/2019 04:25, James Almer wrote: > + > >>> > >>> Unnecessary empty line. > >> > >> Fixed. > >> > >>> Could we not? The idea is

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-26 Thread Derek Buitenhuis
On 25/05/2019 22:55, Derek Buitenhuis wrote: > This patch also adds support for checking the AVCOL range. If you object that > strongly to it, I'm sure they don't mind switching to -color_range jpeg. That > works with x264, etc. too. Pushed as-is, as per IRC conversation. - Derek

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread Derek Buitenhuis
On 25/05/2019 22:31, James Almer wrote: > Ah hell, whatever, just push it. Jeeb pointed out the reason you wrote > this patch. Reverting this patch in the future should be trivial anyway. This patch also adds support for checking the AVCOL range. If you object that strongly to it, I'm sure they do

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread James Almer
On 5/25/2019 6:03 PM, James Almer wrote: > On 5/25/2019 12:50 PM, Derek Buitenhuis wrote: >> On 25/05/2019 04:25, James Almer wrote: + >>> >>> Unnecessary empty line. >> >> Fixed. >> >>> Could we not? The idea is to eventually kill these, so we should at >>> least try to not make them even mor

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread James Almer
On 5/25/2019 12:50 PM, Derek Buitenhuis wrote: > On 25/05/2019 04:25, James Almer wrote: >>> + >> >> Unnecessary empty line. > > Fixed. > >> Could we not? The idea is to eventually kill these, so we should at >> least try to not make them even more widespread... > > As far as I know, they can't

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread Derek Buitenhuis
On 25/05/2019 04:25, James Almer wrote: >> + > > Unnecessary empty line. Fixed. > Could we not? The idea is to eventually kill these, so we should at > least try to not make them even more widespread... As far as I know, they can't be removed, as there isn't a simple replacement for some of the

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-24 Thread James Almer
On 5/24/2019 12:23 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 07bca81aef..f56def53d5 100644 > --- a/liba

[FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-24 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavcodec/libx265.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 07bca81aef..f56def53d5 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -133,6 +133,14 @