Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-26 Thread Banana M.
Ignore this patch, I've submitted a new one that hopefully has a better chance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-10 Thread Banana M.
> No, you need to set this during init. > You should also set avctx->delay to the same value. This value is part of the bitstream, so theoretically can appear in any packet after the first. Can you confirm it doesn't? How could it be set on init? You'd need to read the bitstream then rewind? And

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-10 Thread Banana M.
> Can you confirm that if you break the decoder intentionally, the test > (still) fails? > > Thank you, Carl Eugen It does. Since file now writes 1 extra packet (as intended) so it'll always differ SIZE_TOLERANCE at min, so decoder changes will go over than value, I think. I tried -frames:a 108 (

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-10 Thread Rostislav Pehlivanov
On Wed, 10 Oct 2018 at 00:15, wrote: > From: bnnm > > Improves trac issue #6722. Fixes truncated WMAPRO/XMA output due to delay > samples and partially applies bitstream gapless info. > > This can be tested with files encoding a small nb_samples (like 400), > which couldn't output anything due t

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-09 Thread Banana M.
I've sent the patch again with some tweaks and fixed the test, please check if it is satisfactory now. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-09 Thread Carl Eugen Hoyos
2018-10-10 1:15 GMT+02:00, bananaman...@gmail.com : > From: bnnm > > Improves trac issue #6722. Fixes truncated WMAPRO/XMA output due to delay > samples and partially applies bitstream gapless info. > > This can be tested with files encoding a small nb_samples (like 400), which > couldn't output a

[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-09 Thread bananaman255
From: bnnm Improves trac issue #6722. Fixes truncated WMAPRO/XMA output due to delay samples and partially applies bitstream gapless info. This can be tested with files encoding a small nb_samples (like 400), which couldn't output anything due to missing delay at the end. Applying end_skip an

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-06 Thread Michael Niedermayer
On Sat, Oct 06, 2018 at 04:53:31PM +0200, Banana M. wrote: > > Is it intended that this doesnt list a human name ? > > (its no problem but jb tends to be unhappy if there are no names in the > log > > so i try to ask people if they really intend to not list their name or if > > its a unintended mis

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-06 Thread Banana M.
> Is it intended that this doesnt list a human name ? > (its no problem but jb tends to be unhappy if there are no names in the log > so i try to ask people if they really intend to not list their name or if > its a unintended mistake) It's the nick/mail I use in github and other places, it's corr

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-05 Thread Michael Niedermayer
On Wed, Oct 03, 2018 at 11:55:32PM +0200, bananaman...@gmail.com wrote: > From: bnnm Is it intended that this doesnt list a human name ? (its no problem but jb tends to be unhappy if there are no names in the log so i try to ask people if they really intend to not list their name or if its a un

[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

2018-10-03 Thread bananaman255
From: bnnm Improves trac issue #6722. Fixes truncated XMA output (was missing 128 samples) and applies bitstream gapless info (partially for XMA, fully for WMAPRO). Applying XMA end_skip would require some extra changes in the XMA multi-stream handling, so end samples are slightly bigger than