Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-08 Thread James Almer
On 9/8/2017 5:25 AM, Nicolas George wrote: > Le primidi 21 fructidor, an CCXXV, James Almer a écrit : >> What can we do, then? NAN and nan("") are sometimes compile-time >> constants and sometimes not, apparently depending on build type and >> target system. >> >> CCing Vittorio as he's the author

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-08 Thread Vittorio Giovara
On Thu, Sep 7, 2017 at 11:26 PM, James Almer wrote: > On 9/7/2017 6:16 PM, Michael Niedermayer wrote: > > On Wed, Sep 06, 2017 at 10:59:13PM -0300, James Almer wrote: > >> Netbsd: > >> src/libavfilter/vf_tonemap.c:314: error: initializer element is not > constant > >> src/libavfilter/vf_tonemap.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-08 Thread Derek Buitenhuis
On 9/8/2017 10:53 AM, Hendrik Leppkes wrote: > So if it would not be defined at all, the filter would still not > build. So what exactly does that change? Yes it would: libavutil/mathematics.h:#define NANav_int2float(0x7fc0) - Derek ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-08 Thread Hendrik Leppkes
On Fri, Sep 8, 2017 at 10:25 AM, Nicolas George wrote: > Le primidi 21 fructidor, an CCXXV, James Almer a écrit : >> What can we do, then? NAN and nan("") are sometimes compile-time >> constants and sometimes not, apparently depending on build type and >> target system. >> >> CCing Vittorio as he'

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-08 Thread Nicolas George
Le primidi 21 fructidor, an CCXXV, James Almer a écrit : > What can we do, then? NAN and nan("") are sometimes compile-time > constants and sometimes not, apparently depending on build type and > target system. > > CCing Vittorio as he's the author of the filter. "The macro NAN is defined if and

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-07 Thread Michael Niedermayer
On Thu, Sep 07, 2017 at 06:26:50PM -0300, James Almer wrote: > On 9/7/2017 6:16 PM, Michael Niedermayer wrote: > > On Wed, Sep 06, 2017 at 10:59:13PM -0300, James Almer wrote: > >> Netbsd: > >> src/libavfilter/vf_tonemap.c:314: error: initializer element is not > >> constant > >> src/libavfilter/v

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-07 Thread James Almer
On 9/7/2017 6:16 PM, Michael Niedermayer wrote: > On Wed, Sep 06, 2017 at 10:59:13PM -0300, James Almer wrote: >> Netbsd: >> src/libavfilter/vf_tonemap.c:314: error: initializer element is not constant >> src/libavfilter/vf_tonemap.c:314: error: (near initialization for >> 'tonemap_options[8].defa

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-07 Thread Michael Niedermayer
On Wed, Sep 06, 2017 at 10:59:13PM -0300, James Almer wrote: > Netbsd: > src/libavfilter/vf_tonemap.c:314: error: initializer element is not constant > src/libavfilter/vf_tonemap.c:314: error: (near initialization for > 'tonemap_options[8].default_val.dbl') > > DJGPP > src/libavfilter/vf_tonemap.

[FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

2017-09-06 Thread James Almer
Netbsd: src/libavfilter/vf_tonemap.c:314: error: initializer element is not constant src/libavfilter/vf_tonemap.c:314: error: (near initialization for 'tonemap_options[8].default_val.dbl') DJGPP src/libavfilter/vf_tonemap.c:314:87: error: initializer element is not constant { "param",