Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-19 Thread Clément Bœsch
On Thu, Jul 16, 2015 at 09:01:53PM +0100, Derek Buitenhuis wrote: On Thu, Jul 16, 2015 at 7:43 PM, Clément Bœsch u...@pkh.me wrote: +Reverses a clip. Requires memory to buffer the entire clip, so trimming is suggested. We use infinitive form, so Reverse. Done locally. You might

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-19 Thread Derek Buitenhuis
On Sun, Jul 19, 2015 at 1:13 PM, Clément Bœsch u...@pkh.me wrote: Is there any reasonable way to determine when to print such a warning? Seems silly to warn over e.g. 40 frames. I meant in the documentation. I don't know for the code. OK. How does this look: -vf trim=end=10,reverse

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-17 Thread Carl Eugen Hoyos
Derek Buitenhuis derek.buitenhuis at gmail.com writes: The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. I always wondered if these kind of filters should require an option like -i_dont_care_about_oom but I am not saying it changes much... Carl Eugen

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-17 Thread Derek Buitenhuis
The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. I always wondered if these kind of filters should require an option like -i_dont_care_about_oom but I am not saying it changes much... Wasn't my idea. ;) - Derek

[FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. --- doc/filters.texi | 4 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +-

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Paul B Mahol
Dana 16. 7. 2015. 20:43 osoba Clément Bœsch u...@pkh.me napisala je: On Thu, Jul 16, 2015 at 05:43:59PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. ;)

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
On Thu, Jul 16, 2015 at 7:43 PM, Clément Bœsch u...@pkh.me wrote: +Reverses a clip. Requires memory to buffer the entire clip, so trimming is suggested. We use infinitive form, so Reverse. Done locally. You might want to print Warning: this filter requires ... Is there any reasonable way

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Clément Bœsch
On Thu, Jul 16, 2015 at 05:43:59PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. ;) --- doc/filters.texi | 4 ++ libavfilter/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
Missing Changelog entry. Added locally. +typedef struct ReverseContext { +const AVClass *class; Apparently not needed. Woops. Yeah. Obviously. Removed. +AVFilterContext *ctx = inlink-dst; +ReverseContext *s= ctx-priv; + + Extra newline. Fixed. Rest looks