Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-02-02 Thread James Almer
On 1/30/2016 2:26 PM, Paul B Mahol wrote: > Should be fixed in 4th version attached. CC libavfilter/vf_nnedi.o src/libavfilter/vf_nnedi.c: In function ‘extract_m8’: src/libavfilter/vf_nnedi.c:506:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-30 Thread Andy Furniss
Paul B Mahol wrote: On 1/30/16, Andy Furniss wrote: Paul B Mahol wrote: On 1/30/16, Andy Furniss wrote: Paul B Mahol wrote: Hi, 3rd version attached! It seems that now bff/tff flags on input are correctly followed and output is good, but it can't be overridden by field=bf or field=tf bot

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-30 Thread Derek Buitenhuis
On 1/28/2016 12:03 PM, Paul B Mahol wrote: > Hi, > > 2nd version attached. [...] > +{"weights_file", NULL, OFFSET(weights_file), AV_OPT_TYPE_STRING, > {.str="nnedi3_weights.bin"}, 0, 0, FLAGS }, I still argue this makes the filter useless for 99% of users. - The weights are literally th

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-30 Thread Paul B Mahol
On 1/30/16, Andy Furniss wrote: > Paul B Mahol wrote: >> On 1/30/16, Andy Furniss wrote: >>> Paul B Mahol wrote: Hi, 3rd version attached! >>> >>> It seems that now bff/tff flags on input are correctly followed >>> and output is good, but it can't be overridden by field=bf or >>> f

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-30 Thread Andy Furniss
Paul B Mahol wrote: On 1/30/16, Andy Furniss wrote: Paul B Mahol wrote: Hi, 3rd version attached! It seems that now bff/tff flags on input are correctly followed and output is good, but it can't be overridden by field=bf or field=tf both give correct output. For raw video though, they are

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-30 Thread Paul B Mahol
On 1/30/16, Andy Furniss wrote: > Paul B Mahol wrote: >> Hi, >> >> 3rd version attached! > > It seems that now bff/tff flags on input are correctly followed and > output is good, but it can't be overridden by field=bf or field=tf both > give correct output. > > For raw video though, they are honor

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-29 Thread Andy Furniss
Paul B Mahol wrote: Hi, 3rd version attached! It seems that now bff/tff flags on input are correctly followed and output is good, but it can't be overridden by field=bf or field=tf both give correct output. For raw video though, they are honored and are still the wrong way round.

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-29 Thread Paul B Mahol
Hi, 3rd version attached! From f7f9cd51e3c22651d4b6d3636c26e9e3b63f6db6 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Jan 2016 17:15:53 +0100 Subject: [PATCH] avfilter: add nnedi filter Port of nnedi3 vapoursynth filter. Signed-off-by: Paul B Mahol --- configure|

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-28 Thread Andy Furniss
Paul B Mahol wrote: Hi, 2nd version attached. Nice - fields support :-) I think bf and tf are the wrong way round. ie. ffmpeg -i something-tff -vf nnedi :field=tf gives wrong output on same file field=bf looks correct. idet confirms input is tff (which I knew anyway) ___

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-28 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > 2nd version attached. > +AVFilter ff_vf_nnedi = { > +.name = "nnedi", > +.description = NULL_IF_CONFIG_SMALL("Apply neural > network edge directed interpolation."), Am I correct that this is a deinterlacer? If yes, please add this to the des

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-28 Thread Paul B Mahol
Hi, 2nd version attached. From bd6be4dcf42e426eeeadc7738aa26354f6876c88 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Jan 2016 17:15:53 +0100 Subject: [PATCH] avfilter: add nnedi filter Port of nnedi3 vapoursynth filter. Signed-off-by: Paul B Mahol --- configure|

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 10:50:37AM +0100, Paul B Mahol wrote: > On 1/24/16, Michael Niedermayer wrote: > > On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: > >> Hi, > >> > >> patch attached. > > > >> configure|1 > >> libavfilter/Makefile |1 > >> libavfil

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Andy Furniss
Paul B Mahol wrote: On 1/24/16, Andy Furniss wrote: Michael Niedermayer wrote: On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: Hi, patch attached. configure|1 libavfilter/Makefile | 1 libavfilter/allfilters.c |1 libavfilter/vf_nnedi.c | 939

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Paul B Mahol
On 1/24/16, Andy Furniss wrote: > Michael Niedermayer wrote: >> On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: >>> Hi, >>> >>> patch attached. >> >>> configure|1 >>> libavfilter/Makefile |1 >>> libavfilter/allfilters.c |1 >>> libavfilter/vf_nn

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Andy Furniss
Michael Niedermayer wrote: On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: Hi, patch attached. configure|1 libavfilter/Makefile |1 libavfilter/allfilters.c |1 libavfilter/vf_nnedi.c | 939 ++

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Paul B Mahol
On 1/24/16, Michael Niedermayer wrote: > On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: >> Hi, >> >> patch attached. > >> configure|1 >> libavfilter/Makefile |1 >> libavfilter/allfilters.c |1 >> libavfilter/vf_nnedi.c | 939 >> +

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Michael Niedermayer
On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: > Hi, > > patch attached. > configure|1 > libavfilter/Makefile |1 > libavfilter/allfilters.c |1 > libavfilter/vf_nnedi.c | 939 > +++ > 4 files chan

[FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-23 Thread Paul B Mahol
Hi, patch attached. From a41c741bb4d3146661e629552d750638a0bdc87c Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Jan 2016 17:15:53 +0100 Subject: [PATCH] avfilter: add nnedi filter Port of nnedi3 vapoursynth filter. Signed-off-by: Paul B Mahol --- configure| 1 +