Re: [FFmpeg-devel] [PATCH] avformat/bit: return early from write_packet if pkt-size is 0

2015-02-26 Thread Nicolas George
L'octidi 8 ventôse, an CCXXIII, Andreas Cadhalpun a écrit : the bit format muxer currently segfaults, when it is passed a packet of size 0. This can be triggered e.g. with: ffmpeg -y -f lavfi -i sine=duration=0.1 -c:a flac -f bit /dev/null Attached patch fixes this. This looks wrong. The

Re: [FFmpeg-devel] [PATCH] avformat/bit: return early from write_packet if pkt-size is 0

2015-02-26 Thread Nicolas George
L'octidi 8 ventôse, an CCXXIII, Nicolas George a écrit : Last: how come ffmpeg/lavf tries to mux an empty packet? It comes from that commit: commit 0957b274e312e985d69cb490bee2a7ff820acaa6 Author: Anton Khirnov an...@khirnov.net Date: 2014-04-29 15:06:45 +0200 lavc: add an option to

Re: [FFmpeg-devel] [PATCH] avformat/bit: return early from write_packet if pkt-size is 0

2015-02-26 Thread Andreas Cadhalpun
On 26.02.2015 20:48, Nicolas George wrote: L'octidi 8 ventôse, an CCXXIII, Andreas Cadhalpun a écrit : the bit format muxer currently segfaults, when it is passed a packet of size 0. This can be triggered e.g. with: ffmpeg -y -f lavfi -i sine=duration=0.1 -c:a flac -f bit /dev/null Attached

Re: [FFmpeg-devel] [PATCH] avformat/bit: return early from write_packet if pkt-size is 0

2015-02-26 Thread Andreas Cadhalpun
On 26.02.2015 21:47, Nicolas George wrote: L'octidi 8 ventôse, an CCXXIII, Nicolas George a écrit : Last: how come ffmpeg/lavf tries to mux an empty packet? It comes from that commit: commit 0957b274e312e985d69cb490bee2a7ff820acaa6 Author: Anton Khirnov an...@khirnov.net Date: 2014-04-29

Re: [FFmpeg-devel] [PATCH] avformat/bit: return early from write_packet if pkt-size is 0

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 10:11:37PM +0100, Andreas Cadhalpun wrote: On 26.02.2015 20:48, Nicolas George wrote: L'octidi 8 ventôse, an CCXXIII, Andreas Cadhalpun a écrit : the bit format muxer currently segfaults, when it is passed a packet of size 0. This can be triggered e.g. with: ffmpeg